opal 0.10.0.beta1 → 0.10.0.beta2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 85f0110e658c1cefc27cccb2781d3a23e92531f0
-  data.tar.gz: 46e3e241849788fa527985c5e5ad52837d315c02
+  metadata.gz: b0d30f54134e49ebcd91c2ece0dd0cf54a6d72ae
+  data.tar.gz: 57d3c8e202237d2e452523b1d772d8ddfe3baa24
 SHA512:
-  metadata.gz: bd22ed6d034471bce5dfaee1b3b76f91aaf16ead1a0465c247d006f00901d90c96854bc8a4774d3b3ec34980c0b009675b6a6c8b63c64877801340cfd1f82eef
-  data.tar.gz: ccb284eac1e8fe124ef80a3a0b7ad2fada35204eb141f252893d7babfc84b2a8a7143e12430219290bd771225a94723a080179fd0313003647b57bef3284cb94
+  metadata.gz: 0417410d72d8b82f366042085243ccd06d6d4394e46dbe507a3834e9df68d2ec5c76585b660466888ea6d3e8618e96f551e1e3482c3e66b0f270f5a9c4051482
+  data.tar.gz: da1d154ccf0f0ae319bed44b962e2ef6a588af39d22ede501cd7af7c7d8f095c9223bee1ecf0bafdf6b8500f605589d7c2b814daaf841b9caf5707ea6d0602a4

data/CHANGELOG.md

@@ -105,6 +105,7 @@ Whitespace conventions:
 - Fixed parsing of `%{}` lists when list item contains same brackets.
 - Fixed an issue with `"-"` inside the second arg of `String#tr`
 - Fixed Base64 and enabled specs
+- Fixed method definition in method body.
 
 
 ### Removed

data/lib/opal/nodes/args/normarg.rb

@@ -14,11 +14,15 @@ module Opal
         arg_name = @sexp[1].to_sym
         var_name = variable(arg_name)
 
-        default_value = scope.in_mlhs? ? "|| nil" : ""
-
         if @sexp.meta[:post]
           add_temp var_name
-          line "#{var_name} = #{scope.working_arguments}.splice(0,1)[0] #{default_value};"
+          line "#{var_name} = #{scope.working_arguments}.splice(0,1)[0];"
+        end
+
+        if scope.in_mlhs?
+          line "if (#{var_name} == null) {"
+          line "  #{var_name} = nil;"
+          line "}"
         end
       end
     end

data/lib/opal/nodes/def.rb

@@ -120,6 +120,8 @@ module Opal
         elsif scope.top?
           unshift "Opal.defn(Opal.Object, '$#{mid}', "
           push ')'
+        elsif scope.def?
+          wrap "Opal.def(self, '$#{mid}', ", ')'
         else
           raise "Unsupported use of `def`; please file a bug at https://github.com/opal/opal reporting this message."
         end

data/lib/opal/version.rb

@@ -1,5 +1,5 @@
 module Opal
   # WHEN RELEASING:
   # Remember to update RUBY_ENGINE_VERSION in opal/corelib/constants.rb too!
-  VERSION = '0.10.0.beta1'
+  VERSION = '0.10.0.beta2'
 end

data/opal/corelib/constants.rb

@@ -1,7 +1,7 @@
 RUBY_PLATFORM       = 'opal'
 RUBY_ENGINE         = 'opal'
 RUBY_VERSION        = '2.2.3'
-RUBY_ENGINE_VERSION = '0.10.0.beta1'
+RUBY_ENGINE_VERSION = '0.10.0.beta2'
 RUBY_RELEASE_DATE   = '2015-12-20'
 RUBY_PATCHLEVEL     = 0
 RUBY_REVISION       = 0

data/opal/corelib/unsupported.rb

@@ -202,3 +202,11 @@ module Kernel
                                "See https://github.com/opal/opal/blob/#{RUBY_ENGINE_VERSION}/docs/opal_parser.md for details."
   end
 end
+
+def self.public(*)
+  # stub
+end
+
+def self.private(*)
+  #stub
+end

data/spec/filters/bugs/language.rb

@@ -288,4 +288,22 @@ opal_filter "language" do
   fails "A Proc taking |(a, b)| arguments calls #to_ary to convert a single passed object to an Array"
   fails "A Proc taking |(a, b)| arguments calls #to_ary to convert a single passed object to an Array"
   fails "A Proc taking |(a, b)| arguments raises a TypeError if #to_ary does not return an Array"
+  fails "A singleton method definition can be declared for a local variable"
+  fails "A singleton method definition can be declared for an instance variable"
+  fails "A singleton method definition can be declared for a global variable"
+  fails "A singleton method definition can be declared for a class variable"
+  fails "A singleton method defined with extreme default arguments may use a method definition as a default"
+  fails "A singleton method defined with extreme default arguments may use an fcall as a default"
+  fails "A singleton method defined with extreme default arguments evaluates the defaults in the singleton scope"
+  fails "A singleton method defined with extreme default arguments may use preceding arguments as defaults"
+  fails "A singleton method defined with extreme default arguments may use a lambda as a default"
+  fails "A nested method definition creates an instance method when evaluated in an instance method"
+  fails "A nested method definition creates a class method when evaluated in a class method"
+  fails "A method defined with extreme default arguments may use an fcall as a default" # fails on phantomjs
+  fails "A method definition in an eval creates an instance method"
+  fails "A method definition in an eval creates a class method"
+  fails "A method definition in an eval creates a singleton method"
+  fails "An instance method with a default argument shadows an existing method with the same name as the local"
+  fails "A nested method definition creates a method in the surrounding context when evaluated in a def expr.method"
+  fails "The def keyword within a closure looks outside the closure for the visibility"
 end

data/spec/filters/unsupported/freeze.rb

@@ -45,4 +45,6 @@ opal_filter "freezing" do
   fails "String#clone copies frozen state"
   fails "String#initialize with no arguments does not raise an exception when frozen"
   fails "StringScanner#initialize returns an instance of StringScanner"
+  fails "A singleton method definition raises RuntimeError if frozen"
+  fails "A method definition inside a metaclass scope raises RuntimeError if frozen"
 end

data/spec/filters/unsupported/privacy.rb

@@ -134,4 +134,12 @@ opal_filter "private" do
   fails "OpenStruct#initialize is private"
   fails "OpenStruct#new_ostruct_member is protected"
   fails "OpenStruct#table is protected"
+  fails "Defining a method at the top-level defines it on Object with private visibility by default"
+  fails "Defining an 'initialize' method sets the method's visibility to private"
+  fails "Defining an 'initialize_copy' method sets the method's visibility to private"
+  fails "Defining an 'initialize_dup' method sets the method's visibility to private"
+  fails "Defining an 'initialize_clone' method sets the method's visibility to private"
+  fails "Defining a 'respond_to_missing?' method sets the method's visibility to private"
+  fails "Redefining a singleton method does not inherit a previously set visibility"
+  fails "Redefining a singleton method does not inherit a previously set visibility"
 end

data/spec/opal/core/language/arguments/mlhs_arg_spec.rb

@@ -0,0 +1,19 @@
+# regression test
+describe 'mlhs argument' do
+  context 'when pased value is falsey in JS' do
+    it 'still returns it' do
+      p = ->((a)){ a }
+      p.call(false).should == false
+      p.call("").should == ""
+      p.call(0).should == 0
+    end
+  end
+
+  context 'when passed value == null' do
+    it 'replaces it with nil' do
+      p = ->((a)){ a }
+      p.call([`undefined`]).should == nil
+      p.call([`null`]).should == nil
+    end
+  end
+end

data/spec/ruby_specs

@@ -94,7 +94,6 @@ ruby/core/unboundmethod
 
 ruby/language
 !ruby/language/constants_spec
-!ruby/language/def_spec
 !ruby/language/execution_spec
 !ruby/language/hash_spec
 !ruby/language/next_spec

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: opal
 version: !ruby/object:Gem::Version
-  version: 0.10.0.beta1
+  version: 0.10.0.beta2
 platform: ruby
 authors:
 - Adam Beynon
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-03-30 00:00:00.000000000 Z
+date: 2016-03-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: sourcemap
@@ -691,6 +691,7 @@ files:
 - spec/opal/core/kernel/respond_to_spec.rb
 - spec/opal/core/kernel/send_spec.rb
 - spec/opal/core/kernel/sprintf_spec.rb
+- spec/opal/core/language/arguments/mlhs_arg_spec.rb
 - spec/opal/core/language/block_spec.rb
 - spec/opal/core/language/class_spec.rb
 - spec/opal/core/language/equal_spec.rb
@@ -1354,6 +1355,7 @@ test_files:
 - spec/opal/core/kernel/respond_to_spec.rb
 - spec/opal/core/kernel/send_spec.rb
 - spec/opal/core/kernel/sprintf_spec.rb
+- spec/opal/core/language/arguments/mlhs_arg_spec.rb
 - spec/opal/core/language/block_spec.rb
 - spec/opal/core/language/class_spec.rb
 - spec/opal/core/language/equal_spec.rb