opal-jquery 0.4.2 → 0.4.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 5756803ad9fee99689694217261dfbba137d50d7
-  data.tar.gz: 4bfe28a1b93a06735ed6a83fce93855d8e52ca7e
+SHA256:
+  metadata.gz: 03e8ec06442542e3a02161a4269dccf0b8462ae075ccd62754677edc32bf9be3
+  data.tar.gz: 97cc7ccc004b2efe8f5aaed1977897fdb77502396bcee847e8ec2f9f49c1e9bf
 SHA512:
-  metadata.gz: 87271b5c13e5c02aadf0faa1515f8a8c65c5771c1e2343d8675f3ea0fdf603094a5eae73792481b7aa8b0c637e30956dc9ddc8895c50d17d6dffffcd0fbfa05f
-  data.tar.gz: f86975805b7a90566de578722020aba59c512754895220e365ae109a4a78c8e4e5f1781b30d756929a0ed1c27102d5404a69f863cc337bf717772e4ff0adb5f3
+  metadata.gz: ab2f982ed40e4a462544cc0ebc050858a31ef381f6f57523d249afb032873662512f1b19219266f48efacaecc6335ee89744191fd0f952f93d88a44c61ca2672
+  data.tar.gz: 23a15f17d4230d9204685c45c1f537470f6fcc9357f8097d0ec6098d58dbd572a87050e53bdfc9ea023c236f5fc4e2d4bf07d323152d21ef4f4c83b7cc7f32f6

data/.editorconfig

@@ -0,0 +1,12 @@
+root = true
+
+[*]
+indent_style = space
+indent_size = 2
+end_of_line = lf
+charset = utf-8
+trim_trailing_whitespace = true
+insert_final_newline = true
+
+[*.md]
+trim_trailing_whitespace = false

data/.travis.yml

@@ -2,25 +2,18 @@ language: ruby
 sudo: false
 
 fast_finish: true
-script: rake $RUN
-
-before_install:
-  # thanks to https://mediocre.com/forum/topics/phantomjs-2-and-travis-ci-we-beat-our-heads-against-a-wall-so-you-dont-have-to
-  - wget https://s3.amazonaws.com/travis-phantomjs/phantomjs-2.0.0-ubuntu-12.04.tar.bz2
-  - tar -xjf phantomjs-2.0.0-ubuntu-12.04.tar.bz2
-  # Keep track of which version of phantomjs we're running the specs against
-  - phantomjs -v
+script: bundle exec rake $RUN
 
 matrix:
   include:
-    - rvm: 2.3.1
-      env: PATH=".:$PATH"
-    - rvm: 2.2.4
-      env: PATH=".:$PATH"
+    - rvm: 2.4.2
+      env: OPAL_VERSION='master'
+    - rvm: 2.3.4
+      env: OPAL_VERSION='~> 0.10.5'
     - rvm: 2.1.10
-      env: PATH=".:$PATH" RACK_VERSION='< 2.0'
+      env: RACK_VERSION='< 2.0'
     - rvm: 2.0.0
-      env: PATH=".:$PATH" RACK_VERSION='< 2.0'
+      env: RACK_VERSION='< 2.0'
 
     # We use 2.1.9 to differentiate the rvm version
     # as travis doesn't allow failures by env.
@@ -28,5 +21,19 @@ matrix:
       env: RUN=zepto PATH=".:$PATH" RACK_VERSION='< 2.0'
 
   allow_failures:
-    - rvm: 2.1.9
+    - rvm: 2.1.9 # zepto
+
+
+cache:
+  bundler: true
+  directories:
+  - node_modules
+
+before_install:
+  - gem update --system
+  - "export PATH=$PWD/travis_phantomjs/phantomjs-2.1.1-linux-x86_64/bin:$PATH"
+  - "if [ $(phantomjs --version) != '2.1.1' ]; then rm -rf $PWD/travis_phantomjs; mkdir -p $PWD/travis_phantomjs; fi"
+  - "if [ $(phantomjs --version) != '2.1.1' ]; then wget https://assets.membergetmember.co/software/phantomjs-2.1.1-linux-x86_64.tar.bz2 -O $PWD/travis_phantomjs/phantomjs-2.1.1-linux-x86_64.tar.bz2; fi"
+  - "if [ $(phantomjs --version) != '2.1.1' ]; then tar -xvf $PWD/travis_phantomjs/phantomjs-2.1.1-linux-x86_64.tar.bz2 -C $PWD/travis_phantomjs; fi"
+  - "phantomjs --version"
 

data/CHANGELOG.md

@@ -1,8 +1,46 @@
-## 0.4.2 2016-07-04
+## (0.5.0)[https://github.com/opal/opal-jquery/compare/v0.4.3...HEAD] Unreleased
+
+*see diff*
+
+## (0.4.3)[https://github.com/opal/opal-jquery/compare/v0.4.2...v0.4.3] 2018-07-24
+
+*   Add `Element#==` as an alias of `.is()`
+
+*   Add `Element#method_missing` to allow not yet wrapped methods and plugins to be accessed with zero setup
+
+*   Avoid `||` in JS-land because it would consider some values as falsy (e.g. `""` and `0`). **breaking**
+
+*   Call `Element#prop` via `Native.call` to get the right semantics around `nil` vs. `undefined` **breaking**
+
+*   Expose `Element#click`
+
+*   Fix semantics of `Element#attr` to better reflect jQuery's **breaking**
+
+*   Skip sending a callback to `Element#animate` if no block is given
+
+*   Let `Element#data` return a usable Ruby object (`Array`/`Hash`) instead of a native one **breaking**
+
+*   Don't wrap events with `Event.new` if no args are provided or the event is not a native object to increase performance in `Element#on` and `Element#one`
+
+*   Rename the internal property holding the callback wrapper in `Element#on` and `Element#one` from `._jq_wrap` to `.$$jqwrap` to avoid polluting instance variables and following the custom of Opal's core classes
+
+*   Fix `Element#value`, `Element#height` and `Element#width` to perform the `||` at ruby level to avoid overwriting values that are *falsy* in JavaScript with `nil` **breaking**
+
+*   Add `Element#==` as an alias to jQuery's `.is()`
+
+*   Add `Element#method_missing` and `Element#respond_to_missing?` to forward calls to native plugins
+
+*   Add `HTTP#inspect` with a basic summary
+
+*   Updated specs to also use jQuery 3
+
+*   Allow Opal v0.11.0
+
+## (0.4.2)[https://github.com/opal/opal-jquery/compare/v0.4.1...v0.4.2] 2016-07-04
 
 *   Allow Opal v0.10.0
 
-## 0.4.1 2015-11-02
+## (0.4.1)[https://github.com/opal/opal-jquery/compare/v0.4.0...v0.4.1] 2015-11-02
 
 *   Updated specs to use jQuery 1.8 (that was initially released in 2012)
 
@@ -12,7 +50,7 @@
 
 *   `Document.ready?` now works even after the document is loaded (unlike jQuery)
 
-## 0.4.0 2015-07-17
+## (0.4.0)[https://github.com/opal/opal-jquery/compare/v0.3.0...v0.4.0] 2015-07-17
 
 *   `Element#[]=` now removes the attribute when the assigned value is nil.
 

data/Gemfile

@@ -1,6 +1,17 @@
 source 'https://rubygems.org'
 gemspec
 
-gem 'opal', ENV['OPAL_VERSION'] || '~> 0.10.0'
-gem 'opal-rspec', github: 'opal/opal-rspec', submodules: true
+case (opal_version = ENV['OPAL_VERSION'])
+when 'master'
+  gem 'opal', github: 'opal/opal', branch: 'master'
+  gem 'opal-sprockets', github: 'opal/opal-sprockets'
+  gem 'opal-rspec', github: 'opal/opal-rspec', branch: 'elia/opal-master', submodules: true
+when nil
+  gem 'opal' # let bundler pick a version
+else
+  gem 'opal', opal_version
+end
+
+# gem 'opal-rspec', github: 'opal/opal-rspec', submodules: true
+# gem 'opal-rspec', path: '../opal-rspec'
 gem 'rack', ENV['RACK_VERSION'] || '> 0'

data/README.md

@@ -5,7 +5,7 @@
 opal-jquery provides DOM access to opal by wrapping jQuery (or zepto)
 and providing a nice ruby syntax for dealing with jQuery instances.
 
-See the Opal website for [documentation](http://opalrb.org/docs/jquery).
+<!-- See the Opal website for [documentation](http://opalrb.org/docs/jquery). -->
 
 
 

data/Rakefile

@@ -2,13 +2,22 @@ require 'bundler'
 Bundler.require
 Bundler::GemHelper.install_tasks
 
+ENV['RUNNER'] = 'chrome'
+
 require 'opal/rspec/rake_task'
-Opal::RSpec::RakeTask.new(:default) do |s|
-  s.index_path = 'spec/jquery/index.html.erb'
+Opal::RSpec::RakeTask.new(:default) do |server, task|
+  server.index_path = 'spec-opal/jquery/index.html.erb'
+  task.default_path = 'spec-opal'
+end
+
+Opal::RSpec::RakeTask.new(:jquery3) do |server, task|
+  server.index_path = 'spec-opal/jquery/index3.html.erb'
+  task.default_path = 'spec-opal'
 end
 
-Opal::RSpec::RakeTask.new(:zepto) do |s|
-  s.index_path = 'spec/zepto/index.html.erb'
+Opal::RSpec::RakeTask.new(:zepto) do |server, task|
+  server.index_path = 'spec-opal/zepto/index.html.erb'
+  task.default_path = 'spec-opal'
 end
 
 desc "Build build/opal-jquery.js"
@@ -64,6 +73,11 @@ namespace :doc do
     sh 'git', 'clone', '-b', 'gh-pages', '--', remote, doc_repo.to_s
   end
 
+  # To generate docs that live on http://opalrb.org/opal-jquery/ use the
+  # `rake doc` task
+  #
+  # DOC_REPO_REMOTE=https://github.com/opal/opal-jquery.git bundle exec rake doc
+  # open gh-pages/index.html
   task :default => doc_repo.to_s do
     git  = current_git_release.call
     name = 'api'
@@ -72,6 +86,10 @@ namespace :doc do
               "--readme opal/README.md -o gh-pages/doc/#{git}/#{name}"
     puts command; system command
   end
+
+  # To generate api docs on rubygems: http://www.rubydoc.info/gems/opal-jquery/0.4.2
+  # yard --main README.md --markup markdown --github
+  # open doc/index.html
 end
 
 task :doc => 'doc:default'

data/config.ru

@@ -1,13 +1,11 @@
 require 'bundler'
 Bundler.require
 
-require 'opal-rspec'
-Opal.append_path File.expand_path('../spec', __FILE__)
+require 'opal/rspec'
 
-run Opal::Server.new { |s|
+sprockets_env = Opal::RSpec::SprocketsEnvironment.new
+run Opal::Server.new(sprockets: sprockets_env) { |s|
   s.main = 'opal/rspec/sprockets_runner'
-  s.append_path 'spec'
+  sprockets_env.add_spec_paths_to_sprockets
   s.debug = false
-  s.index_path = 'spec/jquery/index.html.erb'
 }
-

data/lib/opal/jquery/element.rb

@@ -298,10 +298,12 @@ class Element < `#{JQUERY_CLASS.to_n}`
   # @!method get
   alias_native :get
 
-  # @!method prop(name, value = nil)
+  # @!method prop(name, value = undefined)
   #
   # Get or set the property `name` on each element in collection.
-  alias_native :prop
+  def prop(*args)
+    Native.call(self, :prop, *args)
+  end
 
   alias succ next
   alias << append
@@ -338,6 +340,9 @@ class Element < `#{JQUERY_CLASS.to_n}`
   # @!method submit()
   alias_native :submit
 
+  # @!method click()
+  alias_native :click
+
   # @!method text=(text)
   #
   # Set text content of each element in this collection.
@@ -416,10 +421,11 @@ class Element < `#{JQUERY_CLASS.to_n}`
       var size = args.length;
       switch (size) {
       case 1:
-        return #{self[`args[0]`]};
+        var result = self.attr(args[0]);
+        return( (result == null) ? nil : result );
         break;
       case 2:
-        return #{self[`args[0]`] = `args[1]`};
+        return self.attr(args[0], args[1]);
         break;
       default:
         #{raise ArgumentError, '#attr only accepts 1 or 2 arguments'}
@@ -508,16 +514,21 @@ class Element < `#{JQUERY_CLASS.to_n}`
   # is given, the block is run as a callback when the animation finishes.
   def animate(params, &block)
     speed = params.has_key?(:speed) ? params.delete(:speed) : 400
-    %x{
-      self.animate(#{params.to_n}, #{speed}, function() {
-        #{block.call if block_given?}
-      })
-    }
+    if block_given?
+      `self.animate(#{params.to_n}, #{speed}, block)`
+    else
+      `self.animate(#{params.to_n}, #{speed})`
+    end
   end
 
   def data(*args)
     %x{
       var result = self.data.apply(self, args);
+      if (
+        (typeof(result) === 'object') && !(result instanceof #{JQUERY_CLASS})
+      ) {
+        result = #{ JSON.from_object `result` };
+      }
       return result == null ? nil : result;
     }
   end
@@ -646,15 +657,22 @@ class Element < `#{JQUERY_CLASS.to_n}`
 
   def on(name, sel = nil, &block)
     %x{
-      var wrapper = function(evt) {
-        if (evt.preventDefault) {
-          evt = #{Event.new `evt`};
+      var has_args = #{block.arity} !== 0;
+
+      var wrapper = function() {
+        for(var args = new Array(arguments.length), i = 0, ii = args.length; i < ii; i++) {
+          args[i] = arguments[i];
+        }
+
+        // Use preventDefault as a canary for native events
+        if (has_args && args[0].preventDefault) {
+          args[0] = #{Event.new `args[0]`};
         }
 
-        return block.apply(null, arguments);
+        return block.apply(null, args);
       };
 
-      block._jq_wrap = wrapper;
+      block.$$jqwrap = wrapper;
 
       if (sel == nil) {
         self.on(name, wrapper);
@@ -669,15 +687,22 @@ class Element < `#{JQUERY_CLASS.to_n}`
 
   def one(name, sel = nil, &block)
     %x{
-      var wrapper = function(evt) {
-        if (evt.preventDefault) {
-          evt = #{Event.new `evt`};
+      var has_args = #{block.arity} !== 0;
+
+      var wrapper = function() {
+        for(var args = new Array(arguments.length), i = 0, ii = args.length; i < ii; i++) {
+          args[i] = arguments[i];
+        }
+
+        // Use preventDefault as a canary for native events
+        if (has_args && args[0].preventDefault) {
+          args[0] = #{Event.new `args[0]`};
         }
 
-        return block.apply(null, arguments);
+        return block.apply(null, args);
       };
 
-      block._jq_wrap = wrapper;
+      block.$$jqwrap = wrapper;
 
       if (sel == nil) {
         self.one(name, wrapper);
@@ -696,10 +721,10 @@ class Element < `#{JQUERY_CLASS.to_n}`
         return self.off(name);
       }
       else if (block === nil) {
-        return self.off(name, sel._jq_wrap);
+        return self.off(name, sel.$$jqwrap);
       }
       else {
-        return self.off(name, sel, block._jq_wrap);
+        return self.off(name, sel, block.$$jqwrap);
       }
     }
   end
@@ -714,18 +739,46 @@ class Element < `#{JQUERY_CLASS.to_n}`
   alias size length
 
   def value
-    `self.val() || ""`
+    `self.val()` || ""
   end
 
   def height
-    `self.height() || nil`
+    `self.height()` || nil
   end
 
   def width
-    `self.width() || nil`
+    `self.width()` || nil
   end
 
   def position
     Native(`self.position()`)
   end
+
+  def ==(other)
+    `self.is(other)`
+  end
+
+  def respond_to_missing?(name, _)
+    %x{
+      var method = self[#{name}];
+      if (typeof(method) === 'function') {
+        return true;
+      } else {
+        return #{super};
+      }
+    }
+  end
+
+  def method_missing(name, *args, &block)
+    args << block if block_given?
+
+    %x{
+      var method = self[#{name}];
+      if (typeof(method) === 'function') {
+        return method.apply(self, #{args.to_n});
+      } else {
+        return #{super};
+      }
+    }
+  end
 end

data/lib/opal/jquery/http.rb

@@ -165,7 +165,7 @@ class HTTP
 
     %x{
       if (typeof(#{payload}) === 'string') {
-        #{settings}.data = payload;
+        settings.data = payload;
       }
       else if (payload != nil) {
         settings.data = payload.$to_json();
@@ -231,6 +231,10 @@ class HTTP
     }
   end
 
+  def inspect
+    "#<HTTP @url=#{@url} @method=#{@method}>"
+  end
+
   private
 
   def promise

data/lib/opal/jquery/version.rb

@@ -1,5 +1,5 @@
 module Opal
   module JQuery
-    VERSION = '0.4.2'
+    VERSION = '0.4.3'
   end
 end

data/opal-jquery.gemspec

@@ -4,19 +4,20 @@ require File.expand_path('../lib/opal/jquery/version', __FILE__)
 Gem::Specification.new do |s|
   s.name         = 'opal-jquery'
   s.version      = Opal::JQuery::VERSION
-  s.author       = 'Adam Beynon'
-  s.email        = 'adam.beynon@gmail.com'
+  s.authors      = ['Adam Beynon', 'Elia Schito']
+  s.email        = 'elia@schito.me'
   s.homepage     = 'http://opalrb.org'
-  s.summary      = 'Opal access to jquery'
-  s.description  = 'Opal DOM library for jquery'
+  s.summary      = 'Opal access to jQuery'
+  s.description  = 'Opal DOM library for jQuery'
 
   s.files          = `git ls-files`.split("\n")
   s.executables    = `git ls-files -- bin/*`.split("\n").map { |f| File.basename(f) }
   s.test_files     = `git ls-files -- {test,spec,features}/*`.split("\n")
   s.require_paths  = ['lib']
 
-  s.add_runtime_dependency 'opal', '>= 0.7.0', '< 0.11.0'
-  s.add_development_dependency 'opal-rspec', '~> 0.5'
+  s.add_runtime_dependency 'opal', '>= 0.10.0', '< 0.12.0'
+  s.add_development_dependency 'opal-rspec', '~> 0.7.0.rc.2'
+  s.add_development_dependency 'opal-sprockets', '~> 0.4.1'
   s.add_development_dependency 'yard'
   s.add_development_dependency 'rake'
 end