opal-jquery 0.3.0 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5fe34adcb3d10d1ae28751e6f725a4b672de271c
-  data.tar.gz: cffe3b6a9521fde67c56cba78e1e86ab8ae73080
+  metadata.gz: 4a9d9c033904e8b586417d0c7236116c3e6ebe62
+  data.tar.gz: 05ce1e402fa399dd553d121d6744a27804c0adf4
 SHA512:
-  metadata.gz: 18f0077b6c30b76aed392779714ffa6a19a7de0e93d64707e8ac9bf21e1d472519a6877ca5bd497d4e696685971980ee2251a0ffe679a6461c1f5c63603f13f6
-  data.tar.gz: ce4159eec47d034b697e6994dd7c135e0692680ae0d79c2a6874f1eb94a088442b991c2b05b130e950c756ff6b1b6953882adda00f6206f8bd54d42c519019c8
+  metadata.gz: 96ecfc84b0e87f36d24f9f45170878dc522c9d214a18985a3c329b7b032befb1a2d1ddd3b2b2102aecc498fde2230edb523395300f1054b7b29db879e906a336
+  data.tar.gz: dccc89db5ec46ccd303b749059d00ce6db1c7911b89a3163f9a750dc3e622c3920c21d69d5f0d4a0f880a67dbafe996c9c9df2b333f34ad21e82ad1e63c67b5c

data/CHANGELOG.md

@@ -1,4 +1,12 @@
-## EDGE
+## 0.4.0 2015-07-17
+
+*   `Element#[]=` now removes the attribute when the assigned value is nil.
+
+*   `Element#attr` now better follows jQuery's behaviour by checking the number of arguments passed. Also it's now just a proxy to `Element#[]` and `Element#[]=`
+
+*   `Element#[]` now returns `nil` only for attributes that are missing, better following jQuery behaviour (which is to return `undefined` on such attributes). `Element#has_attribute?` has been updated accordingly.
+
+*   Add `Element#prepend` method.
 
 ## 0.3.0 2015-02-03
 

data/README.md

@@ -290,6 +290,22 @@ request.errback { |response|
 }
 ```
 
+## Usage of JQuery plugins
+Extra plugins used for JQuery aren't available to ruby code by default, you will have to `expose` these functions to opal-jquery.
+
+```ruby
+Element.expose :cool_plugin
+```
+
+Arguments to a `exposed` function will be passed as they are, so these arguments will have to be passed as native JS instead of ruby code. A conversion to native JS can be done with the `.to_n` method.
+
+```ruby
+Element.expose :cool_plugin
+
+el = Element['.html_element']
+el.cool_plugin({argument: 'value', argument1: 1000}.to_n)
+```
+
 ##  License
 
 (The MIT License)

data/lib/opal/jquery/element.rb

@@ -244,6 +244,11 @@ class Element < `#{JQUERY_CLASS.to_n}`
   # @param content [String, Element]
   alias_native :append
 
+  # @!method prepend(content)
+  #
+  # @param content [String, Element]
+  alias_native :prepend
+
   # @!method serialize
   alias_native :serialize
 
@@ -296,13 +301,6 @@ class Element < `#{JQUERY_CLASS.to_n}`
   alias succ next
   alias << append
 
-  # @!method []=(attr, value)
-  #
-  # Set the given attribute `attr` on each element in this collection.
-  #
-  # @see http://api.jquery.com/attr/
-  alias_native :[]=, :attr
-
   # @!method add_class(class_name)
   alias_native :add_class, :addClass
 
@@ -320,12 +318,21 @@ class Element < `#{JQUERY_CLASS.to_n}`
   # @param content [String, Element]
   alias_native :html=, :html
 
+  # @!method index(selector_or_element = nil)
+  alias_native :index
+
+  # @!method is?(selector)
+  alias_native :is?, :is
+
   # @!method remove_attr(attr)
   alias_native :remove_attr, :removeAttr
 
   # @!method remove_class(class_name)
   alias_native :remove_class, :removeClass
 
+  # @!method submit()
+  alias_native :submit
+
   # @!method text=(text)
   #
   # Set text content of each element in this collection.
@@ -384,19 +391,39 @@ class Element < `#{JQUERY_CLASS.to_n}`
   end
 
   def [](name)
-    `self.attr(name) || nil`
+    %x{
+      var value = self.attr(name);
+      if(value === undefined) return nil;
+      return value;
+    }
   end
 
-  def attr(name, value=nil)
-    if value.nil?
-      `self.attr(name) || nil`
-    else
-      `self.attr(name, value)`
-    end
+  # Set the given attribute `attr` on each element in this collection.
+  #
+  # @see http://api.jquery.com/attr/
+  def []=(name, value)
+    `return self.removeAttr(name)` if value.nil?
+    `self.attr(name, value)`
+  end
+
+  def attr(*args)
+    %x{
+      var size = args.length;
+      switch (size) {
+      case 1:
+        return #{self[`args[0]`]};
+        break;
+      case 2:
+        return #{self[`args[0]`] = `args[1]`};
+        break;
+      default:
+        #{raise ArgumentError, '#attr only accepts 1 or 2 arguments'}
+      }
+    }
   end
 
   def has_attribute?(name)
-    `!!self.attr(name)`
+    `self.attr(name) !== undefined`
   end
 
   def append_to_body
@@ -635,6 +662,29 @@ class Element < `#{JQUERY_CLASS.to_n}`
     block
   end
 
+  def one(name, sel = nil, &block)
+    %x{
+      var wrapper = function(evt) {
+        if (evt.preventDefault) {
+          evt = #{Event.new `evt`};
+        }
+
+        return block.apply(null, arguments);
+      };
+
+      block._jq_wrap = wrapper;
+
+      if (sel == nil) {
+        self.one(name, wrapper);
+      }
+      else {
+        self.one(name, sel, wrapper);
+      }
+    }
+
+    block
+  end
+
   def off(name, sel, block = nil)
     %x{
       if (sel == null) {
@@ -649,6 +699,11 @@ class Element < `#{JQUERY_CLASS.to_n}`
     }
   end
 
+  # returns an Array of Hashes
+  def serialize_array
+    `self.serializeArray()`.map { |e| Hash.new(e) }
+  end
+
   alias size length
 
   def value

data/lib/opal/jquery/version.rb

@@ -1,5 +1,5 @@
 module Opal
   module JQuery
-    VERSION = '0.3.0'
+    VERSION = '0.4.0'
   end
 end

data/opal-jquery.gemspec

@@ -15,7 +15,7 @@ Gem::Specification.new do |s|
   s.test_files     = `git ls-files -- {test,spec,features}/*`.split("\n")
   s.require_paths  = ['lib']
 
-  s.add_runtime_dependency 'opal', '~> 0.7.0'
+  s.add_runtime_dependency 'opal', '>= 0.7.0', '< 0.9.0'
   s.add_development_dependency 'opal-rspec', '~> 0.4.0'
   s.add_development_dependency 'yard'
   s.add_development_dependency 'rake'

data/spec/element/attributes_spec.rb

@@ -11,6 +11,8 @@ describe Element do
     <div id="attr-baz" title=""></div>
     <div id="attr-woosh"></div>
     <div id="attr-kapow" title="Apples"></div>
+    <div id="attr-empty" attr-empty-value=""></div>
+    <div id="attr-missing" attr-auto-value></div>
 
     <div id="has-foo" class="apples"></div>
     <div id="has-bar" class="lemons bananas"></div>
@@ -45,9 +47,15 @@ describe Element do
       Element.find('#attr-foo')[:title].should == "Hello there!"
     end
 
-    it 'should return nil for an empty attribute' do
-      expect(Element.find('#attr-bar')[:title]).to be_nil
-      expect(Element.find('#attr-baz')[:title]).to be_nil
+    it 'should return nil for a missing attribute' do
+      expect(Element.find('#attr-missing')['attr-missing-value']).to be_nil
+    end
+
+    it 'should return "" for an attribute with empty value' do
+      expect(Element.find('#attr-empty')['attr-empty-value']).to eq("")
+
+      # Not sure if this is browser dependant
+      expect(Element.find('#attr-missing')['attr-auto-value']).to eq("")
     end
   end
 
@@ -56,9 +64,15 @@ describe Element do
       expect(Element.find('#attr-foo').attr(:title)).to eq('Hello there!')
     end
 
-    it 'returns nil for empty attributes' do
-      expect(Element.find('#attr-bar').attr(:title)).to be_nil
-      expect(Element.find('#attr-baz').attr(:title)).to be_nil
+    it 'should return nil for a missing attribute' do
+      expect(Element.find('#attr-missing').attr('attr-missing-value')).to be_nil
+    end
+
+    it 'should return "" for an attribute with empty value' do
+      expect(Element.find('#attr-empty').attr('attr-empty-value')).to eq("")
+
+      # Not sure if this is browser dependant
+      expect(Element.find('#attr-missing').attr('attr-auto-value')).to eq("")
     end
   end
 

data/spec/element/prepend_spec.rb

@@ -0,0 +1,21 @@
+require 'spec_helper'
+
+describe 'Element#prepend' do
+  html <<-HTML
+    <div id="foo"></div>
+    <div id="bar">
+      <p>Something</p>
+    </div>
+  HTML
+
+  it 'inserts the given html to beginning of element' do
+    foo = Element.find '#foo'
+    bar = Element.find '#bar'
+
+    foo.prepend '<span>Bore Da</span>'
+    expect(foo.children.first.text).to eq 'Bore Da'
+
+    bar.prepend '<span>Charlie</span>'
+    expect(bar.children.first.text).to eq 'Charlie'
+  end
+end

data/spec/element_spec.rb

@@ -224,3 +224,38 @@ describe "Element#html" do
     expect(foo.html).to include('different content')
   end
 end
+
+describe 'Element.expose' do
+  subject(:element) { Element.new }
+  before do
+    `$.fn.exposableMethod = function() {return 123}`
+    `$.fn.exposableMethod2 = function() {return 12}`
+  end
+
+  after do
+    `delete $.fn.exposableMethod; delete $.fn.$exposableMethod;`
+    `delete $.fn.exposableMethod2; delete $.fn.$exposableMethod2;`
+  end
+
+  it 'exposes methods defined on $.fn' do
+    expect(element).not_to respond_to(:exposableMethod)
+    Element.expose :exposableMethod
+    expect(element).to respond_to(:exposableMethod)
+    expect(element.exposableMethod).to eq(123)
+  end
+
+  it 'work if exposing the same method multiple times' do
+    Element.expose :exposableMethod
+    Element.expose :exposableMethod
+    expect(element.exposableMethod).to eq(123)
+
+    Element.expose :exposableMethod, :exposableMethod
+    expect(element.exposableMethod).to eq(123)
+  end
+
+  it 'work if exposing multiple methods' do
+    Element.expose :exposableMethod, :exposableMethod2
+    expect(element.exposableMethod).to eq(123)
+    expect(element.exposableMethod2).to eq(12)
+  end
+end

metadata

@@ -1,29 +1,35 @@
 --- !ruby/object:Gem::Specification
 name: opal-jquery
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.4.0
 platform: ruby
 authors:
 - Adam Beynon
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-02-03 00:00:00.000000000 Z
+date: 2015-07-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: opal
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: 0.7.0
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: 0.9.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: 0.7.0
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: 0.9.0
 - !ruby/object:Gem::Dependency
   name: opal-rspec
   requirement: !ruby/object:Gem::Requirement
@@ -116,6 +122,7 @@ files:
 - spec/element/iterable_spec.rb
 - spec/element/length_spec.rb
 - spec/element/method_missing_spec.rb
+- spec/element/prepend_spec.rb
 - spec/element/to_s_spec.rb
 - spec/element/traversing_spec.rb
 - spec/element_spec.rb
@@ -149,7 +156,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5
+rubygems_version: 2.4.6
 signing_key: 
 specification_version: 4
 summary: Opal access to jquery
@@ -170,6 +177,7 @@ test_files:
 - spec/element/iterable_spec.rb
 - spec/element/length_spec.rb
 - spec/element/method_missing_spec.rb
+- spec/element/prepend_spec.rb
 - spec/element/to_s_spec.rb
 - spec/element/traversing_spec.rb
 - spec/element_spec.rb