ood_appkit 0.3.0 → 0.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b6fbe94cce7c92a5b9ccf234d59a65c42a25af6d
-  data.tar.gz: 48b20a943231ce1ddcd150d482a9c84ede36a22d
+  metadata.gz: 9d340f86f9f789a9b3734ed32122c4d07ee1e435
+  data.tar.gz: b98f8a153e6f6838524c3bd31c42d840736a00fc
 SHA512:
-  metadata.gz: e2b6601dbd55a03f526802e8c88e9104dbf43939b49fc10c09b649e5d23143d858c5b2520e6b3993f743fe33fdc394f55f0b6582304ce3d28fd45bee0e3355a0
-  data.tar.gz: f4052ec287e187c7c7469309c60aa7a40193538cf1b0306bedb0ac9efc7caf23fc42f1a8a1cd0824470d4a596946587f8d70682f7ad9829d4ae72ec18cc32dde
+  metadata.gz: c52000abc27ec403f4f908f8434ef466139d6408294dd5eef3ddf3f2d7948cd7ddff58326b2bc0a2bcfd901a0823a3dc102da2482c56d7a2287596698797f497
+  data.tar.gz: 24768570fcde9938b3fdaeac0950cdc778057048a03f761ca3792a2908e6d84af801590097e78be10c072c072cecb009842d683f46d90ec46e0ca21d7d713260

data/README.md

@@ -541,10 +541,32 @@ Depending on the type of server chosen, different helper methods will be
 available to the developer. You can find more details on this at
 https://github.com/OSC/ood_cluster.
 
-#### Reservations
+#### Validations
 
-If reservations are supported for the chosen cluster, then a cluster object can
-be used to query reservation information for the current user:
+A cluster may support more validations than whether the current user can access
+it. The extra validations are defined in the configuration YAML file as such:
+
+```yaml
+validators:
+  cluster:
+    - type: "OodAppkit::Validators::Groups"
+      data:
+        groups:
+          - "ruby"
+        allow: true
+  rsv_query:
+    - type: "OodAppkit::Validators::Groups"
+      data:
+        groups:
+          - "sysp"
+          - "hpcsoft"
+        allow: false
+```
+
+where the key is used in the `OodAppkit::ClusterDecorator#valid?` method.
+
+One such validation is whether the current user can query their reservation
+information for the given cluster:
 
 ```ruby
 # Check if reservation query object is valid (am I allowed to use it)
@@ -552,17 +574,9 @@ be used to query reservation information for the current user:
 #     view ALL reservations. This can cause the app to hang.
 my_cluster.valid?(:rsv_query) #=> true
 
-# Get reservation query object
-my_rsv_query = my_cluster.rsv_query
-#=> #<OodReservations::Queries::TorqueMoab>
-
-# Try to get reservation query object from cluster that doesn't support
-# reservations
-cluster_with_no_rsvs.rsv_query
-#=> nil
-
-# Get all reservations I have on this cluster
-my_rsv_query.reservations
+# I am allowed to use it so let's query for user's reservations
+require 'ood_reservations'
+my_rsv_query = OodReservations::Query.build(cluster: my_cluster).reservations
 #=> [ #<OodReservations::Reservation>, ... ]
 ```
 

data/lib/ood_appkit/cluster_decorator.rb

@@ -37,12 +37,6 @@ module OodAppkit
       @validators.fetch(method.to_sym, []).all? { |v| v.success? }
     end
 
-    # A reservation query object used to query reservations for current user
-    # @return [OodReservations::Query,nil] reservation query object
-    def rsv_query
-      OodReservations::Query.build(cluster: self)
-    end
-
     # The comparison operator
     # @param other [#to_sym] object to compare against
     # @return [Boolean] whether objects are equivalent

data/lib/ood_appkit/version.rb

@@ -1,4 +1,4 @@
 module OodAppkit
   # The current version of OodAppkit
-  VERSION = "0.3.0"
+  VERSION = "0.3.1"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ood_appkit
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.3.1
 platform: ruby
 authors:
 - Eric Franz
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-08-30 00:00:00.000000000 Z
+date: 2016-09-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -58,20 +58,6 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '0.0'
-- !ruby/object:Gem::Dependency
-  name: ood_reservations
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.0'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.0'
 - !ruby/object:Gem::Dependency
   name: addressable
   requirement: !ruby/object:Gem::Requirement