onlyoffice_rspec_result_parser 0.1.1 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 90e494964654c9785bcf0e3576c891c74995aa19bbea965bdf02788047b886db
-  data.tar.gz: 417b08f08a82b69cf705be228a1b693a31cbfebab837a1e17bb97cd56c5df385
+  metadata.gz: de345de09e6bcbeb4b5a175a6e06d22986684da50e75ea860e700c9c3d161675
+  data.tar.gz: 7bba8b2ba22b9a9c94a8faa2f475353037b8f8bf0602c9bcccad19c416614ccd
 SHA512:
-  metadata.gz: a70703d0688597535b338adcf5782db1653731ff6708188abdb84310cf9042821978f19e80afc0dbbc79d11c7a1f45ae674884403faf01cd2fd2b86b1ecc50a0
-  data.tar.gz: c0db9d126625febd4a249f7f6a9c3c12dc8b23f15ba13af3eae33ff13624eaa928db866d20ba0c10cbcbcec7d75255bea53fd8cb2bb518dec9c20b4814652ccd
+  metadata.gz: 2175fc3e4324f977c83b39ad2142f765bfe1b4bd9248587f719e75de9cf638087a0f230fcb9841493abdbd98495b6c49dbb3c033a45ea6cccfb577b1514c5aa1
+  data.tar.gz: 3c862db57ea7ed237a9a8c662be49a15d81563e78921a5dd402ff484ca94ecfb37e8da211c38b8dd2768a6771262a160b87d46a81dd4608e9c9e45bf76c9dcd4

data/lib/onlyoffice_rspec_result_parser/rspec_result_parser.rb

@@ -32,17 +32,19 @@ module OnlyofficeRspecResultParser
       alias parse_rspec_html_string parse_rspec_html
 
       def get_failed_cases_count_from_html(html_path)
-        return 0 if html_path.empty?
-
         page = Nokogiri::HTML(read_file(html_path))
-        RspecResult.new.parse_page(page, true).failed_count
+        result = RspecResult.new(page).parse_page(true)
+        return 0 unless result.valid_html?
+
+        result.failed_count
       end
 
       def get_total_result_of_rspec_html(html_path)
-        return html_path if html_path.empty?
-
         page = Nokogiri::HTML(read_file(html_path))
-        RspecResult.new.parse_page(page, true).total
+        result = RspecResult.new(page).parse_page(true)
+        return '' unless result.valid_html?
+
+        result.total
       end
 
       # @param page [String] data in page
@@ -51,7 +53,7 @@ module OnlyofficeRspecResultParser
       # @return [RspecResult] result of parsing
       def parse_test_result(page, with_describe_info: true)
         ResultParser.example_index = 0
-        RspecResult.new.parse_page(page, with_describe_info)
+        RspecResult.new(page).parse_page(with_describe_info)
       end
 
       private

data/lib/onlyoffice_rspec_result_parser/rspec_result_parser/rspec_result.rb

@@ -12,31 +12,46 @@ module OnlyofficeRspecResultParser
     attr_accessor :passed_count
     # @return [Integer] how much tests pending
     attr_accessor :pending_count
+    # @return [String] html page of RspecResult
+    attr_reader :page
+
+    def initialize(page)
+      @page = page
+    end
 
     # @return [Integer] total test result count
     def total_tests_count
       failed_count + passed_count
     end
 
-    def parse_page(page, with_describe_info = true)
-      @describe = get_describe(page) if with_describe_info
-      @processing = get_processing(page)
-      @result = get_total_result(page)
-      @time = get_total_time(page)
-      @total = get_totals(page)
-      @failed_count = get_failed_count(page)
-      @passed_count = get_passed_count(page)
-      @pending_count = get_pending_count(page)
+    def parse_page(with_describe_info = true)
+      return self unless valid_html?
+
+      @describe = fetch_describe if with_describe_info
+      @processing = fetch_processing
+      @result = fetch_total_result
+      @time = fetch_total_time
+      @total = fetch_totals
+      @failed_count = fetch_failed_count
+      @passed_count = fetch_passed_count
+      @pending_count = fetch_pending_count
       self
     end
 
+    # @return [True, False] is html code is valid
+    def valid_html?
+      return false unless page.at_css('div.results')
+
+      true
+    end
+
     private
 
-    def get_describe(page)
+    def fetch_describe
       results = ResultCreator.new
       page.at_css('div.results').xpath('./div').each do |current|
         results.push_to_end(parse_describe(current),
-                            get_describe_level(current))
+                            fetch_describe_level(current))
       end
       results.final_result
     end
@@ -52,14 +67,14 @@ module OnlyofficeRspecResultParser
       describe_obj
     end
 
-    def get_describe_level(describe)
+    def fetch_describe_level(describe)
       style_string = describe.xpath('./dl')[0][:style]
       style_parameter = StringHelper.get_style_param(style_string,
                                                      'margin-left')
       StringHelper.delete_px(style_parameter).to_i / LEVEL_MARGIN
     end
 
-    def get_processing(page)
+    def fetch_processing
       processing = page.css('script:contains("moveProgressBar")').last
       return '0' unless processing
 
@@ -71,11 +86,11 @@ module OnlyofficeRspecResultParser
       end
     end
 
-    def get_total_result(page)
-      get_totals(page).include?(' 0 failures')
+    def fetch_total_result
+      fetch_totals.include?(' 0 failures')
     end
 
-    def get_totals(page)
+    def fetch_totals
       totals = ''
       total_elem = page.css('script:contains(" example")')
       return totals unless total_elem
@@ -88,19 +103,19 @@ module OnlyofficeRspecResultParser
       end
     end
 
-    def get_failed_count(page)
+    def fetch_failed_count
       page.xpath("//*[@class='example failed']").length
     end
 
-    def get_passed_count(page)
+    def fetch_passed_count
       page.xpath("//*[@class='example passed']").length
     end
 
-    def get_pending_count(page)
+    def fetch_pending_count
       page.xpath("//*[@class='example not_implemented']").length
     end
 
-    def get_total_time(page)
+    def fetch_total_time
       total_time = page.css('script:contains("Finished in")')
                        .text
                        .match(/>(.*?)</)

data/lib/onlyoffice_rspec_result_parser/version.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
 module OnlyofficeRspecResultParser
-  VERSION = '0.1.1'
+  VERSION = '0.1.2'
   NAME = 'onlyoffice_rspec_result_parser'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: onlyoffice_rspec_result_parser
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - ONLYOFFICE
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-03-24 00:00:00.000000000 Z
+date: 2020-04-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri