online_migrations 0.7.1 → 0.7.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1194e93630871eb20ffe647cbc6b7bea10a608e5cfdb9060d7ec23f3edf7d364
-  data.tar.gz: 6f88e04a9556be655a4a60688e97a6f4f348bef5c00ca45db91ac8c9437d7e64
+  metadata.gz: 882229e8b11af47ea2e30e16aa8ff55dd482ce1131175ac0287ba3ac2c24142f
+  data.tar.gz: d1e2c65e980c4dc32aa15498dedd3ed7b186e56f4765ff12e25f4cb977797f81
 SHA512:
-  metadata.gz: 7d37838f47ea574fa8a2ad88db0c61ec6db681bf8081453a46d288480d5e27733a8e19e540841a73c87e3ece96eedef0bf01d4e7520a9b648b627e7da49538ff
-  data.tar.gz: b341891c3b81a5d4b68af360ee1ed8b7d9245685e1a3e50966c7547e3c79e132c6d8c028b733e64920587200ae95e31144d21ac2c23dcf936618a223c5e5d34f
+  metadata.gz: 1b008939f6db560c92d0c1742e91a62782a0629dc5700e51e3f16269d76d1e394b1fbed45df1f2066777edf787e77c248271d5b056f747300ec48e0b7f5064c7
+  data.tar.gz: 3d46aa208a7675a4a9a3762dedb7cc25a5cf62724bc7af3774eb5c25e30b07573fe87f3e8803828e98095af7eed71d1e4724a3ec25e20b845d1d8e1c7ca62126

data/CHANGELOG.md

@@ -1,5 +1,12 @@
 ## master (unreleased)
 
+## 0.7.2 (2023-03-08)
+
+- Suggest additional steps for safely renaming a column if Active Record `enumerate_columns_in_select_statements`
+  setting is enabled (implemented in Active Record 7+, disabled by default)
+- Fix `add_reference_concurrently` to correctly check for existence of foreign keys
+- Fix column quoting in `add_not_null_constraint`
+
 ## 0.7.1 (2023-02-22)
 
 - Fix Schema Cache to correctly retrieve metadata from renamed tables

data/README.md

@@ -37,7 +37,7 @@ $ bundle install
 $ bin/rails generate online_migrations:install
 ```
 
-**Note**: If you do not have plans on using [background migrations](BACKGROUND_MIGRATIONS.md) feature, then you can delete the generated migration and regenerate it later, if needed.
+**Note**: If you do not have plans on using [background migrations](docs/background_migrations.md) feature, then you can delete the generated migration and regenerate it later, if needed.
 
 ## Motivation
 
@@ -388,6 +388,17 @@ end
 
 :white_check_mark: **Good**
 
+#### "Classic" approach (abstract)
+
+1. Create a new column
+2. Write to both columns
+3. Backfill data from the old column to the new column
+4. Move reads from the old column to the new column
+5. Stop writing to the old column
+6. Drop the old column
+
+#### :bullettrain_side: Enhanced approach (with concrete steps for Active Record)
+
 The "classic" approach suggests creating a new column and copy data/indexes/etc to it from the old column. This can be costly for very large tables. There is a trick that helps to avoid such heavy operations.
 
 The technique is built on top of database views, using the following steps:
@@ -445,9 +456,27 @@ end
 ```
 
 4. Replace usages of the old column with a new column in the codebase
-5. Deploy
-6. Remove the column rename config from step 1
-7. Remove the VIEW created in step 3 and finally rename the column:
+5. If you enabled Active Record `enumerate_columns_in_select_statements` setting in your application
+  (is disabled by default in Active Record >= 7), then you need to ignore old column:
+
+  ```ruby
+  # For ActiveRecord 5+
+  class User < ApplicationRecord
+    self.ignored_columns = ["name"]
+  end
+
+  # For ActiveRecord < 5
+  class User < ActiveRecord::Base
+    def self.columns
+      super.reject { |c| c.name == "name" }
+    end
+  end
+  ```
+
+6. Deploy
+7. Remove the column rename config from step 1
+8. Remove the column ignore from step 5, if added
+9. Remove the VIEW created in step 3 and finally rename the column:
 
 ```ruby
 class FinalizeRenameUsersNameToFirstName < ActiveRecord::Migration[7.0]
@@ -457,7 +486,7 @@ class FinalizeRenameUsersNameToFirstName < ActiveRecord::Migration[7.0]
 end
 ```
 
-8. Deploy
+10. Deploy
 
 ### Renaming a table
 
@@ -475,6 +504,17 @@ end
 
 :white_check_mark: **Good**
 
+#### "Classic" approach (abstract)
+
+1. Create a new table
+2. Write to both tables
+3. Backfill data from the old table to new table
+4. Move reads from the old table to the new table
+5. Stop writing to the old table
+6. Drop the old table
+
+#### :bullettrain_side: Enhanced approach (with concrete steps for Active Record)
+
 The "classic" approach suggests creating a new table and copy data/indexes/etc to it from the old table. This can be costly for very large tables. There is a trick that helps to avoid such heavy operations.
 
 The technique is built on top of database views, using the following steps:
@@ -1087,216 +1127,11 @@ Certain methods like `execute` and `change_table` cannot be inspected and are pr
 
 ## Configuring the gem
 
-There are a few configurable options for the gem. Custom configurations should be placed in a `online_migrations.rb` initializer.
-
-```ruby
-OnlineMigrations.configure do |config|
-  # ...
-end
-```
-
-**Note**: Check the [source code](https://github.com/fatkodima/online_migrations/blob/master/lib/online_migrations/config.rb) for the list of all available configuration options.
-
-### Custom checks
-
-Add your own custom checks with:
-
-```ruby
-# config/initializers/online_migrations.rb
-
-config.add_check do |method, args|
-  if method == :add_column && args[0].to_s == "users"
-    stop!("No more columns on the users table")
-  end
-end
-```
-
-Use the `stop!` method to stop migrations.
-
-**Note**: Since `remove_column`, `execute` and `change_table` always require a `safety_assured` block, it's not possible to add a custom check for these operations.
-
-### Disable Checks
-
-Disable specific checks with:
-
-```ruby
-# config/initializers/online_migrations.rb
-
-config.disable_check(:remove_index)
-```
-
-Check the [source code](https://github.com/fatkodima/online_migrations/blob/master/lib/online_migrations/error_messages.rb) for the list of keys.
-
-### Down Migrations / Rollbacks
-
-By default, checks are disabled when migrating down. Enable them with:
-
-```ruby
-# config/initializers/online_migrations.rb
-
-config.check_down = true
-```
-
-### Custom Messages
-
-You can customize specific error messages:
-
-```ruby
-# config/initializers/online_migrations.rb
-
-config.error_messages[:add_column_default] = "Your custom instructions"
-```
-
-Check the [source code](https://github.com/fatkodima/online_migrations/blob/master/lib/online_migrations/error_messages.rb) for the list of keys.
-
-### Migration Timeouts
-
-It’s extremely important to set a short lock timeout for migrations. This way, if a migration can't acquire a lock in a timely manner, other statements won't be stuck behind it.
-
-Add timeouts to `config/database.yml`:
-
-```yml
-production:
-  connect_timeout: 5
-  variables:
-    lock_timeout: 10s
-    statement_timeout: 15s
-```
-
-Or set the timeouts directly on the database user that runs migrations:
-
-```sql
-ALTER ROLE myuser SET lock_timeout = '10s';
-ALTER ROLE myuser SET statement_timeout = '15s';
-```
-
-### Lock Timeout Retries
-
-You can configure this gem to automatically retry statements that exceed the lock timeout:
-
-```ruby
-# config/initializers/online_migrations.rb
-
-config.lock_retrier = OnlineMigrations::ExponentialLockRetrier.new(
-  attempts: 30,                # attempt 30 retries
-  base_delay: 0.01.seconds,    # starting with delay of 10ms between each unsuccessful try, increasing exponentially
-  max_delay: 1.minute,         # maximum delay is 1 minute
-  lock_timeout: 0.05.seconds   # and 50ms set as lock timeout for each try
-)
-```
-
-When statement within transaction fails - the whole transaction is retried.
-
-To permanently disable lock retries, you can set `lock_retrier` to `nil`.
-To temporarily disable lock retries while running migrations, set `DISABLE_LOCK_RETRIES` env variable.
-
-**Note**: Statements are retried by default, unless lock retries are disabled. It is possible to implement more sophisticated lock retriers. See [source code](https://github.com/fatkodima/online_migrations/blob/master/lib/online_migrations/lock_retrier.rb) for the examples.
-
-### Existing Migrations
-
-To mark migrations as safe that were created before installing this gem, configure the migration version starting after which checks are performed:
-
-```ruby
-# config/initializers/online_migrations.rb
-
-config.start_after = 20220101000000
-
-# or if you use multiple databases (ActiveRecord 6+)
-config.start_after = { primary: 20211112000000, animals: 20220101000000 }
-```
-
-Use the version from your latest migration.
-
-### Target Version
-
-If your development database version is different from production, you can specify the production version so the right checks run in development.
-
-```ruby
-# config/initializers/online_migrations.rb
-
-config.target_version = 10 # or "12.9" etc
-
-# or if you use multiple databases (ActiveRecord 6+)
-config.target_version = { primary: 10, animals: 14.1 }
-```
-
-For safety, this option only affects development and test environments. In other environments, the actual server version is always used.
-
-### Small Tables
-
-Most projects have tables that are known to be small in size. These are usually "settings", "prices", "plans" etc. It is considered safe to perform most of the dangerous operations on them, like adding indexes, columns etc.
-
-To mark tables as small:
-
-```ruby
-config.small_tables = [:settings, :prices]
-```
-
-### Verbose SQL logs
-
-For any operation, **Online Migrations** can output the performed SQL queries.
-
-This is useful to demystify `online_migrations` inner workings, and to better investigate migration failure in production. This is also useful in development to get a better grasp of what is going on for high-level statements like `add_column_with_default`.
-
-Consider migration, running on PostgreSQL < 11:
-
-```ruby
-class AddAdminToUsers < ActiveRecord::Migration[7.0]
-  disable_ddl_transaction!
-
-  def change
-    add_column_with_default :users, :admin, :boolean, default: false
-  end
-end
-```
-
-Instead of the traditional output:
-
-```
-== 20220106214827 AddAdminToUsers: migrating ==================================
--- add_column_with_default(:users, :admin, :boolean, {:default=>false})
-   -> 0.1423s
-== 20220106214827 AddAdminToUsers: migrated (0.1462s) =========================
-```
-
-**Online Migrations** will output the following logs:
-
-```
-== 20220106214827 AddAdminToUsers: migrating ==================================
-   (0.3ms)  SHOW lock_timeout
-   (0.2ms)  SET lock_timeout TO '50ms'
--- add_column_with_default(:users, :admin, :boolean, {:default=>false})
-  TRANSACTION (0.1ms)  BEGIN
-   (37.7ms)  ALTER TABLE "users" ADD "admin" boolean DEFAULT NULL
-   (0.5ms)  ALTER TABLE "users" ALTER COLUMN "admin" SET DEFAULT FALSE
-  TRANSACTION (0.3ms)  COMMIT
-   Load (0.3ms)  SELECT "users"."id" FROM "users" WHERE ("users"."admin" != FALSE OR "users"."admin" IS NULL) ORDER BY "users"."id" ASC LIMIT $1  [["LIMIT", 1]]
-   Load (0.5ms)  SELECT "users"."id" FROM "users" WHERE ("users"."admin" != FALSE OR "users"."admin" IS NULL) AND "users"."id" >= 1 ORDER BY "users"."id" ASC LIMIT $1 OFFSET $2  [["LIMIT", 1], ["OFFSET", 1000]]
-  #<Class:0x00007f8ae3703f08> Update All (9.6ms)  UPDATE "users" SET "admin" = $1 WHERE ("users"."admin" != FALSE OR "users"."admin" IS NULL) AND "users"."id" >= 1 AND "users"."id" < 1001  [["admin", false]]
-   Load (0.8ms)  SELECT "users"."id" FROM "users" WHERE ("users"."admin" != FALSE OR "users"."admin" IS NULL) AND "users"."id" >= 1001 ORDER BY "users"."id" ASC LIMIT $1 OFFSET $2  [["LIMIT", 1], ["OFFSET", 1000]]
-  #<Class:0x00007f8ae3703f08> Update All (1.5ms)  UPDATE "users" SET "admin" = $1 WHERE ("users"."admin" != FALSE OR "users"."admin" IS NULL) AND "users"."id" >= 1001  [["admin", false]]
-   -> 0.1814s
-   (0.4ms)  SET lock_timeout TO '5s'
-== 20220106214827 AddAdminToUsers: migrated (0.1840s) =========================
-```
-
-So you can actually check which steps are performed.
-
-**Note**: The `SHOW` statements are used by **Online Migrations** to query settings for their original values in order to restore them after the work is done.
-
-To enable verbose sql logs:
-
-```ruby
-# config/initializers/online_migrations.rb
-
-config.verbose_sql_logs = true
-```
-
-This feature is enabled by default in a production Rails environment. You can override this setting via `ONLINE_MIGRATIONS_VERBOSE_SQL_LOGS` environment variable.
+Read [configuring.md](docs/configuring.md).
 
 ## Background Migrations
 
-Read [BACKGROUND_MIGRATIONS.md](BACKGROUND_MIGRATIONS.md) on how to perform data migrations on large tables.
+Read [background_migrations.md](docs/background_migrations.md) on how to perform data migrations on large tables.
 
 ## Credits
 
@@ -1361,7 +1196,7 @@ It has migrations helpers for:
 * adding different types of constraints
 * and others
 
-2. This gem has a [powerful internal framework](https://github.com/fatkodima/online_migrations/blob/master/BACKGROUND_MIGRATIONS.md) for running data migrations on very large tables using background migrations.
+2. This gem has a [powerful internal framework](https://github.com/fatkodima/online_migrations/blob/master/docs/background_migrations.md) for running data migrations on very large tables using background migrations.
 
 For example, you can use background migrations to migrate data that’s stored in a single JSON column to a separate table instead; backfill values from one column to another (as one of the steps when changing column type); or backfill some column’s value from an API.
 

data/docs/configuring.md

@@ -0,0 +1,208 @@
+# Configuring
+
+There are a few configurable options for the gem. Custom configurations should be placed in a `online_migrations.rb` initializer.
+
+```ruby
+OnlineMigrations.configure do |config|
+  # ...
+end
+```
+
+**Note**: Check the [source code](https://github.com/fatkodima/online_migrations/blob/master/lib/online_migrations/config.rb) for the list of all available configuration options.
+
+## Custom checks
+
+Add your own custom checks with:
+
+```ruby
+# config/initializers/online_migrations.rb
+
+config.add_check do |method, args|
+  if method == :add_column && args[0].to_s == "users"
+    stop!("No more columns on the users table")
+  end
+end
+```
+
+Use the `stop!` method to stop migrations.
+
+**Note**: Since `remove_column`, `execute` and `change_table` always require a `safety_assured` block, it's not possible to add a custom check for these operations.
+
+## Disable Checks
+
+Disable specific checks with:
+
+```ruby
+# config/initializers/online_migrations.rb
+
+config.disable_check(:remove_index)
+```
+
+Check the [source code](https://github.com/fatkodima/online_migrations/blob/master/lib/online_migrations/error_messages.rb) for the list of keys.
+
+## Down Migrations / Rollbacks
+
+By default, checks are disabled when migrating down. Enable them with:
+
+```ruby
+# config/initializers/online_migrations.rb
+
+config.check_down = true
+```
+
+## Custom Messages
+
+You can customize specific error messages:
+
+```ruby
+# config/initializers/online_migrations.rb
+
+config.error_messages[:add_column_default] = "Your custom instructions"
+```
+
+Check the [source code](https://github.com/fatkodima/online_migrations/blob/master/lib/online_migrations/error_messages.rb) for the list of keys.
+
+## Migration Timeouts
+
+It’s extremely important to set a short lock timeout for migrations. This way, if a migration can't acquire a lock in a timely manner, other statements won't be stuck behind it.
+
+Add timeouts to `config/database.yml`:
+
+```yml
+production:
+  connect_timeout: 5
+  variables:
+    lock_timeout: 10s
+    statement_timeout: 15s
+```
+
+Or set the timeouts directly on the database user that runs migrations:
+
+```sql
+ALTER ROLE myuser SET lock_timeout = '10s';
+ALTER ROLE myuser SET statement_timeout = '15s';
+```
+
+## Lock Timeout Retries
+
+You can configure this gem to automatically retry statements that exceed the lock timeout:
+
+```ruby
+# config/initializers/online_migrations.rb
+
+config.lock_retrier = OnlineMigrations::ExponentialLockRetrier.new(
+  attempts: 30,                # attempt 30 retries
+  base_delay: 0.01.seconds,    # starting with delay of 10ms between each unsuccessful try, increasing exponentially
+  max_delay: 1.minute,         # maximum delay is 1 minute
+  lock_timeout: 0.05.seconds   # and 50ms set as lock timeout for each try
+)
+```
+
+When statement within transaction fails - the whole transaction is retried.
+
+To permanently disable lock retries, you can set `lock_retrier` to `nil`.
+To temporarily disable lock retries while running migrations, set `DISABLE_LOCK_RETRIES` env variable.
+
+**Note**: Statements are retried by default, unless lock retries are disabled. It is possible to implement more sophisticated lock retriers. See [source code](https://github.com/fatkodima/online_migrations/blob/master/lib/online_migrations/lock_retrier.rb) for the examples.
+
+## Existing Migrations
+
+To mark migrations as safe that were created before installing this gem, configure the migration version starting after which checks are performed:
+
+```ruby
+# config/initializers/online_migrations.rb
+
+config.start_after = 20220101000000
+
+# or if you use multiple databases (ActiveRecord 6+)
+config.start_after = { primary: 20211112000000, animals: 20220101000000 }
+```
+
+Use the version from your latest migration.
+
+## Target Version
+
+If your development database version is different from production, you can specify the production version so the right checks run in development.
+
+```ruby
+# config/initializers/online_migrations.rb
+
+config.target_version = 10 # or "12.9" etc
+
+# or if you use multiple databases (ActiveRecord 6+)
+config.target_version = { primary: 10, animals: 14.1 }
+```
+
+For safety, this option only affects development and test environments. In other environments, the actual server version is always used.
+
+## Small Tables
+
+Most projects have tables that are known to be small in size. These are usually "settings", "prices", "plans" etc. It is considered safe to perform most of the dangerous operations on them, like adding indexes, columns etc.
+
+To mark tables as small:
+
+```ruby
+config.small_tables = [:settings, :prices]
+```
+
+## Verbose SQL logs
+
+For any operation, **Online Migrations** can output the performed SQL queries.
+
+This is useful to demystify `online_migrations` inner workings, and to better investigate migration failure in production. This is also useful in development to get a better grasp of what is going on for high-level statements like `add_column_with_default`.
+
+Consider migration, running on PostgreSQL < 11:
+
+```ruby
+class AddAdminToUsers < ActiveRecord::Migration[7.0]
+  disable_ddl_transaction!
+
+  def change
+    add_column_with_default :users, :admin, :boolean, default: false
+  end
+end
+```
+
+Instead of the traditional output:
+
+```
+== 20220106214827 AddAdminToUsers: migrating ==================================
+-- add_column_with_default(:users, :admin, :boolean, {:default=>false})
+   -> 0.1423s
+== 20220106214827 AddAdminToUsers: migrated (0.1462s) =========================
+```
+
+**Online Migrations** will output the following logs:
+
+```
+== 20220106214827 AddAdminToUsers: migrating ==================================
+   (0.3ms)  SHOW lock_timeout
+   (0.2ms)  SET lock_timeout TO '50ms'
+-- add_column_with_default(:users, :admin, :boolean, {:default=>false})
+  TRANSACTION (0.1ms)  BEGIN
+   (37.7ms)  ALTER TABLE "users" ADD "admin" boolean DEFAULT NULL
+   (0.5ms)  ALTER TABLE "users" ALTER COLUMN "admin" SET DEFAULT FALSE
+  TRANSACTION (0.3ms)  COMMIT
+   Load (0.3ms)  SELECT "users"."id" FROM "users" WHERE ("users"."admin" != FALSE OR "users"."admin" IS NULL) ORDER BY "users"."id" ASC LIMIT $1  [["LIMIT", 1]]
+   Load (0.5ms)  SELECT "users"."id" FROM "users" WHERE ("users"."admin" != FALSE OR "users"."admin" IS NULL) AND "users"."id" >= 1 ORDER BY "users"."id" ASC LIMIT $1 OFFSET $2  [["LIMIT", 1], ["OFFSET", 1000]]
+  #<Class:0x00007f8ae3703f08> Update All (9.6ms)  UPDATE "users" SET "admin" = $1 WHERE ("users"."admin" != FALSE OR "users"."admin" IS NULL) AND "users"."id" >= 1 AND "users"."id" < 1001  [["admin", false]]
+   Load (0.8ms)  SELECT "users"."id" FROM "users" WHERE ("users"."admin" != FALSE OR "users"."admin" IS NULL) AND "users"."id" >= 1001 ORDER BY "users"."id" ASC LIMIT $1 OFFSET $2  [["LIMIT", 1], ["OFFSET", 1000]]
+  #<Class:0x00007f8ae3703f08> Update All (1.5ms)  UPDATE "users" SET "admin" = $1 WHERE ("users"."admin" != FALSE OR "users"."admin" IS NULL) AND "users"."id" >= 1001  [["admin", false]]
+   -> 0.1814s
+   (0.4ms)  SET lock_timeout TO '5s'
+== 20220106214827 AddAdminToUsers: migrated (0.1840s) =========================
+```
+
+So you can actually check which steps are performed.
+
+**Note**: The `SHOW` statements are used by **Online Migrations** to query settings for their original values in order to restore them after the work is done.
+
+To enable verbose sql logs:
+
+```ruby
+# config/initializers/online_migrations.rb
+
+config.verbose_sql_logs = true
+```
+
+This feature is enabled by default in a production Rails environment. You can override this setting via `ONLINE_MIGRATIONS_VERBOSE_SQL_LOGS` environment variable.

data/lib/online_migrations/command_checker.rb

@@ -220,7 +220,8 @@ module OnlineMigrations
             new_column: new_column,
             model: table_name.to_s.classify,
             partial_writes: Utils.ar_partial_writes?,
-            partial_writes_setting: Utils.ar_partial_writes_setting
+            partial_writes_setting: Utils.ar_partial_writes_setting,
+            enumerate_columns_in_select_statements: Utils.ar_enumerate_columns_in_select_statements
         end
       end
 

data/lib/online_migrations/error_messages.rb

@@ -149,17 +149,42 @@ It will use a combination of a VIEW and column aliasing to work with both column
   end
 
 4. Replace usages of the old column with a new column in the codebase
+<% if enumerate_columns_in_select_statements %>
+5. Ignore old column
+
+<% if ar_version >= 5 %>
+  self.ignored_columns = [:<%= column_name %>]
+<% else %>
+  def self.columns
+    super.reject { |c| c.name == \"<%= column_name %>\" }
+  end
+<% end %>
+
+6. Deploy
+7. Remove the column rename config from step 1
+8. Remove the column ignore from step 5
+9. Remove the VIEW created in step 3 and finally rename the column:
+
+  class Finalize<%= migration_name %> < <%= migration_parent %>
+    def change
+      finalize_column_rename :<%= table_name %>, :<%= column_name %>, :<%= new_column %>
+    end
+  end
+
+10. Deploy
+<% else %>
 5. Deploy
 6. Remove the column rename config from step 1
 7. Remove the VIEW created in step 3 and finally rename the column:
 
   class Finalize<%= migration_name %> < <%= migration_parent %>
     def change
-      finalize_column_rename <%= table_name.inspect %>, <%= column_name.inspect %>, <%= new_column.inspect %>
+      finalize_column_rename :<%= table_name %>, :<%= column_name %>, :<%= new_column %>
     end
   end
 
-8. Deploy",
+8. Deploy
+<% end %>",
 
       change_column_with_not_null:
 "Changing the type is safe, but setting NOT NULL is not.",

data/lib/online_migrations/schema_statements.rb

@@ -507,7 +507,7 @@ module OnlineMigrations
          __not_null_constraint_exists?(table_name, column_name, name: name)
         Utils.say("NOT NULL constraint was not created: column #{table_name}.#{column_name} is already defined as `NOT NULL`")
       else
-        expression = "#{column_name} IS NOT NULL"
+        expression = "#{quote_column_name(column_name)} IS NOT NULL"
         name ||= __not_null_constraint_name(table_name, column_name)
         add_check_constraint(table_name, expression, name: name, validate: false)
 
@@ -687,7 +687,7 @@ module OnlineMigrations
         foreign_key = {} if foreign_key == true
 
         foreign_table_name = Utils.foreign_table_name(ref_name, foreign_key)
-        add_foreign_key(table_name, foreign_table_name, **foreign_key.merge(validate: false))
+        add_foreign_key(table_name, foreign_table_name, **foreign_key.merge(column: column_name, validate: false))
 
         if foreign_key[:validate] != false
           validate_foreign_key(table_name, foreign_table_name, **foreign_key)

data/lib/online_migrations/utils.rb

@@ -90,6 +90,14 @@ module OnlineMigrations
         end
       end
 
+      def ar_enumerate_columns_in_select_statements
+        if ar_version >= 7
+          ActiveRecord::Base.enumerate_columns_in_select_statements
+        else
+          false
+        end
+      end
+
       # Returns estimated rows count for a table.
       # https://www.citusdata.com/blog/2016/10/12/count-performance/
       def estimated_count(connection, table_name)

data/lib/online_migrations/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module OnlineMigrations
-  VERSION = "0.7.1"
+  VERSION = "0.7.2"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: online_migrations
 version: !ruby/object:Gem::Version
-  version: 0.7.1
+  version: 0.7.2
 platform: ruby
 authors:
 - fatkodima
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-02-22 00:00:00.000000000 Z
+date: 2023-03-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -31,10 +31,11 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- BACKGROUND_MIGRATIONS.md
 - CHANGELOG.md
 - LICENSE.txt
 - README.md
+- docs/background_migrations.md
+- docs/configuring.md
 - lib/generators/online_migrations/background_migration_generator.rb
 - lib/generators/online_migrations/install_generator.rb
 - lib/generators/online_migrations/templates/background_migration.rb.tt
@@ -101,7 +102,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.3
+rubygems_version: 3.4.7
 signing_key:
 specification_version: 4
 summary: Catch unsafe PostgreSQL migrations in development and run them easier in