online_migrations 0.5.0 → 0.5.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c2515b6dd51e983fbcbdb448d33273e77d5b7f30ef53bc42dacb5127ac390fc8
-  data.tar.gz: b099a129bfea91da13d1dbde5c08d18fb09ae195dd83b56495c5513a881f609f
+  metadata.gz: 95f3b31c9fe8edb868fade7dbdaed0ebf78d53da7a1ff52786a748663bc93bf5
+  data.tar.gz: 94c2fed042d39993d85f6641db3b4a86c3a360b3c858f48aeb2da052bb2c52cc
 SHA512:
-  metadata.gz: '0220675939d3a08c0ecb16ba3e4a212bb40106d34478b7008c2458d2eebbead2c897873634589a6ae55b0665fdf0a02fb691432c639198c7c3a59e378c10d023'
-  data.tar.gz: b3d9a76edb0f4e220790a7de2a2ba5f7930c9106599dd488f585f4003ae61166341feccd66cbc63965b5a181217fe5639eb17e836be48542b0070591c74b8ab6
+  metadata.gz: f844aa5e502a91739923039a8fb84d10ae9682404bd14bd4b92352400c6dae82963b21166178c72c47ea4ecbd0792b6f46da151d92ce205e217a5788c9a8b27a
+  data.tar.gz: 2db40b6b3cf81f923251f16a023aedbb18f8f24d28abb9e6b638090030c013c24dd6a41942df3e4f4cd1264c84c997eaaeb6adcb1c2d8d8844bc4934406f9ebc

data/CHANGELOG.md

@@ -1,5 +1,10 @@
 ## master (unreleased)
 
+## 0.5.1 (2022-07-19)
+
+- Raise for possible index corruption in all environments (previously, the check was made only
+  in the production environment)
+
 ## 0.5.0 (2022-06-23)
 
 - Added check for index corruption with PostgreSQL 14.0 to 14.3

data/lib/online_migrations/change_column_type_helpers.rb

@@ -100,7 +100,7 @@ module OnlineMigrations
       end.to_h
 
       if (extra_keys = (options.keys - conversions.keys)).any?
-        raise ArgumentError, "Options has unknown keys: #{extra_keys.map(&:inspect).join(', ')}. "\
+        raise ArgumentError, "Options has unknown keys: #{extra_keys.map(&:inspect).join(', ')}. " \
                              "Can contain only column names: #{conversions.keys.map(&:inspect).join(', ')}."
       end
 
@@ -400,7 +400,7 @@ module OnlineMigrations
 
           # This is necessary as we can't properly rename indexes such as "taggings_idx".
           unless index.name.include?(from_column)
-            raise "The index #{index.name} can not be copied as it does not "\
+            raise "The index #{index.name} can not be copied as it does not " \
                   "mention the old column. You have to rename this index manually first."
           end
 

data/lib/online_migrations/command_checker.rb

@@ -597,15 +597,14 @@ module OnlineMigrations
           if Utils.developer_env? && (target_version = OnlineMigrations.config.target_version)
             target_version.to_s
           else
-            # For rails 6.0+ we can use connection.database_version
-            pg_connection = connection.raw_connection
-            database_version = pg_connection.server_version
-            patch = database_version % 100
-            database_version /= 100
-            minor = database_version % 100
-            database_version /= 100
-            major = database_version
-            "#{major}.#{minor}.#{patch}"
+            database_version = connection.select_value("SHOW server_version_num").to_i
+            major = database_version / 10000
+            if database_version >= 100000
+              minor = database_version % 10000
+            else
+              minor = (database_version % 10000) / 100
+            end
+            "#{major}.#{minor}"
           end
 
         Gem::Version.new(version)
@@ -745,8 +744,7 @@ module OnlineMigrations
 
       def index_corruption?
         postgresql_version >= Gem::Version.new("14.0") &&
-          postgresql_version < Gem::Version.new("14.4") &&
-          !Utils.developer_env?
+          postgresql_version < Gem::Version.new("14.4")
       end
 
       def run_custom_checks(method, args)

data/lib/online_migrations/schema_statements.rb

@@ -404,7 +404,7 @@ module OnlineMigrations
         batch_options = options.extract!(:batch_size, :batch_column_name, :progress, :pause_ms)
 
         if column_exists?(table_name, column_name)
-          Utils.say("Column was not created because it already exists (this may be due to an aborted migration "\
+          Utils.say("Column was not created because it already exists (this may be due to an aborted migration " \
                     "or similar) table_name: #{table_name}, column_name: #{column_name}")
         else
           transaction do
@@ -655,7 +655,7 @@ module OnlineMigrations
         schema = __schema_for_table(table_name)
 
         if __index_valid?(index_name, schema: schema)
-          Utils.say("Index was not created because it already exists (this may be due to an aborted migration "\
+          Utils.say("Index was not created because it already exists (this may be due to an aborted migration " \
                     "or similar): table_name: #{table_name}, column_name: #{column_name}")
           return
         else
@@ -699,7 +699,7 @@ module OnlineMigrations
           end
         end
       else
-        Utils.say("Index was not removed because it does not exist (this may be due to an aborted migration "\
+        Utils.say("Index was not removed because it does not exist (this may be due to an aborted migration " \
                   "or similar): table_name: #{table_name}, column_name: #{column_names}")
       end
     end
@@ -768,7 +768,7 @@ module OnlineMigrations
       constraint_name = __check_constraint_name(table_name, expression: expression, **options)
 
       if __check_constraint_exists?(table_name, constraint_name)
-        Utils.say("Check constraint was not created because it already exists (this may be due to an aborted migration "\
+        Utils.say("Check constraint was not created because it already exists (this may be due to an aborted migration " \
                   "or similar) table_name: #{table_name}, expression: #{expression}, constraint name: #{constraint_name}")
       else
         query = "ALTER TABLE #{table_name} ADD CONSTRAINT #{constraint_name} CHECK (#{expression})"

data/lib/online_migrations/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module OnlineMigrations
-  VERSION = "0.5.0"
+  VERSION = "0.5.1"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: online_migrations
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.5.1
 platform: ruby
 authors:
 - fatkodima
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-06-23 00:00:00.000000000 Z
+date: 2022-07-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord