online_migrations 0.29.1 → 0.29.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: cdc577e6585babba94ffe21df14f59b4a41681a0f80046e677452741123534d1
-  data.tar.gz: 25f2d76cece9c0c1ae1a61d099e69599391a67f2ac3690abc537852873862df6
+  metadata.gz: 8f0f48b03f81c0a92af100d5d547eefc241806204f0cc0a475eb528fed026037
+  data.tar.gz: 74f9246907e52d527c46f832e66ab4b4b74c89e0ea9492612a303a1d65f006c7
 SHA512:
-  metadata.gz: 14049ce85c5832741d1b0d5928b8e1d69924601f69c56a07d534c0aa558be60928c71d37eb3715cd892e9af68a44e7dd3d69d048c9bb52f5464a2ac7ad97f512
-  data.tar.gz: 7b96a5bea220ea7283bd7a2bacc82b646de611d1b9704abafc412948ea77279cd2fbbf26908a43f1877a99e36d54ad52323a038297e4340600c4ce52d1cbada7
+  metadata.gz: d55296987b866078354a39a06f431c360a18935803b852a5768549b3ae9f18bf8d27a3b0608086b1bf9c20ecaa006ea782ed7f128bd45c57d32bce50e8cc67e3
+  data.tar.gz: b57ae5030819e74eb891565fd87c77a1762ed1e3aa8f74ec4fba570f286150f6da500279f7bbea95cf7e0fb360dcf3acd491ee05e1ce8e635889549211d55bf8

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 ## master (unreleased)
 
+## 0.29.2 (2025-07-21)
+
+- Fix analyzing tables when indexes are added
+
 ## 0.29.1 (2025-07-17)
 
 - Fix idempotency for adding/removing indexes in background

data/lib/generators/online_migrations/templates/initializer.rb.tt

@@ -33,7 +33,7 @@ OnlineMigrations.configure do |config|
 
   # Analyze tables after indexes are added.
   # Outdated statistics can sometimes hurt performance.
-  config.auto_analyze = false
+  config.auto_analyze = true
 
   # Alphabetize table columns when dumping the schema.
   config.alphabetize_schema = false
@@ -130,7 +130,7 @@ OnlineMigrations.configure do |config|
   config.background_schema_migrations.max_attempts = 5
 
   # Statement timeout value used when running background schema migration.
-  config.background_schema_migrations.statement_timeout = 1.hour
+  config.background_schema_migrations.statement_timeout = config.statement_timeout
 
   # The callback to perform when an error occurs during the background schema migration.
   # config.background_schema_migrations.error_handler = ->(error, errored_migration) do

data/lib/online_migrations/background_data_migrations/reset_counters.rb

@@ -55,7 +55,7 @@ module OnlineMigrations
       end
 
       private
-        def has_many_association(counter_association) # rubocop:disable Naming/PredicateName
+        def has_many_association(counter_association) # rubocop:disable Naming/PredicatePrefix
           has_many_association = model.reflect_on_association(counter_association)
 
           if !has_many_association

data/lib/online_migrations/background_schema_migrations/migration.rb

@@ -138,7 +138,7 @@ module OnlineMigrations
                   if index.valid?
                     return
                   else
-                    connection.remove_index(table_name, name: name, algorithm: :concurrently)
+                    connection.remove_index(table_name, name: index.name, algorithm: :concurrently)
                   end
                 end
               end

data/lib/online_migrations/command_checker.rb

@@ -558,11 +558,6 @@ module OnlineMigrations
               end
             end
           end
-
-          # Outdated statistics + a new index can hurt performance of existing queries.
-          if OnlineMigrations.config.auto_analyze && direction == :up
-            connection.execute("ANALYZE #{table_name}")
-          end
         end
       end
 

data/lib/online_migrations/schema_statements.rb

@@ -434,7 +434,7 @@ module OnlineMigrations
     #                           batch_size: 10_000, pause_ms: 100)
     #
     # @note This method should not be run within a transaction
-    # @note For PostgreSQL 11+ you can use `add_column` instead
+    # @note If default value is not volatile, for PostgreSQL 11+ you can use `add_column` instead.
     #
     def add_column_with_default(table_name, column_name, type, **options)
       default = options.fetch(:default)
@@ -727,6 +727,11 @@ module OnlineMigrations
       # It only conflicts with constraint validations, creating/removing indexes,
       # and some other "ALTER TABLE"s.
       super
+
+      # Outdated statistics + a new index can hurt performance of existing queries.
+      if OnlineMigrations.config.auto_analyze
+        execute("ANALYZE #{table_name}")
+      end
     end
 
     # Extends default method to be idempotent.
@@ -777,22 +782,6 @@ module OnlineMigrations
       end
     end
 
-    # Extends default method with disabled statement timeout while validation is run
-    #
-    # @see https://edgeapi.rubyonrails.org/classes/ActiveRecord/ConnectionAdapters/PostgreSQL/SchemaStatements.html#method-i-validate_foreign_key
-    #
-    def validate_foreign_key(from_table, to_table = nil, **options)
-      foreign_key = foreign_key_for!(from_table, to_table: to_table, **options)
-
-      # Skip costly operation if already validated.
-      return if foreign_key.validated?
-
-      # "VALIDATE CONSTRAINT" requires a "SHARE UPDATE EXCLUSIVE" lock.
-      # It only conflicts with other validations, creating/removing indexes,
-      # and some other "ALTER TABLE"s.
-      super
-    end
-
     # Extends default method to be idempotent.
     #
     # @see https://edgeapi.rubyonrails.org/classes/ActiveRecord/ConnectionAdapters/SchemaStatements.html#method-i-remove_foreign_key
@@ -823,22 +812,6 @@ module OnlineMigrations
       end
     end
 
-    # Extends default method with disabled statement timeout while validation is run
-    #
-    # @see https://edgeapi.rubyonrails.org/classes/ActiveRecord/ConnectionAdapters/PostgreSQL/SchemaStatements.html#method-i-validate_check_constraint
-    #
-    def validate_check_constraint(table_name, **options)
-      check_constraint = check_constraint_for!(table_name, **options)
-
-      # Skip costly operation if already validated.
-      return if check_constraint.validated?
-
-      # "VALIDATE CONSTRAINT" requires a "SHARE UPDATE EXCLUSIVE" lock.
-      # It only conflicts with other validations, creating/removing indexes,
-      # and some other "ALTER TABLE"s.
-      super
-    end
-
     # Extends default method to be idempotent
     #
     # @see https://edgeapi.rubyonrails.org/classes/ActiveRecord/ConnectionAdapters/SchemaStatements.html#method-i-remove_check_constraint

data/lib/online_migrations/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module OnlineMigrations
-  VERSION = "0.29.1"
+  VERSION = "0.29.2"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: online_migrations
 version: !ruby/object:Gem::Version
-  version: 0.29.1
+  version: 0.29.2
 platform: ruby
 authors:
 - fatkodima
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2025-07-17 00:00:00.000000000 Z
+date: 2025-07-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord