online_migrations 0.19.2 → 0.19.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: aefd589066f5ee8e4d42964683576a6407782d5a065dae55c42336c4b50af8c6
-  data.tar.gz: 1723e4fd7388be89ac5b30095a4431a5829729b90b984054752ba1645c318b68
+  metadata.gz: 4d8223e51d4016b3752a738ecbc04cc200c94ee44dd3d91a1be2aefbc74060a9
+  data.tar.gz: bbaa8a04c4b730ac33e1503c59782658f6810f9782b4f882ab2b19bd0e0402d2
 SHA512:
-  metadata.gz: c964e25e31eed2fab19c6c205c7c0355ca8fbb1eced99898d17a0385b8f5f8411a8cf1822df3973efe5e69a5fbe7620ee8150e97f167996f55347732b9bcb8c4
-  data.tar.gz: c90709c6369c7a3f5d8c36a92f1a4e98099a538957ac7f282ea04b594df1ffb814d1ef5f5a803a4692c377984ae74ef0b4ddd77ec0e32c91c201087d9d0eafe5
+  metadata.gz: 878031d1e81e5a069500e4c9c8f0d2bb9b9b60320e07ce101a7ae8680556a6a8114de4d0f6bf092340ec3651f9bbbb74fdc6e6453db39be3c22f6846b5a2ad94
+  data.tar.gz: 143a618f2d46a8a452c9f32ca87f44e47dffe5268bae00dcff008f54865cf272e20bb6aa4af7243cf642a195e64e9aed8269660f1658ebb3440bff12eeed37df

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 ## master (unreleased)
 
+## 0.19.3 (2024-08-09)
+
+- Fix idempotency for `add_index`/`remove_index` for expression indexes
+
 ## 0.19.2 (2024-07-09)
 
 - Fix `add_reference_concurrently` to be idempotent when adding a foreign key

data/lib/online_migrations/schema_statements.rb

@@ -684,9 +684,17 @@ module OnlineMigrations
     def add_index(table_name, column_name, **options)
       __ensure_not_in_transaction! if options[:algorithm] == :concurrently
 
-      # Rewrite this with `IndexDefinition#defined_for?` when Active Record >= 7.1 is supported.
-      # See https://github.com/rails/rails/pull/45160.
-      index = indexes(table_name).find { |i| __index_defined_for?(i, column_name, **options) }
+      index =
+        if column_name.is_a?(String) && column_name.match?(/\W/)
+          # Use only name to check if index exists, because it does not work for complex expressions.
+          index_name = (options[:name] || index_name(table_name, column_name)).to_s
+          indexes(table_name).find { |i| i.name == index_name }
+        else
+          # Rewrite this with `IndexDefinition#defined_for?` when Active Record >= 7.1 is supported.
+          # See https://github.com/rails/rails/pull/45160.
+          indexes(table_name).find { |i| __index_defined_for?(i, column_name, **options) }
+        end
+
       if index
         schema = __schema_for_table(table_name)
 
@@ -729,7 +737,17 @@ module OnlineMigrations
 
       __ensure_not_in_transaction! if options[:algorithm] == :concurrently
 
-      if index_exists?(table_name, column_name, **options)
+      column = column_name || options[:column]
+      index_exists =
+        if column.is_a?(String) && column.match?(/\W/)
+          # Use only name to check if index exists, because it does not work for complex expressions.
+          index_name = options[:name] || index_name(table_name, column)
+          index_name_exists?(table_name, index_name)
+        else
+          index_exists?(table_name, column_name, **options)
+        end
+
+      if index_exists
         if OnlineMigrations.config.statement_timeout
           # "DROP INDEX CONCURRENTLY" requires a "SHARE UPDATE EXCLUSIVE" lock.
           # It only conflicts with constraint validations, other creating/removing indexes,

data/lib/online_migrations/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module OnlineMigrations
-  VERSION = "0.19.2"
+  VERSION = "0.19.3"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: online_migrations
 version: !ruby/object:Gem::Version
-  version: 0.19.2
+  version: 0.19.3
 platform: ruby
 authors:
 - fatkodima
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-07-09 00:00:00.000000000 Z
+date: 2024-08-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord