online_migrations 0.16.0 → 0.16.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 48ddbce66257c9010d8ab7361d8860cd898854207b5a1f4c6aa2b6b797aec2e1
-  data.tar.gz: c21fbb5f535f788e13068e339eebe77f05a378c68c00244c4522a10d50a28a0d
+  metadata.gz: '0759df02ba803fe453e3f1f67eac92f73ad9c874a09aa5b9768c2dc82509af03'
+  data.tar.gz: 29772b85d1f2d414af140558790c365ec801bad2fc99fecc051704bfcc4d1ca9
 SHA512:
-  metadata.gz: a5bbff2a8cca45e5fce79d653db3246bc41a4ab9d314f44131bbf74f2659d610fdaf3e87ac5e22baf7928d0cdb481e19eacaa1ed8945e4ee32f1afac3223273f
-  data.tar.gz: 6e3861f420327e0bccec7ab8e7c0a508e7cf224312c366297834091467d7cdb5e4fac8a305dbb59f7c0650d199d9a17062ab0408fd180b6fbaa05946bfd27545
+  metadata.gz: 56e733e9e90c7e7f4f52a5811cce39856e5fce10c717a15dff2c9fe6fd5531cc19a00442cc44fd690ed3037e474a28abaf4e6a7c24cac380a4243365a3e4d8c5
+  data.tar.gz: f89156275fb3886d9405e00f4a8f8aa2c4b28808fa0ba3f2e4991d319fed8bc4cdd3bd54fc249577e3e13ea30dca5ed1cbb5d1dd56843e366674a752fe61e028

data/CHANGELOG.md

@@ -1,5 +1,10 @@
 ## master (unreleased)
 
+## 0.16.1 (2024-03-29)
+
+- Improve error message when background schema migration name is already taken
+- Fix copying column background migration to work with primary keys added via `initialize_column_type_change`
+
 ## 0.16.0 (2024-03-28)
 
 - Add support for asynchronous creation/removal of indexes

data/lib/online_migrations/background_migrations/copy_column.rb

@@ -25,10 +25,7 @@ module OnlineMigrations
       end
 
       def relation
-        model
-          .unscoped
-          .where(copy_to.index_with(nil))
-          .where.not(copy_from.index_with(nil))
+        model.unscoped
       end
 
       def process_batch(relation)

data/lib/online_migrations/background_schema_migrations/migration.rb

@@ -57,9 +57,18 @@ module OnlineMigrations
       belongs_to :parent, class_name: name, optional: true
       has_many :children, class_name: name, foreign_key: :parent_id
 
-      validates :migration_name, presence: true, uniqueness: { scope: :shard }
       validates :table_name, presence: true, length: { maximum: MAX_IDENTIFIER_LENGTH }
       validates :definition, presence: true
+      validates :migration_name, presence: true, uniqueness: {
+        scope: :shard,
+        message: ->(object, data) do
+          message = "(#{data[:value]}) has already been taken."
+          if object.index_addition?
+            message += " Consider enqueuing index creation with a different index name via a `:name` option."
+          end
+          message
+        end,
+      }
 
       validate :validate_children_statuses, if: -> { composite? && status_changed? }
       validate :validate_connection_class, if: :connection_class_name?
@@ -107,6 +116,10 @@ module OnlineMigrations
         end
       end
 
+      def index_addition?
+        definition.match?(/create (unique )?index/i)
+      end
+
       # @private
       def connection_class
         if connection_class_name && (klass = connection_class_name.safe_constantize)
@@ -130,8 +143,7 @@ module OnlineMigrations
             statement_timeout = self.statement_timeout || OnlineMigrations.config.statement_timeout
 
             with_statement_timeout(connection, statement_timeout) do
-              case definition
-              when /create (unique )?index/i
+              if index_addition?
                 index = connection.indexes(table_name).find { |i| i.name == name }
                 if index
                   # Use index validity from https://github.com/rails/rails/pull/45160

data/lib/online_migrations/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module OnlineMigrations
-  VERSION = "0.16.0"
+  VERSION = "0.16.1"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: online_migrations
 version: !ruby/object:Gem::Version
-  version: 0.16.0
+  version: 0.16.1
 platform: ruby
 authors:
 - fatkodima