onkcop 0.50.0.0 → 0.51.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ea0e6f1ee700df43e3b42b05de75ffb8518163704fa42021f9c74c3fadd6e499
-  data.tar.gz: a9743904e7f371cfe3d14602a50b187031ccc4033bb02e46392511aff46ae960
+  metadata.gz: 7f59f884ff0507d3ba72afc6f7ee3187326786bf5f33d1bb60c7d3457c75b257
+  data.tar.gz: 9c5304a8a8327be1226f73821d7675b5ebbde57a70d1bcefeb1656ac1efc5fd2
 SHA512:
-  metadata.gz: b9aaa2d2d3c18f1dd407e68fdce3a7cbcbe038f3498fc3874eff8035a5d0bc537ef43750483c982fdaeadaac9b92925904e2f8a04112f2f8f969b7e410db9830
-  data.tar.gz: cb920dd1f004222fc5e31d0bb2a877b140bfdf6120a252d8b813efc06e7b2c597bbd4c677aa03cde0a6d64fe1537fd35d4b45454e2acb38b222f876f90499747
+  metadata.gz: c1bc840d525ce5855b3f6317a8f7ab900277a0ac7fed63d6596856b800ec1e429a3454a7e3399190a07496bf743717a80a9350c6cfc0c02c36900c4b88e5534f
+  data.tar.gz: 635e0dbfe39584f3aaa9f47e2bb547af1b8e5b2e693629c65cf32fa172bd38f2f4dc5e4207197f9b1eab8d050d47bfe526a300291ebd036960a366a19b47ffc5

data/CHANGELOG.md

@@ -1,5 +1,13 @@
 # onkcop
 
+## v0.51.0.0 (2017-10-20)
+
+* Update `rubocop` v0.51.0 and `rubocop-rspec` v1.19.0
+* Enable `Lint/ReturnInVoidContext` cop
+* Add `staging` env to `Rails/UnknownEnv` cop
+* Add comments to `Style/SafeNavigation` and `Lint/UnusedMethodArgument` cop
+
+
 ## v0.50.0.0 (2017-10-12)
 
 * Update `rubocop` v0.50.0 and `rubocop-rspec` v1.18.0

data/config/rails.yml

@@ -13,3 +13,11 @@ Rails/SafeNavigation:
 # valid? チェックし忘れを防ぎたい
 Rails/SaveBang:
   Enabled: true
+
+# staging 環境を使っているので追加
+Rails/UnknownEnv:
+  Environments:
+    - development # rubocop default.yml
+    - test        # rubocop default.yml
+    - production  # rubocop default.yml
+    - staging

data/config/rubocop.yml

@@ -186,7 +186,14 @@ Style/RedundantReturn:
 Style/RedundantSelf:
   Enabled: false
 
-# 無理して使うモンじゃない
+# user&.admin? が、[nil, true, false] の 3 値を返すことに一瞬で気づけず
+# boolean を返すっぽく見えてしまうので無効に。
+# user && user.admin? なら短絡評価で nil が返ってくるのが一目で分かるので。
+# (boolean を返すメソッド以外なら積極的に使いたいんだけどねぇ
+#
+# 他に auto-correct してはいけないパターンとして
+#   if hoge && hoge.count > 1
+# がある。
 Style/SafeNavigation:
   Enabled: false
 
@@ -310,7 +317,10 @@ Lint/RescueWithoutErrorClass:
 Lint/UnderscorePrefixedVariableName:
   Enabled: false
 
-# 子クラスで実装させるつもりのメソッドで引っかかるので
+# 子クラスで実装させるつもりで中身が
+#   raise NotImplementedError
+# のみのメソッドが引っかかるので。
+# (raise せずに中身が空だと IgnoreEmptyMethods でセーフ)
 Lint/UnusedMethodArgument:
   Enabled: false
 

data/lib/onkcop/version.rb

@@ -1,3 +1,3 @@
 module Onkcop
-  VERSION = "0.50.0.0"
+  VERSION = "0.51.0.0"
 end

data/onkcop.gemspec

@@ -19,8 +19,8 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
-  spec.add_dependency "rubocop", "~> 0.50.0"
-  spec.add_dependency "rubocop-rspec", ">= 1.18.0"
+  spec.add_dependency "rubocop", "~> 0.51.0"
+  spec.add_dependency "rubocop-rspec", ">= 1.19.0"
   spec.add_development_dependency "bundler"
   spec.add_development_dependency "rake"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: onkcop
 version: !ruby/object:Gem::Version
-  version: 0.50.0.0
+  version: 0.51.0.0
 platform: ruby
 authors:
 - Takafumi ONAKA
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-10-11 00:00:00.000000000 Z
+date: 2017-10-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -16,28 +16,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.50.0
+        version: 0.51.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.50.0
+        version: 0.51.0
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.18.0
+        version: 1.19.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.18.0
+        version: 1.19.0
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement