onkcop 0.47.1.0 → 0.47.1.1

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (7) hide show
  1. checksums.yaml +4 -4
  2. data/CHANGELOG.md +12 -0
  3. data/config/rspec.yml +1 -1
  4. data/config/rubocop.yml +18 -3
  5. data/lib/onkcop/version.rb +1 -1
  6. data/onkcop.gemspec +1 -1
  7. metadata +5 -5
checksums.yaml CHANGED
@@ -1,7 +1,7 @@
1
1
  ---
2
2
  SHA1:
3
- metadata.gz: 4cbb1a0f83ebd7affd4a34ac0b2d656a8f043d4e
4
- data.tar.gz: '08a5eb43399ebb6c82c3fc1f4faf6bf211fba208'
3
+ metadata.gz: c5f8ae35091446ca6e5c452da941b291c179d3e0
4
+ data.tar.gz: a00bc64c21da58a412e7aa8ce763e1927d50356b
5
5
  SHA512:
6
- metadata.gz: f45da3476fadbf48492e79381c2e66bda9beebfc2325fa9a8716d800228c8aec9d86886d94f6c9710df58f0a4b2a88dbbef763f86314177930f00039c4990ad7
7
- data.tar.gz: 2c9151c45135b8997cfba6e5d6e0a845b1742bc66ea5b0dec8ba7543e84b942b826e6611b3182f25a78598873273444abed3ac8b872ed1b5178d2d8907c82d26
6
+ metadata.gz: d48ff397e9c71efa3ee736cddd44e8c972ceb7c10aab0c7146d1171b3f742d85778fcadabe02f434c0cc55c97a520f45d57e08eed248f9df1d8168f48db09e44
7
+ data.tar.gz: b89cd1cf61dc4fe6e12a9e8e8f223d3c95640bfbf772cf7162d29afc3490a01be801e21dfb05ea8586eb805afb0031b53f962b9ad95a88912ab59d8bc4ff2d8d
data/CHANGELOG.md CHANGED
@@ -1,5 +1,17 @@
1
1
  # onkcop
2
2
 
3
+ ## v0.47.1.1 (2017-03-01)
4
+
5
+ [full changelog](https://github.com/onk/onkcop/compare/v0.47.1.0...v0.47.1.1)
6
+
7
+ * Update `rubocop-rspec` v1.12.0.
8
+ * Enable `Style/StringMethods` cop.
9
+ * Enable `Style/StringLiteralsInInterpolation` cop.
10
+ * Change `RSpec/DescribedClass` to `explicit` style.
11
+ * Exclude `*.gemspec` from `Metrics/BlockLength` cop.
12
+ * Disable `Lint/EmptyWhen` cop.
13
+
14
+
3
15
  ## v0.47.1.0 (2017-01-20)
4
16
 
5
17
  [full changelog](https://github.com/onk/onkcop/compare/v0.46.0.1...v0.47.1.0)
data/config/rspec.yml CHANGED
@@ -2,7 +2,7 @@ require: "rubocop-rspec"
2
2
 
3
3
  # subject はコピペ可搬性よりもそのまま USAGE であって欲しい
4
4
  RSpec/DescribedClass:
5
- Enabled: false
5
+ EnforcedStyle: explicit
6
6
 
7
7
  # each で回したり aggregate_failures 使ってたりすると厳しい。
8
8
  # feature spec は exclude でも良いかもしれない。
data/config/rubocop.yml CHANGED
@@ -197,9 +197,9 @@ Style/Semicolon:
197
197
  Style/StringLiterals:
198
198
  EnforcedStyle: double_quotes
199
199
 
200
- # auto-correct 時に Style/StringLiterals とカニバって無限ループになる (v0.28.0)
201
- Style/StringLiteralsInInterpolation:
202
- Enabled: false
200
+ # String#intern は ruby の内部表現すぎるので String#to_sym を使う
201
+ Style/StringMethods:
202
+ Enabled: true
203
203
 
204
204
  # 三項演算子は分かりやすく使いたい。
205
205
  # () を外さない方が条件式が何なのか読み取りやすいと感じる。
@@ -221,6 +221,20 @@ Style/ZeroLengthPredicate:
221
221
 
222
222
  ##################### Lint ##################################
223
223
 
224
+ # Style/EmptyCaseCondition と同じく網羅の表現力が empty when を認めた方が高いし、
225
+ # 頻出する対象を最初の when で撥ねるのはパフォーマンス向上で頻出する。
226
+ # また、
227
+ # case foo
228
+ # when 42
229
+ # # nop
230
+ # when 1..100
231
+ # ...
232
+ # end
233
+ # と、下の when がキャッチしてしまう場合等に対応していない。
234
+ # See. http://tech.sideci.com/entry/2016/11/01/105900
235
+ Lint/EmptyWhen:
236
+ Enabled: false
237
+
224
238
  # RuntimeError は「特定の Error を定義できない場合」なので、
225
239
  # 定義できるエラーは RuntimeError ではなく StandardError を継承する。
226
240
  Lint/InheritException:
@@ -255,6 +269,7 @@ Metrics/BlockLength:
255
269
  - "Guardfile"
256
270
  - "config/routes.rb"
257
271
  - "config/routes/**/*.rb"
272
+ - "*.gemspec"
258
273
 
259
274
  # 6 は強すぎるので緩める
260
275
  Metrics/CyclomaticComplexity:
data/lib/onkcop/version.rb CHANGED
@@ -1,3 +1,3 @@
1
1
  module Onkcop
2
- VERSION = "0.47.1.0"
2
+ VERSION = "0.47.1.1"
3
3
  end
data/onkcop.gemspec CHANGED
@@ -20,7 +20,7 @@ Gem::Specification.new do |spec|
20
20
  spec.require_paths = ["lib"]
21
21
 
22
22
  spec.add_dependency "rubocop", "~> 0.47.1"
23
- spec.add_dependency "rubocop-rspec", ">= 1.10.0"
23
+ spec.add_dependency "rubocop-rspec", ">= 1.12.0"
24
24
  spec.add_development_dependency "bundler"
25
25
  spec.add_development_dependency "rake"
26
26
  end
metadata CHANGED
@@ -1,14 +1,14 @@
1
1
  --- !ruby/object:Gem::Specification
2
2
  name: onkcop
3
3
  version: !ruby/object:Gem::Version
4
- version: 0.47.1.0
4
+ version: 0.47.1.1
5
5
  platform: ruby
6
6
  authors:
7
7
  - Takafumi ONAKA
8
8
  autorequire:
9
9
  bindir: exe
10
10
  cert_chain: []
11
- date: 2017-01-20 00:00:00.000000000 Z
11
+ date: 2017-03-01 00:00:00.000000000 Z
12
12
  dependencies:
13
13
  - !ruby/object:Gem::Dependency
14
14
  name: rubocop
@@ -30,14 +30,14 @@ dependencies:
30
30
  requirements:
31
31
  - - ">="
32
32
  - !ruby/object:Gem::Version
33
- version: 1.10.0
33
+ version: 1.12.0
34
34
  type: :runtime
35
35
  prerelease: false
36
36
  version_requirements: !ruby/object:Gem::Requirement
37
37
  requirements:
38
38
  - - ">="
39
39
  - !ruby/object:Gem::Version
40
- version: 1.10.0
40
+ version: 1.12.0
41
41
  - !ruby/object:Gem::Dependency
42
42
  name: bundler
43
43
  requirement: !ruby/object:Gem::Requirement
@@ -112,7 +112,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
112
112
  version: '0'
113
113
  requirements: []
114
114
  rubyforge_project:
115
- rubygems_version: 2.6.8
115
+ rubygems_version: 2.6.10
116
116
  signing_key:
117
117
  specification_version: 4
118
118
  summary: OnkCop is a RuboCop configration gem.