onix 0.8.1 → 0.8.2

data/CHANGELOG

@@ -1,5 +1,8 @@
+v0.8.2 (6th May 2010)
+- fix APAProduct#series and APAProduct#series=
+
 v0.8.1 (5th January 2010)
-- Use libxml2's support for transparent entity conversion when reading an ONIX file
+- Use nokogiri's support for transparent entity conversion when reading an ONIX file
 - Removed entity replacement from ONIX::Normaliser
   - the external dependency on sed made me uncomfortable, and it wasn't really
     necessary now that nokogiri can do it for us
@@ -56,7 +59,7 @@ v0.7.1 (24th June 2009)
 
 v0.7.0 (17th June 2009)
 - try using LibXML for reader again
-  - retrieving the ONIX version of the input file is currently disabled, as 
+  - retrieving the ONIX version of the input file is currently disabled, as
     that seems to be the source of our instability
 - Various Ruby 1.9 compatability tweaks
   - add source file coding declarations. All source files are UTF-8

data/lib/onix.rb

@@ -9,7 +9,7 @@ module ONIX
   module Version #:nodoc:
     Major = 0
     Minor = 8
-    Tiny  = 1
+    Tiny  = 2
 
     String = [Major, Minor, Tiny].join('.')
   end

data/lib/onix/apa_product.rb

@@ -6,7 +6,6 @@ module ONIX
     delegate :record_reference, :record_reference=
     delegate :notification_type, :notification_type=
     delegate :product_form, :product_form=
-    delegate :series, :series=
     delegate :edition, :edition=
     delegate :number_of_pages, :number_of_pages=
     delegate :bic_main_subject, :bic_main_subject=
@@ -107,6 +106,20 @@ module ONIX
       composite.subtitle = str
     end
 
+    def series
+      composite = product.series.first
+      composite.andand.title_of_series
+    end
+
+    def series=(val)
+      composite = product.series.first
+      if composite.nil?
+        composite =  ONIX::Series.new
+        product.series << composite
+      end
+      composite.title_of_series = val.to_s
+    end
+
     # retrieve the current publisher website for this particular product
     def publisher_website
       website(2).andand.website_link

data/spec/apa_product_spec.rb

@@ -56,6 +56,16 @@ context "ONIX::APAProduct" do
 
 end
 
+context ONIX::APAProduct, "series method" do
+  specify "should set the nested series value on the underlying product class" do
+    apa = ONIX::APAProduct.new
+
+    apa.series = "Harry Potter"
+    apa.series.should eql("Harry Potter")
+    apa.to_xml.to_s.include?("<TitleOfSeries>Harry Potter</TitleOfSeries>").should be_true
+  end
+end
+
 context ONIX::APAProduct, "price method" do
   before(:each) do
     @data_path = File.join(File.dirname(__FILE__),"..","data")

data/spec/spec_helper.rb

@@ -3,5 +3,6 @@
 require 'date'
 require 'stringio'
 require 'rubygems'
+gem "activesupport", "<= 2.9.9"
 $LOAD_PATH.unshift(File.dirname(__FILE__) + '/../lib')
 require 'onix'

metadata

@@ -1,7 +1,12 @@
 --- !ruby/object:Gem::Specification 
 name: onix
 version: !ruby/object:Gem::Version 
-  version: 0.8.1
+  prerelease: false
+  segments: 
+  - 0
+  - 8
+  - 2
+  version: 0.8.2
 platform: ruby
 authors: 
 - James Healy
@@ -9,39 +14,62 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-01-05 00:00:00 +11:00
+date: 2010-05-06 00:00:00 +10:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: roxml
-  type: :runtime
-  version_requirement: 
-  version_requirements: !ruby/object:Gem::Requirement 
+  prerelease: false
+  requirement: &id001 !ruby/object:Gem::Requirement 
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
+        segments: 
+        - 3
+        - 1
+        - 1
         version: 3.1.1
-    version: 
+  type: :runtime
+  version_requirements: *id001
 - !ruby/object:Gem::Dependency 
   name: andand
-  type: :runtime
-  version_requirement: 
-  version_requirements: !ruby/object:Gem::Requirement 
+  prerelease: false
+  requirement: &id002 !ruby/object:Gem::Requirement 
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
+        segments: 
+        - 0
         version: "0"
-    version: 
+  type: :runtime
+  version_requirements: *id002
 - !ruby/object:Gem::Dependency 
   name: nokogiri
-  type: :runtime
-  version_requirement: 
-  version_requirements: !ruby/object:Gem::Requirement 
+  prerelease: false
+  requirement: &id003 !ruby/object:Gem::Requirement 
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
+        segments: 
+        - 1
+        - 4
         version: "1.4"
-    version: 
+  type: :runtime
+  version_requirements: *id003
+- !ruby/object:Gem::Dependency 
+  name: activesupport
+  prerelease: false
+  requirement: &id004 !ruby/object:Gem::Requirement 
+    requirements: 
+    - - <=
+      - !ruby/object:Gem::Version 
+        segments: 
+        - 2
+        - 9
+        - 9
+        version: 2.9.9
+  type: :runtime
+  version_requirements: *id004
 description: A convient mapping between ruby objects and the ONIX XML specification
 email: jimmy@deefa.com
 executables: []
@@ -164,18 +192,20 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
+      segments: 
+      - 0
       version: "0"
-  version: 
 required_rubygems_version: !ruby/object:Gem::Requirement 
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
+      segments: 
+      - 0
       version: "0"
-  version: 
 requirements: []
 
 rubyforge_project: rbook
-rubygems_version: 1.3.5
+rubygems_version: 1.3.6
 signing_key: 
 specification_version: 3
 summary: A convient mapping between ruby objects and the ONIX XML specification