oneview 0.0.7 → 0.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 04df1d92f090b2ec6650d15318893970addf3235
-  data.tar.gz: 2ef2e2f7e80737b305b3158c8b644cf4e2f747cb
+SHA256:
+  metadata.gz: 1857bba3aac752fce075e2650e6539f78aed654dce1606ead5e321d1a1d45cbd
+  data.tar.gz: a32f66a7ed8c420062e0d0aab328b87c550f2e0942793273fd478bcedda38840
 SHA512:
-  metadata.gz: 93b6b0be44b4476720145b0624d0efb30041e72f54d11b33dc90cd3238fd40378f20f6cb15906bc58becf36b8f5417616297631fb9b1658862b36955fa0d1d03
-  data.tar.gz: 75001d5c6463ce9993c7c0d116e5f3a51c255d7487593df6857c7ceaf3719357a0e6589d5f4e0ce77df3ee71f29c8ad1d5aabae0049cd71b54b57ae8ffda1287
+  metadata.gz: 5956a4b6c292587295ce697a03a5ed9d1e6aba51895222d451b8c4bac5771d1e387bf0807de9518b340ed8421eac7c47fe09828b3bb930e08bf5dd16c3f03b02
+  data.tar.gz: 3a5a5e4999b732f61150325e9a938d0950b463bc5f0bad030627a04210162ca772dec30170e9185d6bb8938d71bd4bf90d0d7e3d16456d5e847d6fb09c265366

data/lib/oneview/api/contacts.rb

@@ -3,25 +3,28 @@ module Oneview
     class Contacts < Client
       require_all 'oneview/entity', 'contact', 'dynamic_field', 'phone'
       
-      base_uri "http://www.oneview.com.br/api/contacts"
+      base_uri "https://oneview.com.br/api/contacts"
 
       def create(data)
-        return parse_response(self.class.post("/", :body => build_body(data), :headers => header)) if data.is_a?(Hash)
-        return parse_response(self.class.post("/", :body => build_body(data.as_parameter), :headers => header)) if data.is_a?(Oneview::Entity::Contact)
+        return parse_response(self.class.post("/", body: build_body(data), headers: header)) if data.is_a?(Hash)
+        return parse_response(self.class.post("/", body: build_body(data.as_parameter), headers: header)) if data.is_a?(Oneview::Entity::Contact)
+
         raise ArgumentError
       end
       alias :new :create
 
       def update(id, data)
-        return parse_response(self.class.patch("/" + id, :body => build_body(data), :headers => header)) if data.is_a?(Hash)
-        return parse_response(self.class.patch("/" + id, :body => build_body(data.as_parameter), :headers => header)) if data.is_a?(Oneview::Entity::Contact)
+        return parse_response(self.class.patch("/" + id, body: build_body(data), headers: header)) if data.is_a?(Hash)
+        return parse_response(self.class.patch("/" + id, body: build_body(data.as_parameter), headers: header)) if data.is_a?(Oneview::Entity::Contact)
+
         raise ArgumentError
       end
 
       private
-        def build_body(parameters)
-          super({:contact => parameters})
-        end
+
+      def build_body(parameters)
+        super(contact: parameters)
+      end
     end
   end
 end

data/lib/oneview/api/emails.rb

@@ -3,19 +3,21 @@ module Oneview
     class Emails < Client
       require_all 'oneview/entity', 'email'
       
-      base_uri "http://www.oneview.com.br/api/senders/send_email"
+      base_uri "https://oneview.com.br/api/senders/send_email"
       
       def create(data)
-        return parse_response(self.class.post("/", :body => build_body(data), :headers => header)) if data.is_a?(Hash)
-        return parse_response(self.class.post("/", :body => build_body(data.as_parameter), :headers => header)) if data.is_a?(Oneview::Entity::Email)
+        return parse_response(self.class.post("/", body: build_body(data), headers: header)) if data.is_a?(Hash)
+        return parse_response(self.class.post("/", body: build_body(data.as_parameter), headers: header)) if data.is_a?(Oneview::Entity::Email)
+
         raise ArgumentError
       end
       alias :new :create
       
       private
-        def build_body(parameters)
-          super(parameters)
-        end
+
+      def build_body(parameters)
+        super(parameters)
+      end
     end
   end
 end

data/lib/oneview/api/sms.rb

@@ -3,19 +3,21 @@ module Oneview
     class Sms < Client
       require_all 'oneview/entity', 'sms'
       
-      base_uri "http://www.oneview.com.br/api/senders/send_sms"
+      base_uri "https://oneview.com.br/api/senders/send_sms"
       
       def create(data)
-        return parse_response(self.class.post("/", :body => build_body(data), :headers => header)) if data.is_a?(Hash)
-        return parse_response(self.class.post("/", :body => build_body(data.as_parameter), :headers => header)) if data.is_a?(Oneview::Entity::Sms)
+        return parse_response(self.class.post("/", body: build_body(data), headers: header)) if data.is_a?(Hash)
+        return parse_response(self.class.post("/", body: build_body(data.as_parameter), headers: header)) if data.is_a?(Oneview::Entity::Sms)
+
         raise ArgumentError
       end
       alias :new :create
       
       private
-        def build_body(parameters)
-          super(parameters)
-        end
+
+      def build_body(parameters)
+        super(parameters)
+      end
     end
   end
 end

data/lib/oneview/client.rb

@@ -17,6 +17,7 @@ module Oneview
     
     def initialize(access_token)
       raise NoAccessTokenError if access_token.nil? || access_token.strip == ""
+
       @access_token = access_token
     end
     
@@ -33,17 +34,18 @@ module Oneview
     end
     
     protected
-      def header
-        {"Content-Type" => "application/json", "Accept" => "application/json"}
-      end
-      
-      def build_body(parameters)
-        parameters.merge(:access_token => @access_token).to_json
-      end
-      
-      def parse_response(response)
-        return Oneview::Client::Response.new(response)
-      end
+
+    def header
+      {"Content-Type" => "application/json", "Accept" => "application/json"}
+    end
+    
+    def build_body(parameters)
+      parameters.merge(:access_token => @access_token).to_json
+    end
+    
+    def parse_response(response)
+      return Oneview::Client::Response.new(response)
+    end
     
     class Response
       attr_accessor :status, :payload, :raw_response

data/lib/oneview/entity/contact.rb

@@ -11,11 +11,11 @@ module Oneview
       def as_parameter
         variables = instance_variables.map do |name|
           case name
-            when :@phone
-              ["phone_attributes", instance_variable_get(name).as_parameter]
-            when :@dynamic_fields
-            else 
-              [name.to_s.tr("@", ""), instance_variable_get(name)]
+          when :@phone
+            ["phone_attributes", instance_variable_get(name).as_parameter]
+          when :@dynamic_fields
+          else 
+            [name.to_s.tr("@", ""), instance_variable_get(name)]
           end
         end
         

data/lib/oneview/version.rb

@@ -1,3 +1,3 @@
 module Oneview
-  VERSION = "0.0.7"
+  VERSION = "0.1.0"
 end

data/spec/oneview/api/contacts_spec.rb

@@ -1,11 +1,12 @@
 require 'spec_helper'
 
 RSpec.describe Oneview::Api::Contacts do
+  let(:header) { { "Content-Type" => "application/json", "Accept" => "application/json" } }
+
   describe "creating" do
-    let(:contact_params) {{:contact => {:name => "name", :email => "email"}, :access_token => "abc"}}
-    let(:header) {{"Content-Type" => "application/json", "Accept" => "application/json"}}
+    let(:contact_params) { { contact: { name: "name", email: "email" }, access_token: "abc" } }
     
-    before(:each) do
+    before do
       dynamic_field = Oneview::Entity::DynamicField.new
       dynamic_field.name = "dynamic_field"
       dynamic_field.value = "123"
@@ -25,35 +26,34 @@ RSpec.describe Oneview::Api::Contacts do
       @contact.phone = phone
       @contact.dynamic_fields << dynamic_field
       
-      stub_request(:post, "http://www.oneview.com.br/api/contacts/").to_return(:status => 200)
+      stub_request(:post, "https://oneview.com.br/api/contacts/").to_return(status: 200)
     end
     
     describe "with raw parameters" do
-      it "should post to the contacts url" do
-        expect(Oneview::Api::Contacts).to receive(:post).with("/", :body => contact_params.to_json, :headers => header).and_call_original
+      it "issues a post to the contacts url" do
+        expect(Oneview::Api::Contacts).to receive(:post).with("/", body: contact_params.to_json, headers: header).and_call_original
         
-        Oneview.new("abc").contacts.create({:name => "name", :email => "email"})
+        Oneview.new("abc").contacts.create({ name: "name", email: "email"})
       end
     end
     
     describe "with entity parameter" do
-      it "should post to the contacts url" do
-        expect(Oneview::Api::Contacts).to receive(:post).with("/", :body => {:contact => @contact.as_parameter, :access_token => "abc"}.to_json, :headers => header).and_call_original
+      it "issues a post to the contacts url" do
+        expect(Oneview::Api::Contacts).to receive(:post).with("/", body: { contact: @contact.as_parameter, access_token: "abc" }.to_json, headers: header).and_call_original
         
         Oneview.new("abc").contacts.create(@contact)
       end
     end
     
     describe "with invalid parameter" do
-      it "should raise ArgumentError when passing neither a Hash nor a Contact" do
-        expect{Oneview.new("abc").contacts.create(Array.new)}.to raise_error(ArgumentError)
+      it "raises ArgumentError when passing neither a Hash nor a Contact" do
+        expect { Oneview.new("abc").contacts.create(Array.new) }.to raise_error(ArgumentError)
       end
     end
   end
 
   describe "updating" do
-    let(:contact_params) {{:contact => {:name => "name", :email => "email", :id => "23" }, :access_token => "abc"}}
-    let(:header) {{"Content-Type" => "application/json", "Accept" => "application/json"}}
+    let(:contact_params) { { contact: { name: "name", email: "email", id: "23" }, access_token: "abc" } }
     
     before(:each) do
       phone = Oneview::Entity::Phone.new
@@ -71,28 +71,28 @@ RSpec.describe Oneview::Api::Contacts do
       @contact.zip_code = "12233-444"
       @contact.phone = phone
       
-      stub_request(:patch, "http://www.oneview.com.br/api/contacts/23").to_return(:status => 200)
+      stub_request(:patch, "https://oneview.com.br/api/contacts/23").to_return(status: 200)
     end
 
     describe "with raw parameters" do
-      it "should patch to the contacts url" do
-        expect(Oneview::Api::Contacts).to receive(:patch).with("/" + contact_params[:contact][:id], :body => contact_params.to_json, :headers => header).and_call_original
+      it "issues a patch to the contacts url" do
+        expect(Oneview::Api::Contacts).to receive(:patch).with("/" + contact_params[:contact][:id], body: contact_params.to_json, headers: header).and_call_original
         
-        Oneview.new("abc").contacts.update("23",{:name => "name", :email => "email", :id => "23"})
+        Oneview.new("abc").contacts.update("23", { name: "name", email: "email", id: "23" })
       end
     end
     
     describe "with entity parameter" do
-      it "should patch to the contacts url" do
-        expect(Oneview::Api::Contacts).to receive(:patch).with("/" + @contact.id, :body => {:contact => @contact.as_parameter, :access_token => "abc"}.to_json, :headers => header).and_call_original
+      it "issues a patch to the contacts url" do
+        expect(Oneview::Api::Contacts).to receive(:patch).with("/" + @contact.id, body: { contact: @contact.as_parameter, access_token: "abc" }.to_json, headers: header).and_call_original
         
         Oneview.new("abc").contacts.update(@contact.id, @contact)
       end
     end
     
     describe "with invalid parameter" do
-      it "should raise ArgumentError when passing neither a Hash nor a Contact" do
-        expect{Oneview.new("abc").contacts.create(Array.new)}.to raise_error(ArgumentError)
+      it "raises ArgumentError when passing neither a Hash nor a Contact" do
+        expect { Oneview.new("abc").contacts.create(Array.new) }.to raise_error(ArgumentError)
       end
     end
   end

data/spec/oneview/api/emails_spec.rb

@@ -2,8 +2,8 @@ require 'spec_helper'
 
 RSpec.describe Oneview::Api::Emails do
   describe "creating" do
-    let(:email_params) {{:from => "from@email.com", :to => "to@email.com", :body => "body", :subject => "subject", :schedule => "14/05/2014 15:30", :access_token => "abc"}}
-    let(:header) {{"Content-Type" => "application/json", "Accept" => "application/json"}}
+    let(:email_params) { { from: "from@email.com", to: "to@email.com", body: "body", subject: "subject", schedule: "14/05/2014 15:30", access_token: "abc" } }
+    let(:header) { { "Content-Type" => "application/json", "Accept" => "application/json" } }
     
     before(:each) do
       @email = Oneview::Entity::Email.new
@@ -13,28 +13,28 @@ RSpec.describe Oneview::Api::Emails do
       @email.subject = "subject"
       @email.schedule = "14/05/2014 15:30"
       
-      stub_request(:post, "http://www.oneview.com.br/api/senders/send_email/").to_return(:status => 200)
+      stub_request(:post, "https://oneview.com.br/api/senders/send_email/").to_return(status: 200)
     end
     
     describe "with raw parameters" do
-      it "should post to the send email url" do
-        expect(Oneview::Api::Emails).to receive(:post).with("/", :body => email_params.to_json, :headers => header).and_call_original
+      it "issues a post to the send email url" do
+        expect(Oneview::Api::Emails).to receive(:post).with("/", body: email_params.to_json, headers: header).and_call_original
         
         Oneview.new("abc").emails.create(email_params)
       end
     end
     
     describe "with entity parameter" do
-      it "should post to the send email url" do
-        expect(Oneview::Api::Emails).to receive(:post).with("/", :body => @email.as_parameter.merge(:access_token => "abc").to_json, :headers => header).and_call_original
+      it "issues a post to the send email url" do
+        expect(Oneview::Api::Emails).to receive(:post).with("/", body: @email.as_parameter.merge(access_token: "abc").to_json, headers: header).and_call_original
         
         Oneview.new("abc").emails.create(@email)
       end
     end
     
     describe "with invalid parameter" do
-      it "should raise ArgumentError when passing neither a Hash nor an Email" do
-        expect{Oneview.new("abc").emails.create(Array.new)}.to raise_error(ArgumentError)
+      it "raises ArgumentError when passing neither a Hash nor an Email" do
+        expect { Oneview.new("abc").emails.create(Array.new) }.to raise_error(ArgumentError)
       end
     end
   end

data/spec/oneview/api/sms_spec.rb

@@ -2,8 +2,8 @@ require 'spec_helper'
 
 RSpec.describe Oneview::Api::Sms do
   describe "creating" do
-    let(:sms_params) {{:numbers => "55129985587", :message => "message", :schedule => "14/05/2014 15:30", :access_token => "abc"}}
-    let(:header) {{"Content-Type" => "application/json", "Accept" => "application/json"}}
+    let(:sms_params) { { numbers: "55129985587", message: "message", schedule: "14/05/2014 15:30", access_token: "abc" } }
+    let(:header) { { "Content-Type" => "application/json", "Accept" => "application/json" } }
     
     before(:each) do
       @sms = Oneview::Entity::Sms.new
@@ -11,28 +11,28 @@ RSpec.describe Oneview::Api::Sms do
       @sms.message = "message"
       @sms.schedule = "14/05/2014 15:30"
       
-      stub_request(:post, "http://www.oneview.com.br/api/senders/send_sms/").to_return(:status => 200)
+      stub_request(:post, "https://oneview.com.br/api/senders/send_sms/").to_return(status: 200)
     end
     
     describe "with raw parameters" do
-      it "should post to the send sms url" do
-        expect(Oneview::Api::Sms).to receive(:post).with("/", :body => sms_params.to_json, :headers => header).and_call_original
+      it "issues a post to the send sms url" do
+        expect(Oneview::Api::Sms).to receive(:post).with("/", body: sms_params.to_json, headers: header).and_call_original
         
         Oneview.new("abc").sms.create(sms_params)
       end
     end
     
     describe "with entity parameter" do
-      it "should post to the send sms url" do
-        expect(Oneview::Api::Sms).to receive(:post).with("/", :body => @sms.as_parameter.merge(:access_token => "abc").to_json, :headers => header).and_call_original
+      it "issues a post to the send sms url" do
+        expect(Oneview::Api::Sms).to receive(:post).with("/", body: @sms.as_parameter.merge(access_token: "abc").to_json, headers: header).and_call_original
         
         Oneview.new("abc").sms.create(@sms)
       end
     end
     
     describe "with invalid parameter" do
-      it "should raise ArgumentError when passing neither a Hash nor an Sms" do
-        expect{Oneview.new("abc").sms.create(Array.new)}.to raise_error(ArgumentError)
+      it "raises ArgumentError when passing neither a Hash nor an Sms" do
+        expect { Oneview.new("abc").sms.create(Array.new) }.to raise_error(ArgumentError)
       end
     end
   end

data/spec/oneview/client_spec.rb

@@ -5,22 +5,22 @@ RSpec.describe Oneview::Client do
     Oneview::Client.send(:public, *Oneview::Client.protected_instance_methods)  
   end
   
-  it "should raise NoAccessTokenError when creating a new client without the access token" do
-    expect{Oneview::Client.new("")}.to raise_error(Oneview::Client::NoAccessTokenError, "Please provide an access token")
+  it "raises NoAccessTokenError when creating a new client without the access token" do
+    expect { Oneview::Client.new("") }.to raise_error(Oneview::Client::NoAccessTokenError, "Please provide an access token")
   end
   
-  it "should return the correct headers" do
+  it "returns the correct headers" do
     expect(Oneview::Client.new("abc").header).to eq({"Content-Type" => "application/json", "Accept" => "application/json"})
   end
   
-  it "should append the access token to the parameters" do
-    expect(Oneview::Client.new("abc").build_body({:abc => "abc", :def => "def"})).to eq({:abc => "abc", :def => "def", :access_token => "abc"}.to_json)
+  it "appends the access token to the parameters" do
+    expect(Oneview::Client.new("abc").build_body(abc: "abc", def: "def")).to eq({ abc: "abc", def: "def", access_token: "abc" }.to_json)
   end
   
-  it "should return an Oneview::Client::Response with the status" do
-    stub_request(:post, "http://www.oneview.com.br/api/contacts/").to_return(:status => 200)
+  it "returns an Oneview::Client::Response with the status" do
+    stub_request(:post, "https://oneview.com.br/api/contacts/").to_return(status: 200)
     
-    response = Oneview.new("abc").contacts.create({:name => "name"})
+    response = Oneview.new("abc").contacts.create(name: "name")
     
     expect(response.class).to eq(Oneview::Client::Response)
     expect(response.status).to eq(200)

data/spec/oneview/entity/contact_spec.rb

@@ -2,11 +2,15 @@ require 'spec_helper'
 
 RSpec.describe Oneview::Entity::Contact do
   describe "as_parameter" do
-    let(:contact_as_parameter) {{"name" => "name", "email" => "email@email.com", "birthday" => "14/10/2014", "city" => "city", "state" => "state",
-      "zip_code" => "12233-444", "phone_attributes" => {"country_code" => "+55", "area_code" => "12", "number" => "998998789"}, 
-      "dynamic_field" => "123"}}
+    let(:contact_as_parameter) do
+      {
+        "name" => "name", "email" => "email@email.com", "birthday" => "14/10/2014", "city" => "city", "state" => "state",
+        "zip_code" => "12233-444", "phone_attributes" => { "country_code" => "+55", "area_code" => "12", "number" => "998998789" },
+        "dynamic_field" => "123"
+      }
+    end
       
-    it "should return the contact as parameter" do
+    it "returns the contact as parameter" do
       contact = Oneview::Entity::Contact.new
       
       contact.name = "name"

data/spec/oneview/entity/dynamic_field_spec.rb

@@ -2,9 +2,9 @@ require 'spec_helper'
 
 RSpec.describe Oneview::Entity::DynamicField do
   describe "as_parameter" do
-    let(:dynamic_field_as_parameter) {{"name" => "dynamic_field", "value" => "abc"}}
+    let(:dynamic_field_as_parameter) { { "name" => "dynamic_field", "value" => "abc" } }
       
-    it "should return the dynamic_field as parameter" do
+    it "returns the dynamic_field as parameter" do
       dynamic_field = Oneview::Entity::DynamicField.new
       dynamic_field.name = "dynamic_field"
       dynamic_field.value = "abc"

data/spec/oneview/entity/email_spec.rb

@@ -2,10 +2,9 @@ require 'spec_helper'
 
 RSpec.describe Oneview::Entity::Email do
   describe "as_parameter" do
-    let(:email_as_parameter) {{"from" => "test@test.com", "to" => "test2@test2.com", "body" => "Bodys Test", 
-      "subject" => "Subjects Test"}}
+    let(:email_as_parameter) { { "from" => "test@test.com", "to" => "test2@test2.com", "body" => "Bodys Test", "subject" => "Subjects Test" } }
       
-    it "should return the email as parameter" do
+    it "returns the email as parameter" do
       email = Oneview::Entity::Email.new
       
       email.from = "test@test.com"

data/spec/oneview/entity/phone_spec.rb

@@ -2,9 +2,9 @@ require 'spec_helper'
 
 RSpec.describe Oneview::Entity::Phone do
   describe "as_parameter" do
-    let(:phone_as_parameter) {{"number" => "999999999", "area_code" => "12", "country_code" => "+55"}}
+    let(:phone_as_parameter) { { "number" => "999999999", "area_code" => "12", "country_code" => "+55" } }
       
-    it "should return the phone as parameter" do
+    it "returns the phone as parameter" do
       phone = Oneview::Entity::Phone.new
       phone.country_code = "+55"
       phone.area_code = "12"

data/spec/oneview/entity/sms_spec.rb

@@ -2,9 +2,9 @@ require 'spec_helper'
 
 RSpec.describe Oneview::Entity::Sms do
   describe "as_parameter" do
-    let(:sms_as_parameter) {{"numbers" => "5512998998798", "message" => "Bodys Test"}}
+    let(:sms_as_parameter) { { "numbers" => "5512998998798", "message" => "Bodys Test" } }
       
-    it "should return the sms as parameter" do
+    it "returns the sms as parameter" do
       sms = Oneview::Entity::Sms.new
 
       sms.message = "Bodys Test"

data/spec/oneview_spec.rb

@@ -1,7 +1,7 @@
 require 'spec_helper'
 
 RSpec.describe Oneview do
-  it "should return a new Oneview::Client" do
+  it "returns a new Oneview::Client" do
     expect(Oneview.new("abc").class).to eq(Oneview::Client)
   end
 end

data/spec/spec_helper.rb

@@ -4,7 +4,7 @@ CodeClimate::TestReporter.start
 require 'oneview'
 require 'webmock/rspec'
 
-WebMock.disable_net_connect!(:allow => "codeclimate.com")
+WebMock.disable_net_connect!(allow: "codeclimate.com")
 
 RSpec.configure do |config|
   config.mock_with :rspec

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: oneview
 version: !ruby/object:Gem::Version
-  version: 0.0.7
+  version: 0.1.0
 platform: ruby
 authors:
 - Gustavo Berdugo
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-11-04 00:00:00.000000000 Z
+date: 2021-03-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httparty
@@ -95,8 +95,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.4.8
+rubygems_version: 3.0.8
 signing_key: 
 specification_version: 4
 summary: This gem provides integration with Oneview APIs (http://www.oneview.com.br/)