onelinejson 0.1.3 → 0.1.4

data/lib/onelinejson.rb

@@ -18,6 +18,12 @@ module Onelinejson
     /^HTTP_AUTHORIZATION$/,
     /.*HIDDEN.*/,
   ]
+
+  REJECTED_PARAMS = [
+    "password",
+    "password_confirmation"
+  ]
+
   ELIP = "\xe2\x80\xa6"
   LOG_MAX_LENGTH = 16384
   ENTRY_MAX_LENGTH = 128
@@ -80,8 +86,9 @@ module Onelinejson
       params.reject do |k,v|
         k == 'controller' ||
           k == 'action' ||
-          v.is_a?(ActionDispatch::Http::UploadedFile) ||
-          v.is_a?(Hash)
+          (defined?(ActionDispatch) && v.is_a?(ActionDispatch::Http::UploadedFile)) ||
+          v.is_a?(Hash) ||
+          REJECTED_PARAMS.include?(k.to_s.downcase)
       end
     end
 

data/lib/onelinejson/version.rb

@@ -1,3 +1,3 @@
 module Onelinejson
-  VERSION = "0.1.3"
+  VERSION = "0.1.4"
 end

data/spec/lib/onelinejson_spec.rb

@@ -19,12 +19,37 @@ describe Onelinejson::AppControllerMethods do
   end
 
   describe '.extract_headers' do
+    let(:headers) { {"HTTP_X" => 0, "HTTP_AUTHORIZATION" => 1} }
+    let(:extracted) { Onelinejson::AppControllerMethods.extract_headers(headers) }
+    it "rejects Authorization" do
+      expect(extracted).to eq({"HTTP_X" => 0})
+    end
+
     context 'when rails 3' do
-      it 'extracts'
+      let(:headers) { stub(env: {"HTTP_X" => 0}) }
+      it 'extracts' do
+        expect(extracted).to eq({"HTTP_X" => 0})
+      end
     end
 
     context 'when rails 4' do
-      it 'extracts'
+      let(:headers) { stub(to_hash: {"HTTP_X" => 0}) }
+      it 'extracts' do
+        expect(extracted).to eq({"HTTP_X" => 0})
+      end
+    end
+  end
+
+  describe '.extract_params' do
+    let(:params) { {password: 0, "password" => 1, "password_confirmation" => 2, "x" => 3} }
+    let(:extracted) { Onelinejson::AppControllerMethods.extract_params(params) }
+
+    it 'rejects password' do
+      expect(extracted).to eq({"x" => 3})
+    end
+
+    it 'rejects password_confirmation' do
+      expect(extracted).to eq({"x" => 3})
     end
   end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: onelinejson
 version: !ruby/object:Gem::Version
-  version: 0.1.3
+  version: 0.1.4
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-03-20 00:00:00.000000000 Z
+date: 2014-04-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: lograge
@@ -60,7 +60,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -4410736805529295176
+      hash: 1245502309369756739
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -69,7 +69,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -4410736805529295176
+      hash: 1245502309369756739
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.23