onebox 1.9.1 → 1.9.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0b7e6ac1cf48f79f8a8c6ae0cb5887c0ee9750d13c6eea7a43ce0e6fe3bbb984
-  data.tar.gz: c1f63e7a58ec3fad7c42ac782207c7a9105e4e162692f4dee2e56421a11363cc
+  metadata.gz: 47ec1b31a8406efdfdb54baa19d1e58c10a510375a5e60b3a9ae4126231b0fd9
+  data.tar.gz: 956fba622e0595c37463a12f4101a8c9514e314de84ed5a1829d81666a8dbcd0
 SHA512:
-  metadata.gz: cd292a010fdf4f9d127f15b691ea56fb338b79a1b9549dd484ebdbba7ade321f2a362f9250bf98004da333fd084bc5b41a147ffe60bc52ed50e9a3f529c4955b
-  data.tar.gz: 2f1c8b5233c4085f965acd495e706a6ce0d0b3dda6caa4db2e8581a7da88c205d7955960e683a836774c085cbeb83c51bae6da9cff512cee6516163889b42cb6
+  metadata.gz: 42f471b30e82e46eb9c50d7fde5dc9908a57c70e5ee95a02f969c487cfe9deff6df7bc123e564def85db1e7e153f08154f7d1b0f13bb43a2884a5dcaddcaa660
+  data.tar.gz: a0f08a4c1929a74e8ce473915780adeec2019467e1e31303dd081dd27140df500e8c58cb00b70f3b670b9560e6874e7a0290256d5cba8774f9a8f212d0a476cb

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    onebox (1.9.1)
+    onebox (1.9.2)
       htmlentities (~> 4.3)
       moneta (~> 1.0)
       multi_json (~> 1.11)

data/lib/onebox/engine/audio_onebox.rb

@@ -23,7 +23,7 @@ module Onebox
       end
 
       def placeholder_html
-        "<div class='onebox-placeholder-container'><span class='placeholder-icon audio'></span></div>"
+        ::Onebox::Helpers.audio_placeholder_html
       end
     end
   end

data/lib/onebox/engine/trello_onebox.rb

@@ -20,7 +20,7 @@ module Onebox
       end
 
       def placeholder_html
-        "<div class='onebox-placeholder-container'><span class='placeholder-icon generic'></span></div>"
+        ::Onebox::Helpers.generic_placeholder_html
       end
 
       private

data/lib/onebox/engine/typeform_onebox.rb

@@ -22,7 +22,7 @@ module Onebox
       end
 
       def placeholder_html
-        "<div class='onebox-placeholder-container'><span class='placeholder-icon generic'></span></div>"
+        ::Onebox::Helpers.generic_placeholder_html
       end
 
       private

data/lib/onebox/engine/video_onebox.rb

@@ -24,7 +24,7 @@ module Onebox
       end
 
       def placeholder_html
-        "<div class='onebox-placeholder-container'><span class='placeholder-icon video'></span></div>"
+        ::Onebox::Helpers.video_placeholder_html
       end
     end
   end

data/lib/onebox/engine/whitelisted_generic_onebox.rb

@@ -190,8 +190,9 @@ module Onebox
 
       def placeholder_html
         return article_html if is_article?
-        return image_html   if has_image? && (is_video? || is_image?)
-        return article_html if has_text? && is_embedded?
+        return image_html if is_image?
+        return Onebox::Helpers.video_placeholder_html if is_video? || is_card?
+        return Onebox::Helpers.generic_placeholder_html if is_embedded?
         to_html
       end
 

data/lib/onebox/helpers.rb

@@ -236,5 +236,17 @@ module Onebox
       encoded += '#' + uri_query_encode(parts[:fragment]) unless parts[:fragment].nil?
       encoded
     end
+
+    def self.video_placeholder_html
+      "<div class='onebox-placeholder-container'><span class='placeholder-icon video'></span></div>"
+    end
+
+    def self.audio_placeholder_html
+      "<div class='onebox-placeholder-container'><span class='placeholder-icon audio'></span></div>"
+    end
+
+    def self.generic_placeholder_html
+      "<div class='onebox-placeholder-container'><span class='placeholder-icon generic'></span></div>"
+    end
   end
 end

data/lib/onebox/mixins/twitch_onebox.rb

@@ -20,7 +20,7 @@ module Onebox
         end
 
         def placeholder_html
-          "<div class='onebox-placeholder-container'><span class='placeholder-icon video'></span></div>"
+          ::Onebox::Helpers.video_placeholder_html
         end
 
         def to_html

data/lib/onebox/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Onebox
-  VERSION = "1.9.1"
+  VERSION = "1.9.2"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: onebox
 version: !ruby/object:Gem::Version
-  version: 1.9.1
+  version: 1.9.2
 platform: ruby
 authors:
 - Joanna Zeta
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-07-09 00:00:00.000000000 Z
+date: 2019-07-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: multi_json