onebox 1.8.68 → 1.8.69

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8ebcc562d8b0dcc66b83ddd79e1a3bcc47e2202686d8b96417a00e1a28b4bf3e
-  data.tar.gz: d7d3ba019ba3c50c02236b731e64981812cbd08ed51ef903d226fd31a7bc900c
+  metadata.gz: 98a0701ca393ddadda7d9d38abcd9d99b2d9fbdfec7a18643b106adfddf45ad7
+  data.tar.gz: 699090849c9ac55d0362b3785f8d4a447c509bd7a47cc4d2ee6ae79ee0f869db
 SHA512:
-  metadata.gz: 13eb57f76bd7419811a03149467fbf89d3ea4d587fae333e20a28cabd3087c315bf6ba6a08346e59060284b07289f83d4de1d05a678a0d6897a732cac066505b
-  data.tar.gz: 7d32c90c35c3ce018aadbf547b987ed034076ee8bdd15d6d5f90d6f7f6ba2716cc8ab2910d9b07d48acd0247c70bf51331f595b8c35295ae5f08c9892c8b74c8
+  metadata.gz: 3f474fc31092624d6d00062167334fcf2a61fb85b2da6075d73ed74ef34ffbc9561fd74d1d2b467410cec9c72c16f1fad863320646980422da544c40c2c16b67
+  data.tar.gz: 204da8eaac3fa2fef4fdbb39b0b470807eba0c2fa969bcd4d9168739e07fc5ff2e5d9c868632621ff7bdd879c9a0c6d3adeeb2af935e2d996aff4e137723386c

data/.gitignore

@@ -18,3 +18,5 @@ test/version_tmp
 tmp
 *.swp
 .DS_Store
+
+.rubocop-https---raw-githubusercontent-com-discourse-discourse-master--rubocop-yml

data/.rubocop.yml

@@ -1,112 +1 @@
-AllCops:
-  TargetRubyVersion: 2.3
-  DisabledByDefault: true
-  Include:
-    - 'onebox.gemspec'
-    - 'Rakefile'
-  Exclude:
-    - 'vendor/**/*'
-
-# Prefer &&/|| over and/or.
-Style/AndOr:
-  Enabled: true
-
-# Do not use braces for hash literals when they are the last argument of a
-# method call.
-Style/BracesAroundHashParameters:
-  Enabled: true
-
-# Align `when` with `case`.
-Layout/CaseIndentation:
-  Enabled: true
-
-# Align comments with method definitions.
-Layout/CommentIndentation:
-  Enabled: true
-
-# No extra empty lines.
-Layout/EmptyLines:
-  Enabled: true
-
-# Use Ruby >= 1.9 syntax for hashes. Prefer { a: :b } over { :a => :b }.
-Style/HashSyntax:
-  Enabled: true
-
-# Two spaces, no tabs (for indentation).
-Layout/IndentationWidth:
-  Enabled: true
-
-Layout/SpaceAfterColon:
-  Enabled: true
-
-Layout/SpaceAfterComma:
-  Enabled: true
-
-Layout/SpaceAroundEqualsInParameterDefault:
-  Enabled: true
-
-Layout/SpaceAroundKeyword:
-  Enabled: true
-
-Layout/SpaceAroundOperators:
-  Enabled: true
-
-Layout/SpaceBeforeFirstArg:
-    Enabled: true
-
-# Defining a method with parameters needs parentheses.
-Style/MethodDefParentheses:
-  Enabled: true
-
-# Use `foo {}` not `foo{}`.
-Layout/SpaceBeforeBlockBraces:
-  Enabled: true
-
-# Use `foo { bar }` not `foo {bar}`.
-Layout/SpaceInsideBlockBraces:
-  Enabled: true
-
-# Use `{ a: 1 }` not `{a:1}`.
-Layout/SpaceInsideHashLiteralBraces:
-  Enabled: true
-
-Layout/SpaceInsideParens:
-  Enabled: true
-
-# Detect hard tabs, no hard tabs.
-Layout/Tab:
-  Enabled: true
-
-# Blank lines should not have any spaces.
-Layout/TrailingBlankLines:
-  Enabled: true
-
-# No trailing whitespace.
-Layout/TrailingWhitespace:
-  Enabled: true
-
-Lint/Debugger:
-  Enabled: true
-
-Lint/BlockAlignment:
-  Enabled: true
-
-# Align `end` with the matching keyword or starting expression except for
-# assignments, where it should be aligned with the LHS.
-Lint/EndAlignment:
-  Enabled: true
-  EnforcedStyleAlignWith: variable
-
-# Use my_method(my_arg) not my_method( my_arg ) or my_method my_arg.
-Lint/RequireParentheses:
-  Enabled: true
-
-Layout/MultilineMethodCallIndentation:
-  Enabled: true
-  EnforcedStyle: indented
-
-Layout/AlignHash:
-  Enabled: true
-
-Bundler/OrderedGems:
-  Enabled: false
+inherit_from: https://raw.githubusercontent.com/discourse/discourse/master/.rubocop.yml

data/README.md

@@ -4,7 +4,6 @@ onebox
 [![Gem Version](https://badge.fury.io/rb/onebox.png)](https://rubygems.org/gems/onebox)
 [![Code Climate](https://codeclimate.com/github/dysania/onebox.png)](https://codeclimate.com/github/dysania/onebox)
 [![Build Status](https://travis-ci.org/discourse/onebox.png)](https://travis-ci.org/discourse/onebox)
-[![Dependency Status](https://gemnasium.com/discourse/onebox.png)](https://gemnasium.com/discourse/onebox)
 
 Onebox is a library for turning media URLs into simple HTML previews of the resource.
 

data/lib/onebox/engine/asciinema_onebox.rb

@@ -18,9 +18,9 @@ module Onebox
 
       private
 
-        def match
-          @match ||= @url.match(/asciinema\.org\/a\/(?<asciinema_id>[\p{Alnum}_\-]+)$/)
-        end
+      def match
+        @match ||= @url.match(/asciinema\.org\/a\/(?<asciinema_id>[\p{Alnum}_\-]+)$/)
+      end
     end
   end
 end

data/lib/onebox/engine/cloudapp_onebox.rb

@@ -21,37 +21,37 @@ module Onebox
 
       private
 
-        def link_html(og)
-          escaped_url = ::Onebox::Helpers.normalize_url_for_output(og[:url])
+      def link_html(og)
+        escaped_url = ::Onebox::Helpers.normalize_url_for_output(og[:url])
 
-          <<-HTML
+        <<-HTML
             <a href='#{escaped_url}' target='_blank'>
               #{og[:title]}
             </a>
           HTML
-        end
+      end
 
-        def video_html(og)
-          src = og[:url]
-          title = og[:title]
-          direct_src = ::Onebox::Helpers.normalize_url_for_output("#{src}/#{title}")
+      def video_html(og)
+        src = og[:url]
+        title = og[:title]
+        direct_src = ::Onebox::Helpers.normalize_url_for_output("#{src}/#{title}")
 
-          <<-HTML
+        <<-HTML
             <video width='480' height='360' #{Helpers.title_attr(og)} controls loop>
               <source src='#{direct_src}' type='video/mp4'>
             </video>
           HTML
-        end
+      end
 
-        def image_html(og)
-          escaped_url = ::Onebox::Helpers.normalize_url_for_output(og[:url])
+      def image_html(og)
+        escaped_url = ::Onebox::Helpers.normalize_url_for_output(og[:url])
 
-          <<-HTML
+        <<-HTML
             <a href='#{escaped_url}' target='_blank' class='onebox'>
               <img src='#{og[:image]}' #{Helpers.title_attr(og)} alt='CloudApp' width='480'>
             </a>
           HTML
-        end
+      end
     end
   end
 end

data/lib/onebox/engine/douban_onebox.rb

@@ -9,14 +9,14 @@ module Onebox
 
       private
 
-        def data
-          {
-            link: link,
-            title: raw.css('title').text.gsub("\n", '').strip(),
-            image: raw.css('img[rel*="v:"]').first['src'],
-            description: raw.css('meta[name=description]').first['content'],
-          }
-        end
+      def data
+        {
+          link: link,
+          title: raw.css('title').text.gsub("\n", '').strip(),
+          image: raw.css('img[rel*="v:"]').first['src'],
+          description: raw.css('meta[name=description]').first['content'],
+        }
+      end
 
     end
   end

data/lib/onebox/engine/gfycat_onebox.rb

@@ -58,30 +58,30 @@ module Onebox
 
       private
 
-        def match
-          @match ||= @url.match(/^https?:\/\/gfycat\.com\/(gifs\/detail\/)?(?<name>.+)/)
-        end
+      def match
+        @match ||= @url.match(/^https?:\/\/gfycat\.com\/(gifs\/detail\/)?(?<name>.+)/)
+      end
 
-        def data
+      def data
 
-          total_tags = [raw['gfyItem']['tags'], raw['gfyItem']['userTags']].flatten.compact
-          tag_links = total_tags.map { |t| "<a href='https://gfycat.com/gifs/search/#{t}'>##{t}</a>" }.join(' ') if total_tags
-          autoplay = raw['gfyItem']['webmSize'].to_i < 10485760 ? 'autoplay' : ''
+        total_tags = [raw['gfyItem']['tags'], raw['gfyItem']['userTags']].flatten.compact
+        tag_links = total_tags.map { |t| "<a href='https://gfycat.com/gifs/search/#{t}'>##{t}</a>" }.join(' ') if total_tags
+        autoplay = raw['gfyItem']['webmSize'].to_i < 10485760 ? 'autoplay' : ''
 
-          {
-            name: raw['gfyItem']['gfyName'],
-            title: raw['gfyItem']['title'] || 'No Title',
-            author: raw['gfyItem']['userName'],
-            tags: tag_links,
-            url: @url,
-            posterUrl: raw['gfyItem']['posterUrl'],
-            webmUrl: raw['gfyItem']['webmUrl'],
-            mp4Url: raw['gfyItem']['mp4Url'],
-            width: raw['gfyItem']['width'],
-            height: raw['gfyItem']['height'],
-            autoplay: autoplay
-          }
-        end
+        {
+          name: raw['gfyItem']['gfyName'],
+          title: raw['gfyItem']['title'] || 'No Title',
+          author: raw['gfyItem']['userName'],
+          tags: tag_links,
+          url: @url,
+          posterUrl: raw['gfyItem']['posterUrl'],
+          webmUrl: raw['gfyItem']['webmUrl'],
+          mp4Url: raw['gfyItem']['mp4Url'],
+          width: raw['gfyItem']['width'],
+          height: raw['gfyItem']['height'],
+          autoplay: autoplay
+        }
+      end
 
     end
   end

data/lib/onebox/engine/google_photos_onebox.rb

@@ -17,23 +17,23 @@ module Onebox
 
       private
 
-        def video_html(og)
-          escaped_src = ::Onebox::Helpers.normalize_url_for_output(og[:video_secure_url])
-          escaped_image_src = ::Onebox::Helpers.normalize_url_for_output(get_secure_link(og[:image]))
+      def video_html(og)
+        escaped_src = ::Onebox::Helpers.normalize_url_for_output(og[:video_secure_url])
+        escaped_image_src = ::Onebox::Helpers.normalize_url_for_output(get_secure_link(og[:image]))
 
-          <<-HTML
+        <<-HTML
             <video width='#{og[:video_width]}' height='#{og[:video_height]}' #{Helpers.title_attr(og)} poster="#{escaped_image_src}" controls loop>
               <source src='#{escaped_src}' type='video/mp4'>
             </video>
           HTML
-        end
+      end
 
-        def album_html(og)
-          escaped_url = ::Onebox::Helpers.normalize_url_for_output(url)
-          escaped_src = ::Onebox::Helpers.normalize_url_for_output(get_secure_link(og[:image]))
-          album_title = Onebox::Helpers::blank?(og[:description]) ? og[:title].strip : "[#{og[:description].strip}] #{og[:title].strip}"
+      def album_html(og)
+        escaped_url = ::Onebox::Helpers.normalize_url_for_output(url)
+        escaped_src = ::Onebox::Helpers.normalize_url_for_output(get_secure_link(og[:image]))
+        album_title = Onebox::Helpers::blank?(og[:description]) ? og[:title].strip : "[#{og[:description].strip}] #{og[:title].strip}"
 
-          <<-HTML
+        <<-HTML
             <div class='onebox google-photos-album'>
               <a href='#{escaped_url}' target='_blank'>
                 <span class='outer-box' style='width:#{og[:image_width]}px'>
@@ -45,24 +45,24 @@ module Onebox
               </a>
             </div>
           HTML
-        end
+      end
 
-        def image_html(og)
-          escaped_url = ::Onebox::Helpers.normalize_url_for_output(url)
-          escaped_src = ::Onebox::Helpers.normalize_url_for_output(get_secure_link(og[:image]))
+      def image_html(og)
+        escaped_url = ::Onebox::Helpers.normalize_url_for_output(url)
+        escaped_src = ::Onebox::Helpers.normalize_url_for_output(get_secure_link(og[:image]))
 
-          <<-HTML
+        <<-HTML
             <a href='#{escaped_url}' target='_blank' class="onebox">
               <img src='#{escaped_src}' #{Helpers.title_attr(og)} alt='Google Photos' height='#{og[:image_height]}' width='#{og[:image_width]}'>
             </a>
           HTML
-        end
+      end
 
-        def get_secure_link(link)
-          secure_link = URI(link)
-          secure_link.scheme = 'https'
-          secure_link.to_s
-        end
+      def get_secure_link(link)
+        secure_link = URI(link)
+        secure_link.scheme = 'https'
+        secure_link.to_s
+      end
     end
   end
 end

data/lib/onebox/engine/imgur_onebox.rb

@@ -17,23 +17,23 @@ module Onebox
 
       private
 
-        def video_html(og)
-          escaped_src = ::Onebox::Helpers.normalize_url_for_output(og[:video_secure_url])
+      def video_html(og)
+        escaped_src = ::Onebox::Helpers.normalize_url_for_output(og[:video_secure_url])
 
-          <<-HTML
+        <<-HTML
             <video width='#{og[:video_width]}' height='#{og[:video_height]}' #{Helpers.title_attr(og)} controls loop>
               <source src='#{escaped_src}' type='video/mp4'>
               <source src='#{escaped_src.gsub('mp4', 'webm')}' type='video/webm'>
             </video>
           HTML
-        end
+      end
 
-        def album_html(og)
-          escaped_url = ::Onebox::Helpers.normalize_url_for_output(url)
-          escaped_src = ::Onebox::Helpers.normalize_url_for_output(get_secure_link(og[:image]))
-          album_title = "[Album] #{Onebox::Helpers.truncate(og[:title].strip, 80)}"
+      def album_html(og)
+        escaped_url = ::Onebox::Helpers.normalize_url_for_output(url)
+        escaped_src = ::Onebox::Helpers.normalize_url_for_output(get_secure_link(og[:image]))
+        album_title = "[Album] #{Onebox::Helpers.truncate(og[:title].strip, 80)}"
 
-          <<-HTML
+        <<-HTML
             <div class='onebox imgur-album'>
               <a href='#{escaped_url}' target='_blank'>
                 <span class='outer-box' style='width:#{og[:image_width]}px'>
@@ -45,31 +45,31 @@ module Onebox
               </a>
             </div>
           HTML
-        end
+      end
 
-        def is_album?
-          response = Onebox::Helpers.fetch_response("https://api.imgur.com/oembed.json?url=#{url}") rescue "{}"
-          oembed_data = Onebox::Helpers.symbolize_keys(::MultiJson.load(response))
-          imgur_data_id = Nokogiri::HTML(oembed_data[:html]).xpath("//blockquote").attr("data-id")
-          imgur_data_id.to_s[/a\//]
-        end
+      def is_album?
+        response = Onebox::Helpers.fetch_response("https://api.imgur.com/oembed.json?url=#{url}") rescue "{}"
+        oembed_data = Onebox::Helpers.symbolize_keys(::MultiJson.load(response))
+        imgur_data_id = Nokogiri::HTML(oembed_data[:html]).xpath("//blockquote").attr("data-id")
+        imgur_data_id.to_s[/a\//]
+      end
 
-        def image_html(og)
-          escaped_url = ::Onebox::Helpers.normalize_url_for_output(url)
-          escaped_src = ::Onebox::Helpers.normalize_url_for_output(get_secure_link(og[:image]))
+      def image_html(og)
+        escaped_url = ::Onebox::Helpers.normalize_url_for_output(url)
+        escaped_src = ::Onebox::Helpers.normalize_url_for_output(get_secure_link(og[:image]))
 
-          <<-HTML
+        <<-HTML
             <a href='#{escaped_url}' target='_blank' class="onebox">
               <img src='#{escaped_src}' #{Helpers.title_attr(og)} alt='Imgur' height='#{og[:image_height]}' width='#{og[:image_width]}'>
             </a>
           HTML
-        end
+      end
 
-        def get_secure_link(link)
-          secure_link = URI(link)
-          secure_link.scheme = 'https'
-          secure_link.to_s
-        end
+      def get_secure_link(link)
+        secure_link = URI(link)
+        secure_link.scheme = 'https'
+        secure_link.to_s
+      end
 
     end
   end

data/lib/onebox/engine/soundcloud_onebox.rb

@@ -19,16 +19,16 @@ module Onebox
 
       private
 
-        def oembed_data
-          @oembed_data ||= begin
-            oembed_url = "https://soundcloud.com/oembed.json?url=#{url}"
-            oembed_url << "&maxheight=166" unless url["/sets/"]
-            response = Onebox::Helpers.fetch_response(oembed_url) rescue "{}"
-            Onebox::Helpers.symbolize_keys(::MultiJson.load(response))
-          rescue
-            {}
-          end
+      def oembed_data
+        @oembed_data ||= begin
+          oembed_url = "https://soundcloud.com/oembed.json?url=#{url}"
+          oembed_url << "&maxheight=166" unless url["/sets/"]
+          response = Onebox::Helpers.fetch_response(oembed_url) rescue "{}"
+          Onebox::Helpers.symbolize_keys(::MultiJson.load(response))
+        rescue
+          {}
         end
+      end
 
     end
   end