onebox 1.8.2 → 1.8.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7bddc4ec5570d9e839158818316491272520c001
-  data.tar.gz: 804d4e8c466460438cea08bda90d2d2a225ab033
+  metadata.gz: 988dda6f5b64b8781329e91c3f0b8dc826d0e8bc
+  data.tar.gz: df7b513451cfb05039fd6d45ff236d042bd8359c
 SHA512:
-  metadata.gz: cddd07899a1e69d94a798153e96d24422dabc06f35e65b8cd2b8ba1f57d2eb32bb5176556ba43430d8eb21bf3476b7b64ed19015895f6c190de7a9453314f060
-  data.tar.gz: 8baa511eec5d00d94b03705e53ef7eb386c13d58844b4dd94b177d0a84f370fc22550639fb3d088782cbc5572bb220b3422dd614cad4889a981eff13e3e418ce
+  metadata.gz: 50f11c399aaf148cc15111f3bc420f1f7dfd1e39c301b1757008ba13bc71f7ea73745f4c22e25c372696cb50587215b38510e47f835567545934028a12a2c2d7
+  data.tar.gz: 727cbe61c73b320fb63a9232a88afe41e75e231dfcb3d169d6571875c4bc5693688381f964454f77ce8e5c47a08813f0ccf1966d64517f0bb157aec77b6e0db0

data/lib/onebox/engine/amazon_onebox.rb

@@ -36,7 +36,7 @@ module Onebox
         if (main_image = raw.css("#main-image")) && main_image.any?
           attributes = main_image.first.attributes
 
-          return attributes["data-a-hires"] if attributes["data-a-hires"]
+          return attributes["data-a-hires"].to_s if attributes["data-a-hires"]
 
           if attributes["data-a-dynamic-image"]
             return ::JSON.parse(attributes["data-a-dynamic-image"].value).keys.first
@@ -44,7 +44,7 @@ module Onebox
         end
 
         if (landing_image = raw.css("#landingImage")) && landing_image.any?
-          landing_image.first["src"]
+          landing_image.first["src"].to_s
         end
       end
 

data/lib/onebox/helpers.rb

@@ -132,7 +132,7 @@ module Onebox
       # expect properly encoded url, remove any unsafe chars
       url.gsub!("'", "'")
       url.gsub!('"', """)
-      url.gsub!(/[^\w\-`.~:\/?#\[\]@!$&'\(\)*+,;=]/, "")
+      url.gsub!(/[^\w\-`.~:\/?#\[\]@!$&'\(\)*+,;=%]/, "")
       url
     end
 

data/lib/onebox/version.rb

@@ -1,3 +1,3 @@
 module Onebox
-  VERSION = "1.8.2"
+  VERSION = "1.8.3"
 end

data/onebox.gemspec

@@ -20,9 +20,9 @@ Gem::Specification.new do |spec|
 
   spec.add_runtime_dependency 'multi_json', '~> 1.11'
   spec.add_runtime_dependency 'mustache'
-  spec.add_runtime_dependency 'nokogiri', '~> 1.6.6'
-  spec.add_runtime_dependency 'moneta', '~> 0.8'
-  spec.add_runtime_dependency 'htmlentities', '~> 4.3.4'
+  spec.add_runtime_dependency 'nokogiri', '~> 1.7'
+  spec.add_runtime_dependency 'moneta', '~> 1.0'
+  spec.add_runtime_dependency 'htmlentities', '~> 4.3'
   spec.add_runtime_dependency 'fast_blank', '>= 1.0.0'
   spec.add_runtime_dependency 'sanitize'
 

data/spec/spec_helper.rb

@@ -6,6 +6,14 @@ require 'mocha/api'
 
 require_relative "support/html_spec_helper"
 
+# Monkey-patch fakeweb to support Ruby 2.4+.
+# See https://github.com/chrisk/fakeweb/pull/59.
+module FakeWeb
+  class StubSocket
+    def close; end
+  end
+end
+
 RSpec.configure do |config|
   config.before(:all) do
     FakeWeb.allow_net_connect = false
@@ -50,6 +58,10 @@ shared_examples_for "an engine" do
     it "includes link" do
       expect(data[:link]).not_to be_nil
     end
+
+    it "is serializable" do
+      expect { Marshal.dump(data) }.to_not raise_error
+    end
   end
 end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: onebox
 version: !ruby/object:Gem::Version
-  version: 1.8.2
+  version: 1.8.3
 platform: ruby
 authors:
 - Joanna Zeta
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-02-17 00:00:00.000000000 Z
+date: 2017-03-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: multi_json
@@ -46,42 +46,42 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.6.6
+        version: '1.7'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.6.6
+        version: '1.7'
 - !ruby/object:Gem::Dependency
   name: moneta
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.8'
+        version: '1.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.8'
+        version: '1.0'
 - !ruby/object:Gem::Dependency
   name: htmlentities
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 4.3.4
+        version: '4.3'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 4.3.4
+        version: '4.3'
 - !ruby/object:Gem::Dependency
   name: fast_blank
   requirement: !ruby/object:Gem::Requirement
@@ -491,7 +491,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.7
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: A gem for turning URLs into previews.
@@ -558,4 +558,3 @@ test_files:
 - spec/lib/onebox_spec.rb
 - spec/spec_helper.rb
 - spec/support/html_spec_helper.rb
-has_rdoc: