onebox 1.8.19 → 1.8.20

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 38a4803aa8b41e5e08c6b2881049952f0c772e37
-  data.tar.gz: 2f376044f6d308b5d806dc8056ada1c55f17b214
+  metadata.gz: d0d747ccf49e968f722763eca04698951e5c7e68
+  data.tar.gz: 35af72508f38423f9967f3eef0d1e91a13a5dbb7
 SHA512:
-  metadata.gz: 31f66a6050c43f98620b41a179f32917126bfc266376a60be8b83282fb73a6c9d1a1fadc3131b755b901da4bc69b35f53f6d67b5b54ab324a833623f8bb131ab
-  data.tar.gz: 6a033b6660c4a06ad1eaad84115fd1c8a386923e306e9678e7e5b26b0fe710157dd0fabe132f887fedba36e7f401fc4627bfe6d99ce6fd34d8bfef5dd3b0bc03
+  metadata.gz: 461d1871c66df3448f96e8a6283bea3be8476cae3352b25708913734dd3af2ecd93eee2f413b0459a3a25bb3ed7f984644fda7825cbef147a9b27f1bc4403629
+  data.tar.gz: 5751126eacb1be8122f6ff008fb981a6e38ec00fb4c02586a6662a28ad817d9e65d666fb3d279c51bb53f221f25717ff9bf3b1531a9110c43270c6d8c1baebba

data/README.md

@@ -1,11 +1,10 @@
 onebox
-----------
-
-  - [![Gem Version](https://badge.fury.io/rb/onebox.png)](https://rubygems.org/gems/onebox)
-  - [![Code Climate](https://codeclimate.com/github/dysania/onebox.png)](https://codeclimate.com/github/dysania/onebox)
-  - [![Build Status](https://travis-ci.org/discourse/onebox.png)](https://travis-ci.org/discourse/onebox)
-  - [![Dependency Status](https://gemnasium.com/discourse/onebox.png)](https://gemnasium.com/discourse/onebox)
+======
 
+[![Gem Version](https://badge.fury.io/rb/onebox.png)](https://rubygems.org/gems/onebox)
+[![Code Climate](https://codeclimate.com/github/dysania/onebox.png)](https://codeclimate.com/github/dysania/onebox)
+[![Build Status](https://travis-ci.org/discourse/onebox.png)](https://travis-ci.org/discourse/onebox)
+[![Dependency Status](https://gemnasium.com/discourse/onebox.png)](https://gemnasium.com/discourse/onebox)
 
 Onebox is a library for turning media URLs into simple HTML previews of the resource.
 
@@ -19,7 +18,7 @@ It was originally created for [Discourse](http://discourse.org) but has since be
 extracted into this convenient gem for all to use!
 
 Usage
-=====
+-----
 
 Using onebox is fairly simple!
 First, make sure the library is required:
@@ -73,7 +72,7 @@ preview = Onebox.preview(url)
 ```
 
 Development Preview Interface
-=============================
+-----------------------------
 
 The onebox gem comes with a development server for previewing the results
 of your changes. You can run it by running `bundle exec rake server` after checking
@@ -84,7 +83,7 @@ make sure to hit CTRL-C and restart the server to try a code change out.
 
 
 Adding Support for a new URL
-============================
+----------------------------
 
   1. Check if the site supports [oEmbed](http://oembed.com/) or [Open Graph](https://developers.facebook.com/docs/opengraph/).
      If it does, you can probably get away with just whitelisting the URL in `Onebox::Engine::WhitelistedGenericOnebox` (see: [Whitelisted Generic Onebox caveats](#user-content-whitelisted-generic-onebox-caveats)).
@@ -177,7 +176,7 @@ Adding Support for a new URL
 
 
 Whitelisted Generic Onebox caveats
-==================================
+----------------------------------
 
 The Whitedlisted Generic Onebox has some caveats for it's use, beyond simply whitelisting the domain.
 
@@ -187,7 +186,7 @@ The Whitedlisted Generic Onebox has some caveats for it's use, beyond simply whi
 
 
 Installing
-==========
+----------
 
 Add this line to your application's Gemfile:
 
@@ -203,13 +202,13 @@ Or install it yourself as:
 
 
 Issues / Discussion
-===================
+-------------------
 
 Discussion of the Onebox gem, its development and features should be done on
 [Discourse Meta](https://meta.discourse.org). 
 
 Contributing
-============
+------------
 
   1. Fork it
   2. Create your feature branch (`git checkout -b my-new-feature`)

data/lib/onebox/engine/google_docs_onebox.rb

@@ -26,7 +26,7 @@ module Onebox
         og_data = get_og_data
         result = { link: link,
                    title: og_data[:title] || "Google #{shorttype.to_s.capitalize}",
-                   description: og_data[:description] || "This #{shorttype.to_s.chop.capitalize} is private",
+                   description: Sanitize.fragment(Onebox::Helpers.truncate(og_data[:description], 250)) || "This #{shorttype.to_s.chop.capitalize} is private",
                    type: shorttype
                  }
         result

data/lib/onebox/engine/whitelisted_generic_onebox.rb

@@ -216,6 +216,12 @@ module Onebox
           d[:image] = d[:image_secure_url] || d[:image_url] || d[:thumbnail_url] || d[:image]
           d[:video] = d[:video_secure_url] || d[:video_url] || d[:video]
 
+          # Twitter labels
+          d[:label1] = Sanitize.fragment(Onebox::Helpers.truncate(d[:label1].strip))
+          d[:data1] = Sanitize.fragment(Onebox::Helpers.truncate(d[:data1].strip))
+          d[:label2] = Sanitize.fragment(Onebox::Helpers.truncate(d[:label2].strip))
+          d[:data2] = Sanitize.fragment(Onebox::Helpers.truncate(d[:data2].strip))
+
           d
         end
       end

data/lib/onebox/version.rb

@@ -1,3 +1,3 @@
 module Onebox
-  VERSION = "1.8.19"
+  VERSION = "1.8.20"
 end

data/templates/whitelistedgeneric.mustache

@@ -3,3 +3,14 @@
 <h3><a href='{{link}}' target="_blank">{{title}}</a></h3>
 
 <p>{{description}}</p>
+
+{{#data1}}
+  <p><span class="label1">{{label1}}: {{data1}}</span>
+  {{#data2}}
+    <span class="label2">{{label2}}: {{data2}}</span></p>
+  {{/data2}}
+  {{^data2}}
+    </p>
+  {{/data2}}
+{{/data1}}
+

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: onebox
 version: !ruby/object:Gem::Version
-  version: 1.8.19
+  version: 1.8.20
 platform: ruby
 authors:
 - Joanna Zeta
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-09-18 00:00:00.000000000 Z
+date: 2017-11-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: multi_json