onebox 1.8.13 → 1.8.14

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 881354a49c26f3ff8f7f96286bfda2f1fe313cf5
-  data.tar.gz: ff63ab334806ad83ba234af67d29eff74a40c0b2
+  metadata.gz: 4f00805e5c613840f9f98fefcb90c73d6d51b7f8
+  data.tar.gz: e792fae938aa9941c43b9dc2e777bc9989e5a1ff
 SHA512:
-  metadata.gz: c7ce9b381f54dfa5c1ae033ee67c7c824a026b2eedb91e7569668e105745dc0e1158a683baeb5582850c79016c0d0f3178c17d155fa3eea3d2b9334f8fc70e5e
-  data.tar.gz: 4099701a95bc9eb0c7a5d39df03f062f794f81c63aeb69ec96b489f193d3034e4d270dabeedbcc00972cbfd919b05f703fdb1f5b3303707a49cc80da7e24e7a4
+  metadata.gz: fac489547c2fe0b742a73e079976ce2ced75fbc700c52136b24406ab6765d8157ee02bb25ce64c2a6fbaa8d674163f4f998212ad5a4dd1628ebae5c705aad3b2
+  data.tar.gz: d1ab7cae2d6fee5348f161b50936fa4d7fbb64ba3ff607a58640751160c0294de5f29d4a45b31e1881f42450a83fae3dba354b5d484a924bc4724a9dd7b9fe94

data/lib/onebox/engine.rb

@@ -180,3 +180,4 @@ require_relative "engine/pdf_onebox"
 require_relative "engine/twitch_clips_onebox"
 require_relative "engine/twitch_stream_onebox"
 require_relative "engine/twitch_video_onebox"
+require_relative "engine/trello_onebox"

data/lib/onebox/engine/google_maps_onebox.rb

@@ -119,7 +119,8 @@ module Onebox
 
         when :canonical
           uri = URI(@url)
-          query = Hash[*uri.query.split("&").map{|a|a.split("=")}.flatten]
+
+          query = URI::decode_www_form(uri.query).to_h
           if !query.has_key?("ll")
             raise ArgumentError, "canonical url lacks location argument" unless query.has_key?("sll")
             query["ll"] = query["sll"]

data/lib/onebox/engine/trello_onebox.rb

@@ -0,0 +1,30 @@
+module Onebox
+  module Engine
+    class TrelloOnebox
+      include Engine
+      include StandardEmbed
+
+      matches_regexp(/^https:\/\/trello\.com\/[bc]\/\W*/)
+      always_https
+
+      def to_html
+        link = "https://trello.com/#{match[:type]}/#{match[:key]}.html"
+
+        height = match[:type] == 'b' ? 400 : 200
+
+        <<-HTML
+          <iframe src=\"#{link}\" width=\"100%\" height=\"#{height}\" frameborder=\"0\" style=\"border:0\"></iframe>
+        HTML
+      end
+
+      private
+        def match
+          return @match if @match
+
+          @match = @url.match(%{trello\.com/(?<type>[^/]+)/(?<key>[^/]+)/?\W*})
+
+          @match
+        end
+    end
+  end
+end

data/lib/onebox/version.rb

@@ -1,3 +1,3 @@
 module Onebox
-  VERSION = "1.8.13"
+  VERSION = "1.8.14"
 end

data/spec/lib/onebox/engine/trello_onebox_spec.rb

@@ -0,0 +1,30 @@
+require "spec_helper"
+
+describe Onebox::Engine::TrelloOnebox do
+  context "Boards" do
+    it "should onebox with SEF url corrrectly" do
+      expect(Onebox.preview('https://trello.com/b/nC8QJJoZ/trello-development-roadmap').to_s).to match('iframe src="https://trello.com/b/nC8QJJoZ.html"')
+    end
+
+    it "should onebox without SEF url corrrectly" do
+      expect(Onebox.preview('https://trello.com/b/nC8QJJoZ/').to_s).to match('iframe src="https://trello.com/b/nC8QJJoZ.html"')
+
+      # Without trailing slash
+      expect(Onebox.preview('https://trello.com/b/nC8QJJoZ').to_s).to match('iframe src="https://trello.com/b/nC8QJJoZ.html"')
+    end
+  end
+
+  context "Cards" do
+    it "should onebox with SEF url corrrectly" do
+      expect(Onebox.preview('https://trello.com/c/NIRpzVDM/1211-what-can-you-expect-from-this-board').to_s).to match('iframe src="https://trello.com/c/NIRpzVDM.html"')
+    end
+
+    it "should onebox without SEF url corrrectly" do
+      expect(Onebox.preview('https://trello.com/c/NIRpzVDM/').to_s).to match('iframe src="https://trello.com/c/NIRpzVDM.html"')
+
+      # Without trailing slash
+      expect(Onebox.preview('https://trello.com/c/NIRpzVDM').to_s).to match('iframe src="https://trello.com/c/NIRpzVDM.html"')
+    end
+  end
+
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: onebox
 version: !ruby/object:Gem::Version
-  version: 1.8.13
+  version: 1.8.14
 platform: ruby
 authors:
 - Joanna Zeta
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-06-22 00:00:00.000000000 Z
+date: 2017-07-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: multi_json
@@ -365,6 +365,7 @@ files:
 - lib/onebox/engine/stack_exchange_onebox.rb
 - lib/onebox/engine/standard_embed.rb
 - lib/onebox/engine/steam_store_onebox.rb
+- lib/onebox/engine/trello_onebox.rb
 - lib/onebox/engine/twitch_clips_onebox.rb
 - lib/onebox/engine/twitch_stream_onebox.rb
 - lib/onebox/engine/twitch_video_onebox.rb
@@ -443,6 +444,7 @@ files:
 - spec/lib/onebox/engine/pubmed_onebox_spec.rb
 - spec/lib/onebox/engine/slides_onebox_spec.rb
 - spec/lib/onebox/engine/stack_exchange_onebox_spec.rb
+- spec/lib/onebox/engine/trello_onebox_spec.rb
 - spec/lib/onebox/engine/twitch_clips_onebox_spec.rb
 - spec/lib/onebox/engine/twitch_stream_onebox_spec.rb
 - spec/lib/onebox/engine/twitch_video_onebox_spec.rb
@@ -563,6 +565,7 @@ test_files:
 - spec/lib/onebox/engine/pubmed_onebox_spec.rb
 - spec/lib/onebox/engine/slides_onebox_spec.rb
 - spec/lib/onebox/engine/stack_exchange_onebox_spec.rb
+- spec/lib/onebox/engine/trello_onebox_spec.rb
 - spec/lib/onebox/engine/twitch_clips_onebox_spec.rb
 - spec/lib/onebox/engine/twitch_stream_onebox_spec.rb
 - spec/lib/onebox/engine/twitch_video_onebox_spec.rb