onebox 1.8.10 → 1.8.11

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 456aaa9602502159cf7927cf63c8f12dac02fcdd
-  data.tar.gz: bd0a13a8f4716ece3fbe7b4eae08eb56cec974d4
+  metadata.gz: b9fdd8decf0ce95f8a5c44381780bbc8d66e8c50
+  data.tar.gz: 8147a14fb6fd5990ace1e5cf2bcefa928a1e0ba9
 SHA512:
-  metadata.gz: 2f249d787803f2182a17365d608be8f9806fddc299cd9a943993610c745ccc26fad939a679ae4a2af5591bb5c931c1a86c30e57c2344677e9c89fe5582724f2e
-  data.tar.gz: 29f295edadf7c3945dcb0d2f848e3be6b001d036be10db49028573d37a11a3600eba47bb67885bff69f661de6ac232358f715ef9e9baa9a8a800608dbd5c6e20
+  metadata.gz: b0c8feea7c6a688a416f524d33d981377b5307e02aeb58e110679c239fb1b73a4c4fc5bc043eb6cda31e309a78065ee087194d483afa3c1c249c22017a03e643
+  data.tar.gz: 6f17186c5a4a3ae9dce8b4866b3c87d4c94d5c65a829b28ade3f4aa76d464f572ca05fcc45da173516f0b4abf7376dd53873994ff06307bfa8e01b4f3c4b77e8

data/lib/onebox/engine/standard_embed.rb

@@ -50,7 +50,14 @@ module Onebox
       protected
 
         def html_doc
-          @html_doc ||= Nokogiri::HTML((Onebox::Helpers.fetch_response(url) rescue nil))
+          return @html_doc if @html_doc
+
+          headers = nil
+          headers = { 'Cookie' => options[:cookie] } if options[:cookie]
+
+          response = (Onebox::Helpers.fetch_response(url, nil, nil, headers) rescue nil)
+
+          @html_doc = Nokogiri::HTML(response)
         end
 
         def get_oembed

data/lib/onebox/helpers.rb

@@ -39,8 +39,9 @@ module Onebox
       og
     end
 
-    def self.fetch_response(location, limit=5, domain=nil, headers=nil)
+    def self.fetch_response(location, limit=nil, domain=nil, headers=nil)
 
+      limit ||= 5
       limit = Onebox.options.redirect_limit if limit > Onebox.options.redirect_limit
 
       raise Net::HTTPError.new('HTTP redirect too deep', location) if limit == 0
@@ -70,7 +71,7 @@ module Onebox
         http.request(request) do |response|
 
           if cookie = response.get_fields('set-cookie')
-            header = { 'cookie' => cookie.join }
+            header = { 'Cookie' => cookie.join }
           end
 
           header = nil unless header.is_a? Hash

data/lib/onebox/preview.rb

@@ -66,7 +66,11 @@ module Onebox
 
       def engine
         return nil unless @engine_class
-        @engine ||= @engine_class.new(@url, cache)
+        return @engine if @engine
+
+        @engine = @engine_class.new(@url, cache)
+        @engine.options = @options
+        @engine
       end
 
       class InvalidURI < StandardError; end

data/lib/onebox/version.rb

@@ -1,3 +1,3 @@
 module Onebox
-  VERSION = "1.8.10"
+  VERSION = "1.8.11"
 end

data/spec/lib/onebox/engine/whitelisted_generic_onebox_spec.rb

@@ -83,6 +83,20 @@ describe Onebox::Engine::WhitelistedGenericOnebox do
     end
   end
 
+  describe "cookie support" do
+    let(:url) { "http://cookie-test.com" }
+    before do
+      fake(url, response('dailymail'))
+    end
+
+    it "sends the cookie with the request" do
+      onebox = described_class.new(url)
+      onebox.options = { cookie: "evil=trout" }
+      expect(onebox.to_html).not_to be_empty
+      expect(FakeWeb.last_request['Cookie']).to eq('evil=trout')
+    end
+  end
+
   describe 'to_html' do
     after(:each) do
       Onebox.options = Onebox::DEFAULTS

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: onebox
 version: !ruby/object:Gem::Version
-  version: 1.8.10
+  version: 1.8.11
 platform: ruby
 authors:
 - Joanna Zeta
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-06-02 00:00:00.000000000 Z
+date: 2017-06-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: multi_json