onebox 1.6.4 → 1.6.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f66b9e99739c4d99ed0de7f781c2103857372d39
-  data.tar.gz: 44909b6ed468b9da999d79ab23f7edd0cdf49108
+  metadata.gz: d7ab04f20175f2f5178aeff589be9de5a3c6efbf
+  data.tar.gz: 30c66d325d2a5f48124dda00297da95373ff2a9e
 SHA512:
-  metadata.gz: c9f604421b36115f034264bd092366e3f640087c750d38d8293e1f3db4343e74c236a60eba98b33eb5c1f06d0d5277f188515cd37c54c5b5bb7e94422c44e69e
-  data.tar.gz: 48b59ff62e5417e353a5a5ff7daaf002475243b2e8bf71d45ee00639e271a85de6e1bf22dda104ac6a2a6c34e1f953dd3428ca17fe63d11035cb0ad3b773c7d1
+  metadata.gz: 4174a3df1a3af3bb4ef2c3e1604bd06102128d1ec8557bf8bef70f670f47e65015f3764cd49dfc4b6d1638d63f07cdbc1f79a267ca4208a88d66f8a560c2088e
+  data.tar.gz: bc7fcc8ecdf0b816f64f0ccd37a40841a37b0f0d8aa282fb5a7f3239e18a8929b8a3b321143373f33d5ad547eeccc9c6626a29adfbc6ed7c818d2d4a2cd1b317

data/lib/onebox.rb

@@ -8,6 +8,7 @@ require "moneta"
 require "cgi"
 require "net/http"
 require "digest"
+require "fast_blank"
 
 module Onebox
   DEFAULTS = {

data/lib/onebox/helpers.rb

@@ -57,7 +57,11 @@ module Onebox
     end
 
     def self.blank?(value)
-      value.respond_to?(:empty?) ? !!value.empty? || !value[/\S/] : !value
+      if value.respond_to?(:blank?)
+        value.blank?
+      else
+        value.respond_to?(:empty?) ? !!value.empty? : !value
+      end
     end
 
     def self.truncate(string, length = 50)

data/lib/onebox/version.rb

@@ -1,3 +1,3 @@
 module Onebox
-  VERSION = "1.6.4"
+  VERSION = "1.6.5"
 end

data/onebox.gemspec

@@ -23,6 +23,7 @@ Gem::Specification.new do |spec|
   spec.add_runtime_dependency 'nokogiri', '~> 1.6.6'
   spec.add_runtime_dependency 'moneta', '~> 0.8'
   spec.add_runtime_dependency 'htmlentities', '~> 4.3.4'
+  spec.add_runtime_dependency 'fast_blank', '>= 1.0.0'
 
   spec.add_development_dependency 'bundler', '~> 1.7'
   spec.add_development_dependency 'rake', '~> 10.4'

data/spec/lib/onebox/helpers_spec.rb

@@ -0,0 +1,16 @@
+require 'spec_helper'
+
+RSpec.describe Onebox::Helpers do
+  describe '.blank?' do
+    it { expect(Onebox::Helpers.blank?("")).to be(true) }
+    it { expect(Onebox::Helpers.blank?(" ")).to be(true) }
+    it { expect(Onebox::Helpers.blank?("test")).to be(false) }
+    it { expect(Onebox::Helpers.blank?(["test", "testing"])).to be(false) }
+    it { expect(Onebox::Helpers.blank?([])).to be(true) }
+    it { expect(Onebox::Helpers.blank?({})).to be(true) }
+    it { expect(Onebox::Helpers.blank?({a: 'test'})).to be(false) }
+    it { expect(Onebox::Helpers.blank?(nil)).to be(true) }
+    it { expect(Onebox::Helpers.blank?(true)).to be(false) }
+    it { expect(Onebox::Helpers.blank?(false)).to be(true) }
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: onebox
 version: !ruby/object:Gem::Version
-  version: 1.6.4
+  version: 1.6.5
 platform: ruby
 authors:
 - Joanna Zeta
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-12-14 00:00:00.000000000 Z
+date: 2016-12-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: multi_json
@@ -82,6 +82,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 4.3.4
+- !ruby/object:Gem::Dependency
+  name: fast_blank
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 1.0.0
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 1.0.0
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -399,6 +413,7 @@ files:
 - spec/lib/onebox/engine/youku_onebox_spec.rb
 - spec/lib/onebox/engine/youtube_onebox_spec.rb
 - spec/lib/onebox/engine_spec.rb
+- spec/lib/onebox/helpers_spec.rb
 - spec/lib/onebox/layout_spec.rb
 - spec/lib/onebox/matcher_spec.rb
 - spec/lib/onebox/preview_spec.rb
@@ -449,7 +464,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.7
+rubygems_version: 2.5.2
 signing_key: 
 specification_version: 4
 summary: A gem for turning URLs into previews.
@@ -505,6 +520,7 @@ test_files:
 - spec/lib/onebox/engine/youku_onebox_spec.rb
 - spec/lib/onebox/engine/youtube_onebox_spec.rb
 - spec/lib/onebox/engine_spec.rb
+- spec/lib/onebox/helpers_spec.rb
 - spec/lib/onebox/layout_spec.rb
 - spec/lib/onebox/matcher_spec.rb
 - spec/lib/onebox/preview_spec.rb
@@ -512,4 +528,3 @@ test_files:
 - spec/lib/onebox_spec.rb
 - spec/spec_helper.rb
 - spec/support/html_spec_helper.rb
-has_rdoc: