onebox 1.5.16 → 1.5.17

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 05960d76842fc3238a0f46a23628e0be16c1318a
-  data.tar.gz: 48c532235d45121bc4f3c781b52b6400db94debb
+  metadata.gz: 451ff8d5ee7ce3d3c3fdeffca55cccba29cdb91c
+  data.tar.gz: 83033812a9b67dd10048cfe72896c5b315e2d5da
 SHA512:
-  metadata.gz: 6a7f575db20f96c4267882b4cb7c9ec2b2a2c2e7335897545342ad1074a7eeccdc2bf4edd087f714c759b7560571bbe9de0b8038cb9f7d34028f4f0708b29270
-  data.tar.gz: 0f5e9e0d2ea683fce332e4718ad4b810d5594159fedd2ccf9338c0d964fe90f9390f842c668d940570e7b7921697825486273c4b36bc4c02f1717309dcfec5aa
+  metadata.gz: a76b282e64d1191b6e7ddd4dc2f8a2b8f30c6f10f409a12ee71d3e794005c6cba66f26d315aec092e05ceb6bc586af6afe2c08ea29ba14000ebb4afd330992c6
+  data.tar.gz: 10faeefda12d96758903bbb6f11e1bfc2462a4f73e6be19466e1b6f3030d3eeb93ca2b0ceb9e7d74114fc0f04e25b5f272b24efc47125dce3b88027280f826a8

data/lib/onebox/engine.rb

@@ -123,12 +123,14 @@ require_relative "engine/standard_embed"
 require_relative "engine/html"
 require_relative "engine/json"
 require_relative "engine/amazon_onebox"
-require_relative "engine/classic_google_maps_onebox"
 require_relative "engine/github_issue_onebox"
 require_relative "engine/github_blob_onebox"
 require_relative "engine/github_commit_onebox"
 require_relative "engine/github_gist_onebox"
 require_relative "engine/github_pullrequest_onebox"
+require_relative "engine/google_calendar_onebox"
+require_relative "engine/google_docs_onebox"
+require_relative "engine/google_maps_onebox"
 require_relative "engine/google_play_app_onebox"
 require_relative "engine/image_onebox"
 require_relative "engine/video_onebox"
@@ -141,5 +143,3 @@ require_relative "engine/youku_onebox"
 require_relative "engine/douban_onebox"
 require_relative "engine/whitelisted_generic_onebox"
 require_relative "engine/pubmed_onebox"
-require_relative "engine/google_calendar_onebox"
-require_relative "engine/google_docs_onebox"

data/lib/onebox/engine/google_maps_onebox.rb

@@ -0,0 +1,176 @@
+module Onebox
+  module Engine
+    class GoogleMapsOnebox
+      include Engine
+
+      class << self
+        def ===(other)
+          if other.kind_of? URI
+            @@matchers && @@matchers.any? {|m| other.to_s =~ m[:regexp] }
+          else
+            super
+          end
+        end
+
+        private
+
+        def matches_regexp(key, regexp)
+          (@@matchers ||= []) << {key: key, regexp: regexp}
+        end
+      end
+
+      # Matches shortened Google Maps URLs
+      matches_regexp :short,      %r"^(https?:)?//goo\.gl/maps/"
+
+      # Matches URLs for custom-created maps
+      matches_regexp :custom,     %r"^(?:https?:)?//www\.google(?:\.(?:\w{2,}))+/maps/d/(?:edit|viewer|embed)\?mid=.+$"
+
+      # Matches URLs with streetview data
+      matches_regexp :streetview, %r"^(?:https?:)?//www\.google(?:\.(?:\w{2,}))+/maps[^@]+@(?<lon>[\d.]+),(?<lat>[\d.]+),(?:\d+)a,(?<zoom>[\d.]+)y,(?<heading>[\d.]+)h,(?<pitch>[\d.]+)t.+?data=.*?!1s(?<pano>[^!]{22})"
+
+      # Matches "normal" Google Maps URLs with arbitrary data
+      matches_regexp :standard,   %r"^(?:https?:)?//www\.google(?:\.(?:\w{2,}))+/maps"
+
+      # Matches URLs for the old Google Maps domain which we occasionally get redirected to
+      matches_regexp :canonical,  %r"^(?:https?:)?//maps\.google(?:\.(?:\w{2,}))+/maps\?"
+
+      def initialize(url, cache = nil, timeout = nil)
+        super
+        resolve_url!
+      rescue Net::HTTPServerException, Timeout::Error, Net::HTTPError, Errno::ECONNREFUSED, RuntimeError => err
+        raise ArgumentError, "malformed url or unresolveable: #{err.message}"
+      end
+
+      def streetview?
+        !!@streetview
+      end
+
+      def to_html
+        Helpers.click_to_scroll_div + "<iframe src=\"#{link}\" width=\"690\" height=\"400\" frameborder=\"0\" style=\"border:0\"></iframe>"
+      end
+
+      def placeholder_html
+        width = @placeholder_width || 690
+        height = @placeholder_height || 400
+        "<img src=\"#{CGI.escapeHTML(@placeholder)}\" width=\"#{width}\" height=\"#{height}\"/>"
+      end
+
+      private
+
+      def data
+        { link: url, title: url }
+      end
+
+      def resolve_url!
+        @streetview = false
+        type, match = match_url
+
+        # Resolve shortened URL, if necessary
+        if type == :short
+          follow_redirect!
+          type, match = match_url
+        end
+
+        # Try to get the old-maps URI, it is far easier to embed.
+        if type == :standard
+          retry_count = 10
+          while (retry_count -= 1) > 0
+            follow_redirect!
+            type, match = match_url
+            break if type != :standard
+            sleep 0.1
+          end
+        end
+
+        case type
+        when :standard
+          # Fallback for map URLs that don't resolve into an easily embeddable old-style URI
+          # Roadmaps use a "z" zoomlevel, satellite maps use "m" the horizontal width in meters
+          # TODO: tilted satellite maps using "a,y,t"
+          match = @url.match(/@(?<lon>[\d.-]+),(?<lat>[\d.-]+),(?<zoom>\d+)(?<mz>[mz])/)
+          raise "unexpected standard url #{@url}" unless match
+          zoom = match[:mz] == "z" ? match[:zoom] : Math.log2(57280048.0 / match[:zoom].to_f).round
+          location = "#{match[:lon]},#{match[:lat]}"
+          url = "https://maps.google.com/maps?ll=#{location}&z=#{zoom}&output=embed&dg=ntvb"
+          url += "&q=#{$1}" if match = @url.match(/\/place\/([^\/\?]+)/)
+          url += "&cid=#{($1 + $2).to_i(16)}" if @url.match(/!3m1!1s0x(\h{16}):0x(\h{16})/)
+          @url = url
+          @placeholder = "http://maps.googleapis.com/maps/api/staticmap?maptype=roadmap&center=#{location}&zoom=#{zoom}&size=690x400&sensor=false"
+
+        when :custom
+          url = @url.dup
+          @url = rewrite_custom_url(url, "embed")
+          @placeholder = rewrite_custom_url(url, "thumbnail")
+          @placeholder_height = @placeholder_width = 120
+
+        when :streetview
+          @streetview = true
+          panoid = match[:pano]
+          lon = match[:lon].to_f.to_s
+          lat = match[:lat].to_f.to_s
+          heading = match[:heading].to_f.round(4).to_s
+          pitch = (match[:pitch].to_f / 10.0).round(4).to_s
+          fov = (match[:zoom].to_f / 100.0).round(4).to_s
+          zoom = match[:zoom].to_f.round
+          @url = "https://www.google.com/maps/embed?pb=!3m2!2sen!4v0!6m8!1m7!1s#{panoid}!2m2!1d#{lon}!2d#{lat}!3f#{heading}!4f#{pitch}!5f#{fov}"
+          @placeholder = "http://maps.googleapis.com/maps/api/streetview?size=690x400&location=#{lon},#{lat}&pano=#{panoid}&fov=#{zoom}&heading=#{heading}&pitch=#{pitch}&sensor=false"
+
+        when :canonical
+          uri = URI(@url)
+          query = Hash[*uri.query.split("&").map{|a|a.split("=")}.flatten]
+          if !query.has_key?("ll")
+            raise ArgumentError, "canonical url lacks location argument" unless query.has_key?("sll")
+            query["ll"] = query["sll"]
+            @url += "&ll=#{query["sll"]}"
+          end
+          location = query["ll"]
+          if !query.has_key?("z")
+            raise ArgumentError, "canonical url has incomplete query arguments" unless query.has_key?("spn") || query.has_key?("sspn")
+            if !query.has_key?("spn")
+              query["spn"] = query["sspn"]
+              @url += "&spn=#{query["sspn"]}"
+            end
+            angle = query["spn"].split(",").first.to_f
+            zoom = (Math.log(690.0 * 360.0 / angle / 256.0) / Math.log(2)).round
+          else
+            zoom = query["z"]
+          end
+          @url = @url.sub('output=classic', 'output=embed')
+          @placeholder = "http://maps.googleapis.com/maps/api/staticmap?maptype=roadmap&size=690x400&sensor=false&center=#{location}&zoom=#{zoom}"
+
+        else
+          raise "unexpected url type #{type.inspect}"
+        end
+      end
+
+      def match_url
+        @@matchers.each do |matcher|
+          if m = matcher[:regexp].match(@url)
+            return matcher[:key], m
+          end
+        end
+        raise ArgumentError, "\"#{@url}\" does not match any known pattern"
+      end
+
+      def rewrite_custom_url(url, target)
+        uri = URI(url)
+        uri.path = uri.path.sub(/(?<=^\/maps\/d\/)\w+$/, target)
+        uri.to_s
+      end
+
+      def follow_redirect!
+        uri = URI(@url)
+        begin
+          http = Net::HTTP.start(uri.host, uri.port,
+            use_ssl: uri.scheme == 'https', open_timeout: timeout, read_timeout: timeout)
+          response = http.head(uri.path)
+          raise "unexpected response code #{response.code}" unless %w(301 302).include?(response.code)
+          @url = response["Location"]
+        ensure
+          http.finish rescue nil
+        end
+      end
+
+    end
+  end
+end

data/lib/onebox/engine/standard_embed.rb

@@ -19,9 +19,11 @@ module Onebox
       end
 
       # Some oembed providers (like meetup.com) don't provide links to themselves
-      add_oembed_provider /www\.meetup\.com\//, 'http://api.meetup.com/oembed'
+      add_oembed_provider /www\.flickr\.com\//, 'http://www.flickr.com/services/oembed.json'
       add_oembed_provider /www\.kickstarter\.com\//, 'https://www.kickstarter.com/services/oembed'
+      add_oembed_provider /www\.meetup\.com\//, 'http://api.meetup.com/oembed'
       add_oembed_provider /www\.ted\.com\//, 'http://www.ted.com/services/v1/oembed.json'
+      add_oembed_provider /(.*\.)?vimeo\.com\//, 'http://vimeo.com/api/oembed.json'
 
       # Sites that work better with OpenGraph
       add_opengraph_provider /gfycat\.com\//

data/lib/onebox/engine/whitelisted_generic_onebox.rb

@@ -62,6 +62,7 @@ module Onebox
           hulu.com
           ign.com
           ikea.com
+          imdb.com
           imgur.com
           indiatimes.com
           instagr.am
@@ -131,7 +132,7 @@ module Onebox
       # include the entire page HTML. However for some providers like Imgur it allows us
       # to return gifv and galleries.
       def self.default_html_providers
-        ['Imgur', 'Meetup']
+        ['Flickr', 'Imgur', 'Meetup']
       end
 
       def self.html_providers

data/lib/onebox/helpers.rb

@@ -51,5 +51,9 @@ module Onebox
           response.error!
       end
     end
+
+    def self.click_to_scroll_div(width = 690, height = 400)
+      "<div style=\"background:transparent;position:relative;width:#{width}px;height:#{height}px;top:#{height}px;margin-top:-#{height}px;\" onClick=\"style.pointerEvents='none'\"></div>"
+    end
   end
 end

data/lib/onebox/version.rb

@@ -1,3 +1,3 @@
 module Onebox
-  VERSION = "1.5.16"
+  VERSION = "1.5.17"
 end

data/spec/lib/onebox/engine/google_maps_onebox_spec.rb

@@ -0,0 +1,70 @@
+require "spec_helper"
+
+describe Onebox::Engine::GoogleMapsOnebox do
+
+  URLS = {
+    short: {
+      test: "https://goo.gl/maps/rEG3D",
+      redirect: ["302 Found", :long],
+      expect: "https://maps.google.de/maps?sll=40.689249,-74.0445&sspn=0.0062479,0.0109864&cid=4667599994556318251&q=Statue+of+Liberty+National+Monument&output=embed&dg=ntvb&ll=40.689249,-74.0445&spn=0.0062479,0.0109864",
+    },
+    long: {
+      test: "https://www.google.de/maps/place/Statue+of+Liberty+National+Monument/@40.689249,-74.0445,17z/data=!3m1!4b1!4m2!3m1!1s0x89c25090129c363d:0x40c6a5770d25022b",
+      redirect: ["301 Moved Permanently", :canonical],
+      expect: "https://maps.google.de/maps?sll=40.689249,-74.0445&sspn=0.0062479,0.0109864&cid=4667599994556318251&q=Statue+of+Liberty+National+Monument&output=embed&dg=ntvb&ll=40.689249,-74.0445&spn=0.0062479,0.0109864",
+    },
+    canonical: {
+      test: "https://maps.google.de/maps?sll=40.689249,-74.0445&sspn=0.0062479,0.0109864&cid=4667599994556318251&q=Statue+of+Liberty+National+Monument&output=classic&dg=ntvb",
+      expect: "https://maps.google.de/maps?sll=40.689249,-74.0445&sspn=0.0062479,0.0109864&cid=4667599994556318251&q=Statue+of+Liberty+National+Monument&output=embed&dg=ntvb&ll=40.689249,-74.0445&spn=0.0062479,0.0109864",
+    },
+    custom: {
+      test: "https://www.google.com/maps/d/edit?mid=zPYyZFrHi1MU.kX85W_Y2y2_E",
+      expect: "https://www.google.com/maps/d/embed?mid=zPYyZFrHi1MU.kX85W_Y2y2_E",
+    },
+    streetview: {
+      test: "https://www.google.com/maps/@46.414384,10.013947,3a,75y,232.83h,99.08t/data=!3m5!1e1!3m3!1s9WgYUb5quXDjqqFd3DWI6A!2e0!3e5?hl=de",
+      expect: "https://www.google.com/maps/embed?pb=!3m2!2sen!4v0!6m8!1m7!1s9WgYUb5quXDjqqFd3DWI6A!2m2!1d46.414384!2d10.013947!3f232.83!4f9.908!5f0.75",
+      streetview: true
+    },
+    unresolveable: {
+      test: "https://www.google.com/maps/place/Den+Abattoir/@51.2285173,4.4336702,17z/data=!4m7!1m4!3m3!1s0x47c3f7a5ac48e237:0x63d716018f584a33!2zUGnDqXRyYWlu!3b1!3m1!1s0x0000000000000000:0xfbfac0c41c32471a",
+      redirect: ["302 Found", "https://www.google.com/maps/place/Den+Abattoir/@51.2285173,4.4336702,17z/data=!4m7!1m4!3m3!1s0x47c3f7a5ac48e237:0x63d716018f584a33!2zUGnDqXRyYWlu!3b1!3m1!1s0x0000000000000000:0xfbfac0c41c32471a?dg=dbrw&newdg=1"],
+      expect: "https://maps.google.com/maps?ll=51.2285173,4.4336702&z=17&output=embed&dg=ntvb&q=Den+Abattoir&cid=18157036796216755994"
+    },
+    satellite: {
+      test: "https://www.google.de/maps/@40.6894264,-74.0449146,758m/data=!3m1!1e3",
+      redirect: ["302 Found", "https://www.google.de/maps/@40.6894264,-74.0449146,758m/data=!3m1!1e3?dg=dbrw&newdg=1"],
+      expect: "https://maps.google.com/maps?ll=40.6894264,-74.0449146&z=16&output=embed&dg=ntvb"
+    }
+  }
+
+  # Register URL redirects
+  before(:all) do
+    URLS.values.each do |t|
+      status, location = *t[:redirect]
+      location = URLS[location][:test] if location.is_a? Symbol
+      FakeWeb.register_uri(:head, t[:test], response: "HTTP/1.1 #{status}\nLocation: #{location}\n\n")
+    end
+  end
+
+  # Prevent sleep from wasting our time when we test with strange redirects
+  subject { described_class.send(:allocate).tap {|obj|
+    obj.stub(:sleep)
+    obj.send(:initialize, link)
+  }}
+
+  let(:data) { Onebox::Helpers.symbolize_keys(subject.send(:data)) }
+  let(:link) {|example| URLS[example.metadata[:urltype] || :short][:test] }
+
+  include_context "an engine", urltype: :short
+
+  URLS.each do |kind, t|
+    it "processes #{kind.to_s} url correctly", urltype: kind do
+      expect(subject.url).to eq t[:expect]
+      expect(subject.streetview?).to t[:streetview] ? be_truthy : be_falsey
+      expect(subject.to_html).to include("<iframe")
+      expect(subject.placeholder_html).to include("<img")
+    end
+  end
+
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: onebox
 version: !ruby/object:Gem::Version
-  version: 1.5.16
+  version: 1.5.17
 platform: ruby
 authors:
 - Joanna Zeta
@@ -10,244 +10,244 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-04-06 00:00:00.000000000 Z
+date: 2015-05-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: multi_json
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '1.7'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '1.7'
 - !ruby/object:Gem::Dependency
   name: mustache
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '0.99'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '0.99'
 - !ruby/object:Gem::Dependency
   name: nokogiri
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: 1.6.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: 1.6.1
 - !ruby/object:Gem::Dependency
   name: moneta
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '0.7'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '0.7'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '1.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '1.3'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '10.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '10.0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '2.14'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '2.14'
 - !ruby/object:Gem::Dependency
   name: yard
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '0.8'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '0.8'
 - !ruby/object:Gem::Dependency
   name: fakeweb
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '1.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '1.3'
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '0.9'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '0.9'
 - !ruby/object:Gem::Dependency
   name: mocha
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '0.14'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '0.14'
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '0.11'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '0.11'
 - !ruby/object:Gem::Dependency
   name: twitter
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '4.8'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '4.8'
 - !ruby/object:Gem::Dependency
   name: guard-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: 4.2.8
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: 4.2.8
 - !ruby/object:Gem::Dependency
   name: sinatra
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '1.4'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '1.4'
 - !ruby/object:Gem::Dependency
   name: sinatra-contrib
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '1.4'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '1.4'
 - !ruby/object:Gem::Dependency
   name: haml
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '4.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '4.0'
 - !ruby/object:Gem::Dependency
@@ -273,11 +273,11 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- ".gitignore"
-- ".rspec"
-- ".rubocop.yml"
-- ".ruby-gemset"
-- ".travis.yml"
+- .gitignore
+- .rspec
+- .rubocop.yml
+- .ruby-gemset
+- .travis.yml
 - Gemfile
 - Guardfile
 - LICENSE.txt
@@ -287,7 +287,6 @@ files:
 - lib/onebox/engine.rb
 - lib/onebox/engine/amazon_onebox.rb
 - lib/onebox/engine/audio_onebox.rb
-- lib/onebox/engine/classic_google_maps_onebox.rb
 - lib/onebox/engine/douban_onebox.rb
 - lib/onebox/engine/github_blob_onebox.rb
 - lib/onebox/engine/github_commit_onebox.rb
@@ -296,6 +295,7 @@ files:
 - lib/onebox/engine/github_pullrequest_onebox.rb
 - lib/onebox/engine/google_calendar_onebox.rb
 - lib/onebox/engine/google_docs_onebox.rb
+- lib/onebox/engine/google_maps_onebox.rb
 - lib/onebox/engine/google_play_app_onebox.rb
 - lib/onebox/engine/html.rb
 - lib/onebox/engine/image_onebox.rb
@@ -343,13 +343,13 @@ files:
 - spec/fixtures/youtube.response
 - spec/lib/onebox/engine/amazon_onebox_spec.rb
 - spec/lib/onebox/engine/audio_onebox_spec.rb
-- spec/lib/onebox/engine/classic_google_maps_onebox_spec.rb
 - spec/lib/onebox/engine/douban_onebox_spec.rb
 - spec/lib/onebox/engine/github_blob_onebox_spec.rb
 - spec/lib/onebox/engine/github_commit_onebox_spec.rb
 - spec/lib/onebox/engine/github_gist_onebox_spec.rb
 - spec/lib/onebox/engine/github_pullrequest_onebox_spec.rb
 - spec/lib/onebox/engine/google_docs_onebox_spec.rb
+- spec/lib/onebox/engine/google_maps_onebox_spec.rb
 - spec/lib/onebox/engine/google_play_app_onebox_spec.rb
 - spec/lib/onebox/engine/html_spec.rb
 - spec/lib/onebox/engine/image_onebox_spec.rb
@@ -399,17 +399,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.0.14
 signing_key: 
 specification_version: 4
 summary: A gem for turning URLs into previews.
@@ -437,13 +437,13 @@ test_files:
 - spec/fixtures/youtube.response
 - spec/lib/onebox/engine/amazon_onebox_spec.rb
 - spec/lib/onebox/engine/audio_onebox_spec.rb
-- spec/lib/onebox/engine/classic_google_maps_onebox_spec.rb
 - spec/lib/onebox/engine/douban_onebox_spec.rb
 - spec/lib/onebox/engine/github_blob_onebox_spec.rb
 - spec/lib/onebox/engine/github_commit_onebox_spec.rb
 - spec/lib/onebox/engine/github_gist_onebox_spec.rb
 - spec/lib/onebox/engine/github_pullrequest_onebox_spec.rb
 - spec/lib/onebox/engine/google_docs_onebox_spec.rb
+- spec/lib/onebox/engine/google_maps_onebox_spec.rb
 - spec/lib/onebox/engine/google_play_app_onebox_spec.rb
 - spec/lib/onebox/engine/html_spec.rb
 - spec/lib/onebox/engine/image_onebox_spec.rb
@@ -463,3 +463,4 @@ test_files:
 - spec/lib/onebox_spec.rb
 - spec/spec_helper.rb
 - spec/support/html_spec_helper.rb
+has_rdoc: 

data/lib/onebox/engine/classic_google_maps_onebox.rb

@@ -1,62 +0,0 @@
-module Onebox
-  module Engine
-    class ClassicGoogleMapsOnebox
-      include Engine
-
-      matches_regexp /^(https?:)?\/\/((maps|www)\.google\.[\w.]{2,}|goo\.gl)\/maps?.+$/
-
-      def initialize(link, cache = nil, timeout = nil)
-        super(link, cache, timeout)
-        resolve_url!
-      end
-
-      def to_html
-        "<div style=\"background:transparent;position:relative;width:690px;height:400px;top:400px;margin-top:-400px;\" onClick=\"style.pointerEvents='none'\"></div> <iframe src=\"#{link}\" width=\"690px\" height=\"400px\" frameborder=\"0\" style=\"border:0\"></iframe>"
-      end
-
-      def placeholder_html
-        return to_html unless @placeholder
-        "<img src=\"http://maps.googleapis.com/maps/api/staticmap?maptype=roadmap&size=690x400&sensor=false&#{@placeholder}\" width=\"690\" height=\"400\"/>"
-      end
-
-      private
-
-      def resolve_url!
-        @url = follow_redirect(@url) if @url.include?("//goo.gl/maps")
-        if m = @url.match(/@([-.\d]+,[-.\d]+),(\d+)z/)
-          @placeholder = "center=#{m[1]}&zoom=#{m[2]}"
-        end
-
-        @url = follow_redirect(@url) if @url.include?("www.google")
-        query = Hash[*URI(@url).query.split("&").map{|a|a.split("=")}.flatten]
-        @url += "&ll=#{query["sll"]}" if !query["ll"]
-        @url += "&spn=#{query["sspn"]}" if !query["spn"]
-        if !@placeholder
-          angle = (query["spn"] || query["sspn"]).split(",").first.to_f
-          zoom = (Math.log(690.0 * 360.0 / angle / 256.0) / Math.log(2)).round
-          @placeholder = "center=#{query["ll"] || query["sll"]}&zoom=#{zoom}"
-        end
-
-        @url = (@url =~ /output=classic/) ?
-          @url.sub('output=classic', 'output=embed') :
-          @url + '&output=embed'
-      end
-
-      def data
-        {link: url, title: url}
-      end
-
-      def follow_redirect(link)
-        uri = URI(link)
-        http = Net::HTTP.start(uri.host, uri.port, use_ssl: uri.scheme == 'https')
-        http.open_timeout = timeout
-        http.read_timeout = timeout
-        response = http.head(uri.path)
-        response["Location"] if %(301 302).include?(response.code)
-      rescue
-        link
-      end
-
-    end
-  end
-end

data/spec/lib/onebox/engine/classic_google_maps_onebox_spec.rb

@@ -1,52 +0,0 @@
-require "spec_helper"
-
-describe Onebox::Engine::ClassicGoogleMapsOnebox do
-
-  URLS = {
-    short: "https://goo.gl/maps/rEG3D",
-    long: "https://www.google.de/maps/place/Statue+of+Liberty+National+Monument/@40.689249,-74.0445,17z/data=!3m1!4b1!4m2!3m1!1s0x89c25090129c363d:0x40c6a5770d25022b",
-    canonical: "https://maps.google.de/maps?sll=40.689249,-74.0445&sspn=0.0062479,0.0109864&cid=4667599994556318251&q=Statue+of+Liberty+National+Monument&output=classic&dg=ntvb",
-    embed: "https://maps.google.de/maps?sll=40.689249,-74.0445&sspn=0.0062479,0.0109864&cid=4667599994556318251&q=Statue+of+Liberty+National+Monument&output=embed&dg=ntvb&ll=40.689249,-74.0445&spn=0.0062479,0.0109864"
-  }
-
-  before(:all) do
-    FakeWeb.register_uri(:head, URLS[:short], response: "HTTP/1.1 302 Found\nLocation: #{URLS[:long]}\n\n")
-    FakeWeb.register_uri(:head, URLS[:long], response: "HTTP/1.1 301 Moved Permanently\nLocation: #{URLS[:canonical]}\n\n")
-  end
-
-  subject { described_class.new(link) }
-
-  it_behaves_like "an engine" do
-    let(:link) { URLS[:canonical] }
-    let(:data) { Onebox::Helpers.symbolize_keys(subject.send(:data)) }
-  end
-
-  shared_examples "embeddable" do |kind|
-    let(:link) { URLS[kind] }
-
-    it "resolves url correctly" do
-      subject.url.should == URLS[:embed]
-    end
-
-    it "produces an iframe" do
-      subject.to_html.should include("iframe", "output=embed")
-    end
-
-    it "produces a placeholder image" do
-      subject.placeholder_html.should include("img")
-    end
-  end
-
-  context "canonical url" do
-    it_should_behave_like "embeddable", :canonical
-  end
-
-  context "long url" do
-    it_should_behave_like "embeddable", :long
-  end
-
-  context "short url" do
-    it_should_behave_like "embeddable", :short
-  end
-
-end