onebox 1.3.4 → 1.3.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 2e6ec4c0001a218e8b9590098e44d4da52954a40
-  data.tar.gz: 127f485029751a7c358377e2f43724292076ddf1
+  metadata.gz: a2fd6f8d2e4bae8fb9b2cdc34a5926bfb7a0d933
+  data.tar.gz: d28f32d3c1007902967c3a29d499ffb8ae94a5bc
 SHA512:
-  metadata.gz: 333c536b339750392727c685c71d38c7eac70fde2af1f1dcef2b0a31c761d7f461170fdcd38e4658f32c6c7f9351e93ad0dbde3807cebfe1a30dc0102eac8eab
-  data.tar.gz: 4d7ec47617b283561e80f6b57499e75d6be6a50fe7e50888de6694458c15cca51cfc097aa001e177f32c936ddd89553f55e2218e9d59263106ec5835a0766c20
+  metadata.gz: f6cbc44f26e2eb709937db4233e033de53326e80ebafbfc04e86eaadb218f93f8f6bfe3fbe0d86183f102a817fe43ff6544ed8a52fbe063a9a445d82988aa977
+  data.tar.gz: 9f8bcdcdea07104b3f1966cc99c5fc1a24eaef4af3744880595f7fdbdd5811ff9ce848caa9d23c515eba2090ef9c00ea87b13561e0571eef55cd308d8c1bbf0f

data/README.md

@@ -171,8 +171,8 @@ Installing
 
 Add this line to your application's Gemfile:
 
-    gem "onebox". "~> 1.2"
-
+    gem "onebox", "~> 1.2"
+    
 And then execute:
 
     $ bundle

data/lib/onebox/preview.rb

@@ -11,14 +11,14 @@ module Onebox
 
     def to_s
       return "" unless engine
-      engine.to_html || ""
+      process_html(engine_html)
     rescue *Onebox::Preview.web_exceptions
       ""
     end
 
     def placeholder_html
       return "" unless engine
-      engine.placeholder_html || ""
+      process_html(engine.placeholder_html)
     rescue *Onebox::Preview.web_exceptions
       ""
     end
@@ -33,6 +33,35 @@ module Onebox
 
     private
 
+    def engine_html
+      engine.to_html
+    end
+
+    def process_html(html)
+      return "" unless html
+
+      if @options[:max_width]
+        doc = Nokogiri::HTML::fragment(html)
+        if doc
+          doc.css('[width]').each do |e|
+            width = e['width'].to_i
+
+            if width > @options[:max_width]
+              height = e['height'].to_i
+              if (height > 0)
+                ratio = (height.to_f / width.to_f)
+                e['height'] = (@options[:max_width] * ratio).floor
+              end
+              e['width'] = @options[:max_width]
+            end
+          end
+          return doc.to_html
+        end
+      end
+
+      html
+    end
+
     def engine
       return nil unless @engine_class
       @engine ||= @engine_class.new(@url, cache)

data/lib/onebox/version.rb

@@ -1,3 +1,3 @@
 module Onebox
-  VERSION = "1.3.4"
+  VERSION = "1.3.5"
 end

data/spec/lib/onebox/preview_spec.rb

@@ -12,7 +12,8 @@ describe Onebox::Preview do
     FakeWeb.register_uri(:get, "http://www.amazon.com/error-connecting", exception: Errno::ECONNREFUSED)
   end
 
-  let(:preview) { described_class.new("http://www.amazon.com/product") }
+  let(:preview_url) { "http://www.amazon.com/product" }
+  let(:preview) { described_class.new(preview_url) }
 
   describe "#to_s" do
     it "returns some html if given a valid url" do
@@ -45,6 +46,37 @@ describe Onebox::Preview do
     end
   end
 
+  describe "max_width" do
+    let(:iframe_html) { '<iframe src="//player.vimeo.com/video/96017582" width="1280" height="720" frameborder="0" title="GO BIG OR GO HOME" webkitallowfullscreen mozallowfullscreen allowfullscreen></iframe>' }
+
+    it "doesn't change dimensions without an option" do
+      iframe = described_class.new(preview_url)
+      iframe.expects(:engine_html).returns(iframe_html)
+
+      result = iframe.to_s
+      expect(result).to include("width=\"1280\"")
+      expect(result).to include("height=\"720\"")
+    end
+
+    it "doesn't change dimensions if it is smaller than `max_width`" do
+      iframe = described_class.new(preview_url, max_width: 2000)
+      iframe.expects(:engine_html).returns(iframe_html)
+
+      result = iframe.to_s
+      expect(result).to include("width=\"1280\"")
+      expect(result).to include("height=\"720\"")
+    end
+
+    it "changes dimensions if larger than `max_width`" do
+      iframe = described_class.new(preview_url, max_width: 900)
+      iframe.expects(:engine_html).returns(iframe_html)
+
+      result = iframe.to_s
+      expect(result).to include("width=\"900\"")
+      expect(result).to include("height=\"506\"")
+    end
+  end
+
   describe "#engine" do
     it "returns an engine" do
       expect(preview.send(:engine)).to be_an(Onebox::Engine)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: onebox
 version: !ruby/object:Gem::Version
-  version: 1.3.4
+  version: 1.3.5
 platform: ruby
 authors:
 - Joanna Zeta
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-05-30 00:00:00.000000000 Z
+date: 2014-06-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: multi_json
@@ -400,3 +400,4 @@ test_files:
 - spec/lib/onebox_spec.rb
 - spec/spec_helper.rb
 - spec/support/html_spec_helper.rb
+has_rdoc: