onebox 1.3.0 → 1.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 49ef78f13c0ef0d87599f4f69a248165e5b308e2
-  data.tar.gz: 49911be28d9d203063ffdcc902b4829cc2d5eb3e
+  metadata.gz: 9fa2ea983edc182dc92968e18b0c802e4c68f5a9
+  data.tar.gz: eb69673c515f8099e8e3da8177df5458f0aab925
 SHA512:
-  metadata.gz: e32f0f7f5fa0c3ee7a76a75d271a53bd384be729639263a4991a4ecfeed59da8c2728204f77ada350e674dbde58eaa3d65a5c48f8924df2e4d9c4a9d985fde63
-  data.tar.gz: 21efd6021bacc67e17b69c77f8dd96236feab37b7bdec240883c6b764a0c8bc9352d0f11c2024447db0a2a386ece191372dbff3032de82e8d213e811d31b49a5
+  metadata.gz: 92db3996ec6a7fd71d0cca3fc3da1750f643a8d9b1cd1a61a415deceffe92c693d3f62c2a855966502320e12a405cc3ba4a33d4a7e33569636db6d3de37e1f1c
+  data.tar.gz: fefd85244ebab551ebc2fb66845d5e94a90079796fdd3df8986ae854ab8dab1012c33d8b882c40fa745ec164cd7b056c116b0d05ed668b37b524c5b7580b2e59

data/README.md

@@ -5,7 +5,6 @@ onebox
   - [![Code Climate](https://codeclimate.com/github/dysania/onebox.png)](https://codeclimate.com/github/dysania/onebox)
   - [![Build Status](https://travis-ci.org/dysania/onebox.png)](https://travis-ci.org/dysania/onebox)
   - [![Dependency Status](https://gemnasium.com/dysania/onebox.png)](https://gemnasium.com/dysania/onebox)
-  - [![Coverage Status](https://coveralls.io/repos/dysania/onebox/badge.png)](https://coveralls.io/r/dysania/onebox)
 
 
 Onebox is a library for turning media URLs into simple HTML previews of the resource.

data/lib/onebox/engine/audio_onebox.rb

@@ -1,9 +1,9 @@
 module Onebox
   module Engine
-    class VideoOnebox
+    class AudioOnebox
       include Engine
 
-      matches_regexp /^https?:\/\/.*\.mp3$/
+      matches_regexp /^(https?:)?\/\/.*\.(mp3|ogg|wav)(\?.*)?$/
 
       def to_html
         "<audio controls><source src='#{@url}'><a href='#{@url}'>#{@url}</a></audio>"
@@ -11,5 +11,3 @@ module Onebox
     end
   end
 end
-
-

data/lib/onebox/engine/github_gist_onebox.rb

@@ -17,7 +17,7 @@ module Onebox
       end
 
       def to_html
-        "<script src=\"http://gist.github.com/#{match[:sha]}.js\"></script>"
+        "<script src=\"//gist.github.com/#{match[:sha]}.js\"></script>"
       end
 
       private

data/lib/onebox/engine/image_onebox.rb

@@ -3,7 +3,7 @@ module Onebox
     class ImageOnebox
       include Engine
 
-      matches_regexp /^(https?:)?\/\/.+\.(png|jpg|jpeg|gif|bmp|tif|tiff)$/i
+      matches_regexp /^(https?:)?\/\/.+\.(png|jpg|jpeg|gif|bmp|tif|tiff)(\?.*)?$/i
 
       def to_html
         "<a href='#{@url}' target='_blank'><img src='#{@url}'></a>"

data/lib/onebox/engine/video_onebox.rb

@@ -3,7 +3,7 @@ module Onebox
     class VideoOnebox
       include Engine
 
-      matches_regexp /^https?:\/\/.*\.(mov|mp4)$/
+      matches_regexp /^(https?:)?\/\/.*\.(mov|mp4|webm|ogv)(\?.*)?$/
 
       def to_html
         "<video width='100%' height='100%' controls><source src='#{@url}'><a href='#{@url}'>#{@url}</a></video>"
@@ -11,4 +11,3 @@ module Onebox
     end
   end
 end
-

data/lib/onebox/engine/whitelisted_generic_onebox.rb

@@ -47,6 +47,7 @@ module Onebox
           etsy.com
           findery.com
           flickr.com
+          folksy.com
           forbes.com
           foxnews.com
           funnyordie.com
@@ -66,6 +67,7 @@ module Onebox
           kickstarter.com
           kinomap.com
           liveleak.com
+          lessonplanet.com
           mashable.com
           mlb.com
           myspace.com

data/lib/onebox/version.rb

@@ -1,3 +1,3 @@
 module Onebox
-  VERSION = "1.3.0"
+  VERSION = "1.3.1"
 end

data/onebox.gemspec

@@ -27,7 +27,6 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "bundler", "~> 1.3"
   spec.add_development_dependency "rake", "~> 10.0"
   spec.add_development_dependency "rspec", "~> 2.14"
-  spec.add_development_dependency "coveralls", "~> 0.6"
   spec.add_development_dependency "yard", "~> 0.8"
   spec.add_development_dependency "fakeweb", "~> 1.3"
   spec.add_development_dependency "pry", "~> 0.9"

data/spec/lib/onebox/engine/audio_onebox_spec.rb

@@ -0,0 +1,27 @@
+require "spec_helper"
+
+describe Onebox::Engine::AudioOnebox do
+  it "supports ogg" do
+    Onebox.preview('http://upload.wikimedia.org/wikipedia/commons/c/c8/Example.ogg').to_s.should match(/<audio/)
+  end
+
+  it "supports mp3" do
+    Onebox.preview('http://kolber.github.io/audiojs/demos/mp3/juicy.mp3').to_s.should match(/<audio/)
+  end
+
+  it "supports wav" do
+    Onebox.preview('http://download.wavetlan.com/SVV/Media/HTTP/sample14.wav').to_s.should match(/<audio/)
+  end
+
+  it "supports URLs with query parameters" do
+    Onebox.preview('https://upload.wikimedia.org/wikipedia/commons/c/c8/Example.ogg?foo=bar').to_s.should match(/<audio/)
+  end
+
+  it "supports protocol relative URLs" do
+    Onebox.preview('//upload.wikimedia.org/wikipedia/commons/c/c8/Example.ogg').to_s.should match(/<audio/)
+  end
+  
+  it "includes a fallback direct link to the audio" do
+    Onebox.preview('http://kolber.github.io/audiojs/demos/mp3/juicy.mp3').to_s.should match(/<a.*mp3/)
+  end
+end

data/spec/lib/onebox/engine/image_onebox_spec.rb

@@ -0,0 +1,39 @@
+require "spec_helper"
+
+describe Onebox::Engine::ImageOnebox do
+  it "supports png" do
+    Onebox.preview('http://www.discourse.org/images/logo.png').to_s.should match(/<img/)
+  end
+
+  it "supports jpg" do
+    Onebox.preview('http://upload.wikimedia.org/wikipedia/en/a/a9/Example.jpg').to_s.should match(/<img/)
+  end
+
+  it "supports jpeg" do
+    Onebox.preview('http://upload.wikimedia.org/wikipedia/en/b/bb/Poster.jpeg').to_s.should match(/<img/)
+  end
+
+  it "supports gif" do
+    Onebox.preview('http://upload.wikimedia.org/wikipedia/commons/5/55/Tesseract.gif').to_s.should match(/<img/)
+  end
+
+  it "supports tif" do
+    Onebox.preview('http://www.fileformat.info/format/tiff/sample/1f37bbd5603048178487ec88b1a6425b/MARBLES.tif').to_s.should match(/<img/)
+  end
+
+  it "supports bmp" do
+    Onebox.preview('http://www.fileformat.info/format/bmp/sample/d4202a5fc22a48c388d9e1c636792cc6/LAND.BMP').to_s.should match(/<img/)
+  end
+
+  it "supports image URLs with query parameters" do
+    Onebox.preview('https://www.google.com/logos/doodles/2014/percy-julians-115th-birthday-born-1899-5688801926053888-hp.jpg?foo=bar').to_s.should match(/<img/)
+  end
+
+  it "supports protocol relative image URLs" do
+    Onebox.preview('//www.google.com/logos/doodles/2014/percy-julians-115th-birthday-born-1899-5688801926053888-hp.jpg').to_s.should match(/<img/)
+  end
+
+  it "includes a direct link to the image" do
+    Onebox.preview('http://www.discourse.org/images/logo.png').to_s.should match(/<a.*png/)
+  end
+end

data/spec/lib/onebox/engine/video_onebox_spec.rb

@@ -0,0 +1,31 @@
+require "spec_helper"
+
+describe Onebox::Engine::VideoOnebox do
+  it "supports ogv" do
+    Onebox.preview('http://upload.wikimedia.org/wikipedia/commons/3/37/STS-134_launch_2.ogv').to_s.should match(/<video/)
+  end
+
+  it "supports mp4" do
+    Onebox.preview('http://download.wavetlan.com/svv/dev/test.mp4').to_s.should match(/<video/)
+  end
+
+  it "supports mov" do
+    Onebox.preview('http://download.wavetlan.com/SVV/Media/HTTP/BlackBerry.mov').to_s.should match(/<video/)
+  end
+
+  it "supports webm" do
+    Onebox.preview('http://video.webmfiles.org/big-buck-bunny_trailer.webm').to_s.should match(/<video/)
+  end
+
+  it "supports URLs with query parameters" do
+    Onebox.preview('http://video.webmfiles.org/big-buck-bunny_trailer.webm?foo=bar').to_s.should match(/<video/)
+  end
+
+  it "supports protocol relative URLs" do
+    Onebox.preview('//video.webmfiles.org/big-buck-bunny_trailer.webm').to_s.should match(/<video/)
+  end
+
+  it "includes a fallback direct link to the video" do
+    Onebox.preview('http://download.wavetlan.com/svv/dev/test.mp4').to_s.should match(/<a.*mp4/)
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: onebox
 version: !ruby/object:Gem::Version
-  version: 1.3.0
+  version: 1.3.1
 platform: ruby
 authors:
 - Joanna Zeta
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-04-09 00:00:00.000000000 Z
+date: 2014-04-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: multi_json
@@ -124,20 +124,6 @@ dependencies:
     - - ~>
       - !ruby/object:Gem::Version
         version: '2.14'
-- !ruby/object:Gem::Dependency
-  name: coveralls
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: '0.6'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: '0.6'
 - !ruby/object:Gem::Dependency
   name: yard
   requirement: !ruby/object:Gem::Requirement
@@ -314,6 +300,7 @@ files:
 - spec/fixtures/youtube-json.response
 - spec/fixtures/youtube.response
 - spec/lib/onebox/engine/amazon_onebox_spec.rb
+- spec/lib/onebox/engine/audio_onebox_spec.rb
 - spec/lib/onebox/engine/classic_google_maps_onebox_spec.rb
 - spec/lib/onebox/engine/github_blob_onebox_spec.rb
 - spec/lib/onebox/engine/github_commit_onebox_spec.rb
@@ -321,10 +308,12 @@ files:
 - spec/lib/onebox/engine/github_pullrequest_onebox_spec.rb
 - spec/lib/onebox/engine/google_play_app_onebox_spec.rb
 - spec/lib/onebox/engine/html_spec.rb
+- spec/lib/onebox/engine/image_onebox_spec.rb
 - spec/lib/onebox/engine/json_spec.rb
 - spec/lib/onebox/engine/pubmed_onebox_spec.rb
 - spec/lib/onebox/engine/stack_exchange_onebox_spec.rb
 - spec/lib/onebox/engine/twitter_status_onebox_spec.rb
+- spec/lib/onebox/engine/video_onebox_spec.rb
 - spec/lib/onebox/engine/whitelisted_generic_onebox_spec.rb
 - spec/lib/onebox/engine/wikipedia_onebox_spec.rb
 - spec/lib/onebox/engine/youtube_onebox_spec.rb
@@ -387,6 +376,7 @@ test_files:
 - spec/fixtures/youtube-json.response
 - spec/fixtures/youtube.response
 - spec/lib/onebox/engine/amazon_onebox_spec.rb
+- spec/lib/onebox/engine/audio_onebox_spec.rb
 - spec/lib/onebox/engine/classic_google_maps_onebox_spec.rb
 - spec/lib/onebox/engine/github_blob_onebox_spec.rb
 - spec/lib/onebox/engine/github_commit_onebox_spec.rb
@@ -394,10 +384,12 @@ test_files:
 - spec/lib/onebox/engine/github_pullrequest_onebox_spec.rb
 - spec/lib/onebox/engine/google_play_app_onebox_spec.rb
 - spec/lib/onebox/engine/html_spec.rb
+- spec/lib/onebox/engine/image_onebox_spec.rb
 - spec/lib/onebox/engine/json_spec.rb
 - spec/lib/onebox/engine/pubmed_onebox_spec.rb
 - spec/lib/onebox/engine/stack_exchange_onebox_spec.rb
 - spec/lib/onebox/engine/twitter_status_onebox_spec.rb
+- spec/lib/onebox/engine/video_onebox_spec.rb
 - spec/lib/onebox/engine/whitelisted_generic_onebox_spec.rb
 - spec/lib/onebox/engine/wikipedia_onebox_spec.rb
 - spec/lib/onebox/engine/youtube_onebox_spec.rb