onebox 1.2.3 → 1.2.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d9dbbcef9ad30d0ab30cf3b5392f01b781dca291
-  data.tar.gz: 7cd665b5a0d344b702fe7df32b6c691010539028
+  metadata.gz: 4a1c79c861fa854b2cb6f8e846858c6d3960a7d7
+  data.tar.gz: 711cefc867ea1db4cc654f345914e859a1534a1e
 SHA512:
-  metadata.gz: 8bd2e6ed6565c4df9114a62e4628affb6b6227a40bfbd5e483f9ef0d73f8fb196d5dca3034ba46bd30173099d9a5647522dd9e307cf0918057fd1a137da7b892
-  data.tar.gz: a80fa2616b82977524212e8d084849910558e9910f385d8b943c5805f4791e06056bc21974bb9de40660a84fecc4c43703ddc1bc16f69c3ffa9255a58ec20ce2
+  metadata.gz: 63ca35b58d58aacef5d7074ae4a205aedcdee285038d93072d92fda68caea97030de36810fb366929373a6afaefe1ee0337c7b0ac4a50325effd99fa7cef57cd
+  data.tar.gz: 0e2e452056785863e67cff50581d544914022b450a63f675e141fafb3eb1e0b435fabe2ac09b78807f3729829fc3d58d6ed8979b298db0c01f87ca560eb5cc82

data/lib/onebox/engine/whitelisted_generic_onebox.rb

@@ -120,13 +120,17 @@ module Onebox
       end
 
       def self.default_rewrites
-        %w()
+        %w(slideshare.net)
       end
 
       def self.host_matches(uri, list)
         !!list.find {|h| %r((^|\.)#{Regexp.escape(h)}$).match(uri.host) }
       end
 
+      def self.probable_discourse(uri)
+        !!(uri.path =~ /\/t\/[^\/]+\/\d+(\/\d+)?(\?.*)?$/)
+      end
+
       def self.probable_wordpress(uri)
         !!(uri.path =~ /\d{4}\/\d{2}\/\d{2}/)
       end
@@ -134,7 +138,8 @@ module Onebox
       def self.===(other)
         if other.kind_of?(URI)
           return WhitelistedGenericOnebox.host_matches(other, WhitelistedGenericOnebox.whitelist) ||
-                 WhitelistedGenericOnebox.probable_wordpress(other)
+                 WhitelistedGenericOnebox.probable_wordpress(other) ||
+                 WhitelistedGenericOnebox.probable_discourse(other)
         else
           super
         end
@@ -145,6 +150,10 @@ module Onebox
         data[:type] =~ /photo/ || data[:type] =~ /image/
       end
 
+      def article_type?
+        data[:type] == "article"
+      end
+
       def rewrite_agnostic(html)
         return html unless html
         uri = URI(@url)
@@ -156,6 +165,7 @@ module Onebox
 
       def generic_html
         return data[:html] if data[:html] && data[:html] =~ /iframe/
+        return layout.to_html if article_type?
         return html_for_video(data[:video]) if data[:video]
         return image_html if photo_type?
         return nil unless data[:title]
@@ -168,6 +178,7 @@ module Onebox
 
       def placeholder_html
         result = nil
+        return to_html if article_type?
         result = image_html if (data[:html] && data[:html] =~ /iframe/) || data[:video] || photo_type?
         result || to_html
       end

data/lib/onebox/engine/wikipedia_onebox.rb

@@ -22,6 +22,7 @@ module Onebox
         unless paras.empty?
           cnt = 0
           while text.length < Onebox::LayoutSupport.max_text && cnt <= 3
+            break if cnt >= paras.size
             text << " " unless cnt == 0
             paragraph = paras[cnt].inner_text[0..Onebox::LayoutSupport.max_text]
             paragraph.gsub!(/\[\d+\]/mi, "")
@@ -36,7 +37,7 @@ module Onebox
           title: raw.css("html body h1").inner_text,
           description: text
         }
-        img = raw.css(".infobox .image img")
+        img = raw.css(".image img")
         if img && img.first
           result[:image] = img.first["src"]
         end

data/lib/onebox/version.rb

@@ -1,3 +1,3 @@
 module Onebox
-  VERSION = "1.2.3"
+  VERSION = "1.2.4"
 end

data/templates/wikipedia.mustache

@@ -1,4 +1,4 @@
-<img src="{{image}}" class="thumbnail"/>
+{{#image}}<img src="{{image}}" class="thumbnail"/>{{/image}}
 
 <h3><a href='{{{link}}}'>{{title}}</a></h3>
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: onebox
 version: !ruby/object:Gem::Version
-  version: 1.2.3
+  version: 1.2.4
 platform: ruby
 authors:
 - Joanna Zeta
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-02-24 00:00:00.000000000 Z
+date: 2014-02-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: multi_json