onceover 3.15.2 → 3.16.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 691d35bc2e55ba18c7a4f5d8e7c7d40d84b427c900834c58017980dd27cd8854
-  data.tar.gz: a3bc7455a678cffbe2490821ac89c0e5bec19b7e5ee7e8595da495d41b1bca5a
+  metadata.gz: 57310f1e8ec36d6e3351a76138baf7c0e548cf76a78de52accf4f0a19af89bb8
+  data.tar.gz: 69038c881071e8a0f3db773363b06e2f0fd99b9b62f7eb8b9311eed547a45bd7
 SHA512:
-  metadata.gz: 7509c045f9364aba59129e9411ddc252e1f657e0eb793d888c393935fd7413c91681b6f6445b20fc81158b67b501667d685ee219431c07cdc1cf9f50e8eb37ed
-  data.tar.gz: 67f4bd8435ffcf40c347839b49b01b6fe52c9915f387db561bc33fa5bc65b92ca97b76fe2d5cb9ba25419771a312c5d4eca4b4f0be8e743d395f5b2df008ff41
+  metadata.gz: c9565bd5f7002ff26528dd080cb1c5de2ea7a7c2579a80036bde8764a7be92351e8006ccf6e97e44e97e57936d48628bc67d4e5e2515b49d1733f062bccfc2c0
+  data.tar.gz: 4042c79024be1863c725e97a88e7812320a3aa5a010e2cea47cc687e59397c1cdac384722c9f4832d79c101fb3b0fff4f0a64e4193ada4a0cfaf402ed959bc81

data/.gitignore

@@ -8,6 +8,7 @@ Gemfile.local
 /.bin
 /.ruby-version
 tmp
+vendor
 
 # Vim
 /.projections.json

data/.rubocop.yml

@@ -1,16 +1,16 @@
 AllCops:
   Include:
-    - 'lib/**/*.rb'
-    - 'ext/**/*.rb'
+    - "lib/**/*.rb"
+    - "ext/**/*.rb"
   Exclude:
-    - '**/*.erb'
-    - 'acceptance/**/*'
-    - 'autotest/**/*'
-    - 'spec/**/*'
-    - 'tasks/**/*'
-    - 'vendor/**/*'
-
-Lint/ConditionPosition:
+    - "**/*.erb"
+    - "acceptance/**/*"
+    - "autotest/**/*"
+    - "spec/**/*"
+    - "tasks/**/*"
+    - "vendor/**/*"
+
+Layout/ConditionPosition:
   Enabled: true
 
 Lint/ElseLayout:
@@ -27,11 +27,7 @@ Lint/EnsureReturn:
   Enabled: false
 
 # MAYBE useful - errors when rescue {} happens.
-Lint/HandleExceptions:
-  Enabled: false
-
-# MAYBE useful - catches while 1
-Lint/LiteralInCondition:
+Lint/SuppressedException:
   Enabled: false
 
 Lint/ShadowingOuterLocalVariable:
@@ -41,7 +37,6 @@ Lint/ShadowingOuterLocalVariable:
 Lint/LiteralInInterpolation:
   Enabled: true
 
-
 # DISABLED really useless. Detects return as last statement.
 Style/RedundantReturn:
   Enabled: false
@@ -97,15 +92,15 @@ Security/Eval:
   Enabled: false
 
 # DISABLED
-Lint/BlockAlignment:
+Layout/BlockAlignment:
   Enabled: false
 
 # DISABLED
-Lint/DefEndAlignment:
+Layout/DefEndAlignment:
   Enabled: false
 
 # DISABLED
-Lint/EndAlignment:
+Layout/EndAlignment:
   Enabled: false
 
 # DISABLED
@@ -123,7 +118,7 @@ Lint/ParenthesesAsGroupedExpression:
 Lint/RescueException:
   Enabled: false
 
-Lint/StringConversionInInterpolation:
+Lint/RedundantStringCoercion:
   Enabled: false
 
 Lint/UnusedBlockArgument:
@@ -147,22 +142,22 @@ Lint/Void:
 Layout/AccessModifierIndentation:
   Enabled: false
 
-Style/AccessorMethodName:
+Naming/AccessorMethodName:
   Enabled: false
 
 Style/Alias:
   Enabled: false
 
-Layout/AlignArray:
+Layout/ArrayAlignment:
   Enabled: false
 
-Layout/AlignHash:
+Layout/HashAlignment:
   Enabled: false
 
-Layout/AlignParameters:
+Layout/ParameterAlignment:
   Enabled: false
 
-Layout/IndentHeredoc:
+Layout/HeredocIndentation:
   Enabled: false
 
 Metrics/BlockNesting:
@@ -174,9 +169,6 @@ Style/AsciiComments:
 Style/Attr:
   Enabled: false
 
-Style/BracesAroundHashParameters:
-  Enabled: false
-
 Style/CaseEquality:
   Enabled: false
 
@@ -195,7 +187,7 @@ Layout/MultilineMethodCallBraceLayout:
 Style/CharacterLiteral:
   Enabled: false
 
-Style/ClassAndModuleCamelCase:
+Naming/ClassAndModuleCamelCase:
   Enabled: false
 
 Style/ClassAndModuleChildren:
@@ -216,29 +208,25 @@ Style/ClassVars:
 Style/WhenThen:
   Enabled: false
 
-
 # DISABLED - not useful
 Style/WordArray:
   Enabled: false
 
-Style/UnneededPercentQ:
+Style/RedundantPercentQ:
   Enabled: false
 
-Layout/Tab:
+Layout/IndentationStyle:
   Enabled: false
 
 Layout/SpaceBeforeSemicolon:
   Enabled: false
 
-Layout/TrailingBlankLines:
+Layout/TrailingEmptyLines:
   Enabled: false
 
 Layout/SpaceInsideBlockBraces:
   Enabled: false
 
-Layout/SpaceInsideBrackets:
-  Enabled: false
-
 Layout/SpaceInsideHashLiteralBraces:
   Enabled: false
 
@@ -278,7 +266,6 @@ Layout/SpaceBeforeBlockBraces:
 Layout/SpaceBeforeComma:
   Enabled: false
 
-
 Style/CollectionMethods:
   Enabled: false
 
@@ -294,7 +281,7 @@ Style/CommentAnnotation:
 Metrics/CyclomaticComplexity:
   Enabled: false
 
-Style/ConstantName:
+Naming/ConstantName:
   Enabled: false
 
 Style/Documentation:
@@ -319,10 +306,10 @@ Style/EachWithObject:
 Layout/EmptyLineBetweenDefs:
   Enabled: false
 
-Layout/IndentArray:
+Layout/FirstArrayElementIndentation:
   Enabled: false
 
-Layout/IndentHash:
+Layout/FirstHashElementIndentation:
   Enabled: false
 
 Layout/IndentationConsistency:
@@ -340,7 +327,7 @@ Layout/EmptyLinesAroundAccessModifier:
 Style/EmptyLiteral:
   Enabled: false
 
-Metrics/LineLength:
+Layout/LineLength:
   Enabled: false
 
 Style/MethodCallWithoutArgsParentheses:
@@ -358,7 +345,10 @@ Layout/TrailingWhitespace:
 Style/StringLiterals:
   Enabled: false
 
-Style/TrailingCommaInLiteral:
+Style/TrailingCommaInArrayLiteral:
+  Enabled: false
+
+Style/TrailingCommaInHashLiteral:
   Enabled: false
 
 Style/TrailingCommaInArguments:
@@ -394,7 +384,6 @@ Style/SingleLineMethods:
 Style/SpecialGlobalVars:
   Enabled: false
 
-
 Style/TrivialAccessors:
   Enabled: false
 
@@ -404,7 +393,7 @@ Style/UnlessElse:
 Style/VariableInterpolation:
   Enabled: false
 
-Style/VariableName:
+Naming/VariableName:
   Enabled: false
 
 Style/WhileUntilDo:
@@ -413,7 +402,7 @@ Style/WhileUntilDo:
 Style/EvenOdd:
   Enabled: false
 
-Style/FileName:
+Naming/FileName:
   Enabled: false
 
 Style/For:
@@ -422,7 +411,7 @@ Style/For:
 Style/Lambda:
   Enabled: false
 
-Style/MethodName:
+Naming/MethodName:
   Enabled: false
 
 Style/MultilineTernaryOperator:
@@ -458,7 +447,7 @@ Style/NumericLiterals:
 Style/OneLineConditional:
   Enabled: false
 
-Style/OpMethod:
+Naming/BinaryOperatorParameterName:
   Enabled: false
 
 Style/ParenthesesAroundCondition:
@@ -470,7 +459,7 @@ Style/PercentLiteralDelimiters:
 Style/PerlBackrefs:
   Enabled: false
 
-Style/PredicateName:
+Naming/PredicateName:
   Enabled: false
 
 Style/RedundantException:
@@ -584,13 +573,10 @@ Layout/EmptyLinesAroundMethodBody:
 Lint/IneffectiveAccessModifier:
   Enabled: false
 
-Performance/StringReplacement:
-  Enabled: false
-
 Layout/ClosingParenthesisIndentation:
   Enabled: false
 
-Style/UnneededInterpolation:
+Style/RedundantInterpolation:
   Enabled: false
 
 Layout/ElseAlignment:
@@ -605,7 +591,7 @@ Layout/FirstParameterIndentation:
 Style/IfInsideElse:
   Enabled: false
 
-Layout/IndentAssignment:
+Layout/AssignmentIndentation:
   Enabled: false
 
 Layout/SpaceAroundBlockParameters:
@@ -614,42 +600,24 @@ Layout/SpaceAroundBlockParameters:
 Style/ParallelAssignment:
   Enabled: false
 
-Performance/RedundantBlockCall:
-  Enabled: false
-
 Style/IdenticalConditionalBranches:
   Enabled: false
 
-Performance/RedundantMatch:
-  Enabled: false
-
 Style/CommandLiteral:
   Enabled: false
 
-Performance/Casecmp:
-  Enabled: false
-
 Lint/NestedMethodDefinition:
   Enabled: false
 
 Layout/SpaceInsideStringInterpolation:
   Enabled: false
 
-Performance/RedundantMerge:
-  Enabled: false
-
-Performance/ReverseEach:
-  Enabled: false
-
 Style/NestedModifier:
   Enabled: false
 
 Lint/NonLocalExitFromIterator:
   Enabled: false
 
-Performance/Count:
-  Enabled: false
-
 Style/NestedParenthesizedCalls:
   Enabled: false
 
@@ -659,19 +627,10 @@ Layout/RescueEnsureAlignment:
 Lint/DuplicateMethods:
   Enabled: false
 
-Performance/RangeInclude:
-  Enabled: false
-
 Style/TrailingUnderscoreVariable:
   Enabled: false
 
-Performance/DoubleStartEndWith:
-  Enabled: false
-
-Performance/RedundantSortBy:
-  Enabled: false
-
-Performance/TimesMap:
+Style/RedundantSortBy:
   Enabled: false
 
 Layout/InitialIndentation:
@@ -691,7 +650,38 @@ Style/ZeroLengthPredicate:
 
 Bundler/OrderedGems:
   Enabled: false
-
   # Enforce LF line endings, even when on Windows
 Layout/EndOfLine:
   EnforcedStyle: lf
+
+Layout/SpaceAroundMethodCallOperator:
+  Enabled: true
+
+Lint/RaiseException:
+  Enabled: true
+
+Lint/StructNewOverride:
+  Enabled: true
+
+Style/ExponentialNotation:
+  Enabled: true
+
+Style/HashEachMethods:
+  Enabled: true
+
+Style/HashTransformKeys:
+  Enabled: true
+
+Style/HashTransformValues:
+  Enabled: true
+
+# Not used becuase too new for support matrix
+Style/NumericPredicate:
+  Enabled: false
+
+# Not used becuase too new for support matrix
+Style/SafeNavigation:
+  Enabled: false
+
+Style/MixinUsage:
+  Enabled: false

data/.travis.yml

@@ -3,22 +3,17 @@ language: ruby
 cache:
   bundler: true
   directories:
-    - 'spec/fixtures/puppet_controlrepo/.onceover' # Onceover cache
+    - "spec/fixtures/puppet_controlrepo/.onceover" # Onceover cache
 
 script: bundle exec rake full_tests
 bundler_args: --path vendor/bundle
 
 matrix:
   include:
-    # 2016.x -> 2017.2
-    - rvm: 2.1.9
-      env: PUPPET_VERSION="~>4.0"
-    
     # 2017.3 -> 2018.1
     - rvm: 2.4.4
       env: PUPPET_VERSION="~>5.0"
-    
+
     # 2019.0 -> now
-    - rvm: 2.5.1
+    - rvm: 2.5.7
       env: PUPPET_VERSION="~>6.0"
-    

data/Gemfile

@@ -9,12 +9,12 @@ if ENV['PUPPET_VERSION']
 end
 
 # Evaluate Gemfile.local if it exists
-if File.exists? "#{__FILE__}.local"
+if File.exist? "#{__FILE__}.local"
   eval(File.read("#{__FILE__}.local"), binding)
 end
 
 # Evaluate ~/.gemfile if it exists
-if File.exists?(File.join(Dir.home, '.gemfile'))
+if File.exist?(File.join(Dir.home, '.gemfile'))
   eval(File.read(File.join(Dir.home, '.gemfile')), binding)
 end
 
@@ -23,3 +23,10 @@ if ENV['APPVEYOR'] == 'True'
   # in order to not have symlinks and therefor work on windows
   gem 'r10k', git: 'https://github.com/puppetlabs/r10k.git'
 end
+
+group :development do
+  gem 'cucumber', '~> 2.0'
+  gem 'pry', '~> 0.10.0'
+  gem 'rubocop', '~> 0.82.0'
+  gem 'rubygems-tasks', '~> 0.2.0'
+end