onceover-codequality 0.4.1 → 0.4.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 63a38c5d3ba138cf100238853ffe501c54e2bdc87d7afc7efd9cc4a1e1544125
-  data.tar.gz: 321dfa4029fec08ea836298d2f98b1a6e109f6e2c4ae54846bbec34af2ec7c52
+  metadata.gz: 2d002a389642fbd94ce6014ecff04a722df6fc11b839f1b89da4af142a45939b
+  data.tar.gz: 85a5ed0c78832166281dad179ce1dcec6ee635f6a34738444273e3da263c7fba
 SHA512:
-  metadata.gz: 81094f3e5df3d0c0ec09ead29b3670ed6384113a6ac1b5f58f25ab3b5d8b490b7c8abd3943cd21802902d81a45a5142882fbb550d1ffcd3ed6510f7ee3761e14
-  data.tar.gz: 6e5c93e4b1481866812933bbf0e05267257e416c470502386341208f851d7a6f3503acc38c739e5a7262c38430978e92b51d5626eeeab9d17a7ea35e1abc877e
+  metadata.gz: 63a2b200eec20907c736b91a5bb853f362c5de63ae8b49f4bbef02f26ba06f1a71c3e362f1cb4d6901578a3948da3474c979863a4798d9876f2a4de410e2e06e
+  data.tar.gz: 8ad26cf6dbc73ab8915719af1fe1a421faf348dd1dadf995d9915602763608132a57b0b6e7e7c5555125f88296ee606fb8261a1f1544002c58d1a1d8fd90ab60

data/lib/onceover/codequality/lint.rb

@@ -2,7 +2,7 @@ class Onceover
   module CodeQuality
     module Lint
 
-      # Apply linting to the manifests directory and each module under `site` 
+      # Apply linting to the manifests directory and each module under `site`
       LINT_PATHS = [
         "manifests",
       ].concat(Dir.glob('site/*').select {|f| File.directory? f})
@@ -25,11 +25,9 @@ class Onceover
         status = true
         LINT_PATHS.each { |p|
           if Dir.exists?(p)
-            Dir.chdir(p) do
-              logger.info("checking #{p}")
-              if ! system("puppet-lint #{LINT_OPTIONS.join ' '} . ")
-                status = false
-              end
+            logger.info("checking #{p}")
+            if ! system("puppet-lint #{LINT_OPTIONS.join ' '} #{p}")
+              status = false
             end
           end
         }

data/lib/onceover/codequality/syntax.rb

@@ -11,13 +11,13 @@ class Onceover
           logger.warn("No Puppetfile found... continuing")
         end
 
-        # rake task contains an exit statement so run it in a subshell to
-        # capture and continue
-        status &= system(
-"ruby << EOD
-    require 'puppet-syntax/tasks/puppet-syntax'
-    Rake::Task['syntax'].invoke
-EOD")
+        require 'puppet-syntax/tasks/puppet-syntax'
+        begin
+          Rake::Task['syntax'].invoke
+        rescue SystemExit => e
+          logger.error("Invalid syntax")
+          status &= e.status
+        end
         status
       end
     end

data/lib/onceover/codequality/version.rb

@@ -1,5 +1,5 @@
 class Onceover
   module CodeQuality
-    VERSION = "0.4.1"
+    VERSION = "0.4.2"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: onceover-codequality
 version: !ruby/object:Gem::Version
-  version: 0.4.1
+  version: 0.4.2
 platform: ruby
 authors:
 - Declarative Systems
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-11-12 00:00:00.000000000 Z
+date: 2018-12-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler