on_the_spot 1.1.2 → 1.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: b529c0ec359d065b5be58926383c947ecd89b40f
-  data.tar.gz: f4b5c500c36945091220524c621814e7f8129d2e
+SHA256:
+  metadata.gz: 40b5d965c2d82d3af5910189c680a7b78ac758b4faddbcbac8724a173420b1bb
+  data.tar.gz: 9cb9cd5073ed51a6561b5878fda09b764a4c13f55dc7f568da2f7daed09dbc51
 SHA512:
-  metadata.gz: 54be6beb41950cdcb7de401b73ec1ab66ecd471960e06d4626818426ec1f942b51614b3fcca3a1c637e6f5d3ab501e3d3a5a8757bbd89d8e9238efd8e5a627cf
-  data.tar.gz: f749c615ed9b9a2e8ddc4af6f4498df88f4f357a26727d056590b77023a46b6eac01e6562679b72dc22e41e42aa9ef5a35ba298746975625a059c1203633535c
+  metadata.gz: '0396ab103978dd4f521c3fb477449a686fbef65e3488855b3f7f379e3f29fb73427b88e69ac9c38c2ced75c619faa09d404cfbd5bb0e0a2194d991ca8030af20'
+  data.tar.gz: 07eb52d9787e8ec4860cb62b6636ee3f2b967ca5b032e6efd42c3939c12dfd4df8f5f8f2925f7c30324d3819ecbc46afcd8d7ba594cbb22373afba620e0fa065

data/README.markdown

@@ -116,6 +116,11 @@ It should be as simple as that :)
 
 ## Detailed options
 
+The `can_edit_on_the_spot` accepts options:
+
+* `:is_allowed`: method-name to call to check if the update is allowed to be performed
+* `:on_success`: method-name that is called when the update was succesfully performed, this could be used for audit-logging a.o.
+
 The `on_the_spot_edit` also accepts options:
 
 * `:type`    : `:textarea`, `:select` or `:checkbox` (none means default edit)
@@ -134,6 +139,7 @@ The `on_the_spot_edit` also accepts options:
    attempt to look up the raw value of the field to edit.  This differs from the `:display_text` option, as this will also be called after update.
    This supersedes the `:display_text` option.
 * `:raw`: if set to true, evaluate the field value as raw HTML.
+* `:onblur`: accepts `cancel`, `submit` or `ignore` changes the behavior of the onblur handler accordingly
 
 
 For the texts: if a text is not specified, the default is taken from the `on_the_spot.en.yml` (or your current language).
@@ -178,7 +184,7 @@ When using `on_the_spot` together with `cancan`, you will have to explicitly exc
 like so:
 
     load_and_authorize_resource :except => [:update_attribute_on_the_spot, :get_attribute_on_the_spot]
-    
+
 The `load_and_authorize_resource` will try to find the object, based on the id in the parameters, but `on_the_spot` uses a different
 encoding to store the object, field and id in one attribute. So if you exclude that, there will not be a problem.
 
@@ -196,6 +202,26 @@ In your controller write:
     end
 
 
+Note, there are two identical ways to add this: either you use the _old format_ : `can_edit_on_the_spot :method_name` or
+you could use the new format: `can_edit_on_the_spot is_allowed: :check_access`. Both are identical
+
+
+## Performing an action upon succesful update
+
+If you want to perform some action upon succesfully updating a field,
+you can specify a method to do just that.
+
+
+In your controller write:
+
+    can_edit_on_the_spot on_success: :log_changes
+
+    protected
+
+    def log_changes(updated_object, field, value)
+      Rails.logger.debug("We updated #{updated_object.name} and set #{field} to #{value}")
+    end
+
 
 ## Example project
 

data/VERSION

@@ -1 +1 @@
-1.1.2
+1.1.3

data/lib/on_the_spot/controller_extension.rb

@@ -8,7 +8,10 @@ module OnTheSpot
     # if this method is called inside a controller, the edit-on-the-spot
     # controller action is added that will allow to edit fields in place
     module ClassMethods
-      def can_edit_on_the_spot(check_acces_method=nil)
+      def can_edit_on_the_spot(options_or_check_access_method=nil)
+        check_access_method = options_or_check_access_method.is_a?(Hash) ? options_or_check_access_method[:is_allowed] : options_or_check_access_method
+        on_success_method   = options_or_check_access_method.is_a?(Hash) ? options_or_check_access_method[:on_success] : nil
+
         define_method :update_attribute_on_the_spot do
           klass_name, field, id = params[:id].split('__')
           select_data = params[:select_array]
@@ -17,7 +20,7 @@ module OnTheSpot
           klass = klass_name.camelize.constantize
           object = klass.find(id)
 
-          is_allowed = check_acces_method.present? ? self.send(check_acces_method, object, field) : true
+          is_allowed = check_access_method.present? ? self.send(check_access_method, object, field) : true
 
           if is_allowed
             saved = if klass.attribute_names.include?(field)
@@ -28,6 +31,9 @@ module OnTheSpot
                       object.save
                     end
             if saved
+              if on_success_method.present?
+                self.send(on_success_method, object, field, params[:value])
+              end
               if select_data.nil?
                 field_or_method = if display_method.present?
                                     object.send(display_method)
@@ -53,7 +59,7 @@ module OnTheSpot
 
           object = klass_name.camelize.constantize.find(id)
 
-          is_allowed = check_acces_method.present? ? self.send(check_acces_method, object, field) : true
+          is_allowed = check_access_method.present? ? self.send(check_access_method, object, field) : true
 
           if is_allowed
             render :plain => object.send(field)

data/on_the_spot.gemspec

@@ -2,16 +2,16 @@
 # DO NOT EDIT THIS FILE DIRECTLY
 # Instead, edit Jeweler::Tasks in Rakefile, and run 'rake gemspec'
 # -*- encoding: utf-8 -*-
-# stub: on_the_spot 1.1.2 ruby lib
+# stub: on_the_spot 1.1.3 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "on_the_spot".freeze
-  s.version = "1.1.2"
+  s.version = "1.1.3"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0".freeze) if s.respond_to? :required_rubygems_version=
   s.require_paths = ["lib".freeze]
   s.authors = ["Nathan Van der Auwera".freeze]
-  s.date = "2018-05-25"
+  s.date = "2019-10-21"
   s.description = "Unobtrusive in place editing, using jEditable; only works in Rails 3".freeze
   s.email = "nathan@dixis.com".freeze
   s.extra_rdoc_files = [
@@ -84,7 +84,7 @@ Gem::Specification.new do |s|
   ]
   s.homepage = "http://github.com/nathanvda/on_the_spot".freeze
   s.licenses = ["MIT".freeze]
-  s.rubygems_version = "2.6.14".freeze
+  s.rubygems_version = "2.7.10".freeze
   s.summary = "unobtrusive in place editing".freeze
 
   if s.respond_to? :specification_version then

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: on_the_spot
 version: !ruby/object:Gem::Version
-  version: 1.1.2
+  version: 1.1.3
 platform: ruby
 authors:
 - Nathan Van der Auwera
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-05-25 00:00:00.000000000 Z
+date: 2019-10-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -142,7 +142,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.14
+rubygems_version: 2.7.10
 signing_key: 
 specification_version: 4
 summary: unobtrusive in place editing