on_form 2.1.0 → 2.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: febeec1d904aefce31f0499e1a0259caff00003c
-  data.tar.gz: 0fa55ca7d0f8692479ae9ee574a1e2f03f2ed42c
+  metadata.gz: ef390c085a64b23daf7e8439918a5db0c33d351f
+  data.tar.gz: fb98c2b228bfb52f2a732a09d513afa7643f840e
 SHA512:
-  metadata.gz: c3a32337ff68ecc0037ab9fb431b279f6897fda0f2a82c90a657add23ca0eeac43c1ce1bf517e2768fa2caa471399551fa32b5a25cc4478912632011ea679dcc
-  data.tar.gz: bb78f1d4a027fee037958b23e232c9c381efa7c9d426018e9b6723e7060a1042c2d14b0876302c75e555226c236e795a2bc49dac33709f45136b78b12dc0b90a
+  metadata.gz: fb5bf8f542ea1243dfe9f232e7cf8fe603b8ab908142d1a657c2c99bd38c41c8c125486a356815881192f6c776f5705e90ee12a9e5d56e4034da710906c3f8d4
+  data.tar.gz: 6dcf2fa5591a255808602edba8399b0625d36c63d6fd9cd65e8c8e0dce24fda3b51c2e1ec5f134501a94e11451c587cc3ed45f8b8e4a9ee344784e635d9d947d

data/CHANGES.md

@@ -1,15 +1,23 @@
 Changelog
 =========
 
-2.01
-----
+2.2.0
+-----
+* Remove the previously existing transaction caveat around model-less saves.
+
+2.1.0
+-----
+* Implement support for introducing typed "artificial" attributes.
+
+2.0.1
+-----
 * Fix regressions in support for Rails 4.2.
 * Support some additional attribute methods such as `*_was` and `*_changed?`.
 
-2.00
-----
+2.0.0
+-----
 * New expose syntax to support prefix:, suffix:, and as: options.
 
-1.00
-----
+1.0.0
+-----
 * First public release.

data/README.md

@@ -228,7 +228,7 @@ end
 
 ### Model-less forms
 
-Taking this one step further, you can define forms which have _no_ exposed model attributes.  *Be aware that forms that expose no models do not automatically start a database transaction, because they don't know which database connection to use.*
+Taking this one step further, you can define forms which have _no_ exposed model attributes.
 
 To actually perform a data change in response to the form submission, you can add a `before_save` or `after_save` callback and from there call your existing model code or service objects.  It's best to keep the code in the form object to just the bits specific to the form - try not to put your business logic in your form objects!
 
@@ -264,6 +264,8 @@ class ChangePasswordForm < OnForm::Form
 end
 ```
 
+Note that when you have no exposed models, OnForm will still wrap the save process in a database transaction for you, using `ActiveRecord::Base.transaction`.  If you have multiple database connections, you may need to start transactions on the other connections yourself.
+
 ### Reusing and extending forms
 
 You can descend form classes from other form classes and expose additional models or additional attributes on existing models.

data/lib/on_form/saving.rb

@@ -5,7 +5,13 @@ module OnForm
     end
 
     def transaction(&block)
-      with_transactions(backing_model_instances, &block)
+      backing_models = backing_model_instances
+
+      if backing_models.empty?
+        with_transactions([ActiveRecord::Base], &block)
+      else
+        with_transactions(backing_model_instances, &block)
+      end
     end
 
     def invalid?

data/lib/on_form/version.rb

@@ -1,3 +1,3 @@
 module OnForm
-  VERSION = "2.1.0"
+  VERSION = "2.2.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: on_form
 version: !ruby/object:Gem::Version
-  version: 2.1.0
+  version: 2.2.0
 platform: ruby
 authors:
 - Will Bryant
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2016-09-28 00:00:00.000000000 Z
+date: 2016-09-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel