on 0.3.1 → 0.3.2

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: 1fcbfef233adfda1d5c83cc0cf03d2d885badc8f
+  data.tar.gz: e0e0c6018ff8575415dac387dd969bc760fb06d6
+SHA512:
+  metadata.gz: 43c9760275254b810483f07a652b3ed16105ad29602d903ea1c912e2ceb33e745530257d173abb2bbf2bea4fd497f30604f0829f23e8527b1d08a1c9277fb171
+  data.tar.gz: 90f68dc570a1738a7c8f76a7af6a4e3ba7442692e7c15e30c9f140d3c9703355d7e904cd15912a472f3b90f27a07f25adc8cd6fbbedc34e789b1c6e3cceb901a

data/.travis.yml

@@ -1,12 +1,20 @@
 language: ruby
+sudo: false
+cache: bundler
+script: bundle exec rake test:all
 rvm:
-  - ree
-  - "1.8.7"
-  - "1.9.2"
-  - "1.9.3"
-  - jruby-18mode
-  - jruby-19mode
-  - rbx-18mode
-  - rbx-19mode
+  - 1.9.3
+  - 2.0
+  - 2.1
+  - 2.2
   - ruby-head
-script: rake test:all
+  - jruby
+  - jruby-head
+  - rbx-2
+env:
+  global:
+    - JRUBY_OPTS='--dev -J-Xmx1024M'
+matrix:
+  allow_failures:
+    - rvm: ruby-head
+    - rvm: jruby-head

data/README.md

@@ -0,0 +1,135 @@
+[github]: https://github.com/neopoly/on
+[doc]: http://rubydoc.info/github/neopoly/on/master/file/README.md
+[gem]: https://rubygems.org/gems/on
+[travis]: https://travis-ci.org/neopoly/on 
+[codeclimate]: https://codeclimate.com/github/neopoly/on
+[inchpages]: https://inch-ci.org/github/neopoly/on
+
+# On
+
+[![Travis](https://img.shields.io/travis/neopoly/on.svg?branch=master)][travis]
+[![Gem Version](https://img.shields.io/gem/v/on.svg)][gem]
+[![Code Climate](https://img.shields.io/codeclimate/github/neopoly/on.svg)][codeclimate]
+[![Test Coverage](https://codeclimate.com/github/neopoly/on/badges/coverage.svg)][codeclimate]
+[![Inline docs](https://inch-ci.org/github/neopoly/on.svg?branch=master&style=flat)][inchpages]
+
+Dynamic callbacks for Ruby blocks.
+
+[Gem][gem] |
+[Source][github] |
+[Documentation][doc]
+
+Inspired by
+http://www.mattsears.com/articles/2011/11/27/ruby-blocks-as-dynamic-callbacks
+
+## Usage
+
+Basic usage.
+
+```ruby
+require 'on'
+
+def tweet(message, &block)
+  callback = On.new(:success, :failure, &block)
+  callback.call :success
+rescue => e
+  callback.call :failure, e.message
+end
+
+tweet "hello world" do |callback|
+  callback.on :success do
+    # handle success
+  end
+  callback.on :failure do |error_message|
+    # handle error message
+  end
+end
+```
+
+## Usage with proc
+
+Syntatic sugar for creating an `on` callback from Proc.
+
+```ruby
+require 'on/proc'
+
+def tweet(message, &block)
+  callback = block.on(:success, :failure)
+  callback.call :success
+rescue => e
+  callback.call :failure, e.message
+end
+
+tweet "hello world" do |callback|
+  callback.on :success do
+    # handle success
+  end
+  callback.on :failure do |error_message|
+    # handle error message
+  end
+end
+```
+
+## Testing with On::TestHelper
+
+```ruby
+require 'minitest/autorun'
+require 'on'
+require 'on/test_helper'
+
+class SomeTest < MiniTest::Spec
+  include On::TestHelper
+
+  let(:recorder) { On::TestHelper::Recorder.new }
+
+  it "records everything" do
+    on = On.new(:success, :failure, &recorder)
+    on.call :success, :some, :args
+    assert_callback recorder, :success, :some, :args
+  end
+
+  it "calls nothing" do
+    on = On.new(:success, :failure, &recorder)
+    # nothing called
+    refute_callbacks recorder
+  end
+
+  it "records everything manually" do
+    on = On.new(:success, :failure) do |result|
+      recorder.record_block
+      recorder.record_callback(result, :success, :failure)
+    end
+    on.call :success, :some, :args
+    assert_callback recorder, :success, :some, :args
+  end
+end
+```
+
+## Installation
+
+Add this line to your application's Gemfile:
+
+```ruby
+gem 'on'
+```
+
+And then execute:
+
+```shell
+$ bundle
+```
+
+Or install it yourself as:
+
+```shell
+$ gem install on
+```
+
+## Contributing
+
+1.  Fork it
+2.  Create your feature branch (`git checkout -b my-new-feature`)
+3.  Commit your changes (`git commit -am 'Add some feature'`)
+4.  Push to the branch (`git push origin my-new-feature`)
+5.  Create new Pull Request
+

data/lib/on/test_helper.rb

@@ -56,12 +56,13 @@ class On
       raise ArgumentError, "Provide args or block but not both" if block_given? && !args.empty?
 
       callback = recorder.last_record
+      assertion_message = proc { "Callback was #{callback}" }
       assert callback, "No callbacks found"
-      assert_equal name, callback.name, "Callback was #{callback}"
+      assert_equal name, callback.name, assertion_message
       if block_given?
         yield *callback.args
       else
-        assert_equal args, callback.args, "Callback was #{callback}"
+        assert_equal args, callback.args, assertion_message
       end
     end
 
@@ -124,8 +125,9 @@ class On
         end
       end
 
-      def callback_recorded(name, args)
-        @callbacks << Callback.new(name, args)
+      def callback_recorded(name, args=[])
+        callback = Callback === name ? name : Callback.new(name, args)
+        @callbacks << callback
       end
 
       # Short-hand for &+recorder.record_all+.

data/lib/on/version.rb

@@ -1,3 +1,3 @@
 class On
-  VERSION = "0.3.1"
+  VERSION = "0.3.2"
 end

data/test/on_test_helper_test.rb

@@ -9,6 +9,11 @@ class OnTestHelperTest < Testem
       assert_callback recorder, :foo
     end
 
+    test "evaluates assertion messages lazily" do
+      record_boom :foo
+      assert_callback recorder, :foo
+    end
+
     test "match with args" do
       record :foo, :bar, :baz
       assert_callback recorder, :foo, :bar, :baz
@@ -99,6 +104,17 @@ class OnTestHelperTest < Testem
 
   private
 
+  class BoomCallback < On::TestHelper::Recorder::Callback
+    def to_s
+      raise "I should NOT be called"
+    end
+  end
+
+  def record_boom(name, *args)
+    callback = BoomCallback.new(name, args)
+    recorder.callback_recorded(callback)
+  end
+
   def record(name, *args)
     recorder.callback_recorded(name, args)
   end

metadata

@@ -1,78 +1,69 @@
 --- !ruby/object:Gem::Specification
 name: 'on'
 version: !ruby/object:Gem::Version
-  version: 0.3.1
-  prerelease: 
+  version: 0.3.2
 platform: ruby
 authors:
 - Peter Suschlik
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-12-07 00:00:00.000000000 Z
+date: 2015-02-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rdoc
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: minitest
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: testem
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 description: Dynamic callbacks with Ruby blocks.
@@ -82,17 +73,16 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
-- .travis.yml
+- ".gitignore"
+- ".travis.yml"
 - Gemfile
-- README.rdoc
+- README.md
 - Rakefile
 - lib/on.rb
 - lib/on/proc.rb
 - lib/on/test_helper.rb
 - lib/on/version.rb
 - on.gemspec
-- on.rb
 - test/helper.rb
 - test/integration_test.rb
 - test/on_proc_test.rb
@@ -100,33 +90,26 @@ files:
 - test/on_test_helper_test.rb
 homepage: https://github.com/neopoly/on
 licenses: []
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: 1483705294558873466
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: 1483705294558873466
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.24
+rubygems_version: 2.2.2
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: Inspired by http://www.mattsears.com/articles/2011/11/27/ruby-blocks-as-dynamic-callbacks
 test_files:
 - test/helper.rb

data/README.rdoc

@@ -1,110 +0,0 @@
-= On {<img src="https://secure.travis-ci.org/neopoly/on.png?branch=master" alt="Build Status" />}[https://travis-ci.org/neopoly/on]
-
-Dynamic callbacks for Ruby blocks.
-
-Gem[https://rubygems.org/gems/on] |
-Source[https://github.com/neopoly/on] |
-Documentation[http://rubydoc.info/github/neopoly/on/master/file/README.rdoc]
-
-Inspired by http://www.mattsears.com/articles/2011/11/27/ruby-blocks-as-dynamic-callbacks
-
-== Usage
-
-Basic usage.
-
-  require 'on'
-
-  def tweet(message, &block)
-    callback = On.new(:success, :failure, &block)
-    callback.call :success
-  rescue => e
-    callback.call :failure, e.message
-  end
-
-  tweet "hello world" do |callback|
-    callback.on :success do
-      # handle success
-    end
-    callback.on :failure do |error_message|
-      # handle error message
-    end
-  end
-
-
-== Usage with proc
-
-Syntatic sugar for creating an +on+ callback from Proc.
-
-  require 'on/proc'
-
-  def tweet(message, &block)
-    callback = block.on(:success, :failure)
-    callback.call :success
-  rescue => e
-    callback.call :failure, e.message
-  end
-
-  tweet "hello world" do |callback|
-    callback.on :success do
-      # handle success
-    end
-    callback.on :failure do |error_message|
-      # handle error message
-    end
-  end
-
-== Testing with On::TestHelper
-
-  require 'minitest/autorun'
-  require 'on'
-  require 'on/test_helper'
-
-  class SomeTest < MiniTest::Spec
-    include On::TestHelper
-
-    let(:recorder) { On::TestHelper::Recorder.new }
-
-    it "records everything" do
-      on = On.new(:success, :failure, &recorder)
-      on.call :success, :some, :args
-      assert_callback recorder, :success, :some, :args
-    end
-
-    it "calls nothing" do
-      on = On.new(:success, :failure, &recorder)
-      # nothing called
-      refute_callbacks recorder
-    end
-
-    it "records everything manually" do
-      on = On.new(:success, :failure) do |result|
-        recorder.record_block
-        recorder.record_callback(result, :success, :failure)
-      end
-      on.call :success, :some, :args
-      assert_callback recorder, :success, :some, :args
-    end
-  end
-
-
-== Installation
-
-Add this line to your application's Gemfile:
-
-  gem 'on'
-
-And then execute:
-
-  $ bundle
-
-Or install it yourself as:
-
-  $ gem install on
-
-== Contributing
-
-1. Fork it
-2. Create your feature branch (`git checkout -b my-new-feature`)
-3. Commit your changes (`git commit -am 'Add some feature'`)
-4. Push to the branch (`git push origin my-new-feature`)
-5. Create new Pull Request

data/on.rb

@@ -1,52 +0,0 @@
-require 'minitest/autorun'
-require 'testem'
-
-class On
-  def initialize *callbacks
-    @callbacks = callbacks
-  end
-
-  def callback(*args)
-    @current = args
-    self
-  end
-
-  def method_missing method, *args, &block
-    if @callbacks.empty? || @callbacks.include?(method)
-      if @current[0] == method
-        yield *@current[1]
-      end
-    else
-      super
-    end
-  end
-end
-
-def tweet(ok, &block)
-  block.callbacks :success, :failure
-  if ok
-    block.callback :success, 23
-  else
-    block.callback :failure, 25
-  end
-end
-
-class Proc
-  def callbacks(*names)
-    @on = On.new(*names)
-  end
-
-  def callback(*args)
-    @on ||= On.new
-    call @on.callback(*args)
-  end
-end
-
-tweet([true, false].sample) do |on|
-  on.success do |number|
-    p :success => number
-  end
-  on.failure do |number|
-    p :fail => number
-  end
-end