omnifocus-github 1.9.0 → 2.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 33de15bbd7d3a7f67dbb3bdaee2a0c7e6e450760226661751521b9f7027db900
-  data.tar.gz: cbb1e9c80d0d536fbff4b182a85a81d413b1e84653add6d75eb002fafe2ab466
+  metadata.gz: 5d40c0e432d4783144432c7f703e64a0f0140b2fdd015400fd1995d3ac495276
+  data.tar.gz: eb73e87311e83ae8d27e7106f998c6e987a585b775f48e34e11ddea58e0402ba
 SHA512:
-  metadata.gz: b96afcbf082d5096f0c016778964174a086ac9c5eed04d913e6100cf948f09e1e91a7b937c0d6b37d7c3d4220145b5fda09921089556f07d172c518066479223
-  data.tar.gz: 7c476a4bb8af78f029b87feb8e1b9d67b696e4921b6fecdc97bfaee6cb0969d2c83f1c4b153c2a07d1bdec86840c80526a68a6d9a2b82c54b7f4ef2d82d94510
+  metadata.gz: d821c4bde4f20d0580cbd0c53b908fc853b1c0e78b5bc95c51fcacdf4f8329880a8e2e57bf96c47403ac5462194954595616dc7a222ca41437251df862f4a62b
+  data.tar.gz: c3389bc17a46a8ec7735f8242954496bf4cc6f7056e42db2b089941ac62057fe041722fec8842a9f097d0fbd1a5157b2c8f387df8034309bdd3f5f6b2336aefd

data/History.rdoc

@@ -1,3 +1,14 @@
+=== 2.0.0 / 2022-09-28
+
+* 1 major enhancement:
+
+  * Removed #gh_client.
+
+* 2 minor enhancements:
+
+  * #process now takes the prefix for the ticket ID (default: GH).
+  * Refactored #gh_client + most #populate_github_tasks into #github_clients that returns a hash of prefix => octokit_client.
+
 === 1.9.0 / 2020-02-12
 
 * 2 minor enhancements:

data/README.rdoc

@@ -10,11 +10,11 @@ Plugin for omnifocus gem to provide github BTS synchronization.
 Support for Github Enterprise:
 
 In your git config, set the key github.accounts to a space
-separated list of github accounts. 
+separated list of github accounts.
 
     git config --global github.accounts "github myghe"
 
-For each account API and web end points and authentication information 
+For each account API and web end points and authentication information
 should be stored in the git config under a key matching the
 account. For example:
 

data/lib/omnifocus/github.rb

@@ -5,12 +5,24 @@ $-w = old_w
 Octokit.auto_paginate = true
 
 module OmniFocus::Github
-  VERSION = "1.9.0"
+  VERSION = "2.0.0"
   PREFIX  = "GH"
 
   def populate_github_tasks
     processed = false
-    omnifocus_git_param(:accounts, "github").split(/\s+/).each do |account|
+
+    github_clients.each do |account, client|
+      account_label = account == "github" ? PREFIX : account
+
+      processed = true
+      process account_label, client
+    end
+
+    raise "No accounts authenticated. Bailing." unless processed
+  end
+
+  def github_clients
+    omnifocus_git_param(:accounts, "github").split(/\s+/).map { |account|
       endpoints = {}
       endpoints[:api] = omnifocus_git_param(:api, nil, account)
       endpoints[:web] = omnifocus_git_param(:web, nil, account)
@@ -30,52 +42,46 @@ module OmniFocus::Github
 
       auth[:name] = auth[:user] if auth[:name].nil?
 
-      processed = true
-      account_label = account == "github" ? nil : account
-
-      process(account_label, gh_client(account, auth, endpoints))
-    end
+      client = nil
 
-    raise "No accounts authenticated. Bailing." unless processed
-  end
+      if account != "github"
+        if endpoints[:api] && endpoints[:web]
+          Octokit.configure do |c|
+            c.api_endpoint = endpoints[:api]
+            c.web_endpoint = endpoints[:web]
+          end
+        else
+          raise ArgumentError, "api and web endpoint configs required for github enterprise"
+        end
+      end
 
-  def omnifocus_git_param name, default = nil, prefix = "omnifocus-github"
-    param = `git config #{prefix}.#{name}`.chomp
-    param.empty? ? default : param
-  end
+      if auth[:user] && auth[:password]
+        client = Octokit::Client.new(:login => auth[:user],
+                                     :password => auth[:password])
 
-  def gh_client account, auth, endpoints
-    if account != "github"
-      if endpoints[:api] && endpoints[:web]
-        Octokit.configure do |c|
-          c.api_endpoint = endpoints[:api]
-          c.web_endpoint = endpoints[:web]
-        end
+        client.user auth[:name]
+      elsif auth[:user] && auth[:oauth]
+        client = Octokit::Client.new :access_token => auth[:oauth]
+        client.user.login
       else
-        raise ArgumentError, "api and web endpoint configs required for github enterprise"
+        raise ArgumentError, "Missing authentication"
       end
-    end
 
-    if auth[:user] && auth[:password]
-      client = Octokit::Client.new(:login => auth[:user],
-                                   :password => auth[:password])
+      [account, client]
+    }.to_h
+  end
 
-      client.user(auth[:name])
-    elsif auth[:user] && auth[:oauth]
-      client = Octokit::Client.new :access_token => auth[:oauth]
-      client.user.login
-    else
-      raise ArgumentError, "Missing authentication"
-    end
-    client
+  def omnifocus_git_param name, default = nil, prefix = "omnifocus-github"
+    param = `git config #{prefix}.#{name}`.chomp
+    param.empty? ? default : param
   end
 
-  def process account, client
+  def process prefix, client
     client.list_issues.each do |issue|
       pr        = issue["pull_request"] && !issue["pull_request"]["diff_url"].nil?
       number    = issue.number
       project   = issue.repository.full_name.split("/").last
-      ticket_id = "#{PREFIX}-#{project}##{number}"
+      ticket_id = "#{prefix}-#{project}##{number}"
       title     = "#{ticket_id}: #{pr ? "[PR] " : ""}#{issue["title"]}"
       # HACK
       url       = "https://github.com/#{issue.repository.full_name}/issues/#{number}"

metadata

@@ -1,19 +1,19 @@
 --- !ruby/object:Gem::Specification
 name: omnifocus-github
 version: !ruby/object:Gem::Version
-  version: 1.9.0
+  version: 2.0.0
 platform: ruby
 authors:
 - Ryan Davis
 - aja
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain:
 - |
   -----BEGIN CERTIFICATE-----
-  MIIDPjCCAiagAwIBAgIBBDANBgkqhkiG9w0BAQsFADBFMRMwEQYDVQQDDApyeWFu
+  MIIDPjCCAiagAwIBAgIBBjANBgkqhkiG9w0BAQsFADBFMRMwEQYDVQQDDApyeWFu
   ZC1ydWJ5MRkwFwYKCZImiZPyLGQBGRYJemVuc3BpZGVyMRMwEQYKCZImiZPyLGQB
-  GRYDY29tMB4XDTE5MTIxMzAwMDIwNFoXDTIwMTIxMjAwMDIwNFowRTETMBEGA1UE
+  GRYDY29tMB4XDTIxMTIyMzIzMTkwNFoXDTIyMTIyMzIzMTkwNFowRTETMBEGA1UE
   AwwKcnlhbmQtcnVieTEZMBcGCgmSJomT8ixkARkWCXplbnNwaWRlcjETMBEGCgmS
   JomT8ixkARkWA2NvbTCCASIwDQYJKoZIhvcNAQEBBQADggEPADCCAQoCggEBALda
   b9DCgK+627gPJkB6XfjZ1itoOQvpqH1EXScSaba9/S2VF22VYQbXU1xQXL/WzCkx
@@ -23,14 +23,14 @@ cert_chain:
   qhtV7HJxNKuPj/JFH0D2cswvzznE/a5FOYO68g+YCuFi5L8wZuuM8zzdwjrWHqSV
   gBEfoTEGr7Zii72cx+sCAwEAAaM5MDcwCQYDVR0TBAIwADALBgNVHQ8EBAMCBLAw
   HQYDVR0OBBYEFEfFe9md/r/tj/Wmwpy+MI8d9k/hMA0GCSqGSIb3DQEBCwUAA4IB
-  AQCkkcHqAa6IKLYGl93rn78J3L+LnqyxaA059n4IGMHWN5bv9KBQnIjOrpLadtYZ
-  vhWkunWDKdfVapBEq5+T4HzqnsEXC3aCv6JEKJY6Zw7iSzl0M8hozuzRr+w46wvT
-  fV2yTN6QTVxqbMsJJyjosks4ZdQYov2zdvQpt1HsLi+Qmckmg8SPZsd+T8uiiBCf
-  b+1ORSM5eEfBQenPXy83LZcoQz8i6zVB4aAfTGGdhxjoMGUEmSZ6xpkOzmnGa9QK
-  m5x9IDiApM+vCELNwDXXGNFEnQBBK+wAe4Pek8o1V1TTOxL1kGPewVOitX1p3xoN
-  h7iEjga8iM1LbZUfiISZ+WrB
+  AQCKB5jfsuSnKb+t/Wrh3UpdkmX7TrEsjVmERC0pPqzQ5GQJgmEXDD7oMgaKXaAq
+  x2m+KSZDrqk7c8uho5OX6YMqg4KdxehfSLqqTZGoeV78qwf/jpPQZKTf+W9gUSJh
+  zsWpo4K50MP+QtdSbKXZwjAafpQ8hK0MnnZ/aeCsW9ov5vdXpYbf3dpg6ADXRGE7
+  lQY2y1tJ5/chqu6h7dQmnm2ABUqx9O+JcN9hbCYoA5i/EeubUEtFIh2w3SpO6YfB
+  JFmxn4h9YO/pVdB962BdBNNDia0kgIjI3ENnkLq0dKpYU3+F3KhEuTksLO0L6X/V
+  YsuyUzsMz6GQA4khyaMgKNSD
   -----END CERTIFICATE-----
-date: 2020-02-13 00:00:00.000000000 Z
+date: 2022-09-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: omnifocus
@@ -86,27 +86,43 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.22'
+        version: '3.25'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.22'
-description: "Plugin for omnifocus gem to provide github BTS synchronization.\n\nSupport
-  for Github Enterprise:\n\nIn your git config, set the key github.accounts to a space\nseparated
-  list of github accounts. \n\n    git config --global github.accounts \"github myghe\"\n\nFor
-  each account API and web end points and authentication information \nshould be stored
-  in the git config under a key matching the\naccount. For example:\n\n    git config
-  --global github.user me\n    git config --global github.password mypassword\n    git
-  config --global myghe.api https://ghe.mydomain.com/api/v3\n    git config --global
-  myghe.api https://ghe.mydomain.com/\n\nFor each account can you specify the following
-  parameters:\n\n* api - specify an API endpoint other than\n  https://api.github.com.
-  This is so you can point this at your Github\n  Enterprise endpoint.\n\n* web -
-  specify an API endpoint other than https://www.github.com. This\n  is so you can
-  point this at your Github Enterprise endpoint\n\n* user, password - A username and
-  password pair for Basic http authentication."
+        version: '3.25'
+description: |-
+  Plugin for omnifocus gem to provide github BTS synchronization.
+
+  Support for Github Enterprise:
+
+  In your git config, set the key github.accounts to a space
+  separated list of github accounts.
+
+      git config --global github.accounts "github myghe"
+
+  For each account API and web end points and authentication information
+  should be stored in the git config under a key matching the
+  account. For example:
+
+      git config --global github.user me
+      git config --global github.password mypassword
+      git config --global myghe.api https://ghe.mydomain.com/api/v3
+      git config --global myghe.api https://ghe.mydomain.com/
+
+  For each account can you specify the following parameters:
+
+  * api - specify an API endpoint other than
+    https://api.github.com. This is so you can point this at your Github
+    Enterprise endpoint.
+
+  * web - specify an API endpoint other than https://www.github.com. This
+    is so you can point this at your Github Enterprise endpoint
+
+  * user, password - A username and password pair for Basic http authentication.
 email:
 - ryand-ruby@zenspider.com
 - kushali@rubyforge.org
@@ -128,7 +144,7 @@ licenses:
 - MIT
 metadata:
   homepage_uri: https://github.com/seattlerb/omnifocus-github
-post_install_message: 
+post_install_message:
 rdoc_options:
 - "--main"
 - README.rdoc
@@ -145,8 +161,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
-signing_key: 
+rubygems_version: 3.3.12
+signing_key:
 specification_version: 4
 summary: Plugin for omnifocus gem to provide github BTS synchronization
 test_files: []