omnifocus-github 1.4.1 → 1.5.0

data/History.txt

@@ -1,3 +1,15 @@
+=== 1.5.0 / 2013-05-10
+
+* 1 major enhancement:
+
+  * Remove support for github api tokens (no longer supported by github)
+
+* 3 bug fixes:
+
+  * add user-agent to api requests (required by github)
+  * display error message if trying to authenticate without user/pass
+  * remove debugging output
+
 === 1.4.1 / 2013-04-09
 
 * 1 bug fix:

data/lib/omnifocus/github.rb

@@ -2,7 +2,7 @@ require 'open-uri'
 require 'json'
 
 module OmniFocus::Github
-  VERSION = "1.4.1"
+  VERSION = "1.5.0"
   PREFIX  = "GH"
 
   GH_API_DEFAULT = "https://api.github.com"
@@ -10,14 +10,13 @@ module OmniFocus::Github
   def populate_github_tasks
     omnifocus_git_param(:accounts, "github").split(/\s+/).each do |account|
       api = omnifocus_git_param(:api, GH_API_DEFAULT, account)
-      # Either token or user + password is required. If both
-      # are present, token is used.
+      # User + password is required
       auth = {
         :user => omnifocus_git_param(:user, nil, account),
         :password => omnifocus_git_param(:password, nil, account),
         :token => omnifocus_git_param(:token, nil, account),
       }
-      unless auth[:token] || (auth[:user] && auth[:password])
+      unless (auth[:user] && auth[:password])
         warn "Missing authentication parameters for account #{account}."
         next
       end
@@ -42,13 +41,18 @@ module OmniFocus::Github
 
   def fetch api, auth, page
     uri = URI.parse "#{api}/issues?page=#{page}"
-    if auth[:token]
-      uri.read "Authorization" => "token #{auth[:token]}"
-    elsif auth[:user] && auth[:password]
-      uri.read :http_basic_authentication => [auth[:user], auth[:password]]
+
+    headers = {
+      "User-Agent"=>"omnifocus-github/#{VERSION}"
+    }
+
+    if auth[:user] && auth[:password]
+      headers[:http_basic_authentication] = [auth[:user], auth[:password]]
     else
       raise ArgumentError, "Missing authentication"
     end
+
+    uri.read headers
   end
 
   def get_last body

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: omnifocus-github
 version: !ruby/object:Gem::Version 
-  hash: 5
+  hash: 3
   prerelease: 
   segments: 
   - 1
-  - 4
-  - 1
-  version: 1.4.1
+  - 5
+  - 0
+  version: 1.5.0
 platform: ruby
 authors: 
 - Ryan Davis
@@ -36,7 +36,7 @@ cert_chain:
   FBHgymkyj/AOSqKRIpXPhjC6
   -----END CERTIFICATE-----
 
-date: 2013-04-09 00:00:00 Z
+date: 2013-05-10 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: omnifocus
@@ -76,11 +76,11 @@ dependencies:
     requirements: 
     - - ~>
       - !ruby/object:Gem::Version 
-        hash: 21
+        hash: 31
         segments: 
-        - 4
-        - 7
-        version: "4.7"
+        - 5
+        - 0
+        version: "5.0"
   type: :development
   version_requirements: *id003
 - !ruby/object:Gem::Dependency 
@@ -91,11 +91,11 @@ dependencies:
     requirements: 
     - - ~>
       - !ruby/object:Gem::Version 
-        hash: 19
+        hash: 27
         segments: 
-        - 3
-        - 10
-        version: "3.10"
+        - 4
+        - 0
+        version: "4.0"
   type: :development
   version_requirements: *id004
 - !ruby/object:Gem::Dependency 
@@ -106,11 +106,11 @@ dependencies:
     requirements: 
     - - ~>
       - !ruby/object:Gem::Version 
-        hash: 13
+        hash: 11
         segments: 
         - 3
-        - 5
-        version: "3.5"
+        - 6
+        version: "3.6"
   type: :development
   version_requirements: *id005
 description: |-