omnicontacts 0.1.6 → 0.1.7

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    omnicontacts (0.1.6)
+    omnicontacts (0.1.7)
       json
       rack
 

data/lib/omnicontacts.rb

@@ -1,6 +1,6 @@
 module OmniContacts
 
-  VERSION = "0.1.6"
+  VERSION = "0.1.7"
 
   autoload :Builder, "omnicontacts/builder"
   autoload :Importer, "omnicontacts/importer"

data/lib/omnicontacts/importer/gmail.rb

@@ -41,7 +41,8 @@ module OmniContacts
             contact = {:email => gd_email.attributes['address']}
             gd_name = entry.elements['gd:name']
             if gd_name
-              contact[:name] = gd_name.elements['gd:fullName'].text
+              gd_full_name = gd_name.elements['gd:fullName']
+              contact[:name] = gd_full_name.text if gd_full_name
             end
             contacts << contact
           end

data/spec/omnicontacts/importer/gmail_spec.rb

@@ -14,6 +14,13 @@ describe OmniContacts::Importer::Gmail do
      </entry>"
   }
 
+  let(:contact_without_fullname) {
+    "<entry xmlns:gd='http://schemas.google.com/g/2005'>
+       <gd:name/>
+       <gd:email rel='http://schemas.google.com/g/2005#work' primary='true' address='bennet@gmail.com'/>
+     </entry>"
+  }
+
   describe "fetch_contacts_using_access_token" do
 
     let(:token) { "token" }
@@ -36,5 +43,13 @@ describe OmniContacts::Importer::Gmail do
       result.first[:email].should eq("bennet@gmail.com")
     end
 
+    it "should handle contact without fullname" do
+      gmail.should_receive(:https_get).and_return(contact_without_fullname)
+      result = gmail.fetch_contacts_using_access_token token, token_type
+      result.size.should be(1)
+      result.first[:name].should be_nil
+      result.first[:email].should eq("bennet@gmail.com")
+    end
+
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: omnicontacts
 version: !ruby/object:Gem::Version
-  version: 0.1.6
+  version: 0.1.7
   prerelease: 
 platform: ruby
 authors: