omniauth-venmo 1.0.1 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 43c3c6a45b943b060325c3531cd415e6faf67a24
-  data.tar.gz: 6a1ffdfead99d716690ede1aa0140150bec37bd8
+  metadata.gz: e878f2af8226f539ff1e04aafc9f096995c0da30
+  data.tar.gz: 78ef250218274c9a7ed34b53fc5d72c761435d88
 SHA512:
-  metadata.gz: c2ec28de14cdf3ceadbe8827508707262479242b0147f77095fdd2beb380a8e7c96714ff3c1614e6b5e09157ec608101f154a9e37cd43854eeb81ea68d300030
-  data.tar.gz: 11937b054a35d26978812e810abf53b6d440f018fc59f1b51ca866ae52b1a5e43ec74ba2eed12132db9041531d2020a574e70894ad423eb23e81a9fdfd922be4
+  metadata.gz: 22748e2880421099571ab560bbce758eb2e2932cb9d43ca361f321e70f1348b5f6ff73cc43d7ef28b029258b1b5eee8cad8c7c2c4c55de3ac963711a49940200
+  data.tar.gz: 84a76513ddef0df5153ff65ac35588fb8673daed8585955d624bee2f77f0bbf89dceccae553bfba19ed8189470e4721d1c121ee50a74ed92b1e2aaba0f514541

data/.rubocop.yml

@@ -0,0 +1,80 @@
+AllCops:
+  Include:
+    - 'Gemfile'
+    - 'Rakefile'
+    - 'omniauth-venmo.gemspec'
+  Exclude:
+    - 'lib/omniauth-venmo.rb'
+
+# Avoid long parameter lists
+ParameterLists:
+  Max: 4
+  CountKeywordArgs: true
+
+MethodLength:
+  CountComments: false
+  Max: 14
+
+# Avoid more than `Max` levels of nesting.
+BlockNesting:
+  Max: 2
+
+# Align with the style guide.
+CollectionMethods:
+  PreferredMethods:
+    map:      'collect'
+    reduce:   'inject'
+    find:     'detect'
+    find_all: 'select'
+
+# Limit line length
+LineLength:
+  Enabled: false
+
+# Disable documentation checking until a class needs to be documented once
+Documentation:
+  Enabled: false
+
+# Enforce Ruby 1.8-compatible hash syntax
+HashSyntax:
+  EnforcedStyle: hash_rockets
+
+# No spaces inside hash literals
+SpaceInsideHashLiteralBraces:
+  EnforcedStyle: no_space
+
+# Allow dots at the end of lines
+DotPosition:
+  Enabled: false
+
+# Don't require magic comment at the top of every file
+Encoding:
+  Enabled: false
+
+# Enforce outdenting of access modifiers (i.e. public, private, protected)
+AccessModifierIndentation:
+  EnforcedStyle: outdent
+
+EmptyLinesAroundAccessModifier:
+  Enabled: true
+
+# Align ends correctly
+EndAlignment:
+  AlignWith: variable
+
+# Indentation of when/else
+CaseIndentation:
+  IndentWhenRelativeTo: end
+  IndentOneStep: false
+
+Lambda:
+  Enabled: false
+
+HandleExceptions:
+  Enabled: false
+
+RaiseArgs:
+  EnforcedStyle: compact
+
+TrailingComma:
+  Enabled: false

data/.travis.yml

@@ -3,11 +3,15 @@ gemfile:
   - Gemfile
 language: ruby
 rvm:
-  - rbx-18mode
-  - rbx-19mode
-  - jruby-18mode
-  - jruby-19mode
-  - 1.8.7
   - 1.9.2
   - 1.9.3
   - 2.0.0
+  - 2.1.0
+  - rbx-2
+  - ruby-head
+  - jruby-19mode
+  - jruby-head
+matrix:
+  allow_failures:
+    - rvm: jruby-head
+    - rvm: ruby-head

data/Gemfile

@@ -2,6 +2,10 @@ source 'https://rubygems.org'
 
 gem 'rake'
 
+group :development do
+  gem 'rubocop'
+end
+
 group :test do
   gem 'coveralls', :require => false
   gem 'rack-test'

data/README.md

@@ -6,7 +6,7 @@ omniauth-venmo
 
 Venmo OAuth2 Strategy for OmniAuth 1.x and supports the OAuth 2.0 server-side flow.
 
-*Venmo API docs are currently in the works and will be released upon completion.*
+You may view the Venmo API documentation [here](https://developer.venmo.com/docs/oauth).
 
 ## Installation
 
@@ -35,7 +35,7 @@ end
 
 Currently, there is only one configuration option that needs to be set:
 
-* `scope`: A comma-separated list of permissions you want to request from the user. The available permissions are as follows: `access_feed`, `access_profile`, `access_friends`, and `make_payments`.  Default: `access_profile`
+* `scope`: A comma-separated list of permissions you want to request from the user. The available permissions are as follows: `access_email`, `access_phone`, `access_balance`, `access_feed`, `access_profile`, `access_friends`, and `make_payments`.  Default: `access_profile`
 
 ```ruby
 Rails.application.config.middleware.use OmniAuth::Builder do
@@ -83,6 +83,26 @@ Here's an example *Auth Hash* available in `request.env['omniauth.auth']`:
 }
 ```
 
+## Supported Ruby Versions
+`omniauth-venmo` is tested under 1.8.7, 1.9.2, 1.9.3, 2.0.0, JRuby (1.8 mode), and Rubinius
+(1.8 and 1.9 modes).
+
+## Versioning
+This library aims to adhere to [Semantic Versioning 2.0.0][semver]. Violations
+of this scheme should be reported as bugs. Specifically, if a minor or patch
+version is released that breaks backward compatibility, that version should be
+immediately yanked and/or a new version should be immediately released that
+restores compatibility. Breaking changes to the public API will only be
+introduced with new major versions. As a result of this policy, you can (and
+should) specify a dependency on this gem using the [Pessimistic Version
+Constraint][pvc] with two digits of precision. For example:
+
+    spec.add_dependency 'omniauth-venmo', '~> 1.0'
+
+[semver]: http://semver.org/
+[pvc]: http://docs.rubygems.org/read/chapter/16#page74
+
+
 ## License
 
 Copyright (c) 2013 by Tom Milewski

data/Rakefile

@@ -1,9 +1,9 @@
 #!/usr/bin/env rake
-require "bundler/gem_tasks"
+require 'bundler/gem_tasks'
 require 'rspec/core/rake_task'
 
 desc 'Default: run specs.'
 task :default => :spec
 
-desc "Run specs"
-RSpec::Core::RakeTask.new
+desc 'Run specs'
+RSpec::Core::RakeTask.new

data/lib/omniauth/strategies/venmo.rb

@@ -6,16 +6,14 @@ module OmniAuth
       DEFAULT_SCOPE = 'access_profile'
 
       option :provider_ignores_state, true
-      option :client_options, {
-        :site               => 'https://api.venmo.com',
-        :authorize_url      => '/oauth/authorize',
-        :token_url          => '/oauth/access_token'
-      }
+      option :client_options, :site          => 'https://api.venmo.com/v1',
+                              :authorize_url => '/oauth/authorize',
+                              :token_url     => '/oauth/access_token'
 
       uid { raw_info['id'] }
 
       info do
-        prune!({
+        prune!(
           'username'    => raw_info['username'],
           'email'       => raw_info['email'],
           'phone'       => raw_info['phone'],
@@ -27,7 +25,7 @@ module OmniAuth
           'urls'        => {
             'profile'   => "https://venmo.com/#{raw_info['username']}"
           }
-        })
+        )
       end
 
       extra do
@@ -50,7 +48,7 @@ module OmniAuth
         super
       end
 
-      private
+    private
 
       def prune!(hash)
         hash.delete_if do |_, value|

data/lib/omniauth/venmo/version.rb

@@ -1,5 +1,5 @@
 module OmniAuth
   module Venmo
-    VERSION = "1.0.1"
+    VERSION = '1.1.0'
   end
 end

data/lib/omniauth-venmo.rb

@@ -1,2 +1,2 @@
 require 'omniauth/venmo/version'
-require 'omniauth/strategies/venmo'
+require 'omniauth/strategies/venmo'

data/omniauth-venmo.gemspec

@@ -1,27 +1,25 @@
 # -*- encoding: utf-8 -*-
-$:.push File.expand_path('../lib', __FILE__)
+$LOAD_PATH.push File.expand_path('../lib', __FILE__)
 require 'omniauth/venmo/version'
 
 Gem::Specification.new do |s|
-  s.name     = 'omniauth-venmo'
-  s.version  = OmniAuth::Venmo::VERSION
-  s.authors  = ['Tom Milewski']
-  s.email    = ['tmilewski@gmail.com']
-  s.summary  = 'Venmo strategy for OmniAuth'
-  s.homepage = 'https://github.com/tmilewski/omniauth-venmo'
-  s.license  = 'MIT'
+  s.name          = 'omniauth-venmo'
+  s.version       = OmniAuth::Venmo::VERSION
+  s.authors       = ['Tom Milewski']
+  s.email         = ['tmilewski@gmail.com']
+  s.summary       = 'Venmo strategy for OmniAuth'
+  s.description   = 'Venmo strategy for OmniAuth v1.2'
+  s.homepage      = 'https://github.com/tmilewski/omniauth-venmo'
+  s.license       = 'MIT'
 
   s.files         = `git ls-files`.split("\n")
   s.test_files    = `git ls-files -- {test,spec,features}/*`.split("\n")
-  s.executables   = `git ls-files -- bin/*`.split("\n").map { |f| File.basename(f) }
+  s.executables   = `git ls-files -- bin/*`.split("\n").collect { |f| File.basename(f) }
   s.require_paths = ['lib']
 
-  s.add_runtime_dependency 'omniauth'
+  s.add_runtime_dependency 'omniauth', '~> 1.2' 
   s.add_runtime_dependency 'omniauth-oauth2', '~> 1.1'
 
-  s.add_development_dependency 'dotenv'
-  s.add_development_dependency 'sinatra'
-  s.add_development_dependency 'rake'
-  s.add_development_dependency 'rspec', '~> 2.7'
-  s.add_development_dependency 'simplecov'
+  s.add_development_dependency 'dotenv', '~> 0'
+  s.add_development_dependency 'sinatra', '~> 0'
 end

data/spec/app.rb

@@ -1,5 +1,5 @@
-$:.unshift File.expand_path('..', __FILE__)
-$:.unshift File.expand_path('../../lib', __FILE__)
+$LOAD_PATH.unshift File.expand_path('..', __FILE__)
+$LOAD_PATH.unshift File.expand_path('../../lib', __FILE__)
 
 require 'dotenv'
 require 'sinatra'
@@ -8,11 +8,11 @@ require 'omniauth-venmo'
 
 Dotenv.load
 
-use Rack::Session::Cookie, key: 'key',
-                           domain: "localhost",
-                           path: '/',
-                           expire_after: 14400,
-                           secret: 'secret'
+use Rack::Session::Cookie, :key => 'key',
+                           :domain => 'localhost',
+                           :path => '/',
+                           :expire_after => 14_400,
+                           :secret => 'secret'
 
 use OmniAuth::Builder do
   provider :venmo, ENV['CLIENT_ID'], ENV['CLIENT_SECRET'], :scope => 'access_profile'
@@ -31,7 +31,7 @@ end
 get '/auth/:name/callback' do
   auth = request.env['omniauth.auth']
 
-  puts %Q{
+  puts %Q(
     >> UID
       #{auth.uid.inspect}
 
@@ -43,7 +43,7 @@ get '/auth/:name/callback' do
       #
     >> EXTRA
       #{auth.extra.inspect}
-  }
+  )
 
-  "Check logs for user information."
+  'Check logs for user information.'
 end

data/spec/omniauth/strategies/venmo_spec.rb

@@ -8,13 +8,13 @@ describe OmniAuth::Strategies::Venmo do
     end
   end
 
-  context "client options" do
+  context 'client options' do
     it 'should have correct name' do
-      expect(subject.options.name).to eq("venmo")
+      expect(subject.options.name).to eq('venmo')
     end
 
     it 'should have correct site' do
-      expect(subject.options.client_options.site).to eq('https://api.venmo.com')
+      expect(subject.options.client_options.site).to eq('https://api.venmo.com/v1')
     end
 
     it 'should have correct authorize url' do
@@ -30,37 +30,37 @@ describe OmniAuth::Strategies::Venmo do
     end
   end
 
-  context "#prune!" do
-    it "should remove nil values" do
+  context '#prune!' do
+    it 'should remove nil values' do
       expect(
-        subject.send(:prune!, { "a" => "b", "c" => nil })
-      ).to eq({ "a" => "b" })
+        subject.send(:prune!, 'a' => 'b', 'c' => nil)
+      ).to eq('a' => 'b')
     end
 
-    it "should remove empty values" do
+    it 'should remove empty values' do
       expect(
-        subject.send(:prune!, { "a" => "b", "c" => "" })
-      ).to eq({ "a" => "b" })
+        subject.send(:prune!, 'a' => 'b', 'c' => '')
+      ).to eq('a' => 'b')
     end
 
-    it "should remove nil values recursively" do
+    it 'should remove nil values recursively' do
       expect(
-        subject.send(:prune!, { "a" => "b", "c" => { "d" => nil} })
-      ).to eq({ "a" => "b" })
+        subject.send(:prune!, 'a' => 'b', 'c' => {'d' => nil})
+      ).to eq('a' => 'b')
 
       expect(
-        subject.send(:prune!, { "a" => "b", "c" => { "d" => nil, "e" => "f"} })
-      ).to eq({ "a" => "b", "c" => {"e" => "f"} })
+        subject.send(:prune!, 'a' => 'b', 'c' => {'d' => nil, 'e' => 'f'})
+      ).to eq('a' => 'b', 'c' => {'e' => 'f'})
     end
 
-    it "should remove empty values recursively" do
+    it 'should remove empty values recursively' do
       expect(
-        subject.send(:prune!, { "a" => "b", "c" => { "d" => ""} })
-      ).to eq({ "a" => "b" })
+        subject.send(:prune!, 'a' => 'b', 'c' => {'d' => ''})
+      ).to eq('a' => 'b')
 
       expect(
-        subject.send(:prune!, { "a" => "b", "c" => { "d" => "", "e" => "f"} })
-      ).to eq({ "a" => "b", "c" => {"e" => "f"} })
+        subject.send(:prune!, 'a' => 'b', 'c' => {'d' => '', 'e' => 'f'})
+      ).to eq('a' => 'b', 'c' => {'e' => 'f'})
     end
   end
 end

data/spec/spec_helper.rb

@@ -1,5 +1,5 @@
-$:.unshift File.expand_path('..', __FILE__)
-$:.unshift File.expand_path('../../lib', __FILE__)
+$LOAD_PATH.unshift File.expand_path('..', __FILE__)
+$LOAD_PATH.unshift File.expand_path('../../lib', __FILE__)
 
 require 'rspec'
 require 'simplecov'
@@ -9,5 +9,5 @@ require 'omniauth'
 require 'omniauth-venmo'
 
 RSpec.configure do |config|
-  config.extend  OmniAuth::Test::StrategyMacros, :type => :strategy
+  config.extend OmniAuth::Test::StrategyMacros, :type => :strategy
 end

metadata

@@ -1,122 +1,81 @@
 --- !ruby/object:Gem::Specification
 name: omniauth-venmo
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.1.0
 platform: ruby
 authors:
 - Tom Milewski
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-10-10 00:00:00.000000000 Z
+date: 2014-05-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: omniauth
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.2'
 - !ruby/object:Gem::Dependency
   name: omniauth-oauth2
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.1'
 - !ruby/object:Gem::Dependency
   name: dotenv
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: sinatra
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: rake
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: rspec
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: '2.7'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: '2.7'
-- !ruby/object:Gem::Dependency
-  name: simplecov
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - '>='
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '0'
-description: 
+description: Venmo strategy for OmniAuth v1.2
 email:
 - tmilewski@gmail.com
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
-- .travis.yml
+- ".gitignore"
+- ".rubocop.yml"
+- ".travis.yml"
 - Gemfile
 - README.md
 - Rakefile
@@ -137,17 +96,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.3
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: Venmo strategy for OmniAuth