omniauth-vatsim 0.1.5 → 0.1.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b52c390454c367f391288e009cbf53a22b159daf
-  data.tar.gz: e22e722792fc7f34270eddb2b00223847770a46f
+  metadata.gz: c26ba6c5cced00dd267e6316e190f959834db29c
+  data.tar.gz: 4e7e6a96c6a05c6db96988356ccb848ff3d2883c
 SHA512:
-  metadata.gz: 3f462f9b676eb155ae8918d4b47a924fada515bea021610ae64ce6d475328f76b7f16f3c9c0fbb45177b146bcb6a21660fba3bb1ec4abed157212cde32e15fd1
-  data.tar.gz: 2adb7e7437667337092b2cd1c6ce25435b76f1417327b247a67cddb168577a177dbd632a836df1d6592f91a8420accef5c745eb5585297894fa10cbf2a96be38
+  metadata.gz: 0f7003a65a55d0619464b21bdf703f1263973677632762ea73c412d72793897547ea1149a6fbc53dc4c4c23e59467fac3920946d5ff1b5dde64ece6a0e45d758
+  data.tar.gz: ed470ebe23b228788612b8be69d960a8bb28b0fd3ddfa5ff7a34f4d2cfc3a4f6571dc39f6854cb224e95e2fbe01cf0b498149d3a243899396f6b090d1c721828

data/README.md

@@ -34,26 +34,40 @@ gem 'omniauth-vatsim', git: 'https://github.com/jvoss/omniauth-vatsim.git'
 ```
 
 ### RSA-SHA1 (Recommended)
+#### IMPORTANT NOTE 
+An issue with OAuth-Ruby v0.5.1 requires the consumer secret to
+be set with RSA-SHA1. Unfortunately that means it must be set to the 
+contents of an unencrypted (no passphrase) private key file! In my examples
+below, I suggest a way to do this in memory while still keeping a passphrase
+on the key.
+
+Specifically the issue lies [here](https://github.com/oauth-xx/oauth-ruby/blob/v0.5.1/lib/oauth/signature/rsa/sha1.rb) 
+at line 37. It does not matter if a private key is specified in the consumer, it 
+always will instantiate a new private key object.
 
 For a Rails application, create an initializer ```config/initializers/omniauth.rb```:
 
 ```ruby
 Rails.application.config.middleware.use OmniAuth::Builder do
-  provider :vatsim, 'app_id', nil, 
+  private_key = OpenSSL::PKey::RSA.new(IO.read('<PRIVATE KEY FILENAME>'), ENV['key_passphrase'])
+
+  provider :vatsim, 'Consumer Key', private_key.to_pem, 
      site: 'https://cert.vatsim.net/sso',
      signature_method: 'RSA-SHA1',
-     private_key: OpenSSL::PKey::RSA.new(IO.read('<PRIVATE KEY FILENAME>'), ENV['key_passphrase'])
+     private_key: private_key
 end
 ```
 
 For a Rails application using [Devise](https://github.com/plataformatec/devise), modify ```config/initializers/devise.rb```:
 
 ```ruby
-config.omniauth :vatsim, 'app_id', nil, 
+private_key = OpenSSL::PKey::RSA.new(IO.read('<PRIVATE KEY FILENAME>'), ENV['key_passphrase'])
+
+config.omniauth :vatsim, 'Consumer Key', private_key, 
   client_options: {
     site: 'https://cert.vatsim.net/sso',
     signature_method: 'RSA-SHA1',
-    private_key: OpenSSL::PKey::RSA.new(IO.read('<PRIVATE KEY FILENAME>'), ENV['key_passphrase'])
+    private_key: private_key
   }
 ```
 
@@ -61,11 +75,14 @@ For Sinatra you would add:
 
 ```ruby
 use Rack::Session::Cookie
+
+private_key = OpenSSL::PKey::RSA.new(IO.read('<PRIVATE KEY FILENAME>'), ENV['key_passphrase'])
+
 use OmniAuth::Builder do
-  provider :vatsim, 'api_id', nil, 
+  provider :vatsim, 'Consumer Key', private_key, 
     site: 'https://cert.vatsim.net/sso'
     signature_method: 'RSA-SHA1',
-    private_key: OpenSSL::PKey::RSA.new(IO.read('<PRIVATE KEY FILENAME>'), ENV['key_passphrase'])
+    private_key: private_key
 end
 ```
 
@@ -75,14 +92,14 @@ For a Rails application, create an initializer ```config/initializers/omniauth.r
 
 ```ruby
 Rails.application.config.middleware.use OmniAuth::Builder do
-  provider :vatsim, 'app_id', 'app_secret', site: 'https://cert.vatsim.net/sso'
+  provider :vatsim, 'Consumer Key', 'Consumer Secret', site: 'https://cert.vatsim.net/sso'
 end
 ```
 
 For a Rails application using [Devise](https://github.com/plataformatec/devise), modify ```config/initializers/devise.rb```:
 
 ```ruby
-config.omniauth :vatsim, 'app_id', 'app_secret', client_options: {site: 'https://cert.vatsim.net/sso'}
+config.omniauth :vatsim, 'Consumer Key', 'Consumer Secret', client_options: {site: 'https://cert.vatsim.net/sso'}
 ```
 
 For Sinatra you would add:
@@ -90,7 +107,7 @@ For Sinatra you would add:
 ```ruby
 use Rack::Session::Cookie
 use OmniAuth::Builder do
-  provider :vatsim, 'api_id', 'api_secret', site: 'https://cert.vatsim.net/sso'
+  provider :vatsim, 'Consumer Key', 'Consumer Secret', site: 'https://cert.vatsim.net/sso'
 end
 ```
 

data/lib/omniauth-vatsim/version.rb

@@ -1,5 +1,5 @@
 module Omniauth
   module Vatsim
-    VERSION = "0.1.5"
+    VERSION = "0.1.6"
   end
 end

data/lib/omniauth/strategies/vatsim.rb

@@ -8,6 +8,7 @@ module OmniAuth
 
       option :client_options, {
         site:               'http://sso.hardern.net/server', # default to demo site
+        scheme:             :body,
         authorize_path:     '/auth/pre_login/?',
         request_token_path: '/api/login_token',
         access_token_path:  '/api/login_return',

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: omniauth-vatsim
 version: !ruby/object:Gem::Version
-  version: 0.1.5
+  version: 0.1.6
 platform: ruby
 authors:
 - Jonathan P. Voss
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-04-08 00:00:00.000000000 Z
+date: 2017-04-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: multi_json