omniauth-twitter 1.0.1 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9e6626f2d76da338cfcc7a60eb7881276193d59f
-  data.tar.gz: 5a4b555f23c9bff6d3947d485d18b8f85ce9392f
+  metadata.gz: edfaab177e44aa04f7cfd4fa8068b019c76fbfe4
+  data.tar.gz: cfdf961107d830fd2e695c3a3970f934d0150fb6
 SHA512:
-  metadata.gz: 35bced171375fac4f94231679e3707afbba5912a672cb284a30cc82f796736b2e67f32ee9fdbccfa8b41c2ad53f0e4f0e88a2ca9cd42aa787c13e0574da6a515
-  data.tar.gz: 813b9096c7ed44a87530a4a7bdb162040809f4a4711baf5cd2cbab3af0ff16d09d5cdd5fdf1593627dfb40ebee6d004e5df64f3572cf1ecd62c7aed910b88a30
+  metadata.gz: 3c76675fc707da726fc34f00f7369856a39886668fe8e8627b9c8cb228136fdb3bcad02035ae911991f0bc7de3f5d8a84e3aa4810ffd8bef01a8743a6c360422
+  data.tar.gz: 84303d1f90d44ae137e70a1f5da8fdcdb82e3bcb258815f4723dd745ab6b7b3a4fee839d94fe0d39c84e972de870bde7690b3752fe51a1cc9f8fd72190144084

data/.travis.yml

@@ -1,6 +1,6 @@
 rvm:
-  - 1.8.7
-  - 1.9.2
   - 1.9.3
-  - ree
+  - 2.0.0
+  - 2.1.0
   - jruby
+  - rbx-2

data/CONTRIBUTING.md

@@ -0,0 +1,40 @@
+# Contributing
+
+For the best chance of having your changes merged, please:
+
+* Fork the project.
+
+* Make your feature addition or bug fix.
+
+* Add tests for it. This is important so it is not accidentally broken in a future version.
+
+* Commit, do not mess with rakefile, version, or history. (If you want to have your own version, that is fine but bump version in a commit by itself so it can be ignored when pulled).
+
+* Send a pull request. Bonus points for topic branches.
+
+If your proposed changes only affect documentation, include the following on a
+new line in each of your commit messages:
+
+```
+[ci skip]
+```
+
+This will signal [Travis](https://travis-ci.org) that running the test suite is
+not necessary for these changes.
+
+# Reporting Bugs
+
+If you are experiencing unexpected behavior and, after having read [omniauth](https://github.com/intridea/omniauth) and [omniauth-twitter](https://github.com/arunagw/omniauth-twitter)'s documentation, are convinced this behavior is a bug, please:
+
+1. [Search](https://github.com/arunagw/omniauth-twitter/issues) existing issues.
+2. Collect enough information to reproduce the issue:
+
+  * omniauth-twitter version
+
+  * Ruby version
+
+  * Specific setup conditions
+
+  * Description of expected behavior
+
+  * Description of actual behavior

data/README.md

@@ -1,16 +1,20 @@
 # OmniAuth Twitter
 
+[![Gem Version](https://badge.fury.io/rb/omniauth-twitter.svg)](http://badge.fury.io/rb/omniauth-twitter)
+[![CI Build Status](https://secure.travis-ci.org/arunagw/omniauth-twitter.svg?branch=master)](http://travis-ci.org/arunagw/omniauth-twitter)
+[![Code Climate](https://codeclimate.com/github/arunagw/omniauth-twitter.png)](https://codeclimate.com/github/arunagw/omniauth-twitter)
+
 This gem contains the Twitter strategy for OmniAuth.
 
 Twitter offers a few different methods of integration. This strategy implements the browser variant of the "[Sign in with Twitter](https://dev.twitter.com/docs/auth/implementing-sign-twitter)" flow.
 
-Twitter uses OAuth 1.0a. Twitter's developer area contains ample documentation on how it implements this, so if you are really interested in the details, go check that out for more.
+Twitter uses OAuth 1.0a. Twitter's developer area contains ample documentation on how it implements this, so check that out if you are really interested in the details.
 
 ## Before You Begin
 
 You should have already installed OmniAuth into your app; if not, read the [OmniAuth README](https://github.com/intridea/omniauth) to get started.
 
-Now sign in into the [Twitter developer area](http://dev.twitter.com) and create an application. Take note of your Consumer Key and Consumer Secret (not the Access Token and Secret) because that is what your web application will use to authenticate against the Twitter API. Make sure to set a callback URL or else you may get authentication errors. (It doesn't matter what it is, just that it is set.)
+Now sign in into the [Twitter developer area](https://dev.twitter.com) and create an application. Take note of your API Key and API Secret (not the Access Token and Access Token Secret) because that is what your web application will use to authenticate against the Twitter API. Make sure to set a callback URL or else you may get authentication errors. (It doesn't matter what it is, just that it is set.)
 
 ## Using This Strategy
 
@@ -30,11 +34,11 @@ Next, tell OmniAuth about this provider. For a Rails app, your `config/initializ
 
 ```ruby
 Rails.application.config.middleware.use OmniAuth::Builder do
-  provider :twitter, "CONSUMER_KEY", "CONSUMER_SECRET"
+  provider :twitter, "API_KEY", "API_SECRET"
 end
 ```
 
-Replace CONSUMER_KEY and CONSUMER_SECRET with the appropriate values you obtained from dev.twitter.com earlier.
+Replace `"API_KEY"` and `"API_SECRET"` with the appropriate values you obtained [earlier](https://apps.twitter.com).
 
 ## Authentication Options
 
@@ -60,7 +64,7 @@ Here's an example of a possible configuration where the the user's original prof
 
 ```ruby
 Rails.application.config.middleware.use OmniAuth::Builder do
-  provider :twitter, ENV["TWITTER_KEY"], ENV["TWITTER_SECRET"],
+  provider :twitter, "API_KEY", "API_SECRET",
     {
       :secure_image_url => 'true',
       :image_size => 'original',
@@ -98,8 +102,8 @@ An example auth hash available in `request.env['omniauth.auth']`:
     :access_token => "", # An OAuth::AccessToken object
     :raw_info => {
       :name => "John Q Public",
-      :listed_count" => 0,
-      :profile_sidebar_border_color" => "181A1E",
+      :listed_count => 0,
+      :profile_sidebar_border_color => "181A1E",
       :url => nil,
       :lang => "en",
       :statuses_count => 129,
@@ -152,18 +156,11 @@ Ryan Bates has put together an excellent RailsCast on OmniAuth:
 
 ## Supported Rubies
 
-OmniAuth Twitter is tested under 1.8.7, 1.9.2, 1.9.3 and Ruby Enterprise Edition.
-
-[![CI Build
-Status](https://secure.travis-ci.org/arunagw/omniauth-twitter.png)](http://travis-ci.org/arunagw/omniauth-twitter)
+OmniAuth Twitter is tested under 1.9.3, 2.0.0, 2.1.0, JRuby, and Rubinius.
 
-## Note on Patches/Pull Requests
+## Contributing
 
-- Fork the project.
-- Make your feature addition or bug fix.
-- Add tests for it. This is important so I don’t break it in a future version unintentionally.
-- Commit, do not mess with rakefile, version, or history. (if you want to have your own version, that is fine but bump version in a commit by itself I can ignore when I pull)
-- Send me a pull request. Bonus points for topic branches.
+Please read the [contribution guidelines](CONTRIBUTING.md) for some information on how to get started. No contribution is too small.
 
 ## License
 

data/lib/omniauth-twitter/version.rb

@@ -1,5 +1,5 @@
 module OmniAuth
   module Twitter
-    VERSION = "1.0.1"
+    VERSION = "1.1.0"
   end
 end

data/lib/omniauth/strategies/twitter.rb

@@ -51,7 +51,7 @@ module OmniAuth
           end
         end
 
-        if request.params['use_authorize'] == 'true'
+        if options[:use_authorize] || request.params['use_authorize'] == 'true'
           options[:client_options][:authorize_path] = '/oauth/authorize'
         else
           options[:client_options][:authorize_path] = '/oauth/authenticate'

data/spec/omniauth/strategies/twitter_spec.rb

@@ -6,7 +6,7 @@ describe OmniAuth::Strategies::Twitter do
   subject do
     args = ['appid', 'secret', @options || {}].compact
     OmniAuth::Strategies::Twitter.new(*args).tap do |strategy|
-      strategy.stub(:request) {
+      allow(strategy).to receive(:request) {
         request
       }
     end
@@ -30,7 +30,7 @@ describe OmniAuth::Strategies::Twitter do
     context 'when user has an image' do
       it 'should return image with size specified' do
         @options = { :image_size => 'original' }
-        subject.stub(:raw_info).and_return(
+        allow(subject).to receive(:raw_info).and_return(
           { 'profile_image_url' => 'http://twimg0-a.akamaihd.net/sticky/default_profile_images/default_profile_0_normal.png' }
         )
         expect(subject.info[:image]).to eq('http://twimg0-a.akamaihd.net/sticky/default_profile_images/default_profile_0.png')
@@ -38,14 +38,14 @@ describe OmniAuth::Strategies::Twitter do
 
       it 'should return secure image with size specified' do
         @options = { :secure_image_url => 'true', :image_size => 'mini' }
-        subject.stub(:raw_info).and_return(
+        allow(subject).to receive(:raw_info).and_return(
           { 'profile_image_url_https' => 'https://twimg0-a.akamaihd.net/sticky/default_profile_images/default_profile_0_normal.png' }
         )
         expect(subject.info[:image]).to eq('https://twimg0-a.akamaihd.net/sticky/default_profile_images/default_profile_0_mini.png')
       end
 
       it 'should return normal image by default' do
-        subject.stub(:raw_info).and_return(
+        allow(subject).to receive(:raw_info).and_return(
           { 'profile_image_url' => 'http://twimg0-a.akamaihd.net/sticky/default_profile_images/default_profile_0_normal.png' }
         )
         expect(subject.info[:image]).to eq('http://twimg0-a.akamaihd.net/sticky/default_profile_images/default_profile_0_normal.png')
@@ -56,15 +56,29 @@ describe OmniAuth::Strategies::Twitter do
   describe 'request_phase' do
     context 'with no request params set and x_auth_access_type specified' do
       before do
-        subject.stub(:request).and_return(
+        allow(subject).to receive(:request).and_return(
           double('Request', {:params => {'x_auth_access_type' => 'read'}})
         )
-        subject.stub(:old_request_phase).and_return(:whatever)
+        allow(subject).to receive(:old_request_phase).and_return(:whatever)
       end
 
       it 'should not break' do
         expect { subject.request_phase }.not_to raise_error
       end
     end
+
+    context "with no request params set and use_authorize options provided" do
+      before do
+        @options = { :use_authorize => true }
+        subject.stub(:request).and_return(
+          double('Request', {:params => {}})
+        )
+        subject.stub(:old_request_phase).and_return(:whatever)
+      end
+
+      it "should switch authorize_path from authenticate to authorize" do
+        expect { subject.request_phase }.to change { subject.options.client_options.authorize_path }.from('/oauth/authenticate').to('/oauth/authorize')
+      end
+    end
   end
 end

metadata

@@ -1,97 +1,97 @@
 --- !ruby/object:Gem::Specification
 name: omniauth-twitter
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.1.0
 platform: ruby
 authors:
 - Arun Agrawal
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-10-04 00:00:00.000000000 Z
+date: 2014-10-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: multi_json
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.3'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.3'
 - !ruby/object:Gem::Dependency
   name: omniauth-oauth
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '2.7'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '2.7'
 - !ruby/object:Gem::Dependency
   name: rack-test
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: webmock
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 description: OmniAuth strategy for Twitter
@@ -101,9 +101,10 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
-- .rspec
-- .travis.yml
+- ".gitignore"
+- ".rspec"
+- ".travis.yml"
+- CONTRIBUTING.md
 - Gemfile
 - README.md
 - Rakefile
@@ -123,17 +124,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: omniauth-twitter
-rubygems_version: 2.0.6
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: OmniAuth strategy for Twitter