omniauth-service-now 1.0.0 → 2.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5cdf084cebc8eee55da8b756f621878b99894f6f0f52ef7f86f5c86e5f55329d
-  data.tar.gz: eb96020d43a8153607e3485db33b832582292d2b1edbe0c216c9df7b58ff06ae
+  metadata.gz: 401a619d8073b6e676320fa1ceed5e40234298a7fbd61c728e41a7bcec1b3921
+  data.tar.gz: 751f89bdcfadfad10faa316d23ffb9e48aacab36f966684e2babd92a58231fb0
 SHA512:
-  metadata.gz: d9e739d187c57a94646eb5e44e22ae608d13b23e0019173489f8280be260d4abd70b76e6ca13ed2cc65e3e6976990c4b60a81ddc6884357c305f6e1b260d3138
-  data.tar.gz: b73725010c6e36e1e7990dd5ecc030eed329da92123d70efd05181ff7e3fa653eb16c4968d3329b1cf8f804fbad5f6006e0db8ad0448cbde99914b03f701d59a
+  metadata.gz: 71b37df009b18ff5c8f0636bede9d2faaabc32619fd871d5fca0623bd5fb2f907684a0716e276c4ea6a1e3d7ea4e7c442903addb2e5ec7afe5d875aeb0435520
+  data.tar.gz: 0d0a051bcaf2015e6575be793aeef78fd958b00faf547f20476fe180ea4d59d11a7134ed1ad7a6fc44086e11d42281dc3d1e8665a56cf5f343f186aa27a151be

data/.github/workflows/ruby.yml

@@ -7,12 +7,12 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        ruby-version: ["2.4", "2.5", "2.6", "2.7"]
+        ruby-version: ["3.0", "3.1", "3.2", "3.3"]
 
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
       - name: Set up Ruby ${{ matrix.ruby-version }}
-        uses: actions/setup-ruby@v1
+        uses: ruby/setup-ruby@v1
         with:
           ruby-version: ${{ matrix.ruby-version }}
       - name: Build and test with Rake

data/.gitignore

@@ -15,3 +15,5 @@ spec/reports
 test/tmp
 test/version_tmp
 tmp
+.ruby-version
+.DS_Store

data/lib/omniauth/strategies/service_now.rb

@@ -78,7 +78,7 @@ module OmniAuth
       end
 
       def callback_url
-        full_host + script_name + callback_path
+        options.redirect_url || (full_host + callback_path)
       end
     end
   end

data/lib/omniauth-service-now/version.rb

@@ -1,5 +1,5 @@
 module OmniAuth
   module ServiceNow
-    VERSION = "1.0.0"
+    VERSION = "2.0.0"
   end
 end

data/omniauth-service-now.gemspec

@@ -16,7 +16,9 @@ Gem::Specification.new do |gem|
   gem.require_paths = ["lib"]
   gem.version       = OmniAuth::ServiceNow::VERSION
 
-  gem.add_dependency 'omniauth', '~> 1.5'
+  gem.required_ruby_version = ">= 3"
+
+  gem.add_dependency 'omniauth', '~> 2.0.0'
   gem.add_dependency 'omniauth-oauth2', '>= 1.4.0', '< 2.0'
   gem.add_development_dependency 'rspec', '~> 3.5'
   gem.add_development_dependency 'rack-test'

data/spec/omniauth/strategies/service_now_spec.rb

@@ -55,4 +55,26 @@ describe OmniAuth::Strategies::ServiceNow do
       end
     end
   end
+
+  describe '#callback_url' do
+    let(:base_url) { 'https://example.com' }
+
+    context 'no script name present' do
+      it 'has the correct default callback path' do
+        allow(subject).to receive(:full_host) { base_url }
+        allow(subject).to receive(:script_name) { '' }
+        allow(subject).to receive(:query_string) { '' }
+        expect(subject.callback_url).to eq(base_url + '/auth/service_now/callback')
+      end
+    end
+
+    context 'script name' do
+      it 'should set the callback path with script_name' do
+        allow(subject).to receive(:full_host) { base_url }
+        allow(subject).to receive(:script_name) { '/v1' }
+        allow(subject).to receive(:query_string) { '' }
+        expect(subject.callback_url).to eq(base_url + '/v1/auth/service_now/callback')
+      end
+    end
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: omniauth-service-now
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 2.0.0
 platform: ruby
 authors:
 - Quentin Rousseau
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-01-16 00:00:00.000000000 Z
+date: 2024-01-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: omniauth
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.5'
+        version: 2.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.5'
+        version: 2.0.0
 - !ruby/object:Gem::Dependency
   name: omniauth-oauth2
   requirement: !ruby/object:Gem::Requirement
@@ -125,7 +125,7 @@ homepage: https://github.com/kwent/omniauth-service-now
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -133,15 +133,15 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: '3'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
-signing_key: 
+rubygems_version: 3.5.3
+signing_key:
 specification_version: 4
 summary: Official OmniAuth strategy for ServiceNow.
 test_files: