omniauth-seb-elink 0.1.0 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 3efafa13a897a9b344b1d6032da283ea33e9bce5
-  data.tar.gz: 37aa6f644100676823f02d7e59753a6a1bc4290d
+SHA256:
+  metadata.gz: 63a20636eaafeaada769b4139cd32f70e9f70282a44723a25afdf7ffd8e48867
+  data.tar.gz: 0d5805ec85c00c201200d7920c7b2e56f906448751c30968984c3afabd7416b9
 SHA512:
-  metadata.gz: 5f80b64234ab5cfeab0be8075622b3113b01850053318d0dbfa78c7cc3352128df4dec80b6928ef05f418951d369e3937109ad73e511253cf20bbd85f2d4f39b
-  data.tar.gz: cdd90b142b2d0787aa5e6218814af2c00794e620f951a3369233efdfc2482e966b179e5ed8b161f66eedd0d15aa8d4817d0c9928861112a643f3b5cebcb9f4c3
+  metadata.gz: 37c8bf6ed5de4b3c5a9dc2de79c1c313e43bdcaf003f060971f92e623e7ecb8e93f27602dbbc95100f14828053c5b4afa2857dec70657ddad0dbb9823204d0a3
+  data.tar.gz: fc2c7d8e22926dbad0f7b427e6532a4b299b727f1b96cca51189973d243e8e9d26c73e38312c55a989ca38dd035b7b1547c2a9c994cf2da2a2db3e975507aa3f

data/.github/workflows/ruby.yml

@@ -0,0 +1,24 @@
+name: Ruby
+
+on:
+  push:
+    branches:
+      - main
+  pull_request:
+
+jobs:
+  test:
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        ruby-version: ['2.7', '3.0', '3.1', '3.2']
+
+    steps:
+    - uses: actions/checkout@v4
+    - name: Set up Ruby
+      uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: ${{ matrix.ruby-version }}
+        bundler-cache: true # runs 'bundle install' and caches installed gems automatically
+    - name: Run tests
+      run: bundle exec rspec

data/Gemfile

@@ -1,4 +1,4 @@
 source 'https://rubygems.org'
 
-# Specify your gem's dependencies in omniauth-nordea.gemspec
-gemspec
+# Specify your gem's dependencies in omniauth-seb-elink.gemspec
+gemspec

data/README.md

@@ -2,20 +2,20 @@
 
 Omniauth strategy for using SEB e-link as an authentication service provider.
 
-[![Build Status](https://travis-ci.org/mak-it/omniauth-seb-elink.svg?branch=master)](https://travis-ci.org/mak-it/omniauth-seb-elink)
-
-Supported Ruby versions: 2.2+
+Supported Ruby versions: 2.7+
 
 ## Related projects
-- [omniauth-citadele](https://github.com/mak-it/omniauth-citadele) - strategy for authenticating with Citadele
-- [omniauth-dnb](https://github.com/mak-it/omniauth-dnb) - strategy for authenticating with DNB
-- [omniauth-nordea](https://github.com/mak-it/omniauth-nordea) - strategy for authenticating with Nordea
-- [omniauth-swedbank](https://github.com/mak-it/omniauth-swedbank) - strategy for authenticating with Swedbank
+
+- [omniauth-citadele](https://github.com/mitigate-dev/omniauth-citadele) - strategy for authenticating with Citadele
+- [omniauth-dnb](https://github.com/mitigate-dev/omniauth-dnb) - strategy for authenticating with DNB
+- [omniauth-nordea](https://github.com/mitigate-dev/omniauth-nordea) - strategy for authenticating with Nordea
+- [omniauth-swedbank](https://github.com/mitigate-dev/omniauth-swedbank) - strategy for authenticating with Swedbank
 
 ## Installation
 
-Add this line to your application's Gemfile:
+Add these lines to your application's Gemfile (omniauth-rails_csrf_protection is required if using Rails):
 
+    gem 'omniauth-rails_csrf_protection'
     gem 'omniauth-seb-elink'
 
 And then execute:
@@ -24,7 +24,7 @@ And then execute:
 
 Or install it yourself as:
 
-    $ gem install omniauth-seb-elink
+    $ gem install omniauth-rails_csrf_protection omniauth-seb-elink
 
 ## Usage
 

data/lib/omniauth/seb/version.rb

@@ -1,5 +1,5 @@
 module Omniauth
   module Seb
-    VERSION = '0.1.0'
+    VERSION = '0.2.0'
   end
 end

data/lib/omniauth/strategies/seb/response.rb

@@ -22,8 +22,12 @@ module OmniAuth
           raw_str = SIGNED_KEYS.map{|k| prepend_length(@hash[k])}.join
           received_sig_str = Base64.decode64(@hash['IB_CRC'])
 
-          if !pub_key.verify(OpenSSL::Digest::SHA1.new, received_sig_str, raw_str)
-            raise ValidationError, 'Invalid signature'
+          if !pub_key.verify(OpenSSL::Digest::SHA512.new, received_sig_str, raw_str)
+            if !pub_key.verify(OpenSSL::Digest::SHA1.new, received_sig_str, raw_str)
+              raise ValidationError, 'Invalid signature'
+            else
+              OmniAuth.logger.debug('Received message with old SHA1 signature from SEB')
+            end
           end
 
           self

data/lib/omniauth/strategies/seb.rb

@@ -12,6 +12,14 @@ module OmniAuth
 
       include OmniAuth::Strategy
 
+      def self.render_nonce?
+         defined?(ActionDispatch::ContentSecurityPolicy::Request) != nil
+      end
+      if render_nonce?
+        include ActionDispatch::ContentSecurityPolicy::Request
+        delegate :get_header, :set_header, to: :request
+      end
+
       args [:public_crt, :snd_id]
 
       option :public_crt, nil
@@ -62,24 +70,49 @@ module OmniAuth
       def request_phase
         fail!(:invalid_snd_id) if options.snd_id.nil?
 
+        set_locale_from_query_param
+
         message = OmniAuth::Strategies::Seb::Message.new(
           'IB_SND_ID': options.snd_id,
           'IB_SERVICE': AUTH_SERVICE,
-          'IB_LANG': 'LAT'
+          'IB_LANG': resolve_bank_ui_language
         )
 
         # Build redirect form
         form = OmniAuth::Form.new(title: I18n.t('omniauth.seb.please_wait'), url: options.site)
 
         message.each_pair do |k,v|
-          form.html "<input type=\"hidden\" name=\"#{k}\" value=\"#{v}\" />"
+          form.html "<input type=\"hidden\" name=\"#{escape(k.to_s)}\" value=\"#{escape(v)}\" />"
         end
 
         form.button I18n.t('omniauth.seb.click_here_if_not_redirected')
+        nonce_attribute = nil
+        if self.class.render_nonce?
+          nonce_attribute = " nonce='#{escape(content_security_policy_nonce)}'"
+        end
         form.instance_variable_set('@html',
-          form.to_html.gsub('</form>', '</form><script type="text/javascript">document.forms[0].submit();</script>'))
+          form.to_html.gsub('</form>', "</form><script type=\"text/javascript\"#{nonce_attribute}>document.forms[0].submit();</script>"))
         form.to_response
       end
+
+      private
+
+      def set_locale_from_query_param
+        locale = request.params['locale']
+        I18n.locale = locale if I18n.locale_available?(locale)
+      end
+
+      def resolve_bank_ui_language
+        case I18n.locale
+        when :ru then 'RUS'
+        when :en then 'ENG'
+        else 'LAT'
+        end
+      end
+
+      def escape(html_attribute_value)
+         CGI.escapeHTML(html_attribute_value) unless html_attribute_value.nil?
+      end
     end
   end
 end

data/omniauth-seb-elink.gemspec

@@ -6,11 +6,11 @@ require 'omniauth/seb/version'
 Gem::Specification.new do |gem|
   gem.name          = 'omniauth-seb-elink'
   gem.version       = Omniauth::Seb::VERSION
-  gem.authors       = ['MAK IT']
-  gem.email         = ['admin@makit.lv']
+  gem.authors       = ['Mitigate']
+  gem.email         = ['admin@mitigate.dev']
   gem.description   = %q{OmniAuth strategy for SEB e-link}
   gem.summary       = %q{OmniAuth strategy for SEB e-link}
-  gem.homepage      = 'https://github.com/mak-it/omniauth-seb-elink'
+  gem.homepage      = 'https://github.com/mitigate-dev/omniauth-seb-elink'
   gem.license       = 'MIT'
 
   gem.files         = `git ls-files`.split($/)
@@ -18,13 +18,14 @@ Gem::Specification.new do |gem|
   gem.test_files    = gem.files.grep(%r{^(test|spec|features)/})
   gem.require_paths = ['lib']
 
-  gem.required_ruby_version = '>= 2.2.2'
+  gem.required_ruby_version = '>= 2.7'
 
-  gem.add_runtime_dependency 'omniauth', '~> 1.0'
+  gem.add_runtime_dependency 'omniauth', '~> 2.1'
   gem.add_runtime_dependency 'i18n'
 
   gem.add_development_dependency 'rack-test'
   gem.add_development_dependency 'rspec'
   gem.add_development_dependency 'bundler'
   gem.add_development_dependency 'rake'
+  gem.add_development_dependency 'rack-session'
 end

data/spec/omniauth/strategies/seb_spec.rb

@@ -1,17 +1,28 @@
 require 'spec_helper'
+require 'rack-protection'
+require 'rack/session'
 
 describe OmniAuth::Strategies::Seb do
   PUBLIC_CRT = File.read(File.join(RSpec.configuration.cert_folder, 'response.public.pem'))
   SND_ID = 'AAA'
 
   let(:app){ Rack::Builder.new do |b|
-    b.use Rack::Session::Cookie, {secret: 'abc123'}
+    b.use Rack::Session::Cookie, {secret: '5242e6bd9daf0e9645c2d4e22b11ba8cee0bed44439906d5f1bd5dad409d8637'}
     b.use OmniAuth::Strategies::Seb, PUBLIC_CRT, SND_ID
     b.run lambda{|env| [404, {}, ['Not Found']]}
   end.to_app }
 
+  let(:token){ Rack::Protection::AuthenticityToken.random_token }
+
   context 'request phase' do
-    before(:each) { get '/auth/seb' }
+    before(:each) do
+      post(
+        '/auth/seb',
+        {},
+        'rack.session' => {csrf: token},
+        'HTTP_X_CSRF_TOKEN' => token
+      )
+    end
 
     it 'displays a single form' do
       expect(last_response.status).to eq(200)
@@ -25,7 +36,7 @@ describe OmniAuth::Strategies::Seb do
     EXPECTED_VALUES = {
       'IB_SND_ID': SND_ID,
       'IB_SERVICE': OmniAuth::Strategies::Seb::AUTH_SERVICE,
-      'IB_LANG': 'LAT'
+      'IB_LANG': 'ENG'
     }
 
     EXPECTED_VALUES.each_pair do |k,v|
@@ -66,7 +77,7 @@ describe OmniAuth::Strategies::Seb do
 
     context 'with non-existant public key file' do
       let(:app){ Rack::Builder.new do |b|
-        b.use Rack::Session::Cookie, {secret: 'abc123'}
+        b.use Rack::Session::Cookie, {secret: '5242e6bd9daf0e9645c2d4e22b11ba8cee0bed44439906d5f1bd5dad409d8637'}
         b.use(OmniAuth::Strategies::Seb, 'missing-public-key-file.pem', SND_ID )
         b.run lambda{|env| [404, {}, ['Not Found']]}
       end.to_app }
@@ -80,7 +91,7 @@ describe OmniAuth::Strategies::Seb do
 
     context 'with non-existant SND ID' do
       let(:app){ Rack::Builder.new do |b|
-        b.use Rack::Session::Cookie, {secret: 'abc123'}
+        b.use Rack::Session::Cookie, {secret: '5242e6bd9daf0e9645c2d4e22b11ba8cee0bed44439906d5f1bd5dad409d8637'}
         b.use(OmniAuth::Strategies::Seb, PUBLIC_CRT, nil )
         b.run lambda{|env| [404, {}, ['Not Found']]}
       end.to_app }

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: omniauth-seb-elink
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
 platform: ruby
 authors:
-- MAK IT
-autorequire: 
+- Mitigate
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2019-02-14 00:00:00.000000000 Z
+date: 2023-09-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: omniauth
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: '2.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: '2.1'
 - !ruby/object:Gem::Dependency
   name: i18n
   requirement: !ruby/object:Gem::Requirement
@@ -94,15 +94,29 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: rack-session
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: OmniAuth strategy for SEB e-link
 email:
-- admin@makit.lv
+- admin@mitigate.dev
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/workflows/ruby.yml"
 - ".gitignore"
-- ".travis.yml"
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -119,11 +133,11 @@ files:
 - spec/certs/response.public.pem
 - spec/omniauth/strategies/seb_spec.rb
 - spec/spec_helper.rb
-homepage: https://github.com/mak-it/omniauth-seb-elink
+homepage: https://github.com/mitigate-dev/omniauth-seb-elink
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -131,16 +145,15 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.2.2
+      version: '2.7'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.4.8
-signing_key: 
+rubygems_version: 3.3.26
+signing_key:
 specification_version: 4
 summary: OmniAuth strategy for SEB e-link
 test_files:

data/.travis.yml

@@ -1,7 +0,0 @@
-language: ruby
-rvm:
-  - 2.3
-  - 2.4
-  - 2.5
-  - 2.6
-script: bundle exec rspec