omniauth-saml 1.8.0 → 1.8.1

Sign up to get free protection for your applications and to get access to all the features.

Potentially problematic release.


This version of omniauth-saml might be problematic. Click here for more details.

checksums.yaml CHANGED
@@ -1,7 +1,7 @@
1
1
  ---
2
2
  SHA1:
3
- metadata.gz: 27f7eb61023b2810a4d90cad719720226d018107
4
- data.tar.gz: 2e44a8f6da13660d0a32ddf08b1418f7c4122f1f
3
+ metadata.gz: 64a62290bdbae1a6f33c67204014e5e630765689
4
+ data.tar.gz: ea6ffc77a6943da6a7c7b80cafec26dae7e2b59b
5
5
  SHA512:
6
- metadata.gz: fa98d4ddc896effb77f572ab5222f4bb1db9f1c1dc03891a718db4a18b1144a25130ac9c1e1aee6772137b98fe117c3e38a71065f417743c5a050109f823f0c0
7
- data.tar.gz: 692fb62fb8a14d99b700c9152ba02a7dcc17d8157c0f06e1b36565c41f69d265df87ff3603a302026e340755e9886a1358cb9e55acdbe87bab83682c09aa59b1
6
+ metadata.gz: 8923e8d535ef1debb0473e4b9a80cc3e382c4ae60cff00c22ea7d554b7ab6f9c8d0046787cd8c197ab3a31188127198c0ecbf418b324c43a7dc21a6fed35427c
7
+ data.tar.gz: ce61b44b7d132885efe4c8d6e07bb9adb5a941ba8b1bf7c80249dd5fa64be21fc5f8f3c501441972457335ee837971a009099a70cc5c89b4242b7abf17e40aa4
@@ -1,3 +1,12 @@
1
+ <a name="v1.8.1"></a>
2
+ ### v1.8.1 (2017-06-22)
3
+
4
+
5
+ #### Bug Fixes
6
+
7
+ * default assertion_consumer_service_url not set during callback ([4a2a5ef](/../../commit/4a2a5ef))
8
+
9
+
1
10
  <a name="v1.8.0"></a>
2
11
  ### v1.8.0 (2017-06-07)
3
12
 
@@ -1,5 +1,5 @@
1
1
  module OmniAuth
2
2
  module SAML
3
- VERSION = '1.8.0'
3
+ VERSION = '1.8.1'
4
4
  end
5
5
  end
@@ -32,8 +32,6 @@ module OmniAuth
32
32
  option :idp_slo_session_destroy, proc { |_env, session| session.clear }
33
33
 
34
34
  def request_phase
35
- options[:assertion_consumer_service_url] ||= callback_url
36
-
37
35
  authn_request = OneLogin::RubySaml::Authrequest.new
38
36
 
39
37
  with_settings do |settings|
@@ -212,6 +210,7 @@ module OmniAuth
212
210
  end
213
211
 
214
212
  def with_settings
213
+ options[:assertion_consumer_service_url] ||= callback_url
215
214
  yield OneLogin::RubySaml::Settings.new(options)
216
215
  end
217
216
 
@@ -157,6 +157,16 @@ describe OmniAuth::Strategies::SAML, :type => :strategy do
157
157
  end
158
158
  end
159
159
 
160
+ context "when the assertion_consumer_service_url is the default" do
161
+ before :each do
162
+ saml_options.delete(:assertion_consumer_service_url)
163
+ OmniAuth.config.full_host = 'http://localhost:9080'
164
+ post_xml
165
+ end
166
+
167
+ it { is_expected.not_to fail_with(:invalid_ticket) }
168
+ end
169
+
160
170
  context "when there is no SAMLResponse parameter" do
161
171
  before :each do
162
172
  post '/auth/saml/callback'
metadata CHANGED
@@ -1,7 +1,7 @@
1
1
  --- !ruby/object:Gem::Specification
2
2
  name: omniauth-saml
3
3
  version: !ruby/object:Gem::Version
4
- version: 1.8.0
4
+ version: 1.8.1
5
5
  platform: ruby
6
6
  authors:
7
7
  - Raecoo Cao
@@ -14,7 +14,7 @@ authors:
14
14
  autorequire:
15
15
  bindir: bin
16
16
  cert_chain: []
17
- date: 2017-06-07 00:00:00.000000000 Z
17
+ date: 2017-06-22 00:00:00.000000000 Z
18
18
  dependencies:
19
19
  - !ruby/object:Gem::Dependency
20
20
  name: omniauth