omniauth-polaris 1.0.5 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 854ec536ec951da3a404a8fb0cff3afa47f4b2e1
-  data.tar.gz: f275bc49cc3cf0798fb624e9a68eeda2766bb43a
+SHA256:
+  metadata.gz: cdc6774680ba017d52076ea0e48f91c64c639398d68a6efc378e15f176cf7c41
+  data.tar.gz: ac1c47675fb06db77a9e889aaa905fe8dbc5b8ff493b95e7a2ce58fbe3c2b471
 SHA512:
-  metadata.gz: 193cc616630ee2455da017cdb4dfedcbb560fa80aa5c4e5b4e6f2bf421c3575b4040a9f4082f893a66377ca68f145b6590e3e04b7f4511f2142d9b77b7c465df
-  data.tar.gz: d83f04c7c4aff9a7af297661839eb869a4b924da6553b72ce02ce28d0095b4611d976cd89aa865f53d992134dbec970ab0b9f01fcc8eb6c050608b3c32b944b6
+  metadata.gz: 90668f491c693ed44cba53bb920e36f05b394d96e103b1f54dd1a55ef1dff87d090af930c01910a78d705083777613190e64542800c1f4a942290b4933b3d1e7
+  data.tar.gz: 02a9cf3dc5b6ab29db564ed28c63ac616b93572ea2ba4df72c388b5b9937bf535d1aebfe6d169154d563ac917121efb8cae87594bd89a7ed04a285a1e69b5540

data/.gitignore

@@ -50,14 +50,14 @@ Icon?
 ehthumbs.db
 .idea # Rubymine config files
 /.idea/*
-
+.ruby-version
 # Directories to ignore #
 #########################
 /public/data/*
 /jetty/*
 /solr_conf/*
 /fedora_conf/*
-
+scratch.rb
 # Ignore edited Linux files #
 #############################
 

data/.rubocop.yml

@@ -1 +1,25 @@
-require: rubocop-rspec
+inherit_from: .rubocop_todo.yml
+
+# The behavior of RuboCop can be controlled via the .rubocop.yml
+# configuration file. It makes it possible to enable/disable
+# certain cops (checks) and to alter their behavior if they accept
+# any parameters. The file can be placed either in your home
+# directory or in some project directory.
+#
+# RuboCop will start looking for the configuration file in the directory
+# where the inspected file is and continue its way up to the root directory.
+#
+# See https://docs.rubocop.org/rubocop/configuration
+
+AllCops:
+  TargetRubyVersion: 2.7
+  NewCops: enable
+  Exclude:
+    - 'scratch.rb'
+
+Gemspec/RequireMFA:
+  Enabled: false
+
+RSpec/MultipleExpectations:
+  Enabled: true
+  Max: 5

data/.rubocop_todo.yml

@@ -0,0 +1,300 @@
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2023-01-11 17:46:34 UTC using RuboCop version 1.32.0.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 2
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: TreatCommentsAsGroupSeparators, ConsiderPunctuation, Include.
+# Include: **/*.gemfile, **/Gemfile, **/gems.rb
+Bundler/OrderedGems:
+  Enabled: true
+
+# Offense count: 2
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: TreatCommentsAsGroupSeparators, ConsiderPunctuation, Include.
+# Include: **/*.gemspec
+Gemspec/OrderedDependencies:
+  Enabled: true
+
+# Offense count: 1
+# Configuration parameters: Include.
+# Include: **/*.gemspec
+Gemspec/RequiredRubyVersion:
+  Exclude:
+    - 'omniauth-polaris.gemspec'
+
+# Offense count: 2
+# This cop supports safe autocorrection (--autocorrect).
+Layout/EmptyLines:
+  Enabled: true
+# Offense count: 1
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: AllowForAlignment, AllowBeforeTrailingComments, ForceEqualSignAlignment.
+Layout/ExtraSpacing:
+  Enabled: true
+# Offense count: 2
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: EnforcedStyle, IndentationWidth.
+# SupportedStyles: special_inside_parentheses, consistent, align_braces
+Layout/FirstHashElementIndentation:
+  Enabled: true
+
+# Offense count: 1
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: AllowMultipleStyles, EnforcedHashRocketStyle, EnforcedColonStyle, EnforcedLastArgumentHashStyle.
+# SupportedHashRocketStyles: key, separator, table
+# SupportedColonStyles: key, separator, table
+# SupportedLastArgumentHashStyles: always_inspect, always_ignore, ignore_implicit, ignore_explicit
+Layout/HashAlignment:
+  Enabled: true
+
+# Offense count: 3
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: AllowDoxygenCommentStyle, AllowGemfileRubyComment.
+Layout/LeadingCommentSpace:
+  Enabled: true
+
+# Offense count: 1
+# This cop supports safe autocorrection (--autocorrect).
+Layout/LeadingEmptyLines:
+  Enabled: true
+
+# Offense count: 1
+# This cop supports safe autocorrection (--autocorrect).
+Layout/SpaceAfterComma:
+  Enabled: true
+
+# Offense count: 2
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: AllowForAlignment, EnforcedStyleForExponentOperator.
+# SupportedStylesForExponentOperator: space, no_space
+Layout/SpaceAroundOperators:
+  Enabled: true
+
+# Offense count: 3
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces.
+# SupportedStyles: space, no_space
+# SupportedStylesForEmptyBraces: space, no_space
+Layout/SpaceBeforeBlockBraces:
+  Enabled: true
+
+# Offense count: 1
+# This cop supports safe autocorrection (--autocorrect).
+Layout/SpaceBeforeComma:
+  Enabled: true
+
+# Offense count: 4
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces, SpaceBeforeBlockParameters.
+# SupportedStyles: space, no_space
+# SupportedStylesForEmptyBraces: space, no_space
+Layout/SpaceInsideBlockBraces:
+  Enabled: true
+
+# Offense count: 6
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces.
+# SupportedStyles: space, no_space, compact
+# SupportedStylesForEmptyBraces: space, no_space
+Layout/SpaceInsideHashLiteralBraces:
+  Enabled: true
+
+# Offense count: 1
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: space, compact, no_space
+Layout/SpaceInsideParens:
+  Enabled: true
+
+# Offense count: 1
+Lint/RescueException:
+  Enabled: true
+
+# Offense count: 1
+# This cop supports safe autocorrection (--autocorrect).
+Lint/ScriptPermission:
+  Enabled: true
+
+# Offense count: 1
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: ContextCreatingMethods, MethodCreatingMethods.
+Lint/UselessAccessModifier:
+  Enabled: true
+
+# Offense count: 2
+Lint/UselessAssignment:
+  Enabled: true
+
+# Offense count: 3
+# Configuration parameters: IgnoredMethods, CountRepeatedAttributes.
+Metrics/AbcSize:
+  Max: 39
+
+# Offense count: 2
+# Configuration parameters: CountComments, CountAsOne, ExcludedMethods, IgnoredMethods.
+# IgnoredMethods: refine
+Metrics/BlockLength:
+  Max: 63
+
+# Offense count: 1
+# Configuration parameters: IgnoredMethods.
+Metrics/CyclomaticComplexity:
+  Max: 15
+
+# Offense count: 3
+# Configuration parameters: CountComments, CountAsOne, ExcludedMethods, IgnoredMethods.
+Metrics/MethodLength:
+  Max: 20
+
+# Offense count: 1
+# Configuration parameters: IgnoredMethods.
+Metrics/PerceivedComplexity:
+  Max: 13
+
+# Offense count: 1
+# Configuration parameters: ExpectMatchingDefinition, CheckDefinitionPathHierarchy, CheckDefinitionPathHierarchyRoots, Regex, IgnoreExecutableScripts, AllowedAcronyms.
+# CheckDefinitionPathHierarchyRoots: lib, spec, test, src
+# AllowedAcronyms: CLI, DSL, ACL, API, ASCII, CPU, CSS, DNS, EOF, GUID, HTML, HTTP, HTTPS, ID, IP, JSON, LHS, QPS, RAM, RHS, RPC, SLA, SMTP, SQL, SSH, TCP, TLS, TTL, UDP, UI, UID, UUID, URI, URL, UTF8, VM, XML, XMPP, XSRF, XSS
+Naming/FileName:
+  Exclude:
+    - 'lib/omniauth-polaris.rb'
+
+# Offense count: 2
+# Configuration parameters: AllowedConstants.
+Style/Documentation:
+  Exclude:
+    - 'spec/**/*'
+    - 'test/**/*'
+    - 'lib/omniauth/polaris/adaptor.rb'
+    - 'lib/omniauth/strategies/polaris.rb'
+
+# Offense count: 2
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: compact, expanded
+Style/EmptyMethod:
+  Enabled: true
+# Offense count: 1
+# This cop supports safe autocorrection (--autocorrect).
+Style/Encoding:
+  Enabled: true
+
+# Offense count: 3
+# This cop supports safe autocorrection (--autocorrect).
+Style/ExpandPathArguments:
+  Enabled: true
+
+# Offense count: 1
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: format, sprintf, percent
+Style/FormatString:
+  Enabled: true
+
+# Offense count: 1
+# This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: always, always_true, never
+Style/FrozenStringLiteralComment:
+  Enabled: true
+
+# Offense count: 23
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: EnforcedStyle, EnforcedShorthandSyntax, UseHashRocketsWithSymbolValues, PreferHashRocketsForNonAlnumEndingSymbols.
+# SupportedStyles: ruby19, hash_rockets, no_mixed_keys, ruby19_no_mixed_keys
+# SupportedShorthandSyntax: always, never, either
+Style/HashSyntax:
+  Enabled: true
+
+# Offense count: 1
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: both, prefix, postfix
+Style/NegatedIf:
+  Enabled: true
+
+# Offense count: 3
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: PreferredDelimiters.
+Style/PercentLiteralDelimiters:
+  Enabled: true
+
+# Offense count: 2
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: EnforcedStyle, AllowedCompactTypes.
+# SupportedStyles: compact, exploded
+Style/RaiseArgs:
+  Enabled: true
+
+# Offense count: 2
+# This cop supports unsafe autocorrection (--autocorrect-all).
+Style/RedundantInterpolation:
+  Enabled: true
+
+# Offense count: 2
+# This cop supports safe autocorrection (--autocorrect).
+Style/RedundantPercentQ:
+  Enabled: true
+
+# Offense count: 1
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: EnforcedStyle, AllowInnerSlashes.
+# SupportedStyles: slashes, percent_r, mixed
+Style/RegexpLiteral:
+  Enabled: true
+# Offense count: 5
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: AllowAsExpressionSeparator.
+Style/Semicolon:
+  Enabled: true
+
+# Offense count: 3
+# This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: RequireEnglish.
+# SupportedStyles: use_perl_names, use_english_names, use_builtin_english_names
+Style/SpecialGlobalVars:
+  EnforcedStyle: use_perl_names
+
+# Offense count: 1
+# This cop supports safe autocorrection (--autocorrect).
+Style/StderrPuts:
+  Enabled: true
+
+# Offense count: 1
+# This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: Mode.
+Style/StringConcatenation:
+  Enabled: true
+
+# Offense count: 7
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: EnforcedStyle, ConsistentQuotesInMultiline.
+# SupportedStyles: single_quotes, double_quotes
+Style/StringLiterals:
+  Enabled: true
+# Offense count: 1
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: .
+# SupportedStyles: percent, brackets
+Style/SymbolArray:
+  EnforcedStyle: percent
+  MinSize: 3
+
+# Offense count: 1
+# This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: AllowMethodsWithArguments, IgnoredMethods, AllowComments.
+# IgnoredMethods: respond_to, define_method
+Style/SymbolProc:
+  Enabled: true
+
+# Offense count: 16
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, AllowedPatterns, IgnoredPatterns.
+# URISchemes: http, https
+Layout/LineLength:
+  Max: 256

data/Gemfile

@@ -1,13 +1,14 @@
-source 'https://rubygems.org'
+# frozen_string_literal: true
 
+source 'https://rubygems.org'
 
-gem "rubocop", ">= 0.47", require: false
+gem 'rubocop', '~> 1.31', require: false
+gem 'rubocop-performance', '~> 1.15', require: false
+gem 'rubocop-rspec', '~> 2.12', require: false
 
-#TODO create a coveralls repo token for this
 gemspec
 
 group :test do
+  gem 'rack-test'
   gem 'simplecov', require: false
-  gem 'rubocop-rspec', require: false
-  gem 'rack-test', '~> 1.1.0'
 end

data/Rakefile

@@ -1,8 +1,21 @@
-#!/usr/bin/env rake
-# Add your own tasks in files placed in lib/tasks ending in .rake,
-# for example lib/tasks/capistrano.rake, and they will automatically be available to Rake.
+# frozen_string_literal: true
 
-unless Dir[File.expand_path('../config/application', __FILE__)].empty?
-  require File.expand_path('../config/application', __FILE__)
-  OmniauthPolaris::Application.load_tasks
+require 'bundler/gem_tasks'
+require 'rspec/core/rake_task'
+
+RSpec::Core::RakeTask.new(:spec)
+
+begin
+  require 'rubocop/rake_task'
+  RuboCop::RakeTask.new(:rubocop) do |task|
+    task.requires << 'rubocop-rspec'
+    task.requires << 'rubocop-performance'
+    task.fail_on_error = true
+  end
+rescue LoadError
+  task :rubocop do
+    warn 'Rubocop is disabled'
+  end
 end
+
+task default: [:rubocop, :spec]

data/bin/console

@@ -0,0 +1,9 @@
+#!/usr/bin/env ruby
+
+# frozen_string_literal: true
+
+require 'bundler/setup'
+require 'pry'
+require 'omniauth-polaris'
+
+Pry.start

data/lib/omniauth/polaris/adaptor.rb

@@ -0,0 +1,108 @@
+# frozen_string_literal: true
+
+module OmniAuth
+  module Polaris
+    class Adaptor
+      REQUIRED_ADAPTER_CONFIG_KEYS = %i[access_id access_key method http_uri].freeze
+      BASIC_USER_DATA_KEYS = %w[NameFirst NameLast NameMiddle PhoneNumber EmailAddress].freeze
+      METHOD = { POST: :GET }.freeze
+
+      attr_reader :config
+
+      def self.validate!(configuration = {})
+        message = REQUIRED_ADAPTER_CONFIG_KEYS.each_with_object([]) do |name, msg|
+          next msg if configuration[name].present?
+
+          msg << name
+        end
+
+        raise Polaris::ConfigurationError, "#{message.join(' ,')} MUST be provided" unless message.blank?
+      end
+
+      def initialize(configuration = {})
+        self.class.validate!(configuration)
+
+        @configuration = configuration.dup
+
+        @logger = @configuration.delete(:logger)
+
+        REQUIRED_ADAPTER_CONFIG_KEYS.each do |name|
+          instance_variable_set("@#{name}", @configuration[name])
+        end
+
+        @config = {
+          http_uri: @http_uri,
+          method: @method,
+          access_key: @access_key,
+          access_id: @access_id
+        }
+
+        ensure_method!(@method)
+        @polaris_method = METHOD[@method]
+      end
+
+      def authenticate_patron(pin:, barcode:)
+        # According to the polaris api docs "Date must be within +/- 30 minutes of current time or request will fail"
+        http_date = 15.minutes.from_now.in_time_zone('GMT').strftime('%a, %d %b %Y %H:%M:%S %Z')
+
+        # Authorization hash component
+        authorization_hash = authorization_response(pin, barcode, http_date)
+
+        return if authorization_hash.blank?
+
+        # Details hash component
+        details_hash = details_response(pin, barcode, http_date)
+
+        return if details_hash.blank? || details_hash.dig('PatronBasicDataGetResult', 'PatronBasicData').blank?
+
+        patron_user_hash = authorization_hash['PatronValidateResult'].dup
+
+        patron_user_hash.merge(details_hash.dig('PatronBasicDataGetResult', 'PatronBasicData').slice(*BASIC_USER_DATA_KEYS))
+      end
+
+      protected
+
+      def authorization_response(pin, barcode, request_date)
+        patron_validate_uri = "#{@http_uri}/patron/#{barcode}"
+        validation_concated_string = "#{@polaris_method}#{patron_validate_uri}#{request_date}#{pin}"
+        polaris_get_xml_response(patron_validate_uri, request_date, validation_concated_string)
+      end
+
+      def details_response(pin, barcode, request_date)
+        patron_basic_data_uri = "#{@http_uri}#{barcode}/basicdata"
+        details_concated_string = "#{@polaris_method}#{http_basic_data_uri}#{request_date}#{pin}"
+        polaris_get_xml_response(patron_basic_data_uri, request_date, details_concated_string)
+      end
+
+      private
+
+      def polaris_request_headers(request_date, concated_string)
+        { 'Date' => request_date, 'Authorization' => "PWS #{@access_id}:#{sha1_sig(concated_string)}" }
+      end
+
+      def polaris_get_xml_response(uri, request_date, concated_string)
+        xml_response = HTTP.get(uri, headers: polaris_request_headers(request_date, concated_string))
+
+        return {} unless xml_response.status.success?
+
+        Hash.from_xml(xml_response.body.to_s)
+      rescue HTTP::Error, OpenSSL::SSL::SSLError => e
+        raise Polaris::ConnectionError, "Could not connect to polaris due to the following error\n #{e.class.name}: #{e.message}"
+      end
+
+      def sha1_sig(concated_string)
+        Base64.strict_encode64(OpenSSL::HMAC.digest('sha1', @access_key, concated_string).to_s)
+      end
+
+      def ensure_method!(method = 'post')
+        normalized_method = method.to_s.upcase.to_sym
+
+        return normalized_method if METHOD.key?(normalized_method)
+
+        available_methods = METHOD.keys.collect(&:inspect).join(', ')
+
+        raise Polaris::ConfigurationError, "#{method} is not one of the available connect methods: #{available_methods}"
+      end
+    end
+  end
+end

data/lib/omniauth/polaris/version.rb

@@ -0,0 +1,7 @@
+# frozen_string_literal: true
+
+module OmniAuth
+  module Polaris
+    VERSION = '1.1.0'
+  end
+end

data/lib/omniauth/polaris.rb

@@ -0,0 +1,24 @@
+# frozen_string_literal: true
+
+require 'active_support'
+require 'active_support/core_ext/object/blank'
+require 'active_support/core_ext/time'
+require 'active_support/core_ext/integer/time'
+require 'active_support/core_ext/hash/conversions'
+require 'base64'
+require 'cgi'
+require 'openssl'
+require 'http'
+require 'omniauth'
+require 'omniauth/strategies/polaris'
+
+module OmniAuth
+  module Polaris
+    class PolarisError < StandardError; end
+    class ConfigurationError < StandardError; end
+    class AuthenticationError < StandardError; end
+    class ConnectionError < StandardError; end
+  end
+end
+
+require 'omniauth/polaris/adaptor'

data/lib/omniauth/strategies/polaris.rb

@@ -1,108 +1,76 @@
-require 'omniauth' unless defined? OmniAuth
+# frozen_string_literal: true
 
 module OmniAuth
   module Strategies
     class Polaris
       class MissingCredentialsError < StandardError; end
+      class InvalidCredentialsError < StandardError; end
+
       include OmniAuth::Strategy
-      @@config = {
-          'barcode' => 'barcode',
-          'valid_patron' => 'ValidPatron',
-          'patron_id' => 'PatronID',
-          'assigned_branch_id' => 'AssignedBranchID',
-          'assigned_branch_name' => 'AssignedBranchName',
-          'first_name' => 'NameFirst',
-          'last_name' => 'NameLast',
-          'middle_name' => 'NameMiddle',
-          'phone_number' => 'PhoneNumber',
-          'email' => 'EmailAddress'
-      }
-      option :title, "Polaris Authentication" #default title for authentication form
 
+      USER_MAP = {
+        'barcode' => 'Barcode',
+        'valid_patron' => 'ValidPatron',
+        'patron_id' => 'PatronID',
+        'assigned_branch_id' => 'AssignedBranchID',
+        'assigned_branch_name' => 'AssignedBranchName',
+        'first_name' => 'NameFirst',
+        'last_name' => 'NameLast',
+        'middle_name' => 'NameMiddle',
+        'phone_number' => 'PhoneNumber',
+        'email' => 'EmailAddress'
+      }.freeze
+
+      def self.map_user(polaris_user_info)
+        USER_MAP.each_with_object({}) do |(user_key, polaris_user_key), user_hash|
+          user_hash[user_key.to_sym] = polaris_user_info[polaris_user_key] if polaris_user_info[polaris_user_key].present?
+        end
+      end
+
+      option :title, 'Polaris Authentication' # default title for authentication form
 
       def request_phase
-        OmniAuth::Polaris::Adaptor.validate @options
-        f = OmniAuth::Form.new(:title => (options[:title] || "Polaris Authentication"), :url => callback_path)
-        f.text_field 'Barcode', 'barcode'
-        f.password_field 'PIN', 'pin'
-        f.button "Sign In"
-        f.to_response
+        OmniAuth::Polaris::Adaptor.validate!(@options)
+
+        OmniAuth::Form.build(title: options.fetch(:title, 'Polaris Authentication'), url: callback_path) do |f|
+          f.text_field 'Barcode', 'barcode'
+          f.password_field 'PIN', 'pin'
+          f.button 'Sign In'
+        end.to_response
       end
 
+      # rubocop:disable Style/SignalException
       def callback_phase
-        @adaptor = OmniAuth::Polaris::Adaptor.new @options
+        @adaptor = OmniAuth::Polaris::Adaptor.new(@options)
 
-        raise MissingCredentialsError.new("Missing login credentials") if request['barcode'].nil? || request['pin'].nil?
-        begin
-          @polaris_user_info = @adaptor.bind_as(:barcode => request['barcode'], :pin => request['pin'])
-          return fail!(:invalid_credentials) if !@polaris_user_info
+        fail(MissingCredentialsError, 'Missing login credentials') if %w[barcode pin].any? { |request_key| request.params[request_key].blank? }
 
-          @user_info = self.class.map_user(@@config, @polaris_user_info)
-          super
-        rescue Exception => e
-          return fail!(:polaris_error, e)
-        end
+        @polaris_user_info = @adaptor.authenticate_patron(pin: request.params['pin'], barcode: request.params['barcode'])
+
+        fail(InvalidCredentialsError, 'Invalid User Credentials!') if @polaris_user_info.blank?
+
+        @user_info = self.class.map_user(@polaris_user_info)
+
+        super
+      rescue MissingCredentialsError => e
+        fail!(:missing_credentials, e)
+      rescue InvalidCredentialsError => e
+        fail!(:invalid_credentials, e)
+      rescue StandardError => e
+        fail!(:polaris_error, e)
+      end
+      # rubocop:enable Style/SignalException
+
+      uid do
+        @user_info[:barcode]
       end
 
-      uid {
-        request['barcode']
-      }
-      info {
+      info do
         @user_info
-      }
-      extra {
-        { :raw_info => @polaris_user_info }
-      }
-
-      # def map_user(mapper, object)
-      #   Ben 12/24/2018 Doesnt appear this method is in use
-      #   user = {}
-      #   mapper.each do |key, value|
-      #     case value
-      #       when String
-      #         #user[key] = object[value.downcase.to_sym].first if object[value.downcase.to_sym]
-      #         user[key.to_sym] = object[value] if object[value]
-      #       when Array
-      #         #value.each {|v| (user[key] = object[v.downcase.to_sym].first; break;) if object[v.downcase.to_sym]}
-      #         value.each {|v| (user[key] = object[v.downcase.to_sym]; break;) if object[v.downcase.to_sym]}
-      #       when Hash
-      #         value.map do |key1, value1|
-      #           pattern = key1.dup
-      #           value1.each_with_index do |v,i|
-      #             #part = ''; v.collect(&:downcase).collect(&:to_sym).each {|v1| (part = object[v1].first; break;) if object[v1]}
-      #             part = ''; v.collect(&:downcase).collect(&:to_sym).each {|v1| (part = object[v1]; break;) if object[v1]}
-      #             pattern.gsub!("%#{i}", part || '')
-      #           end
-      #           user[key] = pattern
-      #         end
-      #     end
-      #   end
-      #   user
-      # end
-
-
-      def self.map_user(mapper, object)
-        user = {}
-        mapper.each do |key, value|
-          case value.class.to_s
-          when String
-            user[key.to_sym] = object[value.to_sym] if object[value.to_sym]
-          when Array
-            #value.each {|v| (user[key] = object[v.downcase.to_sym].first; break;) if object[v.downcase.to_sym]}
-            value.each {|v| (user[key] = object[v.downcase.to_sym]; break;) if object[v.downcase.to_sym]}
-          when Hash
-            value.map do |key1, value1|
-              pattern = key1.dup
-              value1.each_with_index do |v,i|
-                #part = ''; v.collect(&:downcase).collect(&:to_sym).each {|v1| (part = object[v1].first; break;) if object[v1]}
-                part = ''; v.collect(&:downcase).collect(&:to_sym).each {|v1| (part = object[v1]; break;) if object[v1]}
-                pattern.gsub!("%#{i}", part || '')
-              end
-              user[key] = pattern
-            end
-          end
-        end
-        user
+      end
+
+      extra do
+        { raw_info: @polaris_user_info }
       end
     end
   end

data/lib/omniauth-polaris.rb

@@ -1,3 +1,3 @@
-require 'omniauth-polaris/version'
-require 'omniauth-polaris/adaptor'
-require 'omniauth/strategies/polaris'
+# frozen_string_literal: true
+
+require 'omniauth/polaris'

data/omniauth-polaris.gemspec

@@ -1,29 +1,30 @@
-# -*- encoding: utf-8 -*-
-lib = File.expand_path('../lib', __FILE__)
-$LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
-require 'omniauth-polaris/version'
-Gem::Specification.new do |gem|
-  gem.name = "omniauth-polaris"
-  gem.version = OmniAuth::Polaris::VERSION
-  gem.authors = ["Steven Anderson", "Ben Barber"]
-  gem.email = ["sanderson@bpl.org", "bbarber@bpl.org"]
-  gem.description = %q{A Polaris API strategy for OmniAuth.}
-  gem.summary = %q{A Polaris API strategy for OmniAuth.}
-  gem.homepage = "https://github.com/boston-library/omniauth-polaris"
+# frozen_string_literal: true
+
+$:.push File.expand_path('lib', __dir__)
+require 'omniauth/polaris/version'
 
-  gem.required_ruby_version = '~> 2.4'
+Gem::Specification.new do |gem|
+  gem.name = 'omniauth-polaris'
+  gem.version = OmniAuth::Polaris::VERSION.dup
+  gem.authors = ['Steven Anderson', 'Ben Barber']
+  gem.email = ['digital@bpl.org', 'bbarber@bpl.org']
+  gem.description = 'A Polaris API strategy for OmniAuth.'
+  gem.summary = 'A Polaris API strategy for OmniAuth.'
+  gem.homepage = 'https://github.com/boston-library/omniauth-polaris'
 
+  gem.required_ruby_version = '>= 2.6.10'
 
-  gem.add_dependency 'rest-client', '~> 2.0.2'
+  gem.add_dependency 'activesupport', '< 7'
+  gem.add_dependency 'http', '~> 5.1'
+  gem.add_dependency 'omniauth', '~> 2.1.0'
 
-  gem.add_development_dependency 'omniauth', '~> 1.8.1'
+  gem.add_development_dependency 'awesome_print', '~> 1.9.2'
   gem.add_development_dependency 'bundler', '>= 1.3.0'
-  gem.add_development_dependency 'awesome_print'
-  gem.add_development_dependency 'rspec', '~> 3.8'
   gem.add_development_dependency 'libnotify', '~> 0.9.3'
+  gem.add_development_dependency 'pry', '~> 0.14'
+  gem.add_development_dependency 'rspec', '~> 3.12'
 
   gem.files         = `git ls-files -z`.split("\x0")
   gem.executables   = gem.files.grep(%r{^bin/}) { |f| File.basename(f) }
-  gem.test_files    = gem.files.grep(%r{^(test|spec|features)/})
   gem.require_paths = ['lib']
 end

data/spec/omniauth/polaris/adaptor_spec.rb

@@ -0,0 +1,17 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe 'OmniAuth::Polaris::Adaptor' do
+  describe 'initialize' do
+    let!(:patron_url) { 'http://blah.org/PAPIService/REST/public/v1/1000/100/1/patron/' }
+
+    it 'is expected to throw exception when must have field is not set' do
+      expect { OmniAuth::Polaris::Adaptor.new({ http_uri: patron_url, method: 'POST' }) }.to raise_error(OmniAuth::Polaris::ConfigurationError)
+    end
+
+    it 'is expected to throw exception when method is not supported' do
+      expect { OmniAuth::Polaris::Adaptor.new({ http_uri: patron_url, method: 'GET', access_key: 'F9998888-A000-1111-C22C-CC3333BB4444', access_id: 'API' }) }.to raise_error(OmniAuth::Polaris::ConfigurationError)
+    end
+  end
+end

data/spec/omniauth/strategies/polaris_spec.rb

@@ -1,77 +1,100 @@
-require 'spec_helper'
-describe "OmniAuth::Strategies::Polaris" do
+# frozen_string_literal: true
 
+require 'spec_helper'
 
-  class MyPolarisProvider < OmniAuth::Strategies::Polaris; end
+describe 'OmniAuth::Strategies::Polaris' do
   def app
-    Rack::Builder.new {
+    Rack::Builder.new do
       use OmniAuth::Test::PhonySession
-      use MyPolarisProvider, :name => 'polaris', :title => 'MyPolaris Form', :http_uri => 'http://blah.org/PAPIService/REST/public/v1/1000/100/1/patron/', :access_key => 'F9998888-A000-1111-C22C-CC3333BB4444', :access_id => 'API', :method => 'GET'
-      run lambda { |env| [404, {'Content-Type' => 'text/plain'}, [env.key?('omniauth.auth').to_s]] }
-    }.to_app
+      use OmniAuth::Builder do
+        provider OmniAuth::Strategies::Polaris, name: 'polaris', title: 'MyPolaris Form', http_uri: 'https://blah.org/PAPIService/REST/public/v1/1000/100/1/patron/', access_key: 'F9998888-A000-1111-C22C-CC3333BB4444', access_id: 'API', method: 'POST'
+      end
+      run ->(env) { [404, { 'Content-Type' => 'text/plain' }, [env.key?('omniauth.auth').to_s]] }
+    end.to_app
   end
 
   def session
     last_request.env['rack.session']
   end
 
-  it 'should add a camelization for itself' do
-    expect( OmniAuth::Utils.camelize('polaris') ).to eq('Polaris')
+  it 'is expected to add a camelization for itself' do
+    expect(OmniAuth::Utils.camelize('polaris')).to eq('Polaris')
   end
 
   describe '/auth/polaris' do
-    before(:each){ get '/auth/polaris' }
+    before { post '/auth/polaris' }
 
-    it 'should display a form' do
-      expect(last_response.status).to eql(200)
-      expect(last_response.body).to include("<form")
+    it 'is expected to display a form' do
+      expect(last_response.status).to be(200)
+      expect(last_response.body).to include('<form')
     end
 
-    it 'should have the callback as the action for the form' do
-      expect(last_response.body).to include("action='/auth/polaris/callback'")
+    it 'is expected to have the callback as the action for the form' do
+      expect(last_response.body).to include('/auth/polaris/callback')
     end
 
-    it 'should have a text field for each of the fields' do
+    it 'is expected to have a text field for each of the fields' do
       expect(last_response.body.scan('<input').size).to eq(2)
     end
-    it 'should have a label of the form title' do
+
+    it 'is expected to have a label of the form title' do
       expect(last_response.body.scan('MyPolaris Form').size).to be > 1
     end
-
   end
 
   describe 'post /auth/polaris/callback' do
-    before(:each) do
-      @adaptor = double(OmniAuth::Polaris::Adaptor, {:barcode => '29999999999999'})
-      allow(OmniAuth::Polaris::Adaptor).to receive(:new).and_return(@adaptor)
+    before do
+      allow(OmniAuth::Polaris::Adaptor).to receive(:new).and_return(adaptor)
     end
-    context 'failure' do
-      before(:each) do
-        allow(@adaptor).to receive(:bind_as).and_return(false)
+
+    let!(:adaptor) { instance_double(OmniAuth::Polaris::Adaptor) }
+
+    context 'when failure' do
+      before do
+        allow(adaptor).to receive(:authenticate_patron).and_return(nil)
       end
-      it 'should raise MissingCredentialsError' do
-        expect{ post('/auth/polaris/callback', {}) }.to raise_error OmniAuth::Strategies::Polaris::MissingCredentialsError
+
+      it 'is expected to fail! with :missing_credentials' do
+        post('/auth/polaris/callback', {})
+        expect(last_request.env['omniauth.error']).to be_a_kind_of(OmniAuth::Strategies::Polaris::MissingCredentialsError)
+        expect(last_request.env['omniauth.error.type']).to be(:missing_credentials)
       end
-      it 'should redirect to error page' do
-        post('/auth/polaris/callback', {:barcode => 'ping', :pin => 'password'})
+
+      it 'is expected to redirect to error page' do
+        post('/auth/polaris/callback', { barcode: 'ping', pin: 'password' })
         expect(last_response).to be_redirect
-        expect(last_response.headers['Location']).to match(%r{invalid_credentials})
+        expect(last_response.headers['Location']).to match(/invalid_credentials/)
       end
     end
 
-    context 'success' do
-      let(:auth_hash){ last_request.env['omniauth.auth'] }
-      before(:each) do
-        allow(@adaptor).to receive(:bind_as).and_return({:PAPIErrorCode => "0", :barcode => '29999999999999', :ValidPatron => 'true', :PatronID => '111111', :PatronCodeID => '27',
-                                            :AssignedBranchID => '3', :PatronBarcode => '29999999999999', :AssignedBranchName => 'BPL - Central', :ExpirationDate => '2015-09-20T00:00:00', :OverridePasswordUsed =>'false'})
-        #
-        post('/auth/polaris/callback', {:barcode => '29999021413588', :pin => '0407'})
+    context 'when successful' do
+      let(:auth_hash) { last_request.env['omniauth.auth'] }
+      let(:patron_user_hash) do
+        {
+          'PAPIErrorCode' => '0',
+          'Barcode' => '29999999999999',
+          'ValidPatron' => 'true',
+          'PatronID' => '111111',
+          'PatronCodeID' => '27',
+          'AssignedBranchID' => '3',
+          'PatronBarcode' => '29999999999999',
+          'AssignedBranchName' => 'BPL - Central',
+          'ExpirationDate' => '2026-02-19T00:00:00',
+          'OverridePasswordUsed' => 'false',
+          'NameFirst' => 'Test',
+          'NameLast' => 'Patron',
+          'NameMiddle' => '',
+          'EmailAddress' => 'test.patron@example.com',
+          'PhoneNumber' => '555-555-5555'
+        }
+      end
+
+      before do
+        allow(adaptor).to receive(:authenticate_patron).and_return(patron_user_hash)
+        post('/auth/polaris/callback', { barcode: '29999999999999', pin: '12345678' })
       end
 
-      # it 'should raise MissingCredentialsError' do
-      #   should_not raise_error OmniAuth::Strategies::Polaris::MissingCredentialsError
-      # end
-      it 'should map user info' do
+      it 'is expected to map user info' do
         expect(auth_hash.info.barcode).to eq('29999999999999')
         expect(auth_hash.info.valid_patron).to eq('true')
         expect(auth_hash.info.patron_id).to eq('111111')

data/spec/spec_helper.rb

@@ -1,14 +1,32 @@
-$:.unshift File.expand_path('..', __FILE__)
-$:.unshift File.expand_path('../../lib', __FILE__)
+# frozen_string_literal: true
+
+$:.unshift File.expand_path(__dir__)
+$:.unshift File.expand_path('../lib', __dir__)
+
+ENV['RACK_ENV'] ||= 'test'
+
 require 'simplecov'
 SimpleCov.start
+
+require 'pry'
+require 'awesome_print'
 require 'rspec'
 require 'rack/test'
-require 'omniauth'
 require 'omniauth-polaris'
-require 'awesome_print'
+
+OmniAuth.config.request_validation_phase = nil
 
 RSpec.configure do |config|
   config.include Rack::Test::Methods
-  config.extend OmniAuth::Test::StrategyMacros, :type => :strategy
+  config.extend OmniAuth::Test::StrategyMacros, type: :strategy
+  config.mock_with :rspec do |mocks|
+    # Prevents you from mocking or stubbing a method that does not exist on
+    # a real object. This is generally recommended, and will default to
+    # `true` in RSpec 4.
+    mocks.verify_partial_doubles = true
+  end
+
+  config.expect_with :rspec do |c|
+    c.syntax = :expect
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: omniauth-polaris
 version: !ruby/object:Gem::Version
-  version: 1.0.5
+  version: 1.1.0
 platform: ruby
 authors:
 - Steven Anderson
@@ -9,36 +9,64 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-01-03 00:00:00.000000000 Z
+date: 2023-01-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: rest-client
+  name: activesupport
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '7'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '7'
+- !ruby/object:Gem::Dependency
+  name: http
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.0.2
+        version: '5.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.0.2
+        version: '5.1'
 - !ruby/object:Gem::Dependency
   name: omniauth
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.8.1
+        version: 2.1.0
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 2.1.0
+- !ruby/object:Gem::Dependency
+  name: awesome_print
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 1.9.2
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.8.1
+        version: 1.9.2
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -54,66 +82,70 @@ dependencies:
       - !ruby/object:Gem::Version
         version: 1.3.0
 - !ruby/object:Gem::Dependency
-  name: awesome_print
+  name: libnotify
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.9.3
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.9.3
 - !ruby/object:Gem::Dependency
-  name: rspec
+  name: pry
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.8'
+        version: '0.14'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.8'
+        version: '0.14'
 - !ruby/object:Gem::Dependency
-  name: libnotify
+  name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.9.3
+        version: '3.12'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.9.3
+        version: '3.12'
 description: A Polaris API strategy for OmniAuth.
 email:
-- sanderson@bpl.org
+- digital@bpl.org
 - bbarber@bpl.org
-executables: []
+executables:
+- console
 extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".rubocop.yml"
+- ".rubocop_todo.yml"
 - Gemfile
 - README.rdoc
 - Rakefile
+- bin/console
 - lib/omniauth-polaris.rb
-- lib/omniauth-polaris/adaptor.rb
-- lib/omniauth-polaris/version.rb
+- lib/omniauth/polaris.rb
+- lib/omniauth/polaris/adaptor.rb
+- lib/omniauth/polaris/version.rb
 - lib/omniauth/strategies/polaris.rb
 - omniauth-polaris.gemspec
-- spec/omniauth-ldap/adaptor_spec.rb
+- spec/omniauth/polaris/adaptor_spec.rb
 - spec/omniauth/strategies/polaris_spec.rb
 - spec/spec_helper.rb
 homepage: https://github.com/boston-library/omniauth-polaris
@@ -125,21 +157,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - "~>"
+  - - ">="
     - !ruby/object:Gem::Version
-      version: '2.4'
+      version: 2.6.10
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.6.14.3
+rubygems_version: 3.3.26
 signing_key: 
 specification_version: 4
 summary: A Polaris API strategy for OmniAuth.
-test_files:
-- spec/omniauth-ldap/adaptor_spec.rb
-- spec/omniauth/strategies/polaris_spec.rb
-- spec/spec_helper.rb
+test_files: []

data/lib/omniauth-polaris/adaptor.rb

@@ -1,96 +0,0 @@
-require 'base64'
-require 'cgi'
-require 'openssl'
-require 'rest_client'
-
-module OmniAuth
-  module Polaris
-    class Adaptor
-      class PolarisError < StandardError; end
-      class ConfigurationError < StandardError; end
-      class AuthenticationError < StandardError; end
-      class ConnectionError < StandardError; end
-
-      VALID_ADAPTER_CONFIGURATION_KEYS = [:access_id, :access_key, :method, :http_uri]
-
-      MUST_HAVE_KEYS = [:access_id, :access_key, :method, :http_uri]
-
-      METHOD = {
-          :GET => :GET
-      }
-
-      attr_reader :config
-
-      def self.validate(configuration={})
-        message = []
-        MUST_HAVE_KEYS.each do |name|
-          message << name if configuration[name].nil?
-        end
-        raise ArgumentError.new(message.join(",") +" MUST be provided") unless message.empty?
-      end
-
-      def initialize(configuration={})
-        Adaptor.validate(configuration)
-        @configuration = configuration.dup
-        @logger = @configuration.delete(:logger)
-        VALID_ADAPTER_CONFIGURATION_KEYS.each do |name|
-          instance_variable_set("@#{name}", @configuration[name])
-        end
-
-        @config = {
-            :http_uri => @http_uri,
-            :method => @method,
-            :access_key => @access_key,
-            :access_id => @access_id
-        }
-
-        method = ensure_method(@method)
-
-      end
-
-      public
-      def bind_as(args = {})
-        response = false
-
-        #Basic shared input variables
-        pin = args[:pin]
-        barcode = args[:barcode]
-        http_date = Time.now.in_time_zone("GMT").strftime("%a, %d %b %Y %H:%M:%S %Z")
-
-        #Authorization hash component
-        http_uri_with_barcode =  @http_uri + barcode
-        concated_string = @method + @http_uri + barcode + http_date + pin
-        sha1_sig = Base64.strict_encode64("#{OpenSSL::HMAC.digest('sha1',@access_key, concated_string)}")
-        xml_response = RestClient.get http_uri_with_barcode, {'PolarisDate' => http_date, 'Authorization' =>  "PWS " + @access_id + ":" + sha1_sig}
-        authorization_response = Hash.from_xml xml_response
-
-        #Details hash component
-        http_basic_data_get = @http_uri + barcode + '/basicdata'
-        concated_string = @method + http_basic_data_get + http_date + pin
-        sha1_sig = Base64.strict_encode64("#{OpenSSL::HMAC.digest('sha1',@access_key, concated_string)}")
-        xml_response = RestClient.get http_basic_data_get, {'PolarisDate' => http_date, 'Authorization' =>  "PWS " + @access_id + ":" + sha1_sig}
-        details_response = Hash.from_xml xml_response
-
-        #Add some of the basic details to a single hash, using the authorization as the base.
-        authorization_response["PatronValidateResult"]["NameFirst"] = details_response["PatronBasicDataGetResult"]["PatronBasicData"]["NameFirst"]
-        authorization_response["PatronValidateResult"]["NameLast"] = details_response["PatronBasicDataGetResult"]["PatronBasicData"]["NameLast"]
-        authorization_response["PatronValidateResult"]["NameMiddle"] = details_response["PatronBasicDataGetResult"]["PatronBasicData"]["NameMiddle"]
-        authorization_response["PatronValidateResult"]["PhoneNumber"] = details_response["PatronBasicDataGetResult"]["PatronBasicData"]["PhoneNumber"]
-        authorization_response["PatronValidateResult"]["EmailAddress"] = details_response["PatronBasicDataGetResult"]["PatronBasicData"]["EmailAddress"]
-
-        authorization_response["PatronValidateResult"]
-      end
-
-      private
-
-      def ensure_method(method="get")
-        normalized_method = method.to_s.upcase.to_sym
-        return METHOD[normalized_method] if METHOD.key?(normalized_method)
-
-        available_methods = METHOD.keys.collect {|m| m.inspect}.join(", ")
-        format = "%s is not one of the available connect methods: %s"
-        raise ConfigurationError, format % [method.inspect, available_methods]
-      end
-    end
-  end
-end

data/lib/omniauth-polaris/version.rb

@@ -1,5 +0,0 @@
-module OmniAuth
-  module Polaris
-    VERSION = '1.0.5'.freeze
-  end
-end

data/spec/omniauth-ldap/adaptor_spec.rb

@@ -1,15 +0,0 @@
-require 'spec_helper'
-describe "OmniAuth::Polaris::Adaptor" do
-
-  describe 'initialize' do
-    it 'should throw exception when must have field is not set' do
-      #[:host, :port, :method, :bind_dn]
-      expect{ OmniAuth::Polaris::Adaptor.new({http_uri: "http://blah.org/PAPIService/REST/public/v1/1000/100/1/patron/", method: 'GET'})}.to raise_error(ArgumentError)
-    end
-
-    it 'should throw exception when method is not supported' do
-      expect { OmniAuth::Polaris::Adaptor.new({http_uri: "http://blah.org/PAPIService/REST/public/v1/1000/100/1/patron/", method: 'POST', access_key: 'F9998888-A000-1111-C22C-CC3333BB4444', access_id: 'API'})}.to raise_error(OmniAuth::Polaris::Adaptor::ConfigurationError)
-    end
-  end
-
-end