omniauth-owa 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f5878cdb9a86f12f3fadab9ee79d19e66c2f7fd2
-  data.tar.gz: e8897c9397eab34454b259ed0de56c7fe9b097da
+  metadata.gz: e796f48d32c1f6ed8fb75ab66d6b8c800abee7cb
+  data.tar.gz: 197df82a94e3c74c4e9906735e4caba12e71ce18
 SHA512:
-  metadata.gz: df10832c1139b9168aa19b84f36dde383201b391bd98e2db9b1b930e9c81eaef5d852d81d9829f8448008731c56d977e5d95a912f03753dfaffdd4ea23915ee5
-  data.tar.gz: e1a93a2386d15d4c31bc66ca9d50a8fcb4fc121a9c9c4805686270357c8a5cb2b2900b3d726e0da1f6dc92e9b7f05f736ee2de9e72665d5130d7cbf72f7cc19b
+  metadata.gz: 7748141cbb7ea6884af521ba159055e69315626e7f5cfd422e2c52c56dc697e2e5e58aec3e0219d1e91a90a5821adb71296e72fa7cb83aa96a04217b790d443c
+  data.tar.gz: 071cf99334e5a6c9d39e77db2bcb77987f0e4a6d0340ecf7db06a535488adb757247b8c49754365ad9be28fa434c17f27e1669ec40f67c4acaae4f8bab36ed57

data/.gitignore

@@ -1,3 +1,3 @@
 Gemfile.lock
 .rvmrc
-omniauth-owa-0.0.1.gem
+omniauth-owa-*.gem

data/lib/omniauth-owa/version.rb

@@ -1,5 +1,5 @@
 module OmniAuth
   module Owa
-    VERSION = "0.0.2"
+    VERSION = "0.0.3"
   end
 end

data/lib/omniauth/strategies/owa.rb

@@ -33,6 +33,8 @@ module OmniAuth
         @info[:email] = details.match(/<td[^>]*>E-mail<\/td><td[^>]*>([^<]*)/)[1]
         @info[:name] = "#{@info[:first_name]} #{@info[:last_name]}"
         super
+      rescue
+        fail! :internal_error
       end
 
       uid do

data/spec/omniauth/strategies/owa_spec.rb

@@ -8,6 +8,7 @@ require "omniauth/strategies/owa"
 
 describe OmniAuth::Strategies::OWA do
   include Rack::Test::Methods
+  OmniAuth.config.logger = Logger.new "/dev/null"
 
   let(:app) do
     Rack::Builder.new do |b|
@@ -100,5 +101,18 @@ describe OmniAuth::Strategies::OWA do
         expect(last_response.location).to eq "/auth/failure?message=invalid_credentials&strategy=owa"
       end
     end
+
+    context "when response parsing fails" do
+      before do
+        stub_request(:get, "https://fred:secret@mail.example.com/owa/?ae=Dialog&t=AddressBook&ctx=1&sch=fred").
+          to_return body: "Some gibbersish"
+        post "/auth/owa/callback", uid: "fred", password: "secret"
+      end
+
+      it "fails with 'internal_error'" do
+        expect(last_response).to be_redirect
+        expect(last_response.location).to eq "/auth/failure?message=internal_error&strategy=owa"
+      end
+    end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: omniauth-owa
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Kerry Buckley