omniauth-nationbuilder 0.0.1 → 0.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a09359c904523452ba46358cf476a4e0c39e28fd
-  data.tar.gz: 60aef520596990d65851598a7991203fe0028bb1
+  metadata.gz: 3511d0f723c8d735738fd825950919e2c3ed5a37
+  data.tar.gz: a687e3220fa77d8c262b472e47cade12165f3c95
 SHA512:
-  metadata.gz: 2bc8b79a24ba40dc23920418521826c1041ae036783a0e6231bf7273ee59a89b4bc460a1f607b59bd2c2d2ad35cb31d1340519eaac64cc06b191f6090af40327
-  data.tar.gz: 79b3b3de168b33ead7c6a5fdb543b2e90b2fb0ab3985c49b2a70e0dca71f405084b9fa0250aa671643ff6b5a89416b3abfb165d0feb6ee4167ecf8167c773442
+  metadata.gz: 7399246d8e87ff587c50ef362556070a6cf332a5acd3fff699de4afe4021fca1ed0bccc91ef44736dedaa042ed697cf07c20dae53b89bfcc77ff68418abc9c49
+  data.tar.gz: 7a1baaf5f4960a2d133c614a1f04eefb60b1b3cea69d861450af0f544f20ea6b36b2cc68461bb10b9b6b35d5581ae65f36dc922d6217892740f32a0b9e386318

data/README.md

@@ -1,9 +1,13 @@
+[![Gem Version](https://badge.fury.io/rb/omniauth-nationbuilder.svg)](https://badge.fury.io/rb/omniauth-nationbuilder)
 [![Build Status](https://travis-ci.org/chrisjensen/omniauth-nationbuilder.svg?branch=master)](https://travis-ci.org/chrisjensen/omniauth-nationbuilder)
 
 # Omniauth::Nationbuilder
 
 Strategy to authenticate with Nationbuilder in OmniAuth.
 
+This strategy can be used to authorise your application to use the NationBuilder API.
+At this stage it is not possible to use it to authenticate your NationBuilder supporters.
+
 ## Installation
 
 Add this line to your application's Gemfile:

data/lib/omniauth-nationbuilder/version.rb

@@ -1,5 +1,5 @@
 module Omniauth
   module Nationbuilder
-    VERSION = "0.0.1"
+    VERSION = "0.1.0"
   end
 end

data/lib/omniauth/strategies/nationbuilder.rb

@@ -23,7 +23,8 @@ module OmniAuth
       # Configure site before super initialises the OAuth2 Client
       def client
         options.client_options[:site] = 'https://' + options.client_options[:slug] + '.nationbuilder.com'
-        super
+		log :debug, "Nation to authorise " + deep_symbolize(options.client_options).inspect
+		super
       end
       
       # Returns the slug, nil if one has not been specified anywhere
@@ -50,6 +51,12 @@ module OmniAuth
         super
       end
             
+      # Nationbuilder fails with an invalid callback if the 
+      # query string is passed along
+      def callback_url
+        full_host + script_name + callback_path
+      end
+
       # These are called after authentication has succeeded. If
       # possible, you should try to set the UID without making
       # additional calls (if the user id is returned with the token

data/spec/omniauth/strategies/nationbuilder_spec.rb

@@ -51,6 +51,21 @@ describe OmniAuth::Strategies::Nationbuilder, :type => :strategy do
 	end
   end
   
+  describe 'callback_url' do
+	  let(:nation_slug) { 'nationofkinggeorge' }
+
+	before do
+		allow(subject).to receive(:request) { double('Rack::Test::Request', {:params => {'nation_slug' => nation_slug }, :query_string => 'nation_slug=' + nation_slug, :env => { }}) }
+
+		allow(subject).to receive(:full_host) { 'example.org' }
+		allow(subject).to receive(:script_name) { '' }
+	end
+
+	it "should not include query string" do
+	  expect(subject.callback_url).to eq('example.org/auth/nationbuilder/callback')
+	end
+  end
+
   ### NOTE ###
   # This section involves heavy stubbing of Omniauth and OAuth methods to verify
   # a small amount of code.

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: omniauth-nationbuilder
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.1.0
 platform: ruby
 authors:
 - Chris Jensen