omniauth-multipassword 0.4.1 → 0.4.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e052b8e72afbc6487e4d78c4b73d867fef83ae32
-  data.tar.gz: 50e85068456f3ff78058a4696566364382fee670
+  metadata.gz: d5f7c8a3656ca4686749bd2b4d273cc1460d39ba
+  data.tar.gz: eb372de5e8f9ead660e3631e6b66c9c8ed34a158
 SHA512:
-  metadata.gz: 0882792d59ec159595ad7be345eb282d0896e7ba9f07f9fc2318f2fd99b0a41e12989cddbdf6418484f501ea6da535d07c394e72555e5157f6f422a049aa7c8f
-  data.tar.gz: 380ab3297e12bdf21e420655e5b4a83ff215c79c0389a2e50c714d59db186b882fb7b80e56103b379f57cb4c3d0a77e39581471fcc8def4cd3bd6ddb149e1d55
+  metadata.gz: 513e554cf46d322762dfbff65e764aea532ff2986de7af99770d9f84383b336b63af43492a5a95b63cb853f53cdd0f2bf0f33e190550fa0898ef955657fe07a0
+  data.tar.gz: c15f2b750cba4a41c170d2a983d74d8185665f3c0e70c44895ce268f7a1bdc54a1f7d713e8b7d1e5d58441ae9dd030e665b15f66bf6636ee98303b90f20ef5ad

data/.travis.yml

@@ -0,0 +1,9 @@
+sudo: false
+language: ruby
+cache: bundler
+rvm:
+- '2.1'
+- '2.0'
+- 1.9.3
+- jruby
+- rbx-2

data/Gemfile

@@ -2,3 +2,9 @@ source 'https://rubygems.org'
 
 # Specify your gem's dependencies in omniauth-multipassword.gemspec
 gemspec
+
+gem 'rake'
+gem 'rack-test'
+gem 'rspec'
+gem 'simplecov'
+gem "codeclimate-test-reporter"

data/README.md

@@ -1,7 +1,11 @@
 # Omniauth::Multipassword
 
+[![Build Status](https://travis-ci.org/jgraichen/omniauth-multipassword.svg?branch=master)](https://travis-ci.org/jgraichen/omniauth-multipassword)
+[![Code Climate](https://codeclimate.com/github/jgraichen/omniauth-multipassword/badges/gpa.svg)](https://codeclimate.com/github/jgraichen/omniauth-multipassword)
+[![Test Coverage](https://codeclimate.com/github/jgraichen/omniauth-multipassword/badges/coverage.svg)](https://codeclimate.com/github/jgraichen/omniauth-multipassword/coverage)
+
 **omniauth-multipassword** is a [OmniAuth](https://github.com/intridea/omniauth)
-strategy that allows to authenticate agains different password strategies at once.
+strategy that allows to authenticate again different password strategies at once.
 
 
 ## Installation

data/Rakefile

@@ -1,2 +1,5 @@
-#!/usr/bin/env rake
-require "bundler/gem_tasks"
+require 'bundler/gem_tasks'
+require 'rspec/core/rake_task'
+
+RSpec::Core::RakeTask.new(:spec)
+task default: :spec

data/lib/omniauth/multipassword/base.rb

@@ -42,7 +42,6 @@ module OmniAuth
           f.password_field "Password", password_id
         end.to_response
       end
-
     end
   end
 end

data/lib/omniauth/multipassword/version.rb

@@ -3,7 +3,7 @@ module Omniauth
     module VERSION
       MAJOR = 0
       MINOR = 4
-      PATCH = 1
+      PATCH = 2
       STAGE = nil
 
       def self.to_s

data/lib/omniauth/strategies/multi_password.rb

@@ -11,7 +11,7 @@ module OmniAuth
         super(app, *args) do end
 
         if block.arity == 0
-          instance_eval block
+          instance_eval &block
         else
           block.call self
         end

data/omniauth-multipassword.gemspec

@@ -3,7 +3,7 @@ require File.expand_path('../lib/omniauth/multipassword/version', __FILE__)
 
 Gem::Specification.new do |gem|
   gem.authors       = ["Jan Graichen"]
-  gem.email         = ["jan.graichen@altimos.de"]
+  gem.email         = ["jg@altimos.de"]
   gem.description   = "A OmniAuth strategy to authenticate using different passwort strategies."
   gem.summary       = "A OmniAuth strategy to authenticate using different passwort strategies."
   gem.homepage      = "https://github.com/jgraichen/omniauth-multipassword"

data/spec/omniauth/multipassword/base_spec.rb

@@ -0,0 +1,78 @@
+require 'spec_helper'
+require 'rack/test'
+
+describe OmniAuth::MultiPassword::Base do
+  let(:app) { double 'app' }
+  let(:args) { [] }
+  let(:block) { nil }
+
+  class OmniAuth::Strategy::OneTest
+    include OmniAuth::Strategy
+    include OmniAuth::MultiPassword::Base
+
+    def authenticate(username, password)
+      username == 'john' && password == 'secret'
+    end
+  end
+
+  let(:strategy) do
+    OmniAuth::Strategy::OneTest.new(app, *args, &block)
+  end
+
+  subject { strategy }
+
+  describe '#username_id' do
+    subject { strategy.username_id }
+
+    it 'defaults to :username' do
+      is_expected.to eq :username
+    end
+
+    context 'when configured' do
+      let(:args) { [{fields: [:user, :pass]}] }
+      it { is_expected.to eq :user }
+    end
+  end
+
+  describe '#password_id' do
+    subject { strategy.password_id }
+
+    it 'defaults to :password' do
+      is_expected.to eq :password
+    end
+
+    context 'when configured' do
+      let(:args) { [{fields: [:user, :pass]}] }
+      it { is_expected.to eq :pass }
+    end
+  end
+
+  describe 'single strategy' do
+    include Rack::Test::Methods
+
+    let(:app) do
+      Rack::Builder.new {
+        use OmniAuth::Test::PhonySession
+        use OmniAuth::Strategies::OneTest
+        run ->(env) { [404, {'Content-Type' => 'text/plain'}, [env.key?('omniauth.auth').to_s]] }
+      }.to_app
+    end
+
+    it 'shows login FORM' do
+      get '/auth/onetest'
+
+      expect(last_response.body).to include '<form'
+    end
+
+    it 'redirect on wrong password' do
+      post '/auth/onetest/callback', username: 'john', password: 'wrong'
+      expect(last_response).to be_redirect
+      expect(last_response.headers['Location']).to eq '/auth/failure?message=invalid_credentials&strategy=onetest'
+    end
+
+    it 'authenticates john with correct password' do
+      post '/auth/onetest/callback', username: 'john', password: 'secret'
+      expect(last_response.body).to eq 'true'
+    end
+  end
+end

data/spec/omniauth/strategy/multi_password_spec.rb

@@ -0,0 +1,57 @@
+require 'spec_helper'
+require 'rack/test'
+
+describe OmniAuth::Strategies::MultiPassword do
+  include Rack::Test::Methods
+
+  class OmniAuth::Strategies::OneTest
+    include OmniAuth::Strategy
+    include OmniAuth::MultiPassword::Base
+
+    def authenticate(username, password)
+      username == 'john' && password == 'secret'
+    end
+  end
+
+  class OmniAuth::Strategies::TwoTest
+    include OmniAuth::Strategy
+    include OmniAuth::MultiPassword::Base
+
+    def authenticate(username, password)
+      username == 'jane' && password == '1234'
+    end
+  end
+
+  let(:app) do
+    Rack::Builder.new {
+      use OmniAuth::Test::PhonySession
+      use OmniAuth::Strategies::MultiPassword do
+        authenticator :one_test
+        authenticator :two_test
+      end
+      run ->(env) { [404, {'Content-Type' => 'text/plain'}, [env['omniauth.auth']['uid'].to_s]] }
+    }.to_app
+  end
+
+  it 'shows login FORM' do
+    get '/auth/multipassword'
+
+    expect(last_response.body).to include '<form'
+  end
+
+  it 'redirect on all failed strategies' do
+    post '/auth/multipassword/callback', username: 'paul', password: 'wrong'
+    expect(last_response).to be_redirect
+    expect(last_response.headers['Location']).to eq '/auth/failure?message=invalid_credentials&strategy=multipassword'
+  end
+
+  it 'authenticates john' do
+    post '/auth/multipassword/callback', username: 'john', password: 'secret'
+    expect(last_response.body).to eq 'john'
+  end
+
+  it 'authenticates jane' do
+    post '/auth/multipassword/callback', username: 'jane', password: '1234'
+    expect(last_response.body).to eq 'jane'
+  end
+end

data/spec/spec_helper.rb

@@ -0,0 +1,30 @@
+require 'rspec'
+require 'simplecov'
+
+if ENV['CI'] || (defined?(:RUBY_ENGINE) && RUBY_ENGINE != 'rbx')
+  begin
+    require 'codeclimate-test-reporter'
+    CodeClimate::TestReporter.start
+  rescue LoadError
+  end
+  SimpleCov.start
+end
+
+require 'omniauth-multipassword'
+
+Dir[File.expand_path('spec/support/**/*.rb')].each {|f| require f }
+
+# Disable omniauth logger
+class NullLogger < Logger
+  def initialize(*args)
+  end
+
+  def add(*args, &block)
+  end
+end
+
+OmniAuth.config.logger = NullLogger.new
+
+RSpec.configure do |config|
+  config.order = 'random'
+end

metadata

@@ -1,37 +1,38 @@
 --- !ruby/object:Gem::Specification
 name: omniauth-multipassword
 version: !ruby/object:Gem::Version
-  version: 0.4.1
+  version: 0.4.2
 platform: ruby
 authors:
 - Jan Graichen
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-07-24 00:00:00.000000000 Z
+date: 2015-05-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: omniauth
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.0'
 description: A OmniAuth strategy to authenticate using different passwort strategies.
 email:
-- jan.graichen@altimos.de
+- jg@altimos.de
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
+- ".gitignore"
+- ".travis.yml"
 - Gemfile
 - LICENSE
 - README.md
@@ -41,6 +42,9 @@ files:
 - lib/omniauth/multipassword/version.rb
 - lib/omniauth/strategies/multi_password.rb
 - omniauth-multipassword.gemspec
+- spec/omniauth/multipassword/base_spec.rb
+- spec/omniauth/strategy/multi_password_spec.rb
+- spec/spec_helper.rb
 homepage: https://github.com/jgraichen/omniauth-multipassword
 licenses:
 - MIT
@@ -51,17 +55,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.3
+rubygems_version: 2.4.6
 signing_key: 
 specification_version: 4
 summary: A OmniAuth strategy to authenticate using different passwort strategies.