omniauth-identity 3.0.7 → 3.0.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 89bd05bb3cf63c0a47e41c8f955f9b076d5c6b4ae0704eda10819f801eaa6059
-  data.tar.gz: a272f35f9bcc0de8937279904e2bde912865b50ac3a7752dada19f0ec7d6868c
+  metadata.gz: 26637a55190cccdef70e9a1fc568005e23b7ebff9ba3ec6d2f5ea4398117f04d
+  data.tar.gz: d31d884aae50bd00c0d3820030c107def5bbcaf6507eb5628e068ac090ccc8c7
 SHA512:
-  metadata.gz: 26286ae10ba06b45b815bd21892ac27378eb338e446f0dcbe96037a8aa51d4097b55243ae12f5feef133577b1d793ce4732f636f930a6773c6b7e154e6256b4c
-  data.tar.gz: 11fc92beba0b8b849c1ce15784870bf4318aeaea14e5c7172f9c26b1891e357ba9603106765a5b2554c20d177a17c5e820bdb01733de169f3e67ec192f8d42e4
+  metadata.gz: 86f91851a1e9884d95e3b3d765176f8faed5c7acbf7d79e168d803a09275c228a5cfe1221ee5fedd69689fccbc2af04d4857342bf5ae273f7a4d873a5e7e36c7
+  data.tar.gz: 81462770cbbd476db63d133831a36710178fef1702f5277a8a13248c17bf3fd91bba74f81337239b43202b10c079a3196f2ce912452c803e387c13b0c7361214

data/CHANGELOG.md

@@ -8,6 +8,14 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [3.0.8] - 2021-03-24
+
+### Fixed
+
+- \[Model\] Fixes 2 issues raised in a comment on PR [#108](https://github.com/omniauth/omniauth-identity/pull/108#issuecomment-804456604)
+  - When `options[:on_validation]` is set `new`/`save`/`persisted?` logic is used.
+  - When `options[:on_validation]` is not set `create`/`persisted?` logic is used.
+
 ## [3.0.7] - 2021-03-23
 
 ### Fixed

data/lib/omniauth-identity/version.rb

@@ -2,6 +2,6 @@
 
 module OmniAuth
   module Identity
-    VERSION = '3.0.7'
+    VERSION = '3.0.8'
   end
 end

data/lib/omniauth/strategies/identity.rb

@@ -76,17 +76,19 @@ module OmniAuth
         if model.respond_to?(:column_names) && model.column_names.include?('provider')
           attributes.reverse_merge!(provider: 'identity')
         end
-        @identity = model.new(attributes)
-        if saving_instead_of_creating?
+        if validating?
+          @identity = model.new(attributes)
           env['omniauth.identity'] = @identity
-          if !validating? || valid?
+          if valid?
             @identity.save
             registration_result
           else
             registration_failure(options[:validation_failure_message])
           end
         else
-          deprecated_registration(attributes)
+          @identity = model.create(attributes)
+          env['omniauth.identity'] = @identity
+          registration_result
         end
       end
 
@@ -141,10 +143,6 @@ module OmniAuth
         end
       end
 
-      def saving_instead_of_creating?
-        @identity.respond_to?(:save) && @identity.respond_to?(:persisted?)
-      end
-
       # Validates the model before it is persisted
       #
       # @return [truthy or falsey] :on_validation option is truthy or falsey
@@ -177,17 +175,6 @@ module OmniAuth
           registration_failure(options[:registration_failure_message])
         end
       end
-
-      def deprecated_registration(attributes)
-        warn <<~CREATEDEP
-          [DEPRECATION] Please define '#{model.class}#save'.
-                        Behavior based on '#{model.class}.create' will be removed in omniauth-identity v4.0.
-                        See lib/omniauth/identity/model.rb
-        CREATEDEP
-        @identity = model.create(attributes)
-        env['omniauth.identity'] = @identity
-        registration_result
-      end
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: omniauth-identity
 version: !ruby/object:Gem::Version
-  version: 3.0.7
+  version: 3.0.8
 platform: ruby
 authors:
 - Peter Boling