omniauth-edmodo 0.0.8 → 0.0.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a1e632b24585480c84d4199d2da90a250c45f63a
-  data.tar.gz: c1bfc0573b9f3e19eedd83911815e8767c79a37a
+  metadata.gz: c3b043fa2a5a2713712ef61ca74612a6d7ff5713
+  data.tar.gz: 71ff7005637d164f711958b763f5d43ad5c379a4
 SHA512:
-  metadata.gz: d3a932be2d1d00298c5440664ff37bff5db3d0e362bb71d2434bdaf8d881a71762ab1403b13738e76473ad228cfd366721bfb26a7977abbbe82459e05d4bc211
-  data.tar.gz: b72e2e97efd938e4c705763f6a70bab4b343e4d6ad22faa782d775bdb6bfa32a25f5739957917e2b3b3a7ded01511052cdb335660779269b1cf2a6b882aad79f
+  metadata.gz: fa1c529367b5ccb66a5ab6ccc340b5951b135cad7aa46129290044c074c6656d9623ccab02ffce86e64e2fc0599769ff5dd70d2bb4097971ccda532d44e315df
+  data.tar.gz: de7e273ae1316787faf4d823534bda2194937ba789c886c79bd1d75ad5bd93e90909f4eea8df6d50d839bac8e5ff3c7b8c6631e58c59a972108aac802f1fe0ed

data/README.md

@@ -1,6 +1,6 @@
 # Omniauth Edmodo
 
-This is the OmniAuth strategy for authenticating to Edmodo. TO use it, you'll need to obtain an OAuth2 application key and secret from Edmodo.
+This is the OmniAuth strategy for authenticating to Edmodo. To use it, you'll need to obtain an OAuth2 application key and secret from Edmodo.
 
 ## Installation
 
@@ -18,10 +18,14 @@ Or install it yourself as:
 
 ## Basic Usage
 
-    use OmniAuth::Builder do
+There is no difference between the following code and using each strategy indivually as middleware. This is an example that you might put into a Rails initializer at config/initializers/omniauth.rb
+
+    Rails.application.config.use OmniAuth::Builder do
       provider :edmodo, ENV['EDMODO_KEY'], ENV['EDMODO_SECRET'], scope: "basic,read_user_email"
     end
 
+See more at https://github.com/intridea/omniauth
+
 ## Contributing
 
 1. Fork it ( https://github.com/[my-github-username]/omniauth-edmodo/fork )

data/lib/omniauth/strategies/edmodo.rb

@@ -31,7 +31,7 @@ module OmniAuth
           'email' => raw_info['email'],
           'first_name' => raw_info['first_name'],
           'last_name' => raw_info['last_name'],
-          'image' => raw_info['avatars']['large']
+          'image' => raw_info.fetch('avatars', {})['large']
         }
       end
 

data/lib/omniauth-edmodo/version.rb

@@ -1,5 +1,5 @@
 module Omniauth
   module Edmodo
-    VERSION = "0.0.8"
+    VERSION = "0.0.9"
   end
 end

data/spec/omniauth/strategies/edmodo_spec.rb

@@ -60,4 +60,69 @@ describe OmniAuth::Strategies::Edmodo do
       expect(subject.raw_info).to eq(parsed_response)
     end
   end
+
+  context '#info' do
+    before do
+      allow(access_token).to receive(:get).with('users/me').and_return(response)
+    end
+
+    context 'when user signing in is a student' do
+      let(:parsed_response) do
+        { 'url' => 'https://api.edmodo.com/users/123', 'id' => 123, 'type' => 'student' }
+      end
+
+      it 'should return empty profile' do
+        expect(subject.info).to eq({
+          'nickname' => nil,
+          'email' => nil,
+          'first_name' => nil,
+          'last_name' => nil,
+          'image' => nil
+        })
+      end
+    end
+
+    context 'when user signing in is a teacher' do
+      let(:parsed_response) do
+        {
+          'url' => 'https://api.edmodo.com/users/123',
+          'id' => 123,
+          'type' => 'teacher',
+          'username' => 'jeff',
+          'email' => 'jeff@example.org',
+          'first_name' => 'Jeff',
+          'last_name' => 'Jefferson',
+          'avatars' => { 'large' => 'https://u.ph.edim.co/123/123.png' }
+        }
+      end
+
+      it 'should return profile with nickname, email, first_name, last_name and image' do
+        expect(subject.info).to eq({
+          'nickname' => 'jeff',
+          'email' => 'jeff@example.org',
+          'first_name' => 'Jeff',
+          'last_name' => 'Jefferson',
+          'image' => 'https://u.ph.edim.co/123/123.png'
+        })
+      end
+
+      context 'without an avatar' do
+        let(:parsed_response) do
+          {
+           'url' => 'https://api.edmodo.com/users/123',
+           'id' => 123,
+           'type' => 'teacher',
+           'username' => 'jeff',
+           'email' => 'jeff@example.org',
+           'first_name' => 'Jeff',
+           'last_name' => 'Jefferson'
+          }
+        end
+
+        it 'should include empty "image" property' do
+          expect(subject.info).to include({ 'image' => nil })
+        end
+      end
+    end
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: omniauth-edmodo
 version: !ruby/object:Gem::Version
-  version: 0.0.8
+  version: 0.0.9
 platform: ruby
 authors:
 - Jerry Luk
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-08-12 00:00:00.000000000 Z
+date: 2015-08-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: omniauth
@@ -147,7 +147,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.4.6
 signing_key: 
 specification_version: 4
 summary: OmniAuth strategy for Edmodo