omniauth-artsy 0.2.0 → 0.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 84c99fab0ddb785b438967eb1dbaf35ec62ed53b
-  data.tar.gz: 10d61d64a4a3cb913d72cc62ee0bab142bfe8042
+  metadata.gz: 72a0934cb2f200b475f98786ff00b6f6e941e0ea
+  data.tar.gz: 94efa9e5725f75610d36174e15770ed27582c7fe
 SHA512:
-  metadata.gz: 2d56f1e29e8254e78ee73ab138454badb183d099beae4df6cd7b544dc240fa5e5291e3a828036c52d91b59301a821796e4c8e2507aec10e56f7582ff12a6727f
-  data.tar.gz: 72a3ccaa269c35c9931b7bf87f328653edf86d1902944aaca8407ba0d42f67b2a462fb2e1d8c8e6fc4631868a70cf74ca3dbd2ee4e18f0b8d7d792e477b6e3ec
+  metadata.gz: e3291407926b8f67989fd079e52e201f0c3d59f94a817a8631788dfc906dfe9ae0b2ed982ed7c1af757e5b4f2bcd1d1909dc5acd146d389d4ef440785109ea58
+  data.tar.gz: baf43adc69c2258fff4a456c9ab27ec25606c283a4f26fc1fa200bccfdba2c310223a6330e8d5f9f0c713dd26b4d5da2d47ad8d6636942b5482ed2557ed5d3b2

data/.rubocop_todo.yml

@@ -1,25 +1,47 @@
-# This configuration was generated by `rubocop --auto-gen-config`
-# on 2014-08-25 15:35:38 -0400 using RuboCop version 0.25.0.
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2017-03-31 17:08:47 -0400 using RuboCop version 0.48.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
+# Offense count: 2
+# Configuration parameters: CountComments, ExcludedMethods.
+Metrics/BlockLength:
+  Max: 64
+
 # Offense count: 8
-# Configuration parameters: AllowURI.
+# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
+# URISchemes: http, https
 Metrics/LineLength:
   Max: 154
 
-# Offense count: 2
+# Offense count: 3
 Style/Documentation:
-  Enabled: false
+  Exclude:
+    - 'spec/**/*'
+    - 'test/**/*'
+    - 'lib/omniauth-artsy/config.rb'
+    - 'lib/omniauth/strategies/artsy.rb'
+
+# Offense count: 1
+# Configuration parameters: ExpectMatchingDefinition, Regex, IgnoreExecutableScripts, AllowedAcronyms.
+# AllowedAcronyms: CLI, DSL, ACL, API, ASCII, CPU, CSS, DNS, EOF, GUID, HTML, HTTP, HTTPS, ID, IP, JSON, LHS, QPS, RAM, RHS, RPC, SLA, SMTP, SQL, SSH, TCP, TLS, TTL, UDP, UI, UID, UUID, URI, URL, UTF8, VM, XML, XMPP, XSRF, XSS
+Style/FileName:
+  Exclude:
+    - 'lib/omniauth-artsy.rb'
 
-# Offense count: 7
+# Offense count: 1
 # Configuration parameters: EnforcedStyle, SupportedStyles.
-Style/Encoding:
-  Enabled: false
+# SupportedStyles: module_function, extend_self
+Style/ModuleFunction:
+  Exclude:
+    - 'lib/omniauth-artsy/config.rb'
 
 # Offense count: 1
-# Configuration parameters: Exclude.
-Style/FileName:
-  Enabled: false
+# Cop supports --auto-correct.
+# Configuration parameters: SupportedStyles.
+# SupportedStyles: percent, brackets
+Style/SymbolArray:
+  EnforcedStyle: brackets

data/CHANGELOG.md

@@ -1,3 +1,13 @@
+0.2.2 (Next)
+============
+
+* Your contribution here.
+
+0.2.1
+============
+
+* [#6](https://github.com/artsy/omniauth-artsy/pull/6): Add config so we can configure/initialize `OmniAuth::Artsy` - [@ashkan18](https://github.com/ashkan18).
+
 0.2.0 (5/4/2016)
 ================
 

data/README.md

@@ -28,7 +28,17 @@ end
 
 #### Configuration
 
-Set `ENV['ARTSY_API_URL']` to the location of the Artsy API, typically *https://api.artsy.net* in production. Defaults to *http://localhost:3000*.
+##### Configure in your app
+Add `omniauth_artsy.rb` to your `config/initializers` and set `artsy_api_url`.
+```ruby
+# config/initializers/omniauth_artsy.rb
+OmniAuth::Artsy.configure do |config|
+  config.artsy_api_url = ENV['ARTSY_API_URL']
+end
+```
+
+##### Using ENV
+Set `ENV['ARTSY_API_URL']` to the location of the Artsy API, typically *https://api.artsy.net* in production.
 
 ### License
 

data/lib/omniauth-artsy.rb

@@ -1,2 +1,3 @@
 require 'omniauth-artsy/version'
+require 'omniauth-artsy/config'
 require 'omniauth/strategies/artsy'

data/lib/omniauth-artsy/config.rb

@@ -0,0 +1,25 @@
+module OmniAuth
+  module Artsy
+    module Config
+      extend self
+
+      attr_accessor :artsy_api_url
+
+      def reset
+        self.artsy_api_url = nil
+      end
+
+      reset
+    end
+
+    class << self
+      def configure
+        block_given? ? yield(Config) : Config
+      end
+
+      def config
+        Config
+      end
+    end
+  end
+end

data/lib/omniauth-artsy/version.rb

@@ -1,5 +1,5 @@
 module Omniauth
   module Artsy
-    VERSION = '0.2.0'
+    VERSION = '0.2.1'.freeze
   end
 end

data/lib/omniauth/strategies/artsy.rb

@@ -4,7 +4,7 @@ module OmniAuth
   module Strategies
     class Artsy < OmniAuth::Strategies::OAuth2
       option :client_options,
-             site: ENV['ARTSY_API_URL'] || ENV['gravity_url'] || 'http://localhost:3000',
+             site: OmniAuth::Artsy.config.artsy_api_url || ENV['ARTSY_API_URL'] || ENV['gravity_url'],
              authorize_url: '/oauth2/authorize?scope=offline_access&response_type=code',
              token_url: '/oauth2/access_token?scope=offline_access&response_type=code&grant_type=authorization_code'
 

data/omniauth-artsy.gemspec

@@ -1,4 +1,5 @@
 # -*- encoding: utf-8 -*-
+
 $LOAD_PATH.push File.expand_path('../lib', __FILE__)
 require 'omniauth-artsy/version'
 
@@ -21,5 +22,5 @@ Gem::Specification.new do |s|
   s.add_development_dependency 'rake'
   s.add_development_dependency 'rspec'
   s.add_development_dependency 'webmock'
-  s.add_development_dependency 'rubocop', '0.25.0'
+  s.add_development_dependency 'rubocop'
 end

data/spec/lib/config_spec.rb

@@ -0,0 +1,17 @@
+require 'spec_helper'
+
+describe OmniAuth::Artsy::Config do
+  describe '#configure' do
+    before do
+      OmniAuth::Artsy.configure do |config|
+        config.artsy_api_url = 'http://localhost:3000/api'
+      end
+    end
+    after do
+      OmniAuth::Artsy.config.reset
+    end
+    it 'sets token' do
+      expect(OmniAuth::Artsy.config.artsy_api_url).to eq 'http://localhost:3000/api'
+    end
+  end
+end

data/spec/omniauth/strategies/artsy_spec.rb

@@ -22,8 +22,8 @@ describe OmniAuth::Strategies::Artsy do
   end
 
   describe '#client_options' do
-    it 'has correct Artsy API URL' do
-      expect(subject.options.client_options.site).to eq('http://localhost:3000')
+    it 'returns nil for Artsy API URL without setting' do
+      expect(subject.options.client_options.site).to be_nil
     end
 
     it 'has correct authorize url' do

data/spec/spec_helper.rb

@@ -5,6 +5,4 @@ require 'omniauth-artsy'
 require 'rspec'
 require 'webmock/rspec'
 
-RSpec.configure do |config|
-  config.raise_errors_for_deprecations!
-end
+RSpec.configure(&:raise_errors_for_deprecations!)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: omniauth-artsy
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.1
 platform: ruby
 authors:
 - Dylan Fareed
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-05-04 00:00:00.000000000 Z
+date: 2017-03-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: omniauth-oauth2
@@ -70,16 +70,16 @@ dependencies:
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 0.25.0
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 0.25.0
+        version: '0'
 description: 'Omniauth plugin for Artsy authentication.  '
 email:
 - dylan@artsy.net
@@ -98,9 +98,11 @@ files:
 - README.md
 - Rakefile
 - lib/omniauth-artsy.rb
+- lib/omniauth-artsy/config.rb
 - lib/omniauth-artsy/version.rb
 - lib/omniauth/strategies/artsy.rb
 - omniauth-artsy.gemspec
+- spec/lib/config_spec.rb
 - spec/omniauth/strategies/artsy_spec.rb
 - spec/spec_helper.rb
 homepage: https://github.com/artsy/omniauth-artsy
@@ -123,10 +125,11 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.8
+rubygems_version: 2.6.11
 signing_key: 
 specification_version: 4
 summary: Omniauth plugin for Artsy authentication.
 test_files:
+- spec/lib/config_spec.rb
 - spec/omniauth/strategies/artsy_spec.rb
 - spec/spec_helper.rb