omni_kassa 1.2.1 → 1.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d546a263a0eaf9f3f1e4590da333f59b6ef21d33
-  data.tar.gz: 22e0417674cdffaeb25df9ab428020d07c2f9ac1
+  metadata.gz: 80f9c48b4c414542401fe6ed235bffe8c24fd80a
+  data.tar.gz: 0230889fe5e5eb16b080b58b108df08d9354aafe
 SHA512:
-  metadata.gz: 65e40c69268b321de284d12b0273b5f50e996484cb22c9f9b37f1d304244ef95920de2d4f6f88d3f120cc646e195a4396ca57c9dc8a5826fb4e2a671251fe9ae
-  data.tar.gz: 105c0fe86f25770cb6a33fd63c7e2b7d6b0932536238c4fe2e859e80dfc9ce1ba9463ad4114a8fb0fd090fe6136e72be835b9b5aea9e3d0f092c79e24686a293
+  metadata.gz: 6057c969480ae4b1ff986ceaf7a39bd24a5e05756bb128c8a6362576ad240d3ba820d2be91e2d0c8404056d6d049426d05172cb25424df48b08584b9481f4908
+  data.tar.gz: e3821b5f57be3ef3540c5207c0c5a4b0e5823ec456d7aac38bd5cb0f571ad65164d708e766f97bdff7efa7b98100712125d909ea68993714315728f922073925

data/Gemfile.lock

@@ -1,23 +1,23 @@
 PATH
   remote: .
   specs:
-    omni_kassa (1.2.0)
+    omni_kassa (1.3.0)
       activesupport
       httparty
 
 GEM
   remote: https://rubygems.org/
   specs:
-    activesupport (3.2.11)
-      i18n (~> 0.6)
+    activesupport (3.2.13)
+      i18n (= 0.6.1)
       multi_json (~> 1.0)
-    httparty (0.10.0)
+    httparty (0.11.0)
       multi_json (~> 1.0)
-      multi_xml
+      multi_xml (>= 0.5.2)
     i18n (0.6.1)
     minitest (4.4.0)
-    multi_json (1.5.0)
-    multi_xml (0.5.2)
+    multi_json (1.7.7)
+    multi_xml (0.5.4)
     rack (1.4.3)
     rack-protection (1.3.2)
       rack

data/README.md

@@ -2,7 +2,7 @@
 [![Gem Version](https://badge.fury.io/rb/omni_kassa.png)][gem]
 [![Build Status](https://secure.travis-ci.org/pepijn/omni_kassa.png?branch=master)](https://travis-ci.org/pepijn/omni_kassa) 
 [![Dependency Status](https://gemnasium.com/pepijn/omni_kassa.png)](https://gemnasium.com/pepijn/omni_kassa) 
-[![Code Climate](https://codeclimate.com/badge.png)](https://codeclimate.com/github/pepijn/omni_kassa)
+[![Code Climate](https://codeclimate.com/github/pepijn/omni_kassa.png)](https://codeclimate.com/github/pepijn/omni_kassa)
 
 Easier Rabobank OmniKassa payments. Extracted from www.studysquare.nl. [RDocs](http://rdoc.info/projects/pepijn/omni_kassa).
 

data/lib/omni_kassa/request.rb

@@ -31,6 +31,7 @@ module OmniKassa
     end
 
     def perform
+      # SSLv3 is a TravisCI requirement; won't run otherwise
       HTTParty.post(OmniKassa.url, query: query, ssl_version: :SSLv3).body
     end
 

data/lib/omni_kassa/response.rb

@@ -2,8 +2,10 @@ module OmniKassa
   class Response
     RESPONSE_CODES = {
       0  => :success,
-      17 => :user_cancellation,
-      97 => :request_timeout
+      17 => :cancelled,
+      60 => :pending,
+      90 => :pending,
+      97 => :expired
     }
 
     attr_accessor :data, :seal, :order_id, :response_code, :amount
@@ -15,12 +17,16 @@ module OmniKassa
       verify_seal!
     end
 
+    def pending?
+      response == :pending
+    end
+
     def successful?
       response == :success
     end
 
     def response
-      RESPONSE_CODES[response_code] or :unknown_failure
+      RESPONSE_CODES[response_code] || :unknown_failure
     end
 
     def data=(data)
@@ -48,7 +54,7 @@ module OmniKassa
     end
 
     def data_hash
-      Hash[data.split('|').map {|a| a.split('=') }]
+      Hash[data.split('|').map { |a| a.split('=') }]
     end
 
     class SealMismatchError < OmniKassaError; end

data/omni_kassa.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |s|
   s.name    = 'omni_kassa'
-  s.version = '1.2.1'
+  s.version = '1.3.0'
   s.author  = 'Pepijn Looije'
   s.email   = 'pepijn@plict.nl'
   s.description = s.summary = 'Easier Rabobank OmniKassa payments'

data/test/response_test.rb

@@ -1,14 +1,15 @@
 require 'omni_kassa/test_helper'
 
+RESPONSE_PARAMS =  {
+  Data: "amount=1337|captureDay=0|captureMode=AUTHOR_CAPTURE|currencyCode=978|merchantId=002020000000001|orderId=527|transactionDateTime=2012-12-02T21:41:01+01:00|transactionReference=omnikassatest1354480861|keyVersion=1|authorisationId=0020000006791167|paymentMeanBrand=IDEAL|paymentMeanType=CREDIT_TRANSFER|responseCode=00",
+  InterfaceVersion: "HP_1.0",
+  Encode: '',
+  Seal: '46204f0e97394293c9270b6313e78524027acba1f83d4ce9682848e1f5927ab3'
+}
+
 class ResponseTest < MiniTest::Unit::TestCase
   def setup
-    @params = {
-      Data: "amount=1337|captureDay=0|captureMode=AUTHOR_CAPTURE|currencyCode=978|merchantId=002020000000001|orderId=527|transactionDateTime=2012-12-02T21:41:01+01:00|transactionReference=omnikassatest1354480861|keyVersion=1|authorisationId=0020000006791167|paymentMeanBrand=IDEAL|paymentMeanType=CREDIT_TRANSFER|responseCode=00",
-      InterfaceVersion: "HP_1.0",
-      Encode: '',
-      Seal: '46204f0e97394293c9270b6313e78524027acba1f83d4ce9682848e1f5927ab3'
-    }
-
+    @params = RESPONSE_PARAMS.clone
     @response = OmniKassa::Response.new(@params)
   end
 
@@ -19,15 +20,33 @@ class ResponseTest < MiniTest::Unit::TestCase
 
   def test_responses
     assert_equal :success, @response.response
+    refute @response.pending?
+    assert @response.successful?
 
     @response.response_code = 17
-    assert_equal :user_cancellation, @response.response
+    assert_equal :cancelled, @response.response
+    refute @response.pending?
+    refute @response.successful?
+
+    @response.response_code = 60
+    assert_equal :pending, @response.response
+    assert @response.pending?
+    refute @response.successful?
+
+    @response.response_code = 90
+    assert_equal :pending, @response.response
+    assert @response.pending?
+    refute @response.successful?
 
     @response.response_code = 97
-    assert_equal :request_timeout, @response.response
+    assert_equal :expired, @response.response
+    refute @response.pending?
+    refute @response.successful?
 
     @response.response_code = 1 # not 0
     assert_equal :unknown_failure, @response.response
+    refute @response.pending?
+    refute @response.successful?
   end
 
   def test_invalid_seal

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: omni_kassa
 version: !ruby/object:Gem::Version
-  version: 1.2.1
+  version: 1.3.0
 platform: ruby
 authors:
 - Pepijn Looije
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-05-09 00:00:00.000000000 Z
+date: 2013-06-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httparty
@@ -108,6 +108,7 @@ files:
 - ./lib/omni_kassa/response.rb
 - ./lib/omni_kassa.rb
 - ./LICENSE
+- ./omni_kassa-1.2.1.gem
 - ./omni_kassa.gemspec
 - ./Rakefile
 - ./README.md