omg_pull_request 0.2.1 → 0.2.2

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    omg_pull_request (0.2.1)
+    omg_pull_request (0.2.2)
       activesupport (>= 3.2.6)
       aws-s3 (>= 0.6.3)
       faraday (>= 0.8.4)

data/lib/omg_pull_request/git_client.rb

@@ -13,7 +13,7 @@ module OmgPullRequest
     end
 
     def checkout!(sha)
-      logger.log `cd #{local_repo} && git reset --hard && git fetch && git checkout #{sha} 2>&1`
+      execute_verify_success "cd #{local_repo} && git reset --hard && git fetch && git checkout #{sha} 2>&1"
     end
 
     def merge!(sha)
@@ -22,9 +22,17 @@ module OmgPullRequest
       merge_response.match(/CONFLICT/) ? :conflict : :success
     end
 
-
     private
 
+    def execute_verify_success(command)
+      result = `#{command}`
+      logger.log(command) 
+      logger.log(result)
+      exit_code = $?.to_i
+      raise "Not a successful response code: #{exit_code}" unless exit_code.zero?
+      result
+    end
+
     extend Configuration::Helpers
     delegate_config_to(:configuration, :local_repo)
   end

data/lib/omg_pull_request/version.rb

@@ -1,3 +1,3 @@
 module OmgPullRequest
-  VERSION = "0.2.1"
+  VERSION = "0.2.2"
 end

data/locales/en.yml

@@ -11,7 +11,7 @@ Issue Number: %{issue_number}"
     github:
       message: ":trollface: Running tests: `%{abbr_from_sha}` to `%{abbr_to_sha}`"
       lolcommits:
-        message: ":trollface: Running tests: `%{abbr_from_sha}` to `%{abbr_to_sha}\n\nThis is what hard work looks like\n![Pretty Pictures](%{animation_url})"
+        message: ":trollface: Running tests: `%{abbr_from_sha}` to `%{abbr_to_sha}`\n\nThis is what hard work looks like\n![Pretty Pictures](%{animation_url})"
 
   completed:
     github:

data/test/units/omg_pull_request/git_client_test.rb

@@ -0,0 +1,24 @@
+require './test/test_helper.rb'
+
+module OmgPullRequest
+  class GitClientTest < MiniTest::Unit::TestCase
+    
+    def test_execute_verify_success
+      assert_raises RuntimeError do
+        git_client.send(:execute_verify_success, 'git omg lol 2>&1')
+      end
+
+      git_client.expects(:log).twice
+      resp = git_client.send(:execute_verify_success, 'git --version')
+      assert resp.match(/git/)
+      git_client.unstub(:log)
+    end
+
+    private
+
+    def git_client
+      @git_client ||= GitClient.new(:logger => TestLogger.new)
+    end
+
+  end
+end

data/test/units/omg_pull_request/notifications_test.rb

@@ -39,7 +39,7 @@ module OmgPullRequest
 
     def test_make_comment_test_running
       mock_runner.expects(:github_comment).with(
-        ":trollface: Running tests: `abbr_from_sha` to `abbr_to_sha\n\nThis is what hard work looks like\n![Pretty Pictures](http://lolcommits.com/omg)"
+        ":trollface: Running tests: `abbr_from_sha` to `abbr_to_sha`\n\nThis is what hard work looks like\n![Pretty Pictures](http://lolcommits.com/omg)"
       )
       mock_runner.send(:make_comment_test_running!)
     end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: omg_pull_request
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.2.2
   prerelease: 
 platform: ruby
 authors:
@@ -12,11 +12,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-09-09 00:00:00.000000000Z
+date: 2012-09-18 00:00:00.000000000Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: aws-s3
-  requirement: &70109182790380 !ruby/object:Gem::Requirement
+  requirement: &70262823932520 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -24,10 +24,10 @@ dependencies:
         version: 0.6.3
   type: :runtime
   prerelease: false
-  version_requirements: *70109182790380
+  version_requirements: *70262823932520
 - !ruby/object:Gem::Dependency
   name: faraday
-  requirement: &70109182789880 !ruby/object:Gem::Requirement
+  requirement: &70262823932020 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -35,10 +35,10 @@ dependencies:
         version: 0.8.4
   type: :runtime
   prerelease: false
-  version_requirements: *70109182789880
+  version_requirements: *70262823932020
 - !ruby/object:Gem::Dependency
   name: github_api
-  requirement: &70109182789420 !ruby/object:Gem::Requirement
+  requirement: &70262823931560 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -46,10 +46,10 @@ dependencies:
         version: 0.6.5
   type: :runtime
   prerelease: false
-  version_requirements: *70109182789420
+  version_requirements: *70262823931560
 - !ruby/object:Gem::Dependency
   name: uuid
-  requirement: &70109182788960 !ruby/object:Gem::Requirement
+  requirement: &70262823931100 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -57,10 +57,10 @@ dependencies:
         version: 2.3.5
   type: :runtime
   prerelease: false
-  version_requirements: *70109182788960
+  version_requirements: *70262823931100
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &70109182788500 !ruby/object:Gem::Requirement
+  requirement: &70262823930640 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -68,10 +68,10 @@ dependencies:
         version: 0.9.2.2
   type: :runtime
   prerelease: false
-  version_requirements: *70109182788500
+  version_requirements: *70262823930640
 - !ruby/object:Gem::Dependency
   name: activesupport
-  requirement: &70109182788040 !ruby/object:Gem::Requirement
+  requirement: &70262823930180 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -79,10 +79,10 @@ dependencies:
         version: 3.2.6
   type: :runtime
   prerelease: false
-  version_requirements: *70109182788040
+  version_requirements: *70262823930180
 - !ruby/object:Gem::Dependency
   name: i18n
-  requirement: &70109182787580 !ruby/object:Gem::Requirement
+  requirement: &70262823929720 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -90,7 +90,7 @@ dependencies:
         version: 0.6.0
   type: :runtime
   prerelease: false
-  version_requirements: *70109182787580
+  version_requirements: *70262823929720
 description: Have tests run automatically for your Github Pull Request
 email:
 - kenmazaika@gmail.com
@@ -138,6 +138,7 @@ files:
 - test/mocks/pull_request.rb
 - test/omg_pull_request/.gitkeep
 - test/test_helper.rb
+- test/units/omg_pull_request/git_client_test.rb
 - test/units/omg_pull_request/github_wrapper_test.rb
 - test/units/omg_pull_request/lolcommits_test.rb
 - test/units/omg_pull_request/notifications_test.rb
@@ -182,6 +183,7 @@ test_files:
 - test/mocks/pull_request.rb
 - test/omg_pull_request/.gitkeep
 - test/test_helper.rb
+- test/units/omg_pull_request/git_client_test.rb
 - test/units/omg_pull_request/github_wrapper_test.rb
 - test/units/omg_pull_request/lolcommits_test.rb
 - test/units/omg_pull_request/notifications_test.rb