omg_pull_request 0.2.1 → 0.2.2

Sign up to get free protection for your applications and to get access to all the features.
Files changed (7) hide show
  1. data/Gemfile.lock +1 -1
  2. data/lib/omg_pull_request/git_client.rb +10 -2
  3. data/lib/omg_pull_request/version.rb +1 -1
  4. data/locales/en.yml +1 -1
  5. data/test/units/omg_pull_request/git_client_test.rb +24 -0
  6. data/test/units/omg_pull_request/notifications_test.rb +1 -1
  7. metadata +18 -16
data/Gemfile.lock CHANGED
@@ -1,7 +1,7 @@
1
1
  PATH
2
2
  remote: .
3
3
  specs:
4
- omg_pull_request (0.2.1)
4
+ omg_pull_request (0.2.2)
5
5
  activesupport (>= 3.2.6)
6
6
  aws-s3 (>= 0.6.3)
7
7
  faraday (>= 0.8.4)
data/lib/omg_pull_request/git_client.rb CHANGED
@@ -13,7 +13,7 @@ module OmgPullRequest
13
13
  end
14
14
 
15
15
  def checkout!(sha)
16
- logger.log `cd #{local_repo} && git reset --hard && git fetch && git checkout #{sha} 2>&1`
16
+ execute_verify_success "cd #{local_repo} && git reset --hard && git fetch && git checkout #{sha} 2>&1"
17
17
  end
18
18
 
19
19
  def merge!(sha)
@@ -22,9 +22,17 @@ module OmgPullRequest
22
22
  merge_response.match(/CONFLICT/) ? :conflict : :success
23
23
  end
24
24
 
25
-
26
25
  private
27
26
 
27
+ def execute_verify_success(command)
28
+ result = `#{command}`
29
+ logger.log(command)
30
+ logger.log(result)
31
+ exit_code = $?.to_i
32
+ raise "Not a successful response code: #{exit_code}" unless exit_code.zero?
33
+ result
34
+ end
35
+
28
36
  extend Configuration::Helpers
29
37
  delegate_config_to(:configuration, :local_repo)
30
38
  end
data/lib/omg_pull_request/version.rb CHANGED
@@ -1,3 +1,3 @@
1
1
  module OmgPullRequest
2
- VERSION = "0.2.1"
2
+ VERSION = "0.2.2"
3
3
  end
data/locales/en.yml CHANGED
@@ -11,7 +11,7 @@ Issue Number: %{issue_number}"
11
11
  github:
12
12
  message: ":trollface: Running tests: `%{abbr_from_sha}` to `%{abbr_to_sha}`"
13
13
  lolcommits:
14
- message: ":trollface: Running tests: `%{abbr_from_sha}` to `%{abbr_to_sha}\n\nThis is what hard work looks like\n![Pretty Pictures](%{animation_url})"
14
+ message: ":trollface: Running tests: `%{abbr_from_sha}` to `%{abbr_to_sha}`\n\nThis is what hard work looks like\n![Pretty Pictures](%{animation_url})"
15
15
 
16
16
  completed:
17
17
  github:
data/test/units/omg_pull_request/git_client_test.rb ADDED
@@ -0,0 +1,24 @@
1
+ require './test/test_helper.rb'
2
+
3
+ module OmgPullRequest
4
+ class GitClientTest < MiniTest::Unit::TestCase
5
+
6
+ def test_execute_verify_success
7
+ assert_raises RuntimeError do
8
+ git_client.send(:execute_verify_success, 'git omg lol 2>&1')
9
+ end
10
+
11
+ git_client.expects(:log).twice
12
+ resp = git_client.send(:execute_verify_success, 'git --version')
13
+ assert resp.match(/git/)
14
+ git_client.unstub(:log)
15
+ end
16
+
17
+ private
18
+
19
+ def git_client
20
+ @git_client ||= GitClient.new(:logger => TestLogger.new)
21
+ end
22
+
23
+ end
24
+ end
data/test/units/omg_pull_request/notifications_test.rb CHANGED
@@ -39,7 +39,7 @@ module OmgPullRequest
39
39
 
40
40
  def test_make_comment_test_running
41
41
  mock_runner.expects(:github_comment).with(
42
- ":trollface: Running tests: `abbr_from_sha` to `abbr_to_sha\n\nThis is what hard work looks like\n![Pretty Pictures](http://lolcommits.com/omg)"
42
+ ":trollface: Running tests: `abbr_from_sha` to `abbr_to_sha`\n\nThis is what hard work looks like\n![Pretty Pictures](http://lolcommits.com/omg)"
43
43
  )
44
44
  mock_runner.send(:make_comment_test_running!)
45
45
  end
metadata CHANGED
@@ -1,7 +1,7 @@
1
1
  --- !ruby/object:Gem::Specification
2
2
  name: omg_pull_request
3
3
  version: !ruby/object:Gem::Version
4
- version: 0.2.1
4
+ version: 0.2.2
5
5
  prerelease:
6
6
  platform: ruby
7
7
  authors:
@@ -12,11 +12,11 @@ authors:
12
12
  autorequire:
13
13
  bindir: bin
14
14
  cert_chain: []
15
- date: 2012-09-09 00:00:00.000000000Z
15
+ date: 2012-09-18 00:00:00.000000000Z
16
16
  dependencies:
17
17
  - !ruby/object:Gem::Dependency
18
18
  name: aws-s3
19
- requirement: &70109182790380 !ruby/object:Gem::Requirement
19
+ requirement: &70262823932520 !ruby/object:Gem::Requirement
20
20
  none: false
21
21
  requirements:
22
22
  - - ! '>='
@@ -24,10 +24,10 @@ dependencies:
24
24
  version: 0.6.3
25
25
  type: :runtime
26
26
  prerelease: false
27
- version_requirements: *70109182790380
27
+ version_requirements: *70262823932520
28
28
  - !ruby/object:Gem::Dependency
29
29
  name: faraday
30
- requirement: &70109182789880 !ruby/object:Gem::Requirement
30
+ requirement: &70262823932020 !ruby/object:Gem::Requirement
31
31
  none: false
32
32
  requirements:
33
33
  - - ! '>='
@@ -35,10 +35,10 @@ dependencies:
35
35
  version: 0.8.4
36
36
  type: :runtime
37
37
  prerelease: false
38
- version_requirements: *70109182789880
38
+ version_requirements: *70262823932020
39
39
  - !ruby/object:Gem::Dependency
40
40
  name: github_api
41
- requirement: &70109182789420 !ruby/object:Gem::Requirement
41
+ requirement: &70262823931560 !ruby/object:Gem::Requirement
42
42
  none: false
43
43
  requirements:
44
44
  - - ! '>='
@@ -46,10 +46,10 @@ dependencies:
46
46
  version: 0.6.5
47
47
  type: :runtime
48
48
  prerelease: false
49
- version_requirements: *70109182789420
49
+ version_requirements: *70262823931560
50
50
  - !ruby/object:Gem::Dependency
51
51
  name: uuid
52
- requirement: &70109182788960 !ruby/object:Gem::Requirement
52
+ requirement: &70262823931100 !ruby/object:Gem::Requirement
53
53
  none: false
54
54
  requirements:
55
55
  - - ! '>='
@@ -57,10 +57,10 @@ dependencies:
57
57
  version: 2.3.5
58
58
  type: :runtime
59
59
  prerelease: false
60
- version_requirements: *70109182788960
60
+ version_requirements: *70262823931100
61
61
  - !ruby/object:Gem::Dependency
62
62
  name: rake
63
- requirement: &70109182788500 !ruby/object:Gem::Requirement
63
+ requirement: &70262823930640 !ruby/object:Gem::Requirement
64
64
  none: false
65
65
  requirements:
66
66
  - - ! '>='
@@ -68,10 +68,10 @@ dependencies:
68
68
  version: 0.9.2.2
69
69
  type: :runtime
70
70
  prerelease: false
71
- version_requirements: *70109182788500
71
+ version_requirements: *70262823930640
72
72
  - !ruby/object:Gem::Dependency
73
73
  name: activesupport
74
- requirement: &70109182788040 !ruby/object:Gem::Requirement
74
+ requirement: &70262823930180 !ruby/object:Gem::Requirement
75
75
  none: false
76
76
  requirements:
77
77
  - - ! '>='
@@ -79,10 +79,10 @@ dependencies:
79
79
  version: 3.2.6
80
80
  type: :runtime
81
81
  prerelease: false
82
- version_requirements: *70109182788040
82
+ version_requirements: *70262823930180
83
83
  - !ruby/object:Gem::Dependency
84
84
  name: i18n
85
- requirement: &70109182787580 !ruby/object:Gem::Requirement
85
+ requirement: &70262823929720 !ruby/object:Gem::Requirement
86
86
  none: false
87
87
  requirements:
88
88
  - - ! '>='
@@ -90,7 +90,7 @@ dependencies:
90
90
  version: 0.6.0
91
91
  type: :runtime
92
92
  prerelease: false
93
- version_requirements: *70109182787580
93
+ version_requirements: *70262823929720
94
94
  description: Have tests run automatically for your Github Pull Request
95
95
  email:
96
96
  - kenmazaika@gmail.com
@@ -138,6 +138,7 @@ files:
138
138
  - test/mocks/pull_request.rb
139
139
  - test/omg_pull_request/.gitkeep
140
140
  - test/test_helper.rb
141
+ - test/units/omg_pull_request/git_client_test.rb
141
142
  - test/units/omg_pull_request/github_wrapper_test.rb
142
143
  - test/units/omg_pull_request/lolcommits_test.rb
143
144
  - test/units/omg_pull_request/notifications_test.rb
@@ -182,6 +183,7 @@ test_files:
182
183
  - test/mocks/pull_request.rb
183
184
  - test/omg_pull_request/.gitkeep
184
185
  - test/test_helper.rb
186
+ - test/units/omg_pull_request/git_client_test.rb
185
187
  - test/units/omg_pull_request/github_wrapper_test.rb
186
188
  - test/units/omg_pull_request/lolcommits_test.rb
187
189
  - test/units/omg_pull_request/notifications_test.rb