omdbgateway 0.0.3 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 137ad66ce472ba580fcf5b382690b098d91b5591
-  data.tar.gz: a7faae220e214562050434abf668a68113cdce84
+  metadata.gz: ab416ed1c52d6e21453fe42cff37544ff01aaed4
+  data.tar.gz: 2e04e1371ae9795d3aebe22583d8a7c22f103278
 SHA512:
-  metadata.gz: 4b372f961d728f4687903806e1759afa4fc443e69a62699792b721d4205eb4e9d3c9a71338016cf6a2db521a05fb0845fc4a7c60b815bdc5dea8ea6e5f733ab7
-  data.tar.gz: 13700ee76344ff783bdbed32097442ca4385bc92b5a21f763410e3d435cfe6875e85d08b3c8a4026353af3d99bf9e3c3832745d0c3fce86e0cd5437bd1e8d77a
+  metadata.gz: 8dbc09b1ee9af7e6d791701d34884719d55a3b7e64fc9b34e5b69d72487497f75cc17b492dd95a096ca343f1b030153081d3efb3553f18031f4bf38517c3458f
+  data.tar.gz: 5c6bc1bd2ae4209f2bb86e08e55a983700a211f5b1f40f2525982e1f91b31db3381e3ebe1583b2cfcccfae9948375d22a6eceeb5255157f6ca1ff3bef15e52b0

data/.rspec

@@ -1,2 +1,4 @@
 --color
 --format progress
+--format documentation -o rspec_output.txt
+

data/.travis.yml

@@ -0,0 +1,10 @@
+language: ruby
+rvm:
+  - 2.1.0
+  - 2.0.0
+  - jruby-19mode
+  - rbx
+  - ruby-head
+  - jruby-head
+script: bundle exec rspec
+

data/README.md

@@ -2,6 +2,8 @@
 
 [![Gem Version](https://badge.fury.io/rb/omdbgateway.svg)](http://badge.fury.io/rb/omdbgateway)
 
+[![Build Status](https://travis-ci.org/stujo/omdbgateway.svg?branch=master)](https://travis-ci.org/stujo/omdbgateway)
+
 __Note__ is a faraday rewrite of [Casey Scarborough's omdbapi](https://github.com/caseyscarborough/omdbapi)
 
 Not that there's anything wrong with what he did, I just wanted to try faraday and we're using OMDB

data/fixtures/vcr_cassettes/omdbapi_com.yml

@@ -7,12 +7,12 @@ http_interactions:
       encoding: US-ASCII
       string: ''
     headers:
+      User-Agent:
+      - Faraday v0.8.9
       Accept-Encoding:
       - gzip;q=1.0,deflate;q=0.6,identity;q=0.3
       Accept:
       - "*/*"
-      User-Agent:
-      - Ruby
   response:
     status:
       code: 200
@@ -35,7 +35,7 @@ http_interactions:
       Access-Control-Allow-Origin:
       - "*"
       Date:
-      - Thu, 17 Apr 2014 22:35:44 GMT
+      - Fri, 18 Apr 2014 00:44:48 GMT
       Content-Length:
       - '417'
     body:
@@ -44,7 +44,7 @@ http_interactions:
         May 1983\",\"Runtime\":\"N/A\",\"Genre\":\"Action, Adventure, Sci-Fi\",\"Director\":\"N/A\",\"Writer\":\"N/A\",\"Actors\":\"Harrison
         Ford, Alec Guinness, Mark Hamill, James Earl Jones\",\"Plot\":\"N/A\",\"Language\":\"English\",\"Country\":\"USA\",\"Awards\":\"N/A\",\"Poster\":\"N/A\",\"Metascore\":\"N/A\",\"imdbRating\":\"7.3\",\"imdbVotes\":\"292\",\"imdbID\":\"tt0251413\",\"Type\":\"game\",\"Response\":\"True\"}"
     http_version: 
-  recorded_at: Thu, 17 Apr 2014 22:35:47 GMT
+  recorded_at: Fri, 18 Apr 2014 00:44:53 GMT
 - request:
     method: get
     uri: http://omdbapi.com/?t=True%20Grit
@@ -52,12 +52,12 @@ http_interactions:
       encoding: US-ASCII
       string: ''
     headers:
+      User-Agent:
+      - Faraday v0.8.9
       Accept-Encoding:
       - gzip;q=1.0,deflate;q=0.6,identity;q=0.3
       Accept:
       - "*/*"
-      User-Agent:
-      - Ruby
   response:
     status:
       code: 200
@@ -80,7 +80,7 @@ http_interactions:
       Access-Control-Allow-Origin:
       - "*"
       Date:
-      - Thu, 17 Apr 2014 22:35:44 GMT
+      - Fri, 18 Apr 2014 00:44:48 GMT
       Content-Length:
       - '737'
     body:
@@ -93,7 +93,7 @@ http_interactions:
         woman track down her father's murderer.\",\"Language\":\"English\",\"Country\":\"USA\",\"Awards\":\"Nominated
         for 10 Oscars. Another 31 wins & 85 nominations.\",\"Poster\":\"http://ia.media-imdb.com/images/M/MV5BMjIxNjAzODQ0N15BMl5BanBnXkFtZTcwODY2MjMyNA@@._V1_SX300.jpg\",\"Metascore\":\"80\",\"imdbRating\":\"7.7\",\"imdbVotes\":\"186,806\",\"imdbID\":\"tt1403865\",\"Type\":\"movie\",\"Response\":\"True\"}"
     http_version: 
-  recorded_at: Thu, 17 Apr 2014 22:35:47 GMT
+  recorded_at: Fri, 18 Apr 2014 00:44:53 GMT
 - request:
     method: get
     uri: http://omdbapi.com/?t=True%20Grit&y=1969
@@ -101,12 +101,12 @@ http_interactions:
       encoding: US-ASCII
       string: ''
     headers:
+      User-Agent:
+      - Faraday v0.8.9
       Accept-Encoding:
       - gzip;q=1.0,deflate;q=0.6,identity;q=0.3
       Accept:
       - "*/*"
-      User-Agent:
-      - Ruby
   response:
     status:
       code: 200
@@ -129,7 +129,7 @@ http_interactions:
       Access-Control-Allow-Origin:
       - "*"
       Date:
-      - Thu, 17 Apr 2014 22:35:44 GMT
+      - Fri, 18 Apr 2014 00:44:48 GMT
       Content-Length:
       - '745'
     body:
@@ -142,7 +142,7 @@ http_interactions:
         father's murderer in Indian territory.\",\"Language\":\"English\",\"Country\":\"USA\",\"Awards\":\"Won
         1 Oscar. Another 7 wins & 5 nominations.\",\"Poster\":\"http://ia.media-imdb.com/images/M/MV5BMTYwNTE3NDYzOV5BMl5BanBnXkFtZTcwNTU5MzY0MQ@@._V1_SX300.jpg\",\"Metascore\":\"N/A\",\"imdbRating\":\"7.4\",\"imdbVotes\":\"26,792\",\"imdbID\":\"tt0065126\",\"Type\":\"movie\",\"Response\":\"True\"}"
     http_version: 
-  recorded_at: Thu, 17 Apr 2014 22:35:47 GMT
+  recorded_at: Fri, 18 Apr 2014 00:44:53 GMT
 - request:
     method: get
     uri: http://omdbapi.com/?t=Game%20of%20Thrones
@@ -150,12 +150,12 @@ http_interactions:
       encoding: US-ASCII
       string: ''
     headers:
+      User-Agent:
+      - Faraday v0.8.9
       Accept-Encoding:
       - gzip;q=1.0,deflate;q=0.6,identity;q=0.3
       Accept:
       - "*/*"
-      User-Agent:
-      - Ruby
   response:
     status:
       code: 200
@@ -178,7 +178,7 @@ http_interactions:
       Access-Control-Allow-Origin:
       - "*"
       Date:
-      - Thu, 17 Apr 2014 22:35:44 GMT
+      - Fri, 18 Apr 2014 00:44:48 GMT
       Content-Length:
       - '693'
     body:
@@ -201,7 +201,7 @@ http_interactions:
         MjksNDgyIiwiaW1kYklEIjoidHQwOTQ0OTQ3IiwiVHlwZSI6InNlcmllcyIs
         IlJlc3BvbnNlIjoiVHJ1ZSJ9
     http_version: 
-  recorded_at: Thu, 17 Apr 2014 22:35:48 GMT
+  recorded_at: Fri, 18 Apr 2014 00:44:53 GMT
 - request:
     method: get
     uri: http://omdbapi.com/?plot=full&t=Game%20of%20Thrones
@@ -209,12 +209,12 @@ http_interactions:
       encoding: US-ASCII
       string: ''
     headers:
+      User-Agent:
+      - Faraday v0.8.9
       Accept-Encoding:
       - gzip;q=1.0,deflate;q=0.6,identity;q=0.3
       Accept:
       - "*/*"
-      User-Agent:
-      - Ruby
   response:
     status:
       code: 200
@@ -237,7 +237,7 @@ http_interactions:
       Access-Control-Allow-Origin:
       - "*"
       Date:
-      - Thu, 17 Apr 2014 22:35:45 GMT
+      - Fri, 18 Apr 2014 00:44:48 GMT
       Content-Length:
       - '1588'
     body:
@@ -280,7 +280,7 @@ http_interactions:
         MiIsImltZGJJRCI6InR0MDk0NDk0NyIsIlR5cGUiOiJzZXJpZXMiLCJSZXNw
         b25zZSI6IlRydWUifQ==
     http_version: 
-  recorded_at: Thu, 17 Apr 2014 22:35:48 GMT
+  recorded_at: Fri, 18 Apr 2014 00:44:53 GMT
 - request:
     method: get
     uri: http://omdbapi.com/?t=lsdfoweirjrpwef323423dsfkip
@@ -288,12 +288,12 @@ http_interactions:
       encoding: US-ASCII
       string: ''
     headers:
+      User-Agent:
+      - Faraday v0.8.9
       Accept-Encoding:
       - gzip;q=1.0,deflate;q=0.6,identity;q=0.3
       Accept:
       - "*/*"
-      User-Agent:
-      - Ruby
   response:
     status:
       code: 200
@@ -316,14 +316,14 @@ http_interactions:
       Access-Control-Allow-Origin:
       - "*"
       Date:
-      - Thu, 17 Apr 2014 22:35:45 GMT
+      - Fri, 18 Apr 2014 00:44:49 GMT
       Content-Length:
       - '47'
     body:
       encoding: UTF-8
       string: "{\"Response\":\"False\",\"Error\":\"Movie not found!\"}"
     http_version: 
-  recorded_at: Thu, 17 Apr 2014 22:35:48 GMT
+  recorded_at: Fri, 18 Apr 2014 00:44:53 GMT
 - request:
     method: get
     uri: http://omdbapi.com/?i=tt0411008
@@ -331,12 +331,12 @@ http_interactions:
       encoding: US-ASCII
       string: ''
     headers:
+      User-Agent:
+      - Faraday v0.8.9
       Accept-Encoding:
       - gzip;q=1.0,deflate;q=0.6,identity;q=0.3
       Accept:
       - "*/*"
-      User-Agent:
-      - Ruby
   response:
     status:
       code: 200
@@ -359,7 +359,7 @@ http_interactions:
       Access-Control-Allow-Origin:
       - "*"
       Date:
-      - Thu, 17 Apr 2014 22:35:45 GMT
+      - Fri, 18 Apr 2014 00:44:49 GMT
       Content-Length:
       - '832'
     body:
@@ -385,7 +385,7 @@ http_interactions:
         IjoiMjcxLDg0MiIsImltZGJJRCI6InR0MDQxMTAwOCIsIlR5cGUiOiJzZXJp
         ZXMiLCJSZXNwb25zZSI6IlRydWUifQ==
     http_version: 
-  recorded_at: Thu, 17 Apr 2014 22:35:48 GMT
+  recorded_at: Fri, 18 Apr 2014 00:44:54 GMT
 - request:
     method: get
     uri: http://omdbapi.com/?i=tt1231230123
@@ -393,12 +393,12 @@ http_interactions:
       encoding: US-ASCII
       string: ''
     headers:
+      User-Agent:
+      - Faraday v0.8.9
       Accept-Encoding:
       - gzip;q=1.0,deflate;q=0.6,identity;q=0.3
       Accept:
       - "*/*"
-      User-Agent:
-      - Ruby
   response:
     status:
       code: 200
@@ -421,14 +421,14 @@ http_interactions:
       Access-Control-Allow-Origin:
       - "*"
       Date:
-      - Thu, 17 Apr 2014 22:35:45 GMT
+      - Fri, 18 Apr 2014 00:44:49 GMT
       Content-Length:
       - '48'
     body:
       encoding: UTF-8
       string: "{\"Response\":\"False\",\"Error\":\"Incorrect IMDb ID\"}"
     http_version: 
-  recorded_at: Thu, 17 Apr 2014 22:35:48 GMT
+  recorded_at: Fri, 18 Apr 2014 00:44:54 GMT
 - request:
     method: get
     uri: http://omdbapi.com/?s=Star%20Wars
@@ -436,12 +436,12 @@ http_interactions:
       encoding: US-ASCII
       string: ''
     headers:
+      User-Agent:
+      - Faraday v0.8.9
       Accept-Encoding:
       - gzip;q=1.0,deflate;q=0.6,identity;q=0.3
       Accept:
       - "*/*"
-      User-Agent:
-      - Ruby
   response:
     status:
       code: 200
@@ -464,7 +464,7 @@ http_interactions:
       Access-Control-Allow-Origin:
       - "*"
       Date:
-      - Thu, 17 Apr 2014 22:35:45 GMT
+      - Fri, 18 Apr 2014 00:44:49 GMT
       Content-Length:
       - '1009'
     body:
@@ -494,7 +494,7 @@ http_interactions:
         YXkgU3BlY2lhbCIsIlllYXIiOiIxOTc4IiwiaW1kYklEIjoidHQwMTkzNTI0
         IiwiVHlwZSI6Im1vdmllIn1dfQ==
     http_version: 
-  recorded_at: Thu, 17 Apr 2014 22:35:48 GMT
+  recorded_at: Fri, 18 Apr 2014 00:44:54 GMT
 - request:
     method: get
     uri: http://omdbapi.com/?s=Star%20Wars:%20Episode%20VI%20-%20Return%20of%20the%20Jedi
@@ -502,12 +502,12 @@ http_interactions:
       encoding: US-ASCII
       string: ''
     headers:
+      User-Agent:
+      - Faraday v0.8.9
       Accept-Encoding:
       - gzip;q=1.0,deflate;q=0.6,identity;q=0.3
       Accept:
       - "*/*"
-      User-Agent:
-      - Ruby
   response:
     status:
       code: 200
@@ -530,14 +530,14 @@ http_interactions:
       Access-Control-Allow-Origin:
       - "*"
       Date:
-      - Thu, 17 Apr 2014 22:35:46 GMT
+      - Fri, 18 Apr 2014 00:44:49 GMT
       Content-Length:
       - '117'
     body:
       encoding: UTF-8
       string: "{\"Search\":[{\"Title\":\"Star Wars: Episode VI - Return of the Jedi\",\"Year\":\"1983\",\"imdbID\":\"tt0086190\",\"Type\":\"movie\"}]}"
     http_version: 
-  recorded_at: Thu, 17 Apr 2014 22:35:49 GMT
+  recorded_at: Fri, 18 Apr 2014 00:44:54 GMT
 - request:
     method: get
     uri: http://omdbapi.com/?s=lsdfoweirjrpwef323423dsfkip
@@ -545,12 +545,12 @@ http_interactions:
       encoding: US-ASCII
       string: ''
     headers:
+      User-Agent:
+      - Faraday v0.8.9
       Accept-Encoding:
       - gzip;q=1.0,deflate;q=0.6,identity;q=0.3
       Accept:
       - "*/*"
-      User-Agent:
-      - Ruby
   response:
     status:
       code: 200
@@ -573,12 +573,12 @@ http_interactions:
       Access-Control-Allow-Origin:
       - "*"
       Date:
-      - Thu, 17 Apr 2014 22:35:46 GMT
+      - Fri, 18 Apr 2014 00:44:49 GMT
       Content-Length:
       - '47'
     body:
       encoding: UTF-8
       string: "{\"Response\":\"False\",\"Error\":\"Movie not found!\"}"
     http_version: 
-  recorded_at: Thu, 17 Apr 2014 22:35:49 GMT
+  recorded_at: Fri, 18 Apr 2014 00:44:54 GMT
 recorded_with: VCR 2.9.0

data/lib/omdbgateway.rb

@@ -1,4 +1,6 @@
 require 'omdbgateway/gateway'
+require 'omdbgateway/response_patcher'
+require 'omdbgateway/response_wrapper'
 
 module OMDBGateway
   DEFAULT_API_ENDPOINT = 'http://omdbapi.com'

data/lib/omdbgateway/gateway.rb

@@ -1,9 +1,6 @@
 require 'faraday'
 require 'faraday_middleware'
 
-require_relative 'response_wrapper'
-require_relative 'response_patcher'
-
 module OMDBGateway
   # Faraday Based Gateway
   class Gateway
@@ -42,7 +39,7 @@ module OMDBGateway
     #   title_search('Game of Thrones')
     def title_search(title, year = nil, plot = nil)
       response = get '/' do |req|
-        req.params = {t: title}
+        req.params = {:t => title}
         req.params[:plot] = plot unless plot.nil?
         req.params[:y] = year unless year.nil?
       end
@@ -58,7 +55,7 @@ module OMDBGateway
     #   free_search('Game')
     def free_search(q)
       response = get '/' do |req|
-        req.params = {s: q}
+        req.params = {:s => q}
       end
       response.prune_hash('Search', [])
     end
@@ -72,7 +69,7 @@ module OMDBGateway
     #   find_by_id('tt0944947')
     def find_by_id(imdb_id)
       response = get '/' do |req|
-        req.params = {i: imdb_id}
+        req.params = {:i => imdb_id}
       end
       response
     end

data/omdbgateway.gemspec

@@ -4,7 +4,7 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
 Gem::Specification.new do |spec|
   spec.name          = "omdbgateway"
-  spec.version       = '0.0.3'
+  spec.version       = '0.0.4'
   spec.authors       = ["Stuart Jones"]
   spec.email         = ["omdbgateway@skillbox.com"]
   spec.description   = 'A simple API Service Gateway for the omdb omdbapi.com movie API. Supporting error handling and result pruning'
@@ -27,6 +27,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "rspec", "~> 2.14"
   spec.add_development_dependency "webmock", "~> 1.17"
 
-  spec.add_dependency 'faraday', "~> 0.8"
-  spec.add_dependency "faraday_middleware", "~> 0.9"
+  spec.add_dependency 'faraday', '~> 0.8.9'
+
+  spec.add_dependency "faraday_middleware", '~> 0.8'
 end

data/rspec_output.txt

@@ -0,0 +1,90 @@
+Run options: include {:focus=>true}
+
+All examples were filtered out; ignoring {:focus=>true}
+
+OMDBGateway::Gateway
+  With invalid Endpoint URI
+    should have the correct API endpoint
+    with a movie that exists
+      #success
+        should note failure
+      #error_message
+        should note failure
+  With invalid Endpoint URI
+    should have the correct API endpoint
+    with a movie that exists
+      #success
+        should note failure
+      #error_message
+        should note failure
+  With Valid Endpoint
+    should have the correct API endpoint
+    #title_search
+      with a movie that exists
+        should return a hash of movie attributes
+        should contain a title
+      with the year parameter
+        should not be the same title
+      with the plot parameter
+        should have different plots
+      with a movie that doesnt exist
+        should return a hash
+        should return a hash with a false response
+        should return a hash with an error message
+    #find_by_id
+      with a title that exists
+        should return a hash of movie attributes
+        should contain a title
+      with a movie that does not exist
+        should return nil
+    #free_search
+      with search results
+        should return an ResponseWrapper
+        should return an array with hash contents
+      with a single search result
+        should return an array
+        should return an array with 1 element
+        should have a title
+      with no search results
+        should return an ResponseWrapper
+        should show app failed
+
+OMDBGateway::ResponseWrapper
+  #error_message
+    should be nil
+    should be 'X500 Error'
+    should be 'X500 Error'
+  #success?
+    should be true
+    should be true
+    should be false
+  #as_hash
+    should be {}
+    should be {}
+    should be {}
+    should be {'a' => 'A'}
+  #as_hash
+    should be []
+    should be []
+    should be []
+    should be []
+    should be [{'a' => 'A', 'b' => 'B'}]
+  #prune_hash
+    should be nil for empty array
+    should be 5
+    should not expose Error or Report
+    should be return hash element
+    should be nil for any array
+  #prune_array
+    should be nil for empty array
+    should be default 700
+    should not expose Error or Report
+    should not return hash element but the default
+    should be {'a' => 'A', 'b' => 'B'} for any array
+    should be default (500) for out of bound index for any array
+  #array_first
+    should be nil for empty array
+    should be {'a' => 'A', 'b' => 'B'} for any array
+
+Finished in 0.20503 seconds
+52 examples, 0 failures

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: omdbgateway
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - Stuart Jones
@@ -100,28 +100,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.8'
+        version: 0.8.9
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.8'
+        version: 0.8.9
 - !ruby/object:Gem::Dependency
   name: faraday_middleware
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.9'
+        version: '0.8'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.9'
+        version: '0.8'
 description: A simple API Service Gateway for the omdb omdbapi.com movie API. Supporting
   error handling and result pruning
 email:
@@ -132,6 +132,7 @@ extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".rspec"
+- ".travis.yml"
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -142,6 +143,7 @@ files:
 - lib/omdbgateway/response_patcher.rb
 - lib/omdbgateway/response_wrapper.rb
 - omdbgateway.gemspec
+- rspec_output.txt
 - spec/omdbgateway/gateway_spec.rb
 - spec/omdbgateway/response_wrapper_spec.rb
 - spec/spec_helper.rb